Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | initialize generated modules on inclusion and on inheritence | Aaron Patterson | 2013-07-02 | 2 | -8/+1 | |
| | | | | ||||||
* | | | | push attribute constant cache in to the attribute methods module | Aaron Patterson | 2013-07-02 | 2 | -7/+9 | |
| | | | | ||||||
* | | | | fix to_sql output on eager loaded relations | Aaron Patterson | 2013-07-02 | 2 | -1/+17 | |
| | | | | ||||||
* | | | | lock around mutating the generated methods module | Aaron Patterson | 2013-07-02 | 1 | -2/+4 | |
| | | | | ||||||
* | | | | remove private attribute reader | Aaron Patterson | 2013-07-02 | 2 | -8/+4 | |
| | | | | ||||||
* | | | | define attribute methods in a thread safe manner | Aaron Patterson | 2013-07-02 | 1 | -5/+4 | |
| | | | | ||||||
* | | | | we don't need to use active support *everwhere* common. | Aaron Patterson | 2013-07-02 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | initialize ivars so we don't have to constantly check them | Aaron Patterson | 2013-07-02 | 1 | -1/+3 | |
| | | | | ||||||
* | | | | eagerly initialize the attributes module to avoid check-then-set race conditions | Aaron Patterson | 2013-07-02 | 2 | -8/+13 | |
|/ / / | ||||||
* | | | remove unused `ActiveRecord::TestCase#sqlite3` method. | Yves Senn | 2013-07-02 | 1 | -6/+0 | |
| | | | ||||||
* | | | deprecated `ActiveRecord::TestCase` is no longer public. | Yves Senn | 2013-07-02 | 4 | -99/+100 | |
| | | | | | | | | | | | | /cc @tenderlove | |||||
* | | | Dropped deprecated option `:restrict` for `:dependent` in associations | Neeraj Singh | 2013-07-03 | 9 | -49/+9 | |
| | | | ||||||
* | | | Removed support for deprecated `delete_sql` in associations. | Neeraj Singh | 2013-07-03 | 5 | -46/+15 | |
| | | | ||||||
* | | | no need to to_sym the column name, leave it as-is | Aaron Patterson | 2013-07-02 | 1 | -1/+1 | |
| | | | ||||||
* | | | resolve aliases before passing the hash to the predicate builder | Aaron Patterson | 2013-07-02 | 3 | -4/+12 | |
| | | | ||||||
* | | | Removed support for deprecated `insert_sql` in associations. | Neeraj Singh | 2013-07-02 | 3 | -10/+10 | |
| | | | ||||||
* | | | fix indentation | Neeraj Singh | 2013-07-02 | 1 | -14/+14 | |
| | | | ||||||
* | | | Removed support for deprecated `finder_sql` in associations. | Neeraj Singh | 2013-07-02 | 9 | -197/+10 | |
| | | | ||||||
* | | | Add CHANGELOG enty for #11235 | Rafael Mendonça França | 2013-07-02 | 2 | -1/+4 | |
| | | | ||||||
* | | | Removed support for deprecated `counter_sql` | Neeraj Singh | 2013-07-02 | 8 | -79/+19 | |
| | | | ||||||
* | | | Removing not useful test related to reflect_on_all_associations | Neeraj Singh | 2013-07-02 | 1 | -8/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The comment in the test pretty much summarizes the issue. `FIXME these assertions bust a lot` Adding any type of association in class `Firm` will break this test. I removed some deprecated stuff and this test failed. I do not think this test provides any useful value. First of all who counted last that 39 is the right number of associations. Secondly there are a large number of tests which depend on reflection returning right information about associations. Those tests will start failing if there is a bug in the code. | |||||
* | | | Merge pull request #10604 from ↵ | Rafael Mendonça França | 2013-07-01 | 9 | -17/+117 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | neerajdotname/delete_all_should_not_call_callbacks Do not invoke callbacks when delete_all is called Conflicts: activerecord/CHANGELOG.md | |||||
| * | | | Do not invoke callbacks when delete_all is called | Neeraj Singh | 2013-06-30 | 9 | -17/+117 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Method `delete_all` should not be invoking callbacks and this feature was deprecated in Rails 4.0. This is being removed. `delete_all` will continue to honor the `:dependent` option. However if `:dependent` value is `:destroy` then the default deletion strategy for that collection will be applied. User can also force a deletion strategy by passing parameter to `delete_all`. For example you can do `@post.comments.delete_all(:nullify)` | |||||
* | | | | calling default_scope without a proc will raise ArgumentError | Neeraj Singh | 2013-07-02 | 3 | -6/+8 | |
| | | | | | | | | | | | | | | | | Calling default_scope without a proc will now raise `ArgumentError`. | |||||
* | | | | Merge pull request #11230 from ↵ | Rafael Mendonça França | 2013-07-01 | 1 | -5/+0 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | frodsan/remove_deprecated_clear_stale_cached_connections_method Remove AR::Connection#clear_stale_cached_connections! deprecated method | |||||
| * | | | | Remove deprecated AR::Connection#clear_stale_cached_connections! method | Francesco Rodriguez | 2013-07-01 | 1 | -5/+0 | |
| | | | | | ||||||
* | | | | | Removed deprecated method type_cast_code from Column | Neeraj Singh | 2013-07-02 | 2 | -24/+4 | |
|/ / / / | ||||||
* | | | | avoid intermediate zipped array | Aaron Patterson | 2013-07-01 | 1 | -3/+2 | |
| | | | | ||||||
* | | | | make the identity type a singleton to save on object creation | Aaron Patterson | 2013-07-01 | 2 | -3/+7 | |
| | | | | ||||||
* | | | | only deal with strings internally | Aaron Patterson | 2013-07-01 | 1 | -3/+3 | |
| | | | | ||||||
* | | | | Merge pull request #11222 from neerajdotname/removed-deprecation-for-sql | Rafael Mendonça França | 2013-07-01 | 5 | -41/+8 | |
|\ \ \ \ | | | | | | | | | | | Removed deprecated options for assocations | |||||
| * | | | | Removed deprecated options for assocations | Neeraj Singh | 2013-07-02 | 5 | -41/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | Deprecated options `delete_sql`, `insert_sql`, `finder_sql` and `counter_sql` have been deleted. | |||||
* | | | | | build an AST rather than slapping strings together | Aaron Patterson | 2013-07-01 | 1 | -11/+7 | |
|/ / / / | ||||||
* | | | | Remove deprecation messages about protected_attributes and rails-observers | Carlos Antonio da Silva | 2013-07-01 | 1 | -39/+0 | |
| | | | | ||||||
* | | | | stop exposing the underlying alias datastructure | Aaron Patterson | 2013-07-01 | 1 | -4/+4 | |
| | | | | ||||||
* | | | | we don't need to to_s the column | Aaron Patterson | 2013-07-01 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | the data structure used to store attribute aliases should not be exposed | Aaron Patterson | 2013-07-01 | 1 | -2/+2 | |
| | | | | ||||||
* | | | | remove deprecated `ActiveRecord::Base#connection` method. | Yves Senn | 2013-07-01 | 3 | -12/+5 | |
| | | | | ||||||
* | | | | remove auto-explain-config deprecation warning | Yves Senn | 2013-07-01 | 2 | -11/+4 | |
| | | | | ||||||
* | | | | Remove deprecated `:distinct` option from `Relation#count`. | Yves Senn | 2013-07-01 | 3 | -15/+4 | |
| | | | | ||||||
* | | | | Removed deprecated methods partial_updates and family | Neeraj Singh | 2013-07-02 | 3 | -25/+5 | |
| | | | | | | | | | | | | | | | | | | | | Removed deprecated methods `partial_updates`, `partial_updates?` and `partial_updates=` | |||||
* | | | | Merge pull request #11213 from neerajdotname/scoped-deprecated | Rafael Mendonça França | 2013-07-01 | 2 | -5/+4 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removed deprecated scoped method Conflicts: activerecord/CHANGELOG.md | |||||
| * | | | | Removed deprecated method scoped | Neeraj Singh | 2013-07-01 | 2 | -5/+4 | |
| | | | | | ||||||
* | | | | | Removed deprecated method default_scopes? | Neeraj Singh | 2013-07-01 | 2 | -8/+4 | |
|/ / / / | ||||||
* / / / | don't shadow `through_scope` method name with local var. | Yves Senn | 2013-06-30 | 1 | -7/+7 | |
|/ / / | ||||||
* | | | remove deprecated implicit join references. | Yves Senn | 2013-06-29 | 6 | -87/+25 | |
| | | | ||||||
* | | | Merge pull request #11161 from dmitry/find_in_batches_works_without_logger | Carlos Antonio da Silva | 2013-06-28 | 2 | -2/+12 | |
|\ \ \ | | | | | | | | | | | | | | | | | ActiveRecord find_in_batches should work without logger When I set logger to nil both methods from Batches module find_in_batches or find_each should work anyway. | |||||
| * | | | find_in_batches should work without logger | Dmitry Polushkin | 2013-06-28 | 2 | -2/+12 | |
| | | | | ||||||
* | | | | Remove order_values argument now that default_scope is simplified | Carlos Antonio da Silva | 2013-06-28 | 1 | -5/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In 94924dc32baf78f13e289172534c2e71c9c8cade the internal default_scope implementation has changed making it simpler to follow, meaning that the old usage of with_default_scope has been removed. With that, order_values was the same argument for both calls to find_first_with_limit, so remove it and use the existent attribute for the sake of clarity/simplification. | |||||
* | | | | Simplify/fix implementation of default scopes | Jon Leighton | 2013-06-28 | 12 | -74/+31 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous implementation was necessary in order to support stuff like: class Post < ActiveRecord::Base default_scope where(published: true) scope :ordered, order("created_at") end If we didn't evaluate the default scope at the last possible moment before sending the SQL to the database, it would become impossible to do: Post.unscoped.ordered This is because the default scope would already be bound up in the "ordered" scope, and therefore wouldn't be removed by the "Post.unscoped" part. In 4.0, we have deprecated all "eager" forms of scopes. So now you must write: class Post < ActiveRecord::Base default_scope { where(published: true) } scope :ordered, -> { order("created_at") } end This prevents the default scope getting bound up inside the "ordered" scope, which means we can now have a simpler/better/more natural implementation of default scoping. A knock on effect is that some things that didn't work properly now do. For example it was previously impossible to use #except to remove a part of the default scope, since the default scope was evaluated after the call to #except. |