Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Move sqlite to sqlite3 for this tests to be run only on sqlite3 adapter | Santiago Pastorino | 2010-06-28 | 2 | -0/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-28 | 55 | -554/+846 |
|\ | |||||
| * | Fixes #2415 by creating a new instance of the Model when saving attributes ↵ | George Montana Harkin | 2010-06-27 | 2 | -21/+26 |
| | | | | | | | | | | | | to that model and the associated attributes already exist. Tests included. [#2415 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | removing useless code. [#4988 state:resolved] | Aaron Patterson | 2010-06-26 | 1 | -15/+4 |
| | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | Refactor: metaprogramming here it's confusing and make use of tap | Santiago Pastorino | 2010-06-26 | 1 | -64/+73 |
| | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | Refactor of column_exists? method and this works with PostgreSQL | Santiago Pastorino | 2010-06-26 | 1 | -12/+6 |
| | | |||||
| * | Removes useless flatten | Santiago Pastorino | 2010-06-26 | 1 | -4/+9 |
| | | |||||
| * | Add module_eval missing file_name and line_number args [#4712 state:resolved] | Evgeniy Dolzhenko | 2010-06-26 | 1 | -2/+2 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | adding adapter tests, avoiding private apis, fixing code in 1.9 [#4986 ↵ | Aaron Patterson | 2010-06-26 | 2 | -3/+63 |
| | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Create a little bit less objects in ARel. | José Valim | 2010-06-26 | 1 | -6/+9 |
| | | |||||
| * | refactoring the postgres adapter index method to avoid inject and use ↵ | Aaron Patterson | 2010-06-26 | 1 | -4/+4 |
| | | | | | | | | | | | | values_at. [#4976 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | blocks removed from all the ActiveRelation query_methods, extend method ↵ | Santiago Pastorino | 2010-06-26 | 3 | -9/+14 |
| | | | | | | | | | | | | added instead Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Merge branch 'tago' | José Valim | 2010-06-26 | 4 | -11/+170 |
| |\ | |||||
| | * | Add column and index query methods to ActiveRecord::Schema | Andrew White | 2010-06-26 | 4 | -11/+170 |
| | | | | | | | | | | | | | | | | | | [#4219 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | | index dump should not include full text indexes. Thanks Ken Mayer for the ↵ | Aaron Patterson | 2010-06-26 | 2 | -8/+7 |
| | | | | | | | | | | | | | | | | | | original patch! [#4949 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | | reorder method added to ActiveRelation | Santiago Pastorino | 2010-06-26 | 2 | -0/+14 |
| | | | | | | | | | | | | | | | | | | [#4972 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | | Test for concatenated orders added | Santiago Pastorino | 2010-06-26 | 2 | -1/+7 |
| | | | | | | | | | | | | | | | | | | [#4972] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | | reorganizing adapter specific tests. [#4974 state:resolved] | Aaron Patterson | 2010-06-25 | 13 | -3/+6 |
| |/ | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | Order is not guaranteed here, ordering by id of people table makes it work | Santiago Pastorino | 2010-06-25 | 1 | -2/+2 |
| | | |||||
| * | Support for multiple selects added | Neeraj Singh and Santiago Pastorino | 2010-06-25 | 3 | -7/+18 |
| | | | | | | | | [#4841 state:committed] | ||||
| * | Makes a build_select for the select part of build_arel | Santiago Pastorino | 2010-06-25 | 1 | -10/+13 |
| | | |||||
| * | Metaprogramming not needed here | Santiago Pastorino | 2010-06-25 | 1 | -11/+9 |
| | | |||||
| * | Avoid a blank line before the add/remove columns | Santiago Pastorino | 2010-06-25 | 1 | -2/+2 |
| | | |||||
| * | Line break in migration template and nicer code indentation | Łukasz Strzałkowski | 2010-06-25 | 1 | -6/+8 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Merge remote branch 'miloops/fixes' | José Valim | 2010-06-24 | 8 | -48/+18 |
| |\ | |||||
| | * | Only yield block if given. | Emilio Tagua | 2010-06-24 | 1 | -2/+2 |
| | | | |||||
| | * | Remove block definitions in finder methods. | Emilio Tagua | 2010-06-24 | 1 | -4/+4 |
| | | | |||||
| | * | Remove block definition from method, is not needed since yield is used inside. | Emilio Tagua | 2010-06-24 | 3 | -3/+3 |
| | | | |||||
| | * | Don't define block, just yield if block is given. | Emilio Tagua | 2010-06-24 | 1 | -7/+7 |
| | | | |||||
| | * | Remove deprecated block usage in composed_of. | Emilio Tagua | 2010-06-24 | 2 | -32/+2 |
| | | | |||||
| * | | Your original TIME ZONE value on PostgreSQL is correctly restored now, after ↵ | Santiago Pastorino | 2010-06-24 | 1 | -3/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | going through options :utc and then going back to :local [#4950 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | | quotes are not necessary here | Santiago Pastorino | 2010-06-24 | 1 | -2/+2 |
| |/ | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing ↵ | José Valim | 2010-06-24 | 5 | -40/+37 |
| | | | | | | | | frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved] | ||||
| * | Add tests for relation count. Fix other tests that were conceptually wrong. | Emilio Tagua | 2010-06-24 | 2 | -2/+6 |
| | | | | | | | | | | | | [#4882 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Remove incorrect comment regarding #initialize_copy | Paul Gillard | 2010-06-23 | 1 | -8/+0 |
| | | | | | | | | | | | | Comment added in #3164 is incorrect after reading http://dev.rubyonrails.org/ticket/7191. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Sessions should not be created until written to and session data should be ↵ | Michael Lovitt | 2010-06-23 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | destroyed on reset. [#4938] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | adding fix for to_xml for ActiveRecord relation object | Neeraj Singh | 2010-06-23 | 2 | -1/+6 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | ActiveRecord's relation object should respond to to_json and to_yaml | Neeraj Singh | 2010-06-23 | 2 | -1/+11 |
| | | | | | | | | | | | | [#4547 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | adding column named 'group' to ensure that nothing breaks given that 'group' ↵ | Neeraj Singh | 2010-06-23 | 3 | -6/+7 |
| | | | | | | | | | | | | | | | | is sql reserved word [#4945 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Patch for Namespace problem in Scaffold. [#4763 state:resolved] | Mohammed Siddick.E | 2010-06-23 | 1 | -1/+1 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Don't clone associations [#4894 state:resolved] | Paul Gillard | 2010-06-23 | 2 | -0/+9 |
| | | | | | | | | | | | | Cloning an active record object should be shallow in that it should copy attributes but not associations. This was no longer true as a result of #3164. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | remove_column should raise an ArgumentError when no columns are passed ↵ | Jeff Dean | 2010-06-23 | 3 | -0/+6 |
| | | | | | | | | | | | | [#4803 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
| * | Fix connection reloading in development mode. [#4929 state:resolved] | Edgars Beigarts | 2010-06-22 | 2 | -3/+6 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Avoid method redefined warning | Santiago Pastorino | 2010-06-22 | 1 | -1/+4 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Fix small bug where ActiveRecord::PredicateBuilder#build_from_hash didn't ↵ | James Harton | 2010-06-22 | 1 | -1/+1 |
| | | | | | | | | | | | | test for Arel::Relation as right hand value. [#4917 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | test for #4917 | Neeraj Singh | 2010-06-22 | 1 | -0/+7 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Clean CHANGELOG whitespace. | Emilio Tagua | 2010-06-22 | 1 | -254/+254 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Fix order method to accept relation attributes. | Emilio Tagua | 2010-06-22 | 2 | -3/+7 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Use the new query API in AR performance script. | Emilio Tagua | 2010-06-22 | 1 | -3/+3 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ↵ | Jeroen van Dijk | 2010-06-21 | 4 | -30/+36 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | hash and make various Validators pass their (filtered) options. This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format". Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation. Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options). Also, refactoring of ActiveModel and ActiveRecord Validation tests. Test are a lot more DRY now. Better test coverage as well now. The first four points were reapplied from an older patch of Sven Fuchs which didn't apply cleanly anymore and was not complete yet. Signed-off-by: José Valim <jose.valim@gmail.com> |