Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #31004 from shuheiktgw/remove_unnecessary_returns | Rafael França | 2017-10-31 | 2 | -2/+2 |
|\ | | | | | Remove redundant return statements | ||||
| * | removed unnecessary returns | Shuhei Kitagawa | 2017-10-28 | 2 | -2/+2 |
| | | |||||
* | | `source_type_scope` should respect correct table alias | Ryuta Kamizono | 2017-10-30 | 2 | -7/+17 |
| | | | | | | | | | | | | | | | | | | `join_scopes` in `PolymorphicReflection` is passed aliased `table`, so it should be respected for `source_type_scope`. Closes #13969. Fixes #13920. Fixes #15190. | ||||
* | | `PolymorphicReflection#scopes` is no longer used since a5651eb5 | Ryuta Kamizono | 2017-10-30 | 1 | -5/+0 |
| | | |||||
* | | [ci skip]Update the documentation about the primary key type | suginoy | 2017-10-29 | 4 | -20/+20 |
| | | | | | | | | | | | | Replace the primary key type `integer` in docs with `bigint`. ref #26266 | ||||
* | | Merge pull request #31005 from shuheiktgw/remove_unnecessary_semicolons | Matthew Draper | 2017-10-28 | 3 | -3/+3 |
|\ \ | |/ |/| | | | Removed unnecessary semicolons | ||||
| * | removed unnecessary semicolons | Shuhei Kitagawa | 2017-10-28 | 2 | -2/+2 |
|/ | |||||
* | Remove CHANGELOG entry for PR #28681 [ci skip] | Prathamesh Sonpatki | 2017-10-27 | 1 | -4/+0 |
| | | | | | - It is present in Rails 5.1.3 already. - Backport commit https://github.com/rails/rails/commit/9efa0b70a638dcfdc05b30ab530f89f2847bb9c2 | ||||
* | Fix all `s/trough/through/` | Ryuta Kamizono | 2017-10-27 | 1 | -1/+1 |
| | | | | | | | ``` % git grep -n trough activerecord/test/cases/associations/has_many_through_associations_test.rb:1253: def test_has_many_trough_with_scope_that_has_joined_same_table_with_parent_relation ``` | ||||
* | Fix typo `s/trough/through/` | Ryuta Kamizono | 2017-10-27 | 1 | -1/+1 |
| | |||||
* | Merge pull request #30682 from ahorek/fix_scope_for | Ryuta Kamizono | 2017-10-27 | 6 | -1/+11 |
|\ | | | | | delegate scope_for on PolymorphicReflection | ||||
| * | delegate scope for | pavel | 2017-10-27 | 6 | -1/+11 |
| | | |||||
* | | fix initial count | pavel | 2017-10-27 | 2 | -1/+5 |
|/ | |||||
* | remove incorrect statement about serializable transactions | Joe Van Dyk | 2017-10-25 | 1 | -3/+1 |
| | | | using serializable isolation would prevent the duplicate insert as done in the example from happening | ||||
* | Third party adapters doesn't support index orders yet | Ryuta Kamizono | 2017-10-26 | 1 | -2/+2 |
| | |||||
* | Merge pull request #30984 from yahonda/schema_dumper_pg | Ryuta Kamizono | 2017-10-26 | 2 | -9/+13 |
|\ | | | | | Move `extensions` to `PostgreSQL::SchemaDumper` | ||||
| * | Implement `PostgreSQL::SchemaDumper#extensions` | Yasuo Honda | 2017-10-25 | 2 | -9/+13 |
| | | | | | | | | | | | | | | and abstract `SchemaDumper#extensions` is now an empty method. Since #30337, every database adapter has its own `SchemaDumper`. `extensions` are only supported by PostgreSQL database and postgresql database adapter. | ||||
* | | Merge pull request #30970 from rohitpaulk/fix-sqlite-3-index-order-dump | Rafael França | 2017-10-25 | 3 | -2/+19 |
|\ \ | |/ |/| | Save index order :desc to schema.rb (sqlite). Fixes #30902 | ||||
| * | Avoid using index_xinfo, only available in sqlite >= 3.8.9 | Paul Kuruvilla | 2017-10-25 | 1 | -9/+12 |
| | | |||||
| * | Save index order :desc to schema.rb (sqlite). Fixes #30902 | Paul Kuruvilla | 2017-10-24 | 3 | -3/+17 |
| | | | | | | | | | | Although the sqlite adapter supports index sort orders, they weren't being written to db/schema.rb. | ||||
* | | `supports_extensions?` return always true since PostgreSQL 9.1 | Yasuo Honda | 2017-10-24 | 6 | -488/+466 |
|/ | | | | | | | | since the minimum version of PostgreSQL currently Rails supports is 9.1, there is no need to handle if `supports_extensions?` Refer https://www.postgresql.org/docs/9.1/static/sql-createextension.html "CREATE EXTENSION" | ||||
* | Ensure associations doesn't table name collide with aliased joins | Ryuta Kamizono | 2017-10-24 | 2 | -1/+9 |
| | | | | | | Currently alias tracker only refer a table name, doesn't respect an alias name. Should use `join.left.name` rather than `join.left.table_name`. | ||||
* | Remove `supports_disable_referential_integrity?` | Yasuo Honda | 2017-10-23 | 1 | -25/+17 |
| | | | | | | | | | | | | | | | | `supports_disable_referential_integrity?` used to handle if PostgreSQL database supports `ALTER TABLE <table name> DISABLE/ENABLE TRIGGER` statements. Refer https://github.com/rails/rails/commit/9a947af0e79cfb8692eb7e5ae94c1b8c40756f49 These statements have been documented since 8.1. https://www.postgresql.org/docs/8.1/static/sql-altertable.html > DISABLE/ENABLE TRIGGER Now Rails supports PostgreSQL 9.1 or higher only. No need to handle `supports_disable_referential_integrity?` anymore. Also, this method does not exist in any other adapters including AbstractAdapter. | ||||
* | Remove text about deprecation that was already removed | Rafael Mendonça França | 2017-10-23 | 1 | -2/+1 |
| | |||||
* | Remove deprecated `:if` and `:unless` string filter for callbacks | Rafael Mendonça França | 2017-10-23 | 2 | -3/+3 |
| | |||||
* | Remove deprecated method `#sanitize_conditions` | Rafael Mendonça França | 2017-10-23 | 2 | -2/+4 |
| | |||||
* | Remove deprecated methd `#scope_chain` | Rafael Mendonça França | 2017-10-23 | 3 | -44/+4 |
| | |||||
* | Remove deprecated configuration `.error_on_ignored_order_or_limit` | Rafael Mendonça França | 2017-10-23 | 3 | -48/+4 |
| | |||||
* | Remove deprecated arguments from `#verify!` | Rafael Mendonça França | 2017-10-23 | 3 | -16/+5 |
| | |||||
* | Remove deprecated argument `name` from `#indexes` | Rafael Mendonça França | 2017-10-23 | 7 | -33/+9 |
| | |||||
* | Remove deprecated method `ActiveRecord::Migrator.schema_migrations_table_name` | Rafael Mendonça França | 2017-10-23 | 3 | -9/+4 |
| | |||||
* | Remove deprecated method `supports_primary_key?` | Rafael Mendonça França | 2017-10-23 | 3 | -9/+4 |
| | |||||
* | Remove deprecated method `supports_migrations?` | Rafael Mendonça França | 2017-10-23 | 3 | -9/+4 |
| | |||||
* | Remove deprecated methods `initialize_schema_migrations_table` and ↵ | Rafael Mendonça França | 2017-10-23 | 3 | -15/+4 |
| | | | | `initialize_internal_metadata_table` | ||||
* | Rase when calling `lock!` in a dirty record | Rafael Mendonça França | 2017-10-23 | 3 | -15/+20 |
| | |||||
* | Remove deprecated support to passing a class to `:class_name` on associations | Rafael Mendonça França | 2017-10-23 | 5 | -25/+10 |
| | |||||
* | Remove deprecated argument `default` from `index_name_exists?` | Rafael Mendonça França | 2017-10-23 | 4 | -16/+8 |
| | |||||
* | Remove deprecated support to `quoted_id` when typecasting an Active Record ↵ | Rafael Mendonça França | 2017-10-23 | 5 | -71/+4 |
| | | | | object | ||||
* | Fix duplicate aliases when using both INNER/LEFT JOINs | Ryuta Kamizono | 2017-10-23 | 2 | -3/+9 |
| | | | | | | | | It should be shared the count of alias tracking in both INNER/LEFT JOINs to avoid duplicate aliases. Fixes #30504. Closes #30410. | ||||
* | Ensure associations doesn't table name collide with string joins | Ryuta Kamizono | 2017-10-23 | 2 | -4/+11 |
| | | | | | Currently we have no test for alias tracking with string joins. I've add test case for that to catch a future regression. | ||||
* | Place `MocktailDesigner` in `test/models/drink_designer.rb` | Ryuta Kamizono | 2017-10-23 | 3 | -5/+3 |
| | | | | | Since `MocktailDesigner` inherits `DrinkDesigner` and can not be used alone. | ||||
* | [Active Record] require => require_relative | Akira Matsuda | 2017-10-21 | 35 | -134/+134 |
| | | | | This basically reverts 9d4f79d3d394edb74fa2192e5d9ad7b09ce50c6d | ||||
* | Add test cases for `type` and `foreign_type` in the reflections | Ryuta Kamizono | 2017-10-21 | 1 | -0/+7 |
| | | | | It should be initialized only when polymorphic associations. | ||||
* | Convert ignored_columns to a list of string | Altech | 2017-10-20 | 3 | -15/+37 |
| | |||||
* | Test `ignored_columns` value is inheritable by subclasses | Ryuta Kamizono | 2017-10-19 | 2 | -0/+10 |
| | |||||
* | Merge pull request #30579 from ↵ | Sean Griffin | 2017-10-18 | 3 | -12/+36 |
|\ | | | | | | | | | bogdanvlviv/fix_ar_internal_metadata_for_a_test_database Fix `bin/rails db:setup` and `bin/rails db:test:prepare` create wrong ar_internal_metadata's data for a test database. | ||||
| * | `ActiveRecord::Tasks::DatabaseTasks.load_schema` has always to establish ↵ | bogdanvlviv | 2017-10-15 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | database connection When load schema from `structure.sql`, database connection isn't established. `ActiveRecord::Tasks::DatabaseTasks.load_schema` has to establish database connection since it executes ``` ActiveRecord::InternalMetadata.create_table ActiveRecord::InternalMetadata[:environment] = environment ``` | ||||
| * | Fix `bin/rails db:setup` and `bin/rails db:test:prepare` create wrong ↵ | bogdanvlviv | 2017-10-15 | 3 | -9/+33 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ar_internal_metadata's data for a test database. Before: ``` $ RAILS_ENV=test rails dbconsole > SELECT * FROM ar_internal_metadata; key|value|created_at|updated_at environment|development|2017-09-11 23:14:10.815679|2017-09-11 23:14:10.815679 ``` After: ``` $ RAILS_ENV=test rails dbconsole > SELECT * FROM ar_internal_metadata; key|value|created_at|updated_at environment|test|2017-09-11 23:14:10.815679|2017-09-11 23:14:10.815679 ``` Fixes #26731. | ||||
* | | Enable `hstore` extention disabled at the end of ↵ | Yasuo Honda | 2017-10-18 | 1 | -0/+2 |
| | | | | | | | | | | | | | | `InvertibleMigrationTest#test_migrate_enable_and_disable_extension` to avoid failure of `PostgresqlArrayTest#test_schema_dump_with_shorthand` which expects `hstore` extension enabled. | ||||
* | | Should test `LegacyPrimaryKeyTest` to both `V5_0` and `V4_2` | Ryuta Kamizono | 2017-10-18 | 1 | -15/+34 |
| | |