aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Merge pull request #9332 from ↵Rafael Mendonça França2013-02-203-15/+45
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | wangjohn/adding_documentation_to_error_raising_in_query_methods Tests to make sure empty arguments in WhereChain raise errors
| * | | | Added comments about the check_empty_arguments method which is calledwangjohn2013-02-203-15/+45
| | | | | | | | | | | | | | | | | | | | | | | | | for query methods in a where_clause. Also, modified the CHANGELOG entry because it had false information and added tests.
* | | | | Merge pull request #9342 from hone/db_migrate_with_database_urlRafael Mendonça França2013-02-201-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Fix ActiveRecord::ConnectionAdapters::ConnectionSpecification::ResolverTest
| * | | | | make type_cast_value a class level methodTerence Lee2013-02-211-1/+1
| |/ / / /
* / / / / Reduced memory leak problem in transactions by lazily updating AR objects ↵wangjohn2013-02-206-6/+89
|/ / / / | | | | | | | | | | | | with new transaction state. If AR object has a callback, the callback will be performed immediately (non-lazily) so the transaction still has to keep records with callbacks.
* | | | standardize database_configuration to a hashTerence Lee2013-02-212-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | make connection_url_to_hash a class method This als prevents loading database.yml if it doesn't exist but DATABASE_URL does
* | | | Whitespace :heart: and hash syntax changeRafael Mendonça França2013-02-201-23/+22
| | | |
* | | | descriptive error message when AR adapter was not found. Closes #7313.Yves Senn2013-02-203-3/+20
| | | |
* | | | s/revertible/reversible/Xavier Noria2013-02-191-1/+1
| | | |
* | | | Merge pull request #9315 from ↵Steve Klabnik2013-02-191-23/+0
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Takehiro-Adachi/remove-unecessary-tests-from-ar-base_testrb delete duplicated tests in AR base_test.rb
| * | | | delete duplicated tests in AR base_test.rbTakehiro Adachi2013-02-191-23/+0
| | | | | | | | | | | | | | | | | | | | These are duplicated with the tests which are in relations_test.rb
* | | | | moves a CHANGELOG entry from AR to APXavier Noria2013-02-191-4/+0
| | | | |
* | | | | small tweaks in the AR CHANGELOGXavier Noria2013-02-191-4/+4
| | | | |
* | | | | Raise an error when query methods have blank arguments, and when blank ↵John J Wang2013-02-192-9/+34
| | | | | | | | | | | | | | | | | | | | arguments are meaningless.
* | | | | Gist URLs are now namespacedAkira Matsuda2013-02-182-5/+5
|/ / / / | | | | | | | | | | | | see: https://github.com/blog/1406-namespaced-gists
* | | | add tests for ActiveRecord::Base#createTakehiro Adachi2013-02-181-0/+8
| | | |
* | | | Add CHANGELOG entry for 41ff6a10216f48f43605a1f9cd6094765cab750fAndrew White2013-02-171-0/+40
| | | | | | | | | | | | | | | | [ci skip]
* | | | copy-edits RDoc in fba496fXavier Noria2013-02-161-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This revision makes the terminology uniform with the rest of the file. In general we describe these methods in terms of the adapter, rather than the database. (As a side note, if we wanted to refer to the database we would write "PostgreSQL".)
* | | | Remove valid_type? methodJon Leighton2013-02-154-17/+0
| |/ / |/| | | | | | | | | | | It was supposed to be removed by the preceding two reversions but I did them in the wrong order.
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-02-152-0/+24
|\ \ \ | | | | | | | | | | | | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md
| * | | copy edits [ci skip]Vijay Dev2013-02-151-1/+1
| | | |
| * | | Add example for ActiveRecord::Base.joins using a string as argumentMaurizio De Santis2013-02-071-0/+5
| | | |
| * | | Add example for ActiveRecord::Base.group using a string as argumentMaurizio De Santis2013-02-071-0/+3
| | | |
| * | | Add documentation for ActiveRecord.select when use strings as argumentsMaurizio De Santis2013-02-071-0/+10
| | | |
| * | | Add ActiveRecord.count documentation when used on group relationsMaurizio De Santis2013-02-071-0/+6
| | | |
* | | | Revert "Make valid_type? public"Jon Leighton2013-02-154-12/+17
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 5d528f835e871f5f9d4b68e8a81cfbe900b7e718. Relates to f8c8ad5 which is also getting reverted due to failing test.
* | | | Revert "checking in the abstractions for valid type checking:"Jon Leighton2013-02-154-28/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c321b309a9a90bbfa0912832c11b3fef52e71840. Conflicts: activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb Reason: failing test 1) Error: test_valid_column(ActiveRecord::ConnectionAdapters::SQLite3AdapterTest): NoMethodError: undefined method `column' for test/cases/adapters/sqlite3/sqlite3_adapter_test.rb:29:in `test_valid_column'
* | | | Revert "Revert "Merge pull request #9206 from ranjaykrishna/use_define_method""Jon Leighton2013-02-151-18/+13
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8aa4603a5adaa56c818a7bd1c0b761b4ecca3d3e. Reverting the revert because I reverted the wrong thing! Fail.
* | | | Revert "Merge pull request #9206 from ranjaykrishna/use_define_method"Jon Leighton2013-02-151-13/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 1fc6876b57f2e1d31731e74eb4271b5655e746d2, reversing changes made to 0268b5d8cdc3c5a1337462135f0a326a2654ba1a. Reason: failing test 1) Error: test_valid_column(ActiveRecord::ConnectionAdapters::SQLite3AdapterTest): NoMethodError: undefined method `column' for test/cases/adapters/sqlite3/sqlite3_adapter_test.rb:29:in `test_valid_column'
* | | | Merge pull request #9252 from senny/8423_hmt_preloading_bugRafael Mendonça França2013-02-143-1/+30
|\ \ \ \ | | | | | | | | | | don't cache invalid subsets when preloading hmt associations
| * | | | don't cache invalid subsets when preloading hmt associations.Yves Senn2013-02-143-1/+30
| | | | | | | | | | | | | | | | | | | | closes #8423.
* | | | | Make valid_type? publicSam Ruby2013-02-144-17/+12
|/ / / /
* | | | Merge pull request #9254 from warnickr/9253_avoid_bigdecimal_performance_issueCarlos Antonio da Silva2013-02-131-4/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before writing a numeric attribute value, ActiveRecord does an implicit conversion of boolean types (true => 1 and false => 0). If the numeric value being assigned is a BigDecimal, then ActiveRecord compares a BigDecimal to true and false. This is known to be very slow in Ruby 1.9.3 (see http://www.ruby-forum.com/topic/4409452 and https://bugs.ruby-lang.org/issues/7645#change-35188). The Ruby core team has implemented a fix for this issue that will be included in Ruby 2, but they appear to have no intention of back-porting this fix to Ruby 1.9.3. In my case, the performance impact of this issue was enormous (200% - 300% performance hit) for some of the pages in my application. See c75b5a88a82c79fdf95dfea4d72bf3c5a829930e applied to 3-2-stable branch for more reasoning and a benchmark.
| * | | | 9253: Before writing a numeric attribute value, ActiveRecord does an implicitRyan Warnick2013-02-131-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | conversion of boolean types (true => 1 and false => 0). If the numeric value being assigned is a BigDecimal, then ActiveRecord compares a BigDecimal to true and false. This is known to be very slow in Ruby 1.9.3.
* | | | | Don't call after_commit when creating through an association and save fails, ↵James Miller2013-02-133-1/+36
|/ / / / | | | | | | | | | | | | fixes #5802
* | | | Merge pull request #9204 from ranjaykrishna/col-probAaron Patterson2013-02-128-1/+43
|\ \ \ \ | | | | | | | | | | schema dumper tests now conducted by ActiveRecord::Base.Connection
| * | | | checking in the abstractions for valid type checking:Ranjay Krishna2013-02-128-1/+43
| | | | |
* | | | | Merge pull request #9206 from ranjaykrishna/use_define_methodCarlos Antonio da Silva2013-02-121-18/+13
|\ \ \ \ \ | | | | | | | | | | | | Use define method instead of class_eval
| * | | | | reverted back our changes and added in the new define_methodRanjay Krishna2013-02-121-18/+13
| |/ / / /
* | | | | test for regression from a712e08ebe21f6d8653a0e6602df2e0f5d40d9caAaron Patterson2013-02-111-0/+6
| | | | |
* | | | | define Active Record Store accessors in a moduleSergey Nartimov2013-02-114-12/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow store accessors to be overrided like other attribute methods, e.g.: class User < ActiveRecord::Base store :settings, accessors: [ :color, :homepage ], coder: JSON def color super || 'red' end end
* | | | | fixing bit string testAaron Patterson2013-02-101-3/+3
| | | | |
* | | | | Update activerecord/CHANGELOG.mdGuillermo Iguaran2013-02-091-1/+1
| | | | |
* | | | | Use IN operator like arel for empty hash in where clauserobertomiranda2013-02-091-1/+1
| | | | |
* | | | | Reverting e170014113 (Change behaviour with empty hash in where clause)Guillermo Iguaran2013-02-083-12/+3
| | | | |
* | | | | Reverting 16f6f25 (Change behaviour with empty array in where clause)Guillermo Iguaran2013-02-086-14/+13
| | | | |
* | | | | Improve changelog entries in ARCarlos Antonio da Silva2013-02-081-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Describe better the changes related to raising errors with empty array/hash values in where clauses. [ci skip]
* | | | | Change behaviour with empty array in where clauserobertomiranda2013-02-086-13/+14
| | | | |
* | | | | Change behaviour with empty hash in where clauserobertomiranda2013-02-083-3/+11
| | | | |
* | | | | Merge pull request #9207 from dylanahsmith/mysql-quote-numericGuillermo Iguaran2013-02-078-14/+60
|\ \ \ \ \ | |_|_|_|/ |/| | | | active_record: Quote numeric values compared to string columns.
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-11 13:30:55 +0000