aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* These extra array operations appear to be unnecessary. Reasoning:Jon Leighton2011-05-141-8/+2
| | | | | * It is not necessary to subtract 'id' from the list of copied attributes because record and mem_record are equal, so therefore their id attributes are also equal (so there is no harm in copying it, and this reduces the complexity of the code) * It is not necessary to intersect the attribute names, since record and mem_record are equal, so they have the same id and class, so they have the same columns in the database. If record has non-column attributes then it seems reasonable to also copy them onto mem_record (though I am not sure what situation this would ever happen in)
* CollectionAssociation#merge_target_lists should write to the underlying ↵Jon Leighton2011-05-144-5/+17
| | | | attributes when copying, rather than using the assignment method
* An attempt to make CollectionAssociation#merge_target_lists make more sense.Jon Leighton2011-05-141-16/+35
|
* Added some docs to controller runtime.José Valim2011-05-141-1/+4
|
* Reset ActiveRecord::LogSubscriber runtime at the start of each requestTom Ward2011-05-141-0/+5
| | | | Previously the runtime was reset implicitly when #cleanup_view_runtime was called at the end of most requests. However, this doesn't happen when the request redirects, or send_file is called. Consequently, the ActiveRecord runtime recorded in the logs included the time taken for both the current request and the previous redirect. Explicitly resetting at the start of each request ensures that this can't happen, no matter what occurs previously.
* Merge branch 'master' of git://github.com/lifo/docrailsXavier Noria2011-05-141-1/+1
|\ | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/date_helper.rb railties/lib/rails/generators/rails/app/templates/config/initializers/wrap_parameters.rb.tt
| * :touch => :symbol also updates the updated_at attributeBruno Michel2011-05-101-1/+1
| |
* | Instead of doing find(:all) which does scoped.find(:all) which does ↵Jon Leighton2011-05-131-1/+1
| | | | | | | | scoped.all, just do scoped.all.
* | Remove pointless rescue (it doesn't happen anywhere in the tests, and I ↵Jon Leighton2011-05-131-9/+1
| | | | | | | | can't see a way that it would happen ever)
* | backport skip to the AR base classAaron Patterson2011-05-131-0/+7
| |
* | supporting infinity and -infinity for timestamps in PG. fixes #544Aaron Patterson2011-05-132-0/+39
| |
* | Don't use mass-assignment protection when setting foreign keys or ↵Jon Leighton2011-05-123-9/+45
| | | | | | | | association conditions on singular associations. Fixes #481 (again).
* | updated AR#create! to accept an options hash so the mass-assignment security ↵Josh Kalderimis2011-05-124-18/+44
| | | | | | | | role can be passed in, also updated the Changelog to mention the change to some of the AR method signatures.
* | Merge pull request #491 from arunagw/readme_changesSantiago Pastorino2011-05-111-1/+1
|\ \ | | | | | | Some readme fixes as required.
| * | Some readme fixes as required. Arun Agrawal2011-05-101-1/+1
| | |
* | | Merge pull request #512 from pivotalneutron/fix_eager_load_with_calculationsJon Leighton2011-05-113-6/+18
|\ \ \ | | | | | | | | Bug fixes for calculations with includes
| * | | Bug fixes:Fadzril Muhamad & Joseph Palermo2011-05-123-6/+18
| | | | | | | | | | | | | | | | | | | | | | | | - If doing a count on a relation that has an :include and a :join, it does a distinct even though it should not. - When doing a count on a relation that has an :include, it always falls back to a old style left join when performing the count. Looks like it was broken here: https://github.com/rails/rails/commit/b9599502c9e738a5a1513e75d08f8d40ed408265
* | | | Add missing requiresSantiago Pastorino2011-05-111-0/+1
| | | |
* | | | Fix assigning protected attributes by attributes=knapo2011-05-112-6/+10
| | | |
* | | | Don't remove the target if it has already been destroyedAndrew White2011-05-112-1/+10
| | | |
* | | | Modified NamedScopeTest to use CollectionAssociation.Michael Ebens2011-05-111-1/+1
| | | |
* | | | Modified CollectionAssociation to refer to the new class name.Michael Ebens2011-05-111-1/+1
|/ / /
* | | Don't use select() values from the join model of a through association. ↵Jon Leighton2011-05-115-3/+23
| | | | | | | | | | | | Fixes #508.
* | | Bring back obj.association_loaded? as a deprecated method. Fixes #472.Jon Leighton2011-05-112-0/+22
| | |
* | | fix bug in usage example of #unscopedCorin Langosch2011-05-111-1/+1
| | |
* | | Add test to specify that attributes from an association's conditions should ↵Jon Leighton2011-05-104-4/+28
| | | | | | | | | | | | be assigned without mass-assignment protection when a record is built on the association.
* | | Remove unnecessary '|| {}'Jon Leighton2011-05-101-1/+1
| | |
* | | Don't use mass-assignment protection when applying the ↵Jon Leighton2011-05-103-3/+16
| | | | | | | | | | | | scoped.scope_for_create. Fixes #481.
* | | minor cleaning with new api methodVishnu Atrai2011-05-111-11/+11
| | |
* | | deprecating CSV fixture supportAaron Patterson2011-05-104-55/+7
| | |
* | | deprecating read_csv_fixture_files methodAaron Patterson2011-05-101-0/+2
| | |
* | | Merge pull request #495 from vatrai/minor_fixesPiotr Sarnacki2011-05-102-2/+2
|\ \ \ | | | | | | | | minor cleaning
| * | | minor cleaningVishnu Atrai2011-05-102-2/+2
| |/ /
* | | Merge pull request #493 from guilleiguaran/changelog-fixesAaron Patterson2011-05-101-0/+80
|\ \ \ | | | | | | | | Merging 3.0.x CHANGELOGs
| * | | Merging 3.0.x CHANGELOGsGuillermo Iguaran2011-05-101-0/+80
| | | |
* | | | Methods that return nil should not be considered YAMLJoshua Wehner2011-05-101-4/+1
| |/ / |/| |
* | | Puts ActiveRecord::SessionStore attributes in white list, fixes #483slainer682011-05-102-0/+8
| | |
* | | Fix typos in IM documentationVijay Dev2011-05-101-2/+2
| | |
* | | Document identity map inconsistency with associations, closes #474.José Valim2011-05-101-1/+28
| | |
* | | Fix #480. Passing nil to create association works.José Valim2011-05-101-1/+1
| | |
* | | Revert "b9ea751d0e56bd00d341766977a607ed3f7ddd0f".José Valim2011-05-101-26/+27
| | | | | | | | | | | | | | | Wrapping each Record.associations.build in a transaction is going to make several unneeded queries. Reverting this commit also fixes #479.
* | | Add failing tests according to #479.José Valim2011-05-101-0/+15
| | |
* | | Add failing tests, according to #480.José Valim2011-05-101-0/+14
| | |
* | | Ensure assign_attributes and update_attributes do not fail on nil, closes #478.José Valim2011-05-103-0/+10
|/ /
* | use a null byte as a bind parameter substitute as it is not allowed in ↵Aaron Patterson2011-05-093-12/+59
| | | | | | | | normal SQL. fixes #411, #417
* | removed an unneed AS::Concern from AR::IdentityMapJosh Kalderimis2011-05-091-2/+1
| |
* | Interleave db_list and file_list.Christopher Wade2011-05-091-6/+6
| |
* | Sort migrations by the migration ID.Christopher Wade2011-05-091-2/+2
| |
* | Merge pull request #451 from baroquebobcat/fixing_last_for_issue_371Jon Leighton2011-05-082-1/+27
|\ \
| * | Fix for #371Nick Howard2011-05-082-1/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if a query contains a limit or an offset, ActiveRecord::FinderMethods#find_last had inconsistent behavior. If the records were loaded, it returned the last record in the cached list. If they were not, it reversed the order of the query and changed the limit to one. If the earlier limit was less than the total matching the query in the db, it would return a different record than if the records had been cached. This commit changes find_last so that it loads the records when getting the last record on a query containing a limit or an offset, which makes the behavior consistent.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 09:22:48 +0000