aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Unused model DeprecatedPostWithCommentAkira Matsuda2013-01-241-7/+0
|
* Fix PostgreSQL tests on TravisAndrew White2013-01-243-11/+37
| | | | Travis only has PostgreSQL 9.1.x but 9.2 is required for range datatypes.
* Merge pull request #7345 from slbug/masterRafael Mendonça França2013-01-2311-189/+431
|\ | | | | Postgresql range support
| * Add postgresql range types supportbUg2013-01-2311-189/+431
| |
* | Remove warning by using a custom coderAndrew White2013-01-231-2/+16
|/ | | | | | | | | | | | | | The native JSON library bypasses the `to_json` overrides in active_support/core_ext/object/to_json.rb by calling its native implementation directly. However `ActiveRecord::Store` uses a HWIA so `JSON.dump` will call our `to_json` instead with a `State` object for options rather than a `Hash`. This generates a warning when the `:encoding`, `:only` & `:except` keys are accessed in `Hash#as_json` because the `State` object delegates unknown keys to `instance_variable_get` in its `:[]` method. Workaround this warning in the test by using a custom coder that calls `ActiveSupport::JSON.encode` directly.
* A test case name needs to start with "test_"Akira Matsuda2013-01-231-1/+1
|
* Less strict activerecord-deprecated_finders versionRafael Mendonça França2013-01-221-1/+1
|
* Revert "Round usec when writing timestamp attribute."Andrew White2013-01-222-28/+5
| | | | | | | | | | This reverts commit e9d2ad395ec2ef929d74752f3d71c80674044fbe. Closes #8460 Conflicts: activerecord/lib/active_record/attribute_methods/time_zone_conversion.rb activerecord/test/cases/dirty_test.rb
* Add failing test case for #8460Andrew White2013-01-221-0/+14
| | | | Add a test case to ensure that fractional second updates are detected.
* Whitespaces :scissors:Rafael Mendonça França2013-01-222-19/+16
| | | | [ci skip]
* Just ignore all PRAGMA queriesAkira Matsuda2013-01-221-1/+1
|
* Reset SchemaMigration after updatingAkira Matsuda2013-01-221-0/+1
|
* Preload some join table schemasAkira Matsuda2013-01-221-0/+9
|
* Ignore schema queries on SQLite 3 as wellAkira Matsuda2013-01-221-1/+2
|
* Be sure to clear schema cacheAkira Matsuda2013-01-221-0/+3
|
* Ignore "SHOW search_path" when counting PostgreSQL queriesAkira Matsuda2013-01-221-1/+1
|
* Reset table_name_{prefix,suffix}, and table_name after each testAkira Matsuda2013-01-221-11/+4
| | | | because some tests were not resetting them, and thus the tests were order dependent
* Missing repair_validationsAkira Matsuda2013-01-221-12/+14
|
* Refactored transaction state into its own object. Each transaction creates a ↵wangjohn2013-01-212-7/+34
| | | | new transaction state object upon initialization.
* Remove extra sort from testVipul A M2013-01-211-3/+3
| | | | Cleanup change_schema tests to remove extra sorts on columns.
* Merge pull request #8913 from ↵Carlos Antonio da Silva2013-01-202-0/+10
|\ | | | | | | | | seejee/regression_test_for_chained_preloaded_scopes Added test case to prevent regression of chained, preloaded scopes.
| * Added test case to prevent regression of chained, preloaded scopes. (#7490)Chris Geihsler2013-01-192-0/+10
| |
* | Merge pull request #9008 from ranjaykrishna/dbcreateGuillermo Iguaran2013-01-201-0/+1
|\ \ | | | | | | Added a new rake task in activerecord
| * | added db:drop task that executes mysql:drop_databses and ↵Ranjay Krishna2013-01-201-0/+1
| | | | | | | | | | | | postgresql:drop_databases
* | | Merge pull request #9006 from wangjohn/activerecord_transaction_stateAaron Patterson2013-01-204-11/+49
|\ \ \ | | | | | | | | Created state for a transaction and added tests.
| * | | Added a changelog entry.wangjohn2013-01-201-0/+5
| | | |
| * | | Removed reflects_transaction_state.wangjohn2013-01-201-1/+0
| | | |
| * | | Created state for a transaction and added tests.wangjohn2013-01-203-11/+45
| | | |
* | | | Merge pull request #9005 from ranjaykrishna/dbcreateAaron Patterson2013-01-201-0/+4
|\ \ \ \ | | |/ / | |/| | added a db create rake task.
| * | | removed the puts statement and simplified the execute statementRanjay Krishna2013-01-201-6/+1
| | | |
| * | | added rake db:create that executes mysql:build_databases and ↵Ranjay Krishna2013-01-201-0/+9
| | | | | | | | | | | | | | | | postgresql:build_databases
* | | | Don't use anonymous classes in connection testsGuillermo Iguaran2013-01-191-3/+5
| |/ / |/| |
* | | Anonymous class is not allowed. For reference see #8934 and bc43763247e25Guillermo Iguaran2013-01-191-4/+6
| | |
* | | fix anonymous class issueDavid2013-01-202-0/+15
|/ /
* | Improve relation docs about to_sql and where_values_hashCarlos Antonio da Silva2013-01-191-4/+4
| | | | | | | | | | | | | | | | * User class instead of Users. * #where_values_hash does not change the value to downcase as the example was showing. [ci skip]
* | Merge pull request #8994 from Springest/fix_default_scope_update_all_delete_allJon Leighton2013-01-183-2/+33
|\ \ | | | | | | Fix .update_all and .delete_all when using a condition on a joined table in a default_scope
| * | Fix .update_all and .delete_all when using a condition on a joined tableDerek Kraan2013-01-113-2/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | in a default_scope. `Model.joins(...).where(condition_on_joined_table).update_all` / `delete_all` worked, but the same operation implemented with a default_scope generated a SQL error because ActiveRecord ignored the join but implemented the where condition anyways.
* | | Revert "Merge pull request #8989 from robertomiranda/use-rails-4-find-by"Guillermo Iguaran2013-01-1818-63/+63
| | | | | | | | | | | | | | | This reverts commit 637a7d9d357a0f3f725b0548282ca8c5e7d4af4a, reversing changes made to 5937bd02dee112646469848d7fe8a8bfcef5b4c1.
* | | Merge pull request #8989 from robertomiranda/use-rails-4-find-byGuillermo Iguaran2013-01-1818-63/+63
|\ \ \ | | | | | | | | Replace deprecated find_by_* with find_by
| * | | User Rails 4 find_byrobertomiranda2013-01-1818-63/+63
| | | |
* | | | Undeprecate the :extend optionJon Leighton2013-01-186-3/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Suggested by @dhh. It doesn't affect the generated SQL, so seems reasonable to continue to allow it as an association option.
* | | | CollectionProxy should be default scopedJon Leighton2013-01-182-0/+6
| | | | | | | | | | | | | | | | Fixes #8795
* | | | Merge pull request #8912 from senny/8879_association_empty_methodJon Leighton2013-01-183-1/+19
|\ \ \ \ | | | | | | | | | | `CollectionAssociation#empty?` respects newly builded records
| * | | | `CollectionAssociation#empty?` respects newly builded recordsYves Senn2013-01-133-1/+19
| | |_|/ | |/| |
* | | | iterates the RDoc of update_column(s)Xavier Noria2013-01-181-13/+13
| |/ / |/| | | | | | | | | | | | | | | | | | | | This revision makes crystal clear that the methods go straight to the database and update the receiver. It also adds and example, and removes the duplication in the singular and plural forms by referring one to the other.
* | | Refactor predicate builder when receiving empty hashCarlos Antonio da Silva2013-01-171-4/+4
| | | | | | | | | | | | | | | | | | | | | There's no need to create a new arel table or reflect on the column association if the value is empty, these attributes are not used. Also no need to concat a new array, just append the query value.
* | | Don't rely on Hash key's orderingVitor Baptista2013-01-163-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we set encoding latin1 for a PostgreSQL database, it calls PostgreSQLAdapter::create_database with options that have, among other things: { 'encoding' => 'latin1' } Then, we use reverse_merge(:encoding => "utf8") to setup the default encoding. In the end, the hash looks like: { :encoding => 'utf8', 'encoding' => 'latin1' } The call to options.symbolize_keys calls to_sym on each_key of this Hash. It usually means that the encoding passed overwrites the default utf8, but it's not guaranteed. So, we shouldn't rely on it. The same was happening in ActiveRecord::ConnectionHandling.
* | | Revert "Merge pull request #8930 from cordawyn/ordered_railties"Carlos Antonio da Silva2013-01-152-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8348f9ea72c9b50fc4d4462fd9ebe3bba932c783, reversing changes made to 9dfe2d6f9fabddf9a451a995678a9648c8aaf401. Reason: this broke railties tests as explained in the issue, and the author is going to review and report back. https://github.com/rails/rails/pull/8930#issuecomment-12272671
* | | Merge pull request #8930 from cordawyn/ordered_railtiesCarlos Antonio da Silva2013-01-152-1/+5
|\ \ \ | | | | | | | | rake railties:install:migrations respects the order of railties
| * | | rake railties:install:migrations respects the order of railtiesSlava Kravchenko2013-01-142-1/+5
| |/ /