aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | | support finding by a ruby class [#5979 state:resolved]Aaron Patterson2010-11-152-0/+10
| | | | | | | | | |
* | | | | | | | | | adding more test coverage around finding with active record objectsAaron Patterson2010-11-151-0/+12
| | | | | | | | | |
* | | | | | | | | | use quoted id of single AR::Base objects in predicatesAaron Patterson2010-11-152-0/+8
|/ / / / / / / / /
* | | | | | | | | if association is already loaded and if a find operation is performed on the ↵Neeraj Singh2010-11-152-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | already loaded association list with an empty hash then do not perform another sql [#5972 state:resolved]
* | | | | | | | | fisting a bunch of unused variable warningsAaron Patterson2010-11-154-20/+16
| | | | | | | | |
* | | | | | | | | Remove unused varSantiago Pastorino2010-11-141-1/+1
| | | | | | | | |
* | | | | | | | | Fix bug where size of through association is not correct after adding a ↵Jason Cheow2010-11-142-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | has_many association (occurs only before main object has been reloaded). [#5968 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | | | | | | | | Finder gives a little bit more info on the lookup column (primary key)Franck Verrot2010-11-132-1/+11
| | | | | | | | |
* | | | | | | | | present? is better hereSantiago Pastorino2010-11-111-1/+1
| | | | | | | | |
* | | | | | | | | Merge remote branch 'drogus/plugin_new'José Valim2010-11-111-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: railties/test/generators/app_generator_test.rb
| * | | | | | | | | Use application's generators defaults as engine defaults to not force users ↵Piotr Sarnacki2010-11-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to manually set it
* | | | | | | | | | STI type is now updated when calling AR::Base.becomes on subclasses [#5953 ↵Franck Verrot2010-11-122-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | state:resolved]
* | | | | | | | | | Use ! instead of notSantiago Pastorino2010-11-111-1/+1
| | | | | | | | | |
* | | | | | | | | | Fixed bug in active_record/nested_attributes where an empty string id caused ↵Santiago Pastorino2010-11-112-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | an ActiveRecord::RecordNotFound error. Found by [Ben Tillman] [#5638 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | | | | | | | | | Bump Arel up to 2.0.2Santiago Pastorino2010-11-111-1/+1
| | | | | | | | | |
* | | | | | | | | | Allow AR Session Store to be renewedJosé Valim2010-11-111-0/+1
| | | | | | | | | |
* | | | | | | | | | syncs CHANGELOGs for 3.0.2 in 3-0-stable with the ones in masterXavier Noria2010-11-091-0/+29
| | | | | | | | | |
* | | | | | | | | | Double negation of an already boolean value produces the same resultSantiago Pastorino2010-11-091-1/+1
| | | | | | | | | |
* | | | | | | | | | Don't check if persisted is defined just initialize it properlySantiago Pastorino2010-11-093-4/+1
| | | | | | | | | |
* | | | | | | | | | Execute less operationsSantiago Pastorino2010-11-091-2/+1
| | | | | | | | | |
* | | | | | | | | | use persisted? instead of new_record? wherever possibleDavid Chelimsky2010-11-0935-196/+203
| |_|_|_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | | | | | | | | Update the validates_uniqueness_of documentation to tell you to use a unique ↵Michael Koziarski2010-11-081-25/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | index. The other options mentioned were not good ideas and disclaimed as such in the documentation.
* | | | | | | | | use column names as order by complex function parameters, fix for postgresql ↵Raimonds Simanovskis2010-11-072-13/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | adapter to correctly remove ASC/DESC Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | | | | | | | | reduce duplication in assiciations #construct()Aaron Patterson2010-11-061-9/+3
| | | | | | | | |
* | | | | | | | | make sure we keep parent records in orderAaron Patterson2010-11-061-6/+6
| | | | | | | | |
* | | | | | | | | only call to_s on the association variable onceAaron Patterson2010-11-051-2/+5
| | | | | | | | |
* | | | | | | | | simplify instantiate in the join parts objectAaron Patterson2010-11-051-8/+7
| | | | | | | | |
* | | | | | | | | index is not used, so removing itAaron Patterson2010-11-051-1/+1
| | | | | | | | |
* | | | | | | | | reduce method calls to the join base objectAaron Patterson2010-11-051-4/+6
| | | | | | | | |
* | | | | | | | | stop recursively calling exists?Aaron Patterson2010-11-051-3/+5
| | | | | | | | |
* | | | | | | | | Avoid warning: shadowing outer local variableSantiago Pastorino2010-11-051-2/+2
| | | | | | | | |
* | | | | | | | | Fixes queries using limits and punctuation in order, removes order("col1, ↵Santiago Pastorino2010-11-055-8/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | col2") usage in favor of order(["col1", "col2"}) [#4597 state:committed]
* | | | | | | | | renaming exec in the mysql adapterAaron Patterson2010-11-052-15/+15
| | | | | | | | |
* | | | | | | | | renaming exec in the PG adapterAaron Patterson2010-11-053-14/+14
| | | | | | | | |
* | | | | | | | | converted exec to exec_query for sqliteAaron Patterson2010-11-054-27/+27
| | | | | | | | |
* | | | | | | | | Association Proxy should not undefine the default respond_to_missingsblackstone2010-11-041-1/+1
| | | | | | | | |
* | | | | | | | | ignoring certain SQL when using OracleAaron Patterson2010-11-031-0/+4
| | | | | | | | |
* | | | | | | | | select goes through exec(), so no method chaining for query countsAaron Patterson2010-11-031-12/+0
| | | | | | | | |
* | | | | | | | | use bind params in select with query monkeypatchAaron Patterson2010-11-031-2/+2
|/ / / / / / / /
* | | | | | | | Make should_record_timestamps? serialization aware rather than object#changed?Pratik Naik2010-11-022-5/+1
| | | | | | | |
* | | | | | | | Ensure save always updates timestamps when serialized attributes are presentPratik Naik2010-11-022-0/+18
| | | | | | | |
* | | | | | | | Add timestamps to TopicPratik Naik2010-11-023-6/+7
| |_|_|_|_|_|/ |/| | | | | |
* | | | | | | only returning where values for the corresponding relation, also filtering ↵Aaron Patterson2010-10-302-6/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | where value hash based on table name [#5234 state:resolved] [#5184 state:resolved]
* | | | | | | adding tests for #5234 and #5184. Tests were from Akira Matsuda. Thanks Akira!Aaron Patterson2010-10-302-0/+11
| | | | | | |
* | | | | | | no need to merge where values if no new where values have been addedAaron Patterson2010-10-301-11/+13
| | | | | | |
* | | | | | | Convert :primary_key in association to a string before comparing to column ↵Denis Odorcic2010-10-303-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | names, so that for example :primary_key => :another_pk works as well [#5605 state:resolved]
* | | | | | | refactoring find_join_associationAaron Patterson2010-10-301-5/+6
| | | | | | |
* | | | | | | Fix issues when including the same association multiple times and mixing ↵Ernie Miller2010-10-302-11/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | joins/includes together.
* | | | | | | Refactoring: replace the mix of variables like @finder_sql, @counter_sql, ↵Jon Leighton2010-10-3011-159/+146
| | | | | | | | | | | | | | | | | | | | | | | | | | | | etc with just a single scope hash (created on initialization of the proxy). This is now used consistently across all associations. Therefore, all you have to do to ensure finding/counting etc is done correctly is implement the scope correctly.
* | | | | | | only do string substitution on column names once, remove intermediate data ↵Aaron Patterson2010-10-301-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | structures