aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | log bind variables after they were type casted.Yves Senn2013-11-095-10/+36
| |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The log output used to be confusing in situation where type casting has "unexpected" effects. For example when finding records with a `String`. BEFORE: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", "im-no-integer"]] AFTER: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", 0]]
* | | | | | Mark broken test as pendingRafael Mendonça França2013-11-082-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | This will avoid the broken window effect in our test suite
* | | | | | Remove more skipRafael Mendonça França2013-11-084-13/+7
| | | | | |
* | | | | | Don't skip tests if we don't need to.Rafael Mendonça França2013-11-0830-1023/+966
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can conditional define the tests depending on the adapter or connection. Lets keep the skip for fail tests that need to be fixed.
* | | | | | Merge pull request #12791 from jasonayre/ja/fix_autoload_errorRafael Mendonça França2013-11-072-0/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | add autoload :TransactionState to fix Marshal.load issues
| * | | | | | revised changelog comment to be less than 80 charsJason Ayre2013-11-071-2/+2
| | | | | | |
| * | | | | | add autoload :TransactionState to fix Marshal.load issuesJason Ayre2013-11-072-0/+6
| | |_|_|/ / | |/| | | |
* | | | | | Warning removed for ruby-headRashmi Yadav2013-11-071-1/+1
| |_|_|_|/ |/| | | |
* | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2013-11-072-0/+7
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | refine usage docs of `store` in combination with `hstore` and `json`.Yves Senn2013-11-061-3/+3
| | | | | | | | | | | | | | | | | | | | refs #11561 #12700
| * | | | Hstore and JSON fields are not supported with storeRobin Dupret2013-10-301-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | The use of `store` on Hstore fields (for instance) is not needed because serialization aimed to interact with Ruby objects and not with provided field types
| * | | | warning about saving models with dirty attributesDamien Mathieu2013-10-231-0/+3
| | | | | | | | | | | | | | | | | | | | See #8328
* | | | | Stop using method missing for singleton delegation.Aaron Patterson2013-11-061-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This saved about 46 array allocations per request on an extremely simple application. The delegation happened in the notification subsystem which is a hotspot, so this should result in even more savings with larger apps. Squashed commit of the following: commit 41eef0d1479526f7de25fd4391d98e61c126d9f5 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:32:31 2013 -0800 speed up notifications commit 586b4a18656f66fb2c518fb8e8fee66a016e8ae6 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:31:05 2013 -0800 speed up runtime registry methods commit b67d074cb4314df9a88438f785868cef77e583d7 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:28:12 2013 -0800 change method name and make it public
* | | | | bring back constant to expose the enum mapping as HWIA.Yves Senn2013-11-062-4/+19
| | | | |
* | | | | update the AR enum docs to match the actual behavior. [ci skip]Yves Senn2013-11-061-5/+3
| |_|_|/ |/| | |
* | | | store enum mapping using `Strings` instead of `Symbols`.Yves Senn2013-11-052-3/+9
| | | | | | | | | | | | | | | | | | | | This allows to assign both `String` and `Symbol` values to the enum without having to call `to_sym`, which is a security problem.
* | | | direct enum assignment rasies ArgumentError for unknown values.Yves Senn2013-11-052-1/+18
| | | |
* | | | define enum methods inside a `Module` to make them overwritable.Yves Senn2013-11-053-13/+34
| | | |
* | | | Merge pull request #12390 from kennyj/rename_to_association_methodsRafael Mendonça França2013-11-054-7/+7
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Renamed generated_feature_methods to generated_association_methods. Conflicts: activerecord/lib/active_record/associations/builder/association.rb activerecord/lib/active_record/associations/builder/singular_association.rb activerecord/test/cases/base_test.rb
| * | | | Renamed generated_feature_methods to generated_association_methods.kennyj2013-09-285-12/+12
| | | | |
* | | | | Remove private API testRafael Mendonça França2013-11-051-10/+0
| | | | |
* | | | | Use 1.9 Hash syntax consistentlyPablo Torres2013-11-051-1/+1
| | | | |
* | | | | ask the fixture set for the sql statementsAaron Patterson2013-11-042-11/+17
| | | | |
* | | | | The enum value constant isn't used, so rm it for now.Aaron Patterson2013-11-042-27/+7
| | | | |
* | | | | stop doing the same calculation over and overAaron Patterson2013-11-041-4/+5
| | | | |
* | | | | fix copy & paste test-case naming. [ci skip]Yves Senn2013-11-041-1/+1
| | | | |
* | | | | Fix failures related to enum changesCarlos Antonio da Silva2013-11-041-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 6e4a810f51b9ed2468b92247ef5568cc9d6dbcc0 changed the implementation from class_eval to define_method, but missed the access to the constant versus the access to the constant name.
* | | | | Convert schema file to ruby 1.9 style hashCarlos Antonio da Silva2013-11-041-214/+214
| | | | |
* | | | | Style fixes on test schema fileCarlos Antonio da Silva2013-11-041-6/+6
| | | | |
* | | | | Refactor logic to grab the max time of the list of timestamp names in #cache_keyCarlos Antonio da Silva2013-11-042-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | Reuse the already existing logic used for grabbing this information from the updated columns.
* | | | | Respect cache timestamp format when giving timestamps to #cache_keyCarlos Antonio da Silva2013-11-042-3/+4
| | | | |
* | | | | :scissors: [ci skip]Carlos Antonio da Silva2013-11-041-2/+2
| | | | |
* | | | | Merge pull request #12754 from ↵David Heinemeier Hansson2013-11-041-4/+12
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | ck3g/replace-class-evals-with-define-method-for-enum Replace `class_eval` with `define_method` for enum
| * | | | | Replace `class_eval` with `define_method` for enumVitaly Tatarintsev2013-11-041-4/+12
| | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/commit/db41eb8a6ea88b854bf5cd11070ea4245e1639c5#commitcomment-4502683
* | | | | | Fix changelog indent [ci skip]Carlos Antonio da Silva2013-11-041-6/+6
|/ / / / /
* | | | | Add test verifying that you can only sort ARs of the same typeDavid Heinemeier Hansson2013-11-021-1/+7
| | | | |
* | | | | Revert "ActiveRecord::Base#<=> has been removed. Primary keys may not be in ↵David Heinemeier Hansson2013-11-023-12/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | order," -- will be replaced with a check to ensure that the keys used for comparison are integers, and only fail if they are not. This reverts commit 6256734e2d0bdd89f4b5d11da259d40afa0c95c7. Conflicts: activerecord/CHANGELOG.md
* | | | | Delegate #rewhere to all on the class like all other relation methodsDavid Heinemeier Hansson2013-11-022-1/+5
| | | | |
* | | | | Move documentation around a bitDavid Heinemeier Hansson2013-11-021-4/+7
| | | | |
* | | | | Merge pull request #12747 from yury/explicit-enum-valuesDavid Heinemeier Hansson2013-11-024-1/+15
|\ \ \ \ \ | | | | | | | | | | | | Explicit mapping for enum
| * | | | | Explicit mapping for enumYury Korolev2013-11-024-1/+15
| | | | | |
* | | | | | Added ActiveRecord::QueryMethods#rewhere which will overwrite an existing, ↵David Heinemeier Hansson2013-11-023-0/+52
| | | | | | | | | | | | | | | | | | | | | | | | named where condition.
* | | | | | unscope now works on default_scope after ↵Rafael Mendonça França2013-11-023-9/+9
|/ / / / / | | | | | | | | | | | | | | | 94924dc32baf78f13e289172534c2e71c9c8cade
* | | | | Add a test case for the scope enum addsDavid Heinemeier Hansson2013-11-021-0/+4
| | | | |
* | | | | Extend ActiveRecord::Base#cache_key to take an optional list of timestamp ↵David Heinemeier Hansson2013-11-024-2/+27
| | | | | | | | | | | | | | | | | | | | attributes of which the highest will be used.
* | | | | Use an already existing fixtureCarlos Antonio da Silva2013-11-021-1/+1
| | | | |
* | | | | Fix to work on Ruby 1.9.3, example and changelog improvementsCarlos Antonio da Silva2013-11-024-34/+34
| | | | |
* | | | | Added ActiveRecord::Base#enum for declaring enum attributes where the values ↵David Heinemeier Hansson2013-11-027-2/+128
| | | | | | | | | | | | | | | | | | | | map to integers in the database, but can be queried by name
* | | | | Fix wrong behavior where associations with dependent: :destroy optionsRafael Mendonça França2013-11-013-10/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | was using nullify strategy This caused a regression in applications trying to upgrade. Also if the user set the dependent option as destroy he expects to get the records removed from the database.
* | | | | Test with the right associationRafael Mendonça França2013-11-011-3/+3
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-16 08:03:38 +0000