Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | Remove `DEFAULT NULL` for primary key column to support MySQL 5.7.3 | Yasuo Honda | 2013-12-10 | 3 | -7/+7 | |
|/ / | | | | | | | Since MySQL 5.7.3 m13 does now allow primary key column is null. | |||||
* | | fix typo, "state_state" should be "stale_state" [ci skip] | Scott M | 2013-12-07 | 1 | -1/+1 | |
| | | ||||||
* | | Very tiny typo fix [ci skip] | Robin Dupret | 2013-12-06 | 1 | -1/+1 | |
| | | ||||||
* | | _enum_methods_module should be kept private | Godfrey Chan | 2013-12-05 | 1 | -6/+7 | |
| | | ||||||
* | | Make clear that the enum array should not be changed once defined. [ci skip] | Godfrey Chan | 2013-12-05 | 1 | -1/+12 | |
| | | ||||||
* | | Add integration test for #12459 | George Guimarães | 2013-12-05 | 1 | -0/+8 | |
| | | ||||||
* | | fix pg warnings on geometric types | Aaron Patterson | 2013-12-05 | 1 | -10/+23 | |
| | | ||||||
* | | Improve AR changelog [ci skip] | Carlos Antonio da Silva | 2013-12-05 | 1 | -1/+1 | |
| | | ||||||
* | | Use the right type_map | Rafael Mendonça França | 2013-12-05 | 2 | -5/+3 | |
| | | ||||||
* | | Remove deprecated call to Relation#all | Carlos Antonio da Silva | 2013-12-05 | 1 | -1/+1 | |
| | | ||||||
* | | polymorphic belongs_to association with touch: true updates old record correctly | Severin Schoepke | 2013-12-05 | 3 | -17/+63 | |
| | | | | | | | | | | | | | | | | | | Example: Given you have a comments model with a polymorphic commentable association (e.g. books and songs) with the touch option set. Every time you update a comment its commentable should be touched. This was working when you changed attributes on the comment or when you moved the comment from one book to another. However, it was not working when moving a comment from a book to a song. This is now fixed. | |||||
* | | end sentences with a `.`. [ci skip] | Yves Senn | 2013-12-05 | 1 | -3/+3 | |
| | | ||||||
* | | Use the released arel gem | Rafael Mendonça França | 2013-12-05 | 1 | -1/+1 | |
| | | ||||||
* | | make the type_map per connection. fixes #13182 | Aaron Patterson | 2013-12-04 | 2 | -12/+17 | |
| | | ||||||
* | | Merge pull request #12403 from thedarkone/attr-method-missing-fix | Rafael Mendonça França | 2013-12-04 | 2 | -3/+51 | |
|\ \ | | | | | | | | | | | | | | | | | | | Fix AR#method_missing re-dispatching into overwritten attribute methods Conflicts: activerecord/lib/active_record/attribute_methods.rb | |||||
| * | | Fix AR#method_missing re-dispatching into overwritten attribute methods. | thedarkone | 2013-09-29 | 2 | -3/+51 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was happening when a `super` call in an overwritten attribute method was triggering a method_missing fallback, because attribute methods haven't been generated yet. class Topic < ActiveRecord::Base def title # `super` would re-invoke this method if define_attribute_methods # hasn't been called yet resulting in double '!' appending super + '!' end end | |||||
* | | | Improve AR changelog, add entry for migration error improvements #12462 [ci ↵ | Carlos Antonio da Silva | 2013-12-03 | 1 | -2/+12 | |
| | | | | | | | | | | | | skip] | |||||
* | | | Merge pull request #12462 from jjb/improve_ar_exception_message_formatting | Carlos Antonio da Silva | 2013-12-03 | 1 | -8/+15 | |
|\ \ \ | | | | | | | | | Improve formatting of ActiveRecord migration exception messages | |||||
| * | | | ActiveRecord migration exception message formatting | John Joseph Bachir | 2013-12-03 | 1 | -8/+15 | |
| | | | | ||||||
* | | | | Fix offset with last. | Lauro Caetano | 2013-12-03 | 3 | -1/+16 | |
|/ / / | | | | | | | | | | Closes #7441 | |||||
* | | | `connection.type_to_sql` returns a `String` for unmapped types. | Yves Senn | 2013-12-03 | 3 | -1/+16 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #13146. This fixes an error when using: ``` change_colum :table, :column, :bigint, array: true ``` | |||||
* | | | Fix ActiveRecord::Callbacks sample code [ci skip] | joker1007 | 2013-12-03 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Callback caller class uses `after_initialize`, but Callback callee defines `after_find`. Current sample code causes following error. NoMethodError: undefined method `after_initialize' for #<EncryptionWrapper:0x007fe4931fa5c0> | |||||
* | | | Fix bad usage of #select with hash | Carlos Antonio da Silva | 2013-12-03 | 1 | -1/+1 | |
| | | | ||||||
* | | | Currently, we clear query_cache in cache block finish, even if we may ↵ | Vipul A M | 2013-12-03 | 3 | -1/+15 | |
| | | | | | | | | | | | | | | | | | | already have cache true. This commit takes into account the last cache_enabled value, before clearing query_cache. | |||||
* | | | Introduce a context for rendering fixtures ERB. | Victor Costan | 2013-12-03 | 4 | -1/+95 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixture files are passed through an ERB renderer before being read as YAML. The rendering is currently done in the context of the main object, so method definitons leak into other fixtures, and there is no clean place to define fixture helpers. After this commit, the ERB renderer will use a new subclass of ActiveRecord::FixtureSet.context_class each time a fixture is rendered. | |||||
* | | | Remove deprecated cattr_* requires | Genadi Samokovarov | 2013-12-03 | 2 | -2/+2 | |
| | | | ||||||
* | | | Make the tests break again | Rafael Mendonça França | 2013-12-02 | 1 | -2/+0 | |
| | | | | | | | | | | | | We need to fix this test | |||||
* | | | Cleanups in API docs: his => their | Guillermo Iguaran | 2013-12-02 | 1 | -2/+2 | |
| | | | ||||||
* | | | Use genderless pronouns in API docs | Guillermo Iguaran | 2013-12-01 | 1 | -1/+1 | |
| | | | ||||||
* | | | Improve AR changelog [ci skip] | Carlos Antonio da Silva | 2013-11-30 | 1 | -9/+8 | |
| | | | ||||||
* | | | Merge pull request #13111 from akshay-vishnoi/typo | Carlos Antonio da Silva | 2013-11-30 | 2 | -2/+2 | |
|\ \ \ | | | | | | | | | Typo fixes [ci skip] | |||||
| * | | | Typo fixes [ci skip] | Akshay Vishnoi | 2013-11-30 | 2 | -2/+2 | |
| | | | | ||||||
* | | | | Raise `ArgumentError` when `has_one` is used with `counter_cache` | Godfrey Chan | 2013-11-29 | 5 | -2/+25 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the `has_one` macro incorrectly accepts the `counter_cache` option due to a bug, although that options was never supported nor functional on `has_one` and `has_one ... through` relationships. It now correctly raises an `ArgumentError` when passed that option. For reference, this bug was introduced in 52f8e4b9. | |||||
* | | | | Remove unused variable | Rafael Mendonça França | 2013-11-29 | 1 | -1/+1 | |
|/ / / | | | | | | | | | | | | | This method is not using the block variable directly since it is calling yield | |||||
* | | | Merge pull request #13095 from kuldeepaggarwal/test-case-updation | Yves Senn | 2013-11-29 | 1 | -8/+3 | |
|\ \ \ | | | | | | | | | removed unnecessary test case | |||||
| * | | | updating options documentation for associations | Kuldeep Aggarwal | 2013-11-29 | 1 | -8/+3 | |
| | | | | | | | | | | | | | | | | removed unnecessary test case and improved test case for belongs_to having invalid options | |||||
* | | | | Merge pull request #13099 from kamipo/remove_case_sensitive_equality_operator | Carlos Antonio da Silva | 2013-11-29 | 1 | -4/+0 | |
|\ \ \ \ | | | | | | | | | | | Remove `DatabaseStatements#case_sensitive_equality_operator`. It has been deprecated already. | |||||
| * | | | | Remove `DatabaseStatements#case_sensitive_equality_operator`. It has been ↵ | Ryuta Kamizono | 2013-11-29 | 1 | -4/+0 | |
| | | | | | | | | | | | | | | | | | | | | deprecated already. | |||||
* | | | | | Merge pull request #13100 from akshay-vishnoi/f-refactor | Carlos Antonio da Silva | 2013-11-29 | 1 | -3/+8 | |
|\ \ \ \ \ | |/ / / / |/| | | | | #type_cast - improve performance & readability | |||||
| * | | | | #type_cast - improve performance & readability | Akshay Vishnoi | 2013-11-29 | 1 | -3/+8 | |
| | | | | | ||||||
* | | | | | fix mysql version check in rename_index | Cody Cutrer | 2013-11-28 | 2 | -2/+2 | |
| |/ / / |/| | | | | | | | | | | | also clarify native rename_index support is >= 5.7, not > 5.7 | |||||
* | | | | implement rename_index natively for MySQL > 5.7 | Cody Cutrer | 2013-11-28 | 2 | -0/+12 | |
| | | | | ||||||
* | | | | first pass through CHANGELOGS to extract 4_1_release_notes. [ci skip] | Yves Senn | 2013-11-28 | 1 | -3/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extract **notable changes**, **deprecations** and **removals** from each CHANGELOG. I tried to reference the commits and pull requests for new features and deprecations. In the process I also made some minor changes to the CHANGELOGS. The 4_1_release_notes guide is declared WIP. | |||||
* | | | | Do not create synonym named subjects | Yasuo Honda | 2013-11-27 | 1 | -3/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | because it is only used in `activerecord/test/cases/adapters/oracle/synonym_test.rb` See rails/rails#13054 | |||||
* | | | | Merge pull request #13054 from senny/remove_oracle_tests | Yves Senn | 2013-11-27 | 1 | -17/+0 | |
|\ \ \ \ | | | | | | | | | | | Remove leftover Oracle tests. | |||||
| * | | | | the oracle adapter lives in a gem. Tests should live there as well. | Yves Senn | 2013-11-26 | 1 | -17/+0 | |
| | | | | | ||||||
* | | | | | [ci skip]removed obsolete information about `options` parameter in create method | Kuldeep Aggarwal | 2013-11-27 | 1 | -3/+0 | |
| | | | | | ||||||
* | | | | | [ci skip] used new syntax for scopes | Kuldeep Aggarwal | 2013-11-27 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Merge pull request #13061 from ↵ | Rafael Mendonça França | 2013-11-26 | 3 | -1/+23 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | laurocaetano/fix-uniqueness-validation-for-aliased-attribute Fix bug when validating the uniqueness of an aliased attribute. Conflicts: activerecord/CHANGELOG.md | |||||
* | | | | | changed update counter to act on unscoped model | heruku | 2013-11-26 | 4 | -1/+19 | |
| | | | | |