| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Replace `type_cast` case statement with delegation
|
| |
| |
| |
| |
| |
| |
| |
| | |
All subclasses of column were now delegating `type_cast` to their
injected type object. We can remove the overriding methods, and
generalize it on the `Column` class itself. This also enabled us to
remove several column classes completely, as they no longer had any
meaningful behavior of their own.
|
|\ \
| | |
| | | |
Have Postgres OID types inherit from general types
|
| | |
| | |
| | |
| | |
| | | |
Using general types where possible. Several more can go away once
infinity gets figured out.
|
| | | |
|
| |/
|/| |
|
|/ |
|
|\
| |
| | |
Delegate `#type_cast` to injected type objects on SQLite3
|
| | |
|
|/
|
|
| |
Fixes #14824.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While running Sqlite3 memory tests I encountered the following error:
```
Finished in 69.416366s, 58.0267 runs/s, 162.3681 assertions/s.
1) Error:
ActiveRecord::Migration::ChangeSchemaTest#test_add_column_with_timestamp_type:
NoMethodError: undefined method `type' for nil:NilClass
/Users/senny/Projects/rails/activerecord/test/cases/migration/change_schema_test.rb:244:in `test_add_column_with_timestamp_type'
4028 runs, 11271 assertions, 0 failures, 1 errors, 1 skips
```
This was because the table `testings` was used in multiple test-cases.
This resulted in a wrongly cached schema on `ActiveRecord::Base.schema_chae`.
/cc @zuhao
|
|
|
|
|
| |
Closes #15122
Closes #15107
|
|
|
|
|
|
|
|
|
|
|
|
| |
The `:timestamp` type for columns is unused. All database adapters treat
them as the same database type. All code in `ActiveRecord` which changes
its behavior based on the column's type acts the same in both cases.
However, when the type is passed to code that checks for the `:datetime`
type, but not `:timestamp` (such as XML serialization), the result is
unexpected behavior.
Existing schema definitions will continue to work, and the `timestamp`
type is transparently aliased to `datetime`.
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| | |
jcxplorer/fix-enable_extension-with-table_name_prefix
Fix migrations that use enable_extension with table_name_prefix/suffix
Conflicts:
activerecord/CHANGELOG.md
activerecord/lib/active_record/migration.rb
|
| |
| |
| |
| |
| |
| |
| | |
When using ActiveRecord::Base.table_name_prefix and/or
table_name_suffix, extension names got the same treatment as table names
when running migrations. This led to migrations that tried to call, for
example, enable_extension("prefix_hstore") on the connection.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The decision to wrap type registrations in a proc was made for two
reasons.
1. Some cases need to make an additional decision based on the type
(e.g. a `Decimal` with a 0 scale)
2. Aliased types are automatically updated if they type they point to is
updated later. If a user or another adapter decides to change the
object used for `decimal` columns, `numeric`, and `number` will
automatically point to the new type, without having to track what
types are aliased explicitly.
Everything else here should be pretty straightforward. PostgreSQL ranges
had to change slightly, since the `simplified_type` method is gone.
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
eileencodes/return-early-on-delete-and-destroy-methods
Return early on delete and destroy methods
|
| | |
| | |
| | |
| | |
| | |
| | | |
When delete or destroy is called on all records nothing
is deleted or destroyed. Intead of running through the code and still
not deleteing anything, we should early return
|
|\ \ \
| | | |
| | | | |
Make `:index` in migrations work with all column types
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
Use destructured arguments when looping through pairs
|
| | | |
| | | |
| | | |
| | | | |
Minor refactoring of looping behavior for aggregation
|
| | | |
| | | |
| | | |
| | | | |
Partial revert of c0bfc3f412834ffe8327a15ae3a46602cc28e425
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi]
|
| | | | | |
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
PostgreSQL timestamps should always be datetimes
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The current behavior is that they are treated as `datetime` normally,
but if they are part of an array, they are treated as `timestamp`. The
only place that seems to be impacted by this is schema dumping, which
shouldn't matter since `t.datetime` and `t.timestamp` are equivalent in
the `PostgreSQL` adapter, anyway.
|
| |_|/ /
|/| | |
| | | |
| | | |
| | | |
| | | | |
Part of #15134. In order to perform typecasting polymorphically, we need
to add another argument to the constructor. The order was chosen to
match the `oid_type` on `PostgreSQLColumn`.
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Updates reset_counters to allow counter name in params
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add support for counter name to be passed as parameter
on `CounterCache::ClassMethods#reset_counters`. This is
to be consistent with the other methods in the module
that all accept counter name.
|
| | | | |
|
| | | | |
|
|/ / / |
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Fix `Relation#delete_all` inconsistency
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When relation scopes include one of `uniq`, `group`, `having` or
`offset`, the generated query ignores them and that causes unintended
records to be deleted. This solves the issue by restricting the deletion
when those scopes are present.
rails/rails#11985
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
cc:
https://github.com/rails/rails/commit/a11e2fcff8cdc9691b977d8330abe63024f8c732#commitcomment-6353614
and 0369dbf
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
We are using that code path in only one place so we should not add a
conditional to all the other cases. This will avoid performance
regressions on the old paths.
|
|\ \ \
| | | |
| | | | |
Small refactoring on clear_transaction_record_state
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Make sure when we clean the `@_start_transaction_state` var we do it in
the same code-path.
Also this makes `clear_transaction_record_state`, more consistent with `restore_transaction_record_state`
|
| | | |
| | | |
| | | |
| | | | |
As we have remove code for these adapters so no need to have tasks
|