Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | Move STI docs off of the main Base document, leaving a note | Sean Griffin | 2014-06-30 | 2 | -28/+34 | |
| | | | ||||||
* | | | Update documentation on STI change handling | jamesprior | 2014-06-30 | 1 | -0/+9 | |
| | | | | | | | | | Documenting a potential source of confusion about how STI classes handle changes. | |||||
* | | | Merge pull request #15981 from sgrif/sg-simplify-defaults | Rafael Mendonça França | 2014-06-29 | 3 | -21/+9 | |
|\ \ \ | | | | | | | | | Simplify creation of default attributes on AR instance | |||||
| * | | | Simplify creation of default attributes on AR instance | Sean Griffin | 2014-06-29 | 4 | -21/+10 | |
| | | | | | | | | | | | | | | | | `AttributeSet#dup` has all the behavior we need. | |||||
* | | | | Merge pull request #15977 from sgrif/sg-remove-array-hack | Godfrey Chan | 2014-06-29 | 1 | -24/+0 | |
|\ \ \ \ | | | | | | | | | | | Remove array workaround in PG quoting | |||||
| * | | | | Remove array workaround in PG quoting | Sean Griffin | 2014-06-29 | 1 | -24/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | We no longer need to do fancy legwork to make sure arrays use a type object, now that schema methods use a real type object. | |||||
* | | | | | Remove unused `array_member` from PG quoting for HStore columns | Sean Griffin | 2014-06-29 | 2 | -12/+9 | |
|/ / / / | | | | | | | | | | | | | | | | | Hstore no longer needs additional quoting to be used in an array, the array type handles it sufficiently. | |||||
* | | | | Merge pull request #15983 from sgrif/sg-inline-point | Godfrey Chan | 2014-06-29 | 3 | -19/+9 | |
|\ \ \ \ | | | | | | | | | | | Use the type object when sending point columns to the DB | |||||
| * | | | | Use the type object when sending point columns to the DB | Sean Griffin | 2014-06-29 | 3 | -19/+9 | |
| | | | | | ||||||
* | | | | | Merge pull request #15976 from sgrif/sg-attribute-exists | Godfrey Chan | 2014-06-29 | 1 | -2/+7 | |
|\ \ \ \ \ | |/ / / / |/| | | | | Don't encourage usage of `columns_hash` | |||||
| * | | | | Don't encourage usage of `columns_hash` | Sean Griffin | 2014-06-29 | 1 | -2/+7 | |
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As discussed in https://github.com/plataformatec/simple_form/pull/1094, we should not encourage usage of `columns_hash`, and instead provide an alternate method to determine whether or not an attribute exists. The language `attribute` was chosen over `column` since these are in the `AttributeMethods` module. | |||||
* | | | | Merge pull request #15982 from sgrif/sg-attr-set-map-values | Godfrey Chan | 2014-06-29 | 2 | -7/+4 | |
|\ \ \ \ | | | | | | | | | | | Use `Hash#transform_values` to clean up `AttributeSet` | |||||
| * | | | | Use `Hash#transform_values` to clean up `AttributeSet` | Sean Griffin | 2014-06-29 | 2 | -7/+4 | |
| |/ / / | ||||||
* / / / | Use the type object for sending JSON to the database | Sean Griffin | 2014-06-29 | 4 | -23/+11 | |
|/ / / | ||||||
* | | | Always pass a column with a type object to quote | Sean Griffin | 2014-06-28 | 8 | -28/+25 | |
| | | | | | | | | | | | | | | | | | | | | | | | | The only case where we got a column that was not `nil`, but did not respond to `cast_type` was when type casting the default value during schema creation. We can look up the cast type, and add that object to the column definition. Will allow us to consistently rely on the type objects for type casting in all directions. | |||||
* | | | [Postgresql tests] remove duplicate helper | Abdelkader Boudih | 2014-06-28 | 1 | -12/+3 | |
| | | | ||||||
* | | | MySQL doesn't work with foreign keys | Philippe Creux | 2014-06-27 | 1 | -1/+4 | |
| | | | | | | | | | | | | | | | | | | This was previously fixed in e84799d but broken in 3f596f8. This commit reintroduced the conditional that prevents the foreign keys from being added to MySQL databases. | |||||
* | | | Fix test with add_foreign_key DSL in 9d21ef9 | Philippe Creux | 2014-06-27 | 1 | -1/+1 | |
| | | | ||||||
* | | | Merge pull request #15934 from seuros/rename | Rafael Mendonça França | 2014-06-27 | 3 | -3/+17 | |
|\ \ \ | | | | | | | | | | | | | rename primary key sequence only if it exists | |||||
| * | | | rename sequence only if it exists | Abdelkader Boudih | 2014-06-27 | 3 | -3/+17 | |
| | | | | ||||||
* | | | | Do not change the global state of the test suite | Rafael Mendonça França | 2014-06-27 | 2 | -18/+2 | |
| | | | | ||||||
* | | | | Improve tests to use add_foreign_key DSL | Rafael Mendonça França | 2014-06-27 | 1 | -18/+11 | |
| | | | | ||||||
* | | | | MySQL doesn't works with foreign key | Rafael Mendonça França | 2014-06-27 | 1 | -3/+2 | |
|/ / / | ||||||
* | | | Merge pull request #12450 from iantropov/master | Rafael Mendonça França | 2014-06-27 | 5 | -5/+59 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix bug, when ':dependent => :destroy' violates foreign key constraints Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/associations/builder/association.rb activerecord/lib/active_record/associations/builder/has_one.rb | |||||
| * | | | Fix bug, when ':dependent => :destroy' option violates foreign key ↵ | Ivan Antropov | 2013-10-26 | 5 | -9/+61 | |
| | | | | | | | | | | | | | | | | constraints, issue #12380 | |||||
* | | | | Merge pull request #15788 from sgrif/sg-mutable-strings | Rafael Mendonça França | 2014-06-27 | 5 | -13/+77 | |
|\ \ \ \ | | | | | | | | | | | | | | | | Detect in-place modifications on Strings | |||||
| * | | | | Detect in-place modifications on Strings | Sean Griffin | 2014-06-17 | 4 | -13/+55 | |
| | | | | | ||||||
* | | | | | Merge pull request #8639 from bogdan/valid-with-bang | Rafael Mendonça França | 2014-06-27 | 3 | -1/+36 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | Add AR::Base#valid! method | |||||
| * | | | | | Add AR::Base#validate! method | Bogdan Gusiev | 2014-06-23 | 2 | -1/+31 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Acts same as valid? but raises AR::RecordInvalid exception if validation fails | |||||
* | | | | | | Merge pull request #15940 from DNNX/databases-rake-refactoring | Rafael Mendonça França | 2014-06-27 | 3 | -31/+37 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | databases.rake refactoring | |||||
| * | | | | | | Use AR::SchemaMigration.table_exists? call instead of longish AR::Base...etc,etc | Viktar Basharymau | 2014-06-27 | 1 | -1/+1 | |
| | | | | | | | ||||||
| * | | | | | | Extract AR::SchemaMigration.normalized_versions method | Viktar Basharymau | 2014-06-27 | 2 | -2/+5 | |
| | | | | | | | ||||||
| * | | | | | | db:migrate:status refactoring: Rewrite hand-crafted SQL query with ↵ | Viktar Basharymau | 2014-06-27 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord#pluck | |||||
| * | | | | | | Use Array#flat_map and Array#grep in db:migrate:status task | Viktar Basharymau | 2014-06-27 | 1 | -10/+10 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | It allows the code to be more declarative and elegant. | |||||
| * | | | | | | Add explaining variables to db:migrate:status | Viktar Basharymau | 2014-06-27 | 1 | -2/+2 | |
| | | | | | | | ||||||
| * | | | | | | Replace String index juggling with Pathname goodness in db:fixtures:load | Viktar Basharymau | 2014-06-27 | 1 | -1/+1 | |
| | | | | | | | ||||||
| * | | | | | | db:fixtures:load refactoring: remove unnecessary loop | Viktar Basharymau | 2014-06-27 | 1 | -3/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `ActiveRecord::FixtureSet.create_fixtures` can accept an array of fixture_files. | |||||
| * | | | | | | Extract `fixture_files` variable in fixtures:load rake task | Viktar Basharymau | 2014-06-27 | 1 | -1/+7 | |
| | | | | | | | ||||||
| * | | | | | | Replace a bit of cryptic code in fixtures:load rake task with plain stupid Ruby | Viktar Basharymau | 2014-06-27 | 1 | -1/+5 | |
| | | | | | | | ||||||
| * | | | | | | Get rid of duplication in db:fixtures:{identify,load} | Viktar Basharymau | 2014-06-27 | 2 | -12/+7 | |
| | | | | | | | ||||||
| * | | | | | | db:fixtures:{identify,load} tasks respect AR::Tasks::DatabaseTasks.root | Viktar Basharymau | 2014-06-27 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this commit, if `ENV['FIXTURES_PATH']` was set, then `Rails.root` was used, otherwise the app used `ActiveRecord::Tasks::DatabaseTasks.root`. Now it is consistent. | |||||
| * | | | | | | Simplify complex code in databases.rake | Viktar Basharymau | 2014-06-27 | 1 | -2/+2 | |
| | | | | | | | ||||||
* | | | | | | | Stop using instance exec for type decorators | Sean Griffin & Sean Doyle | 2014-06-27 | 3 | -17/+38 | |
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are moving this behavior out to an object that we would like to keep separated from `ActiveRecord::Base`, which means not passing the class object to it. As such, we need to stop using `instance_exec`, and instead close over the subclass on global type decorators that are applied in `Base`. | |||||
* | | | | | | credit Matthew Higgins for the integration of foreign keys. [ci skip] | Yves Senn | 2014-06-27 | 1 | -0/+3 | |
| | | | | | | ||||||
* | | | | | | Change method visibility | Rafael Mendonça França | 2014-06-26 | 1 | -2/+2 | |
| | | | | | | ||||||
* | | | | | | Add nodoc to internal class [ci skip] | Rafael Mendonça França | 2014-06-26 | 1 | -1/+1 | |
| | | | | | | ||||||
* | | | | | | fk: add docs | Yves Senn | 2014-06-26 | 2 | -0/+70 | |
| | | | | | | ||||||
* | | | | | | fk: review corrections: indent, visibility, syntax, wording. | Yves Senn | 2014-06-26 | 5 | -52/+53 | |
| | | | | | | ||||||
* | | | | | | fk: use random digest names | Yves Senn | 2014-06-26 | 8 | -33/+59 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The name of the foreign key is not relevant from a users perspective. Using random names resolves the urge to rename the foreign key when the respective table or column is renamed. | |||||
* | | | | | | fk: raise for invalid :on_update / :on_delete values | Yves Senn | 2014-06-26 | 2 | -3/+18 | |
| | | | | | |