Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | we don't need to test that constant assignment works | Jon Leighton | 2012-04-13 | 1 | -15/+0 | |
| | | | | ||||||
* | | | | refactoring | Jon Leighton | 2012-04-13 | 1 | -36/+45 | |
| | | | | ||||||
* | | | | Extract clusterfuck method for surgery | Jon Leighton | 2012-04-13 | 2 | -71/+92 | |
|/ / / | ||||||
* | | | mention that coercion only happens when the primary key is an integer and ↵ | Reg Braithwaite | 2012-04-12 | 1 | -2/+2 | |
| | | | | | | | | | | | | use +to_i+ formatting | |||||
* | | | Documents that ActiveRecord's find by id uses to_i to coerce its arguments ↵ | Reg Braithwaite | 2012-04-12 | 1 | -1/+3 | |
| | | | | | | | | | | | | to integers | |||||
* | | | Add bang versions of relation query methods. | Jon Leighton | 2012-04-12 | 3 | -84/+194 | |
|/ / | | | | | | | | | The main reason for this is that I want to separate the code that does the mutating from the code that does the cloning. | |||||
* | | Some refactor for association. | kennyj | 2012-04-12 | 3 | -8/+7 | |
| | | | | | | | | | | | | | | * Remove unused association_class method. * Remove a unnecessary assignment. * Move @updated to BelongsToAssociation that only reference this instance variable. * Reset @stale_state at the reset method. I think this place is right place. | |||||
* | | move apply_finder_options to active_record_deprecated_finders | Jon Leighton | 2012-04-12 | 1 | -22/+0 | |
| | | ||||||
* | | add active_record_deprecated_finders as a dep | Jon Leighton | 2012-04-12 | 2 | -0/+3 | |
| | | ||||||
* | | Merge pull request #5720 from kennyj/should_use_klass_method | Jon Leighton | 2012-04-11 | 2 | -1/+2 | |
|\ \ | | | | | | | Get a properly aliased_table_name, when we use a polymorphic association. | |||||
| * | | Get a properly aliased_table_name, when we use a polymorphic association. | kennyj | 2012-04-04 | 2 | -1/+2 | |
| | | | ||||||
* | | | Override AR::Relation methods in NullRelation. | Juanjo Bazán | 2012-04-11 | 2 | -0/+86 | |
| | | | | | | | | | So a NullRelation (Relation#none) is chainable with database methods. | |||||
* | | | Corrected grammatical errors in schema_dumper and scoping/default | dcurtis | 2012-04-10 | 2 | -2/+2 | |
| | | | ||||||
* | | | Fix delete_all when chained with joins. | Rafael Mendonça França | 2012-04-10 | 4 | -17/+59 | |
| | | | | | | | | | | | | Closes #5202 and #919 | |||||
* | | | Merge pull request #5718 from benedikt/master | Jeremy Kemper | 2012-04-08 | 4 | -6/+13 | |
|\ \ \ | | | | | | | | | Removes caching from ActiveRecord::Core::ClassMethods#relation | |||||
| * | | | Adds test to check that circular preloading does not modify Model.unscoped ↵ | Benedikt Deicke | 2012-04-03 | 3 | -4/+8 | |
| | | | | | | | | | | | | | | | | (as described in #5667) | |||||
| * | | | Removes caching from ActiveRecord::Core::ClassMethods#relation | Benedikt Deicke | 2012-04-03 | 3 | -6/+9 | |
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The #relation method gets called in four places and the return value was instantly cloned in three of them. The only place that did not clone was ActiveRecord::Scoping::Default::ClassMethods#unscoped. This introduced a bug described in #5667 and should really clone the relation, too. This means all four places would clone the relation, so it doesn't make a lot of sense caching it in the first place. The four places with calls to relations are: activerecord/lib/active_record/scoping/default.rb:110:in `block in build_default_scope'" activerecord/lib/active_record/scoping/default.rb:42:in `unscoped'" activerecord/lib/active_record/scoping/named.rb:38:in `scoped'" activerecord/lib/active_record/scoping/named.rb:52:in `scope_attributes'" | |||||
* | / | fix markup error [ci skip] | Vijay Dev | 2012-04-08 | 1 | -1/+1 | |
| |/ |/| | ||||||
* | | Merge pull request #5716 from jurriaan/tr-gsub-cleanup | Santiago Pastorino | 2012-04-04 | 2 | -3/+3 | |
|\ \ | | | | | | | Updated/changed unneeded tr/gsubs | |||||
| * | | Updated/changed useless tr/gsubs | Jurriaan Pruis | 2012-04-03 | 2 | -3/+3 | |
| |/ | ||||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-04-04 | 1 | -3/+3 | |
|\ \ | | | | | | | | | | | | | Conflicts: guides/source/engines.textile | |||||
| * | | Remove unnecessary articles. | Waseem Ahmad | 2012-04-03 | 1 | -3/+3 | |
| |/ | ||||||
* | | DATABASE_URL allows omission of database.yml | Tim Pope | 2012-04-03 | 1 | -1/+3 | |
| | | ||||||
* | | use File.binread to pull in the schema cache | Aaron Patterson | 2012-04-03 | 1 | -1/+1 | |
|/ | ||||||
* | Fix #5667. Preloading should ignore scoping. | Jon Leighton | 2012-03-30 | 2 | -2/+14 | |
| | ||||||
* | clear up duplication between Persistence#destroy and Locking#destroy | Jon Leighton | 2012-03-30 | 2 | -27/+34 | |
| | ||||||
* | fix test | Jon Leighton | 2012-03-30 | 1 | -1/+2 | |
| | ||||||
* | whitespace :scissors: | Jon Leighton | 2012-03-30 | 2 | -5/+4 | |
| | ||||||
* | Merge pull request #5334 from courtland/master | Jon Leighton | 2012-03-30 | 5 | -1/+27 | |
|\ | | | | | Fix deleting from a HABTM join table upon destroying an object of a model with optimistic locking enabled. | |||||
| * | Tests for removing a HABTM association when optimistic locking is enabled. | Nick Rogers | 2012-03-07 | 4 | -1/+25 | |
| | | ||||||
| * | Fix deleting from a HABTM join table upon destroying an object of a model ↵ | Nick Rogers | 2012-03-07 | 1 | -0/+2 | |
| | | | | | | | | with optimistic locking enabled. Issue #5332. | |||||
* | | Add Relation#find_by and Relation#find_by! | Jon Leighton | 2012-03-30 | 5 | -0/+78 | |
| | | ||||||
* | | Merge pull request #2945 from Casecommons/nested_attributes_module | Jon Leighton | 2012-03-30 | 3 | -1/+15 | |
|\ \ | | | | | | | Nested attribute setters can be overridden. | |||||
| * | | Nested attribute setters can be overridden. | Jonathan Mukai & Peter Jaros | 2012-03-28 | 3 | -1/+15 | |
| | | | | | | | | | | | | Overriding implementation can call super. | |||||
* | | | recurse in read_attribute we get caching / don't duplicate code | Jon Leighton | 2012-03-30 | 1 | -3/+2 | |
| | | | ||||||
* | | | Deprecate Column#type_cast_code | Carlos Antonio da Silva | 2012-03-29 | 2 | -4/+4 | |
| | | | ||||||
* | | | Properly typecast id attribute when using custom primary key | Carlos Antonio da Silva | 2012-03-29 | 1 | -1/+4 | |
| | | | ||||||
* | | | CHANGELOG entry for AR#slice | Guillermo Iguaran | 2012-03-29 | 1 | -0/+5 | |
| | | | ||||||
* | | | Add ActiveRecord::Base#slice to slice method calls | Guillermo Iguaran | 2012-03-29 | 2 | -0/+18 | |
| | | | ||||||
* | | | Merge pull request #4843 from seamusabshere/patch-1 | Xavier Noria | 2012-03-28 | 1 | -1/+1 | |
|\ \ \ | |/ / |/| | | Possibly clearer way of getting rid of ` and " | |||||
| * | | thanks to @jurriaan | Seamus Abshere | 2012-02-14 | 1 | -1/+1 | |
| | | | ||||||
| * | | Possibly clearer way of getting rid of ` and " | Seamus Abshere | 2012-02-01 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Incidentally it's also faster... >> a = 'hello "id` world'; Benchmark.realtime { 500_000.times { a.tr('`"', "") } } => 0.7388770580291748 >> a = 'hello "id` world'; Benchmark.realtime { 500_000.times { a.gsub(/[`"]/, "") } } => 1.7843739986419678 | |||||
* | | | much code can be deleted thanks to @tenderlove's refactoring | Jon Leighton | 2012-03-28 | 3 | -72/+6 | |
| | | | ||||||
* | | | Merge pull request #5616 from cbartlett/migration-indent | Santiago Pastorino | 2012-03-27 | 1 | -2/+2 | |
|\ \ \ | | | | | | | | | Fix indenting in migration generator | |||||
| * | | | Fix indenting in migration generator | Colin Bartlett | 2012-03-27 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | $ rails generate migration remove_foo_from_bars foo:string This currently generates: def up remove_column :bars, :foo end Fix it: def up remove_column :bars, :foo end | |||||
* | | | | Remove Arel::Relation constant from PredicateBuilder. | Juanjo Bazán | 2012-03-27 | 1 | -2/+2 | |
| | | | | ||||||
* | | | | attributes are cached by string keys, so to_s to support symbols. fixes #5549 | Aaron Patterson | 2012-03-27 | 3 | -2/+17 | |
| | | | | ||||||
* | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-03-27 | 2 | -2/+2 | |
|\ \ \ \ | |/ / / |/| | | | ||||||
| * | | | Missing generated query for pluck method. | Juanjo Bazán | 2012-03-27 | 1 | -1/+1 | |
| | | | | | | | | | | | | (and changed the use of true for a more database agnostic example). | |||||
| * | | | Use one 'be'. | Waseem Ahmad | 2012-03-24 | 1 | -1/+1 | |
| | | | |