aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Support for create_association! for has_one associationsJon Leighton2011-01-113-1/+23
|
* Refactor the code for singular association constructors. This will allow me ↵Jon Leighton2011-01-111-8/+13
| | | | to define a create_association! method in a minute.
* It's not necessary to pass the association proxy class around nowJon Leighton2011-01-111-22/+15
|
* Get rid of set_association_target and association_loaded? as the parts of ↵Jon Leighton2011-01-115-21/+18
| | | | the code that need that can now just use association_proxy(:name).loaded?/target=
* We can use the association_proxy method directly in HasOneThroughAssociation nowJon Leighton2011-01-112-20/+20
|
* DRY up the code which instantiates the association proxyJon Leighton2011-01-115-48/+60
|
* find_target can be inheritedJon Leighton2011-01-111-4/+0
|
* Document the recent changes to association assignmentJon Leighton2011-01-111-4/+9
|
* Raise ActiveRecord::RecordNotSaved if an AssociationCollection fails to be ↵Jon Leighton2011-01-112-1/+18
| | | | replaced
* When assigning a has_one, if anything fails, the assignment should be rolled ↵Jon Leighton2011-01-112-21/+28
| | | | back entirely
* In a number of places in the tests, we only need to turn off transactional ↵Jon Leighton2011-01-119-43/+51
| | | | fixtures when the DB does not support savepoints. This speeds the test run up by about 8-9% on my computer, when running rake test_sqlite3_mem :)
* SQLite3 has supported savepoints since version 3.6.8, we should use this!Jon Leighton2011-01-112-2/+18
|
* When assigning a has_one, if the new record fails to save, raise an errorJon Leighton2011-01-113-19/+19
|
* When assigning a has_one, if the existing record fails to be removed from ↵Jon Leighton2011-01-112-5/+23
| | | | the association, raise an error
* Have a separate test connection directory for sqlite3 in-memory so that the ↵Jon Leighton2011-01-112-1/+1
| | | | tests can be run without having to specifically rename the connection file (which then causes git to pick up the changes)
* Enable the sqlite3 in-memory test connection to workJon Leighton2011-01-115-17/+25
|
* has_one should always remove the old record (properly), even if not saving ↵Jon Leighton2011-01-114-11/+31
| | | | the new record, so we don't get the database into a pickle
* Return value is irrelevant here as the RHS of the assignment is always ↵Jon Leighton2011-01-111-1/+0
| | | | returned by methods ending in '='
* Remove incorrect documentation about build_assoc on has_one. This is proven, ↵Jon Leighton2011-01-111-2/+1
| | | | for example, by test_successful_build_association in has_one_associations_test.rb
* For a singular association, it should be build_association, rather than ↵Jon Leighton2011-01-111-1/+1
| | | | association.build (as association may be nil)
* Correctly indent the bullet points under 'One-to-one associations', so that ↵Jon Leighton2011-01-111-10/+10
| | | | the lines are not broken in the generated rdoc html
* avoid splatting arrays by using concatAaron Patterson2011-01-111-3/+3
|
* Fix polymorphic belongs_to associationproxy raising errors when loading target.Ernie Miller2011-01-113-0/+16
|
* only use one array when collecting split up queriesAaron Patterson2011-01-101-1/+1
|
* Always return decimal average of integer fieldsRaimonds Simanovskis2011-01-102-9/+10
| | | | In previous version if database adapter (e.g. SQLite and Oracle) returned non-String calculated values then type_cast_using_column converted decimal average value of intefer field to integer value. Now operation parameter is always checked to decide which conversion of calculated value should be done.
* use SQLite3::VERSION rather than the deprecated classAaron Patterson2011-01-101-1/+1
|
* Aligning master changelog w/ 3-0-stableKevin Moore2011-01-091-1/+9
|
* Adding postgresql template option when executing db:test:clone_structureKatrina Owen2011-01-091-1/+1
| | | | | | | | | | Specify the template to use in config/database.yml, e.g. test: adapter: postgresql template: template_postgis If no template is specified, postgresql defaults to template1
* remove unused string substitutionAaron Patterson2011-01-081-6/+1
|
* use select_all because not all database adapters support bind valuesAaron Patterson2011-01-081-1/+1
|
* join the cult of cargo. reduce the number of NoMethodErrors in the systemAaron Patterson2011-01-071-1/+1
|
* stop creating intermediate AR objects, just construct AR objects from a list ↵Aaron Patterson2011-01-071-1/+2
| | | | of hashes
* no need for to_symAaron Patterson2011-01-071-1/+1
|
* String#insert() mutates the string, so no need for lasgnAaron Patterson2011-01-071-1/+1
|
* fewer funcalls to the cached attributes variableAaron Patterson2011-01-071-1/+1
|
* Add test for e0e3adfJeremy Kemper2011-01-071-0/+6
|
* Refactor HasOneAssociation#replaceJon Leighton2011-01-071-26/+22
|
* Don't not remove double negativesJon Leighton2011-01-072-5/+5
|
* Clean up create, create! and build in HasOneAssociationJon Leighton2011-01-071-14/+8
|
* merge_with_conditions is not necessary because the conditions will already ↵Jon Leighton2011-01-071-9/+0
| | | | be in the scope_for_create hash in the scope
* Not really worth having the HasAssociation module for just a single methodJon Leighton2011-01-075-21/+9
|
* Construct an actual ActiveRecord::Relation object for the association scope, ↵Jon Leighton2011-01-0712-125/+76
| | | | rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things.
* Use encode_with for marshallingJon Leighton2011-01-072-0/+27
|
* send() will raise an ArgumentError, so we should leverage rubyAaron Patterson2011-01-072-17/+7
|
* no need for parensAaron Patterson2011-01-071-1/+1
|
* use a hash for caching aggregations rather than ivarsAaron Patterson2011-01-072-14/+9
|
* method is never called with argumentsAaron Patterson2011-01-071-4/+2
|
* only rescue from Mysql::Error exceptions [#6236 state:resolved]Aaron Patterson2011-01-071-4/+9
|
* just use a hash for doing association cachingAaron Patterson2011-01-076-15/+17
|
* no need for selfAaron Patterson2011-01-061-1/+1
|