aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Deprecate using method_missing for attributes that are columns.Jon Leighton2011-09-132-0/+30
| | | | | | This shouldn't ever happen unless people are doing something particularly weird, but adding a deprecation in case there are bugs not caught by our tests.
* Let Ruby deal with method visibility.Jon Leighton2011-09-132-10/+13
| | | | | | Check respond_to_without_attributes? in method_missing. If there is any method that responds (even private), let super handle it and raise NoMethodError if necessary.
* Reset column info when messing with columns.Jon Leighton2011-09-131-0/+2
| | | | | | | We are subclassing Session here, but messing with the columns will affect the attribute methods defined on the Session superclass, and therefore other tests, unless we properly isolate it by resetting column info before and after the test run.
* Always generate attribute methods on the base class.Jon Leighton2011-09-134-6/+36
| | | | | | | | | | | | | | This fixes a situation I encountered where a subclass would cache the name of a generated attribute method in @_defined_class_methods. Then, when the superclass has it's attribute methods undefined, the subclass would always have to dispatch through method_missing, because the presence of the attribute in @_defined_class_methods would mean that it is never generated again, even if undefine_attribute_methods is called on the subclass. There various other confusing edge cases like this. STI classes share columns, so let's just keep all the attribute method generation state isolated to the base class.
* Raise error when using write_attribute with a non-existent attribute.Jon Leighton2011-09-138-25/+47
| | | | | | | | | Previously we would just silently write the attribute. This can lead to subtle bugs (for example, see the change in AutosaveAssociation where a through association would wrongly gain an attribute. Also, ensuring that we never gain any new attributes after initialization will allow me to reduce our dependence on method_missing.
* Make protected method public so we avoid method_missing.Jon Leighton2011-09-131-4/+5
|
* Fix warnings.Jon Leighton2011-09-131-1/+1
| | | | Make sure we don't redefine an already-defined attribute method.
* Add deprecation for doing `attribute_method_suffix ''`Jon Leighton2011-09-131-2/+0
|
* Alias id= if necessary, rather than relying on method_missingJon Leighton2011-09-131-0/+4
|
* Merge pull request #2936 from joelmoss/migration_statusSantiago Pastorino2011-09-111-5/+7
| | | | db:migrate:status not looking at all migration paths
* Not used variables removed. Warnings removed.Arun Agrawal2011-09-101-1/+1
|
* Add missing require in base_test.rb, fixes isolated testGuillermo Iguaran2011-09-091-0/+1
|
* Merge pull request #2757 from andmej/first_or_create_pull_requestJon Leighton2011-09-085-0/+209
|\ | | | | Add first_or_create family of methods to Active Record
| * Using more precise method signatures for AR::Relation#first_or_create family ↵Andrés Mejía2011-09-061-6/+6
| | | | | | | | of methods.
| * Adding first example with no arguments to AR::Relation#first_or_create and ↵Andrés Mejía2011-09-061-15/+15
| | | | | | | | removing examples that create several users at the same time (this is confusing and not really helpful).
| * Adding first_or_create, first_or_create!, first_or_new and first_or_build to ↵Andrés Mejía2011-08-305-0/+209
| | | | | | | | | | | | | | | | | | | | Active Record. This let's you write things like: User.where(:first_name => "Scarlett").first_or_create!(:last_name => "Johansson", :hot => true) Related to #2420.
* | LRU cache in mysql and sqlite are now per-process caches.Aaron Patterson2011-09-075-22/+82
| |
* | fixing file nameAaron Patterson2011-09-071-0/+0
| |
* | LRU should cache per process in postgresql. fixes #1339Aaron Patterson2011-09-072-10/+37
| |
* | fixing view queriesAaron Patterson2011-09-071-3/+5
| |
* | use the supplied bind valuesAaron Patterson2011-09-071-1/+1
| |
* | Merge commit 'refs/pull/2909/head' of https://github.com/rails/rails into rawrAaron Patterson2011-09-072-6/+10
| | | | | | | | | | | | * https://github.com/rails/rails: Postgresql adapter: added current_schema check for table_exists? Postgresql adapter: added current_schema check for table_exists?
* | Add ROWNUM to test first and last to support Oracle.Yasuo Honda2011-09-071-2/+2
| |
* | Don't include any of includes, preload, joins, eager_load in the through ↵Jon Leighton2011-09-072-4/+6
| | | | | | | | association scope.
* | Merge pull request #2485 from akaspick/exists_fixJon Leighton2011-09-072-1/+12
|\ \ | | | | | | fix exists? to return false if passed nil (which may come from a missing
| * | fix exists? to return false if passed nil (which may come from a missing URL ↵Andrew Kaspick2011-08-102-1/+12
| | | | | | | | | | | | param)
* | | Merge pull request #2897 from rsutphin/ar31-remove_connectionAaron Patterson2011-09-063-3/+22
| | | | | | | | | | | | Patch for issue #2820
* | | Database adapters use a statement pool.Aaron Patterson2011-09-063-8/+46
| | | | | | | | | | | | | | | | | | Database adapters use a statement pool for limiting the number of open prepared statments on the database. The limit defaults to 1000, but can be adjusted in your database config by changing 'statement_limit'.
* | | adding a statement pool for mysql and sqlite3Aaron Patterson2011-09-063-9/+102
| | |
* | | Nested through associations: preloads from the default scope of a through ↵Jon Leighton2011-09-062-1/+10
| | | | | | | | | | | | model should not be included in the association scope. (We're already excluding includes.) Fixes #2834.
* | | Ensure we are not comparing a string with a symbol in ↵Jon Leighton2011-09-063-2/+12
| | | | | | | | | | | | HasManyAssociation#inverse_updates_counter_cache?. Fixes #2755, where a counter cache could be decremented twice as far as it was supposed to be.
* | | Make the logic easier to readJon Leighton2011-09-061-4/+7
| | |
* | | Disable active record marshalling tests on Ruby 1.8.7 on Travis CI, as they ↵Jon Leighton2011-09-062-0/+25
| | | | | | | | | | | | have been failing intermittently for a long while due to what appears to be a Ruby bug. If anyone has the skills/expertise/time to debug this, please speak to the Travis guys.
* | | #first doesn't take an order in this testDamien Mathieu2011-09-061-1/+1
| | |
* | | Merge pull request #2877 from dmathieu/fix_tests_pg_18Santiago Pastorino2011-09-051-2/+2
|\ \ \ | | | | | | | | Last orders the records by id
| * | | first and last orders the records by idDamien Mathieu2011-09-061-2/+2
| | | |
* | | | Merge pull request #2716 from jbbarth/fix_invert_rename_indexAaron Patterson2011-09-052-3/+3
|\ \ \ \ | | | | | | | | | | Fix bad options order in AR::Migration::CommandRecorder#invert_rename_index
| * | | | Fixed bad options order in ↵jbbarth2011-08-282-3/+3
| | | | | | | | | | | | | | | | | | | | ActiveRecord::Migration::CommandRecorder#invert_rename_index
* | | | | Don't find belongs_to target when the foreign_key is NULL. Fixes #2828Georg Friedrich2011-09-052-0/+10
| |/ / / |/| | |
* | | | Use LIMIT sql word in last when it's possibleDamien Mathieu2011-09-052-2/+23
| | | |
* | | | use LIMIT SQL word in first - Closes #2783Damien Mathieu2011-09-052-1/+10
| | | |
* | | | Sort here to make sure the order is ok.Arun Agrawal2011-09-051-1/+1
| | | |
* | | | We need to recorder here. Need to drop the order from default scope.Arun Agrawal2011-09-053-1/+31
| | | | | | | | | | | | Fixes #2832
* | | | Revert "Fixes bug in ActiveRecord::QueryMethods, #1697"Jon Leighton2011-09-042-7/+4
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0df27c98d982ec87d2fb48cfda82694eb267993e. Reverted due to failing test, see #2845.
* | | | restores the API docs of AR::Fixtures, made a quick pass over them, revises ↵Xavier Noria2011-09-032-369/+362
| | | | | | | | | | | | | | | | link in fixture template [closes #2840]
* | | | Need to add here to pass the testArun Agrawal2011-09-031-0/+1
| | | | | | | | | | | | As in previous commit it's removed.
* | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-09-021-1/+1
|\ \ \ \
| * | | | Improve examples: use each instead of for...inGabe Berke-Williams2011-08-311-1/+1
| | | | |
* | | | | * Psych errors with poor yaml formatting are proxied. Fixes #2645, #2731Aaron Patterson2011-09-013-2/+27
| | | | |
* | | | | make sure encoding_aware? is availableAaron Patterson2011-09-011-0/+2
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 04:50:04 +0000