aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Created a layer of abstraction for the valid type checking in schema dumper. ↵Ranjay Krishna2013-03-257-1/+40
| | | | Now, connection handles the check for valid types so that each database can handle the changes individually.
* Merge pull request #9864 from vipulnsward/fix_test_AR_v2Rafael Mendonça França2013-03-252-2/+2
|\ | | | | Introduce test on Error#full_message for attribute with underscores; Fix...
| * Add Error#full_message test; Fix typosVipul A M2013-03-222-2/+2
| | | | | | | | | | Introduce test on Error#full_message for attribute with underscores; Fix some typos
* | Merge pull request #9489 from obrie/fix/overridden_defaults_changed_attributesJeremy Kemper2013-03-242-3/+19
|\ \ | | | | | | Fix ActiveRecord locking column defaults not getting persisted
| * | Fix ActiveRecord locking column defaults not getting persistedAaron Pfeifer2013-03-182-3/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When partial inserts are enabled, overridden db defaults are ignored. This results in locking columns having a nil value for new records if the db default is null. This happens because the list of changed attributes for new records is always assumed to be empty. Solution: When a new record's default attributes are set, also initialize the list of changed attributes by comparing current values against what's stored as the column defaults in the database.
* | | Merge pull request #8501 from charliesome/version-to-sRafael Mendonça França2013-03-231-6/+7
|\ \ \ | | | | | | | | Add #to_s method to VERSION modules
| * | | Add version method to top level modulesCharlie Somerville2013-03-211-6/+7
| | | |
* | | | Merge branch 'jlxw-patch-2'Rafael Mendonça França2013-03-232-2/+6
|\ \ \ \ | | | | | | | | | | | | | | | Closes #9184
| * | | | Fix regex to strip quotations from hstore valuesjlxw2013-03-232-2/+6
| | | | | | | | | | | | | | | | | | | | Previously regex did not strip quotation marks where hstore values were multi-line strings.
* | | | | Merge pull request #9891 from doabit/additional_index_supportRafael Mendonça França2013-03-2311-9/+125
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | Custom index type support with :using. Closes #9451
| * | | | Custom index type support with :using.doabit2013-03-2411-9/+125
| | | | |
* | | | | Merge pull request #9889 from neerajdotname/unscopedRafael Mendonça França2013-03-232-8/+4
|\ \ \ \ \ | |/ / / / |/| | | | Unscoped works with other named scope even without block form
| * | | | enhance unscoped testsNeeraj Singh2013-03-231-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | Make it obvious that using unscoped with another scope without the block works
| * | | | unscoped works with named scope [ci skip]Neeraj Singh2013-03-231-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | Update comment to reflect that unscoped works with named scope even when named scope is using without block form
* | | | | Review some CHANGELOG entries [ci skip]Rafael Mendonça França2013-03-231-7/+8
| | | | |
* | | | | Merge pull request #9880 from wangjohn/refactoring_attribute_assignmentRafael Mendonça França2013-03-231-5/+5
|\ \ \ \ \ | | | | | | | | | | | | Refactoring validate_missing_parameters to validate_required_parameters.
| * | | | | Refactoring validate_missing_parameters to validate_required_parameters.wangjohn2013-03-231-5/+5
| |/ / / /
* | | | | Autoload the AlterTable classRafael Mendonça França2013-03-231-0/+1
| | | | |
* | | | | Spelling 'PostgreSQL' correctlyPrathamesh Sonpatki2013-03-231-7/+7
| | | | |
* | | | | Fixed typos in activerecord CHANGELOGPrathamesh Sonpatki2013-03-231-3/+3
|/ / / /
* | | | Merge branch 'schema'Aaron Patterson2013-03-2210-104/+230
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * schema: add uuid primary key support separate primary key from column type push the mysql add_column up to the abstract adapter allow multiple add columns pull add_column_options! off the pg connection class add a pg visitor for dealing with schema modification push alter table add column sql in to the schema modification visitor there is no reason to check for an already defined column push column initialization down to the factory method @columns list is no longer necessary keep ivars private, do not manipulate them outside their owner object factory methods should not alter object state push SQL generation inside the schema creation object mostly decouple TableDefinition from the database connection remove to_sql from TableDefinition decouple column definition from the database connection stop depending on sql_type in pg remove knowledge of SQL from the column definition object
| * | | | add uuid primary key supportAaron Patterson2013-03-225-3/+30
| | | | |
| * | | | separate primary key from column typeAaron Patterson2013-03-221-10/+11
| | | | |
| * | | | push the mysql add_column up to the abstract adapterAaron Patterson2013-03-224-22/+35
| | | | |
| * | | | allow multiple add columnsAaron Patterson2013-03-223-6/+6
| | | | |
| * | | | pull add_column_options! off the pg connection classAaron Patterson2013-03-222-13/+13
| | | | |
| * | | | add a pg visitor for dealing with schema modificationAaron Patterson2013-03-221-4/+21
| | | | |
| * | | | push alter table add column sql in to the schema modification visitorAaron Patterson2013-03-223-14/+51
| | | | |
| * | | | there is no reason to check for an already defined columnAaron Patterson2013-03-221-1/+1
| | | | |
| * | | | push column initialization down to the factory methodAaron Patterson2013-03-221-13/+13
| | | | |
| * | | | @columns list is no longer necessaryAaron Patterson2013-03-221-8/+4
| | | | |
| * | | | keep ivars private, do not manipulate them outside their owner objectAaron Patterson2013-03-222-1/+5
| | | | |
| * | | | factory methods should not alter object stateAaron Patterson2013-03-221-5/+7
| | | | |
| * | | | push SQL generation inside the schema creation objectAaron Patterson2013-03-224-12/+20
| | | | |
| * | | | mostly decouple TableDefinition from the database connectionAaron Patterson2013-03-223-5/+5
| | | | |
| * | | | remove to_sql from TableDefinitionAaron Patterson2013-03-223-9/+5
| | | | |
| * | | | decouple column definition from the database connectionAaron Patterson2013-03-223-11/+11
| | | | |
| * | | | stop depending on sql_type in pgAaron Patterson2013-03-221-6/+8
| | | | |
| * | | | remove knowledge of SQL from the column definition objectAaron Patterson2013-03-223-24/+47
| | | | |
* | | | | squelch an unused variable warningAaron Patterson2013-03-221-0/+1
|/ / / /
* | | | Merge pull request #9866 from choudhuryanupam/fix_connection_testCarlos Antonio da Silva2013-03-221-1/+1
|\ \ \ \ | | | | | | | | | | Removed unused loop variable
| * | | | Removed unused loop variableAnupam Choudhury2013-03-221-1/+1
| | |_|/ | |/| |
* | | | Merge pull request #9867 from choudhuryanupam/fix_mysql2_active_schema_testCarlos Antonio da Silva2013-03-221-2/+1
|\ \ \ \ | | | | | | | | | | Removed unnecessary block
| * | | | Removed unnecessary blockAnupam Choudhury2013-03-221-2/+1
| | | | |
* | | | | test-case to prevent resetting associations when preloading twice.Yves Senn2013-03-221-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/associations/preloader/through_association.rb activerecord/test/cases/associations/eager_test.rb
* | | | | When we pass id to update_attributes it will try to set new id for that recordDmitry Vorotilin2013-03-224-2/+18
|/ / / /
* / / / Delete failing testJon Leighton2013-03-221-36/+0
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I don't think this is testing anything useful, and the test code is exceedingly brittle. It is broken since 34c7e73c1def1312e59ef1f334586ff2f668246e because the test code makes assumptions about the implementation of PostgreSQLAdapter#active? which are incorrect after the commit. I could fix this test but it would be even more brittle (by stubbing the underlying @connection.connect_poll) and it doesn't test any complex logic. I conclude that it's not worth it.
* | | Allows setting fixture_path to a PathnameAlexander Murmann and Can Berk Güder2013-03-212-1/+10
| | |
* | | Adding a bang to method name of raise_on_type_mismatch.wangjohn2013-03-216-8/+8
| | |
* | | Merge pull request #9847 from vipulnsward/fix_sqlite_testRafael Mendonça França2013-03-211-1/+1
|\ \ \ | |/ / |/| | Fix copy table index test; Change == to ! on false in travis.rb
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 01:47:39 +0000