aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Add and Remove string/strip requireArthur Neves2014-09-023-1/+3
| | | | | | | Method .strip_heredoc is defined in active_support/core_ext/string/strip.rb so we need to require it. [fixes #16677]
* Leave all our tests as order_dependent! for nowMatthew Draper2014-09-021-0/+5
| | | | | | | | | We're seeing too many failures to believe otherwise. This reverts commits bc116a55ca3dd9f63a1f1ca7ade3623885adcc57, cbde413df3839e06dd14e3c220e9800af91e83ab, bf0a67931dd8e58f6f878b9510ae818ae1f29a3a, and 2440933fe2c27b27bcafcd9019717800db2641aa.
* MySQL: skip GTID-unsafe statement tests when enforce_gtid_consistency is enabledJeremy Kemper2014-09-013-23/+31
|
* Merge pull request #16704 from ankit1910/use-existing-methodRafael Mendonça França2014-09-011-1/+1
|\ | | | | use self instead of #read_attribute
| * use self instead of #read_attributeankit19102014-08-261-1/+1
| |
* | Clear schema cache before each testAkira Matsuda2014-09-011-0/+1
| |
* | Clear schema cache before each testAkira Matsuda2014-09-011-0/+1
| |
* | MySQL: set connection collation along with the charsetJeremy Kemper2014-08-305-1/+29
| | | | | | | | | | | | | | | | | | | | Sets the connection collation to the database collation configured in database.yml. Otherwise, `SET NAMES utf8mb4` will use the default collation for that charset (utf8mb4_general_ci) when you may have chosen a different collation, like utf8mb4_unicode_ci. This only applies to literal string comparisons, not column values, so it is unlikely to affect you.
* | AR#reset_column_information sometimes queries via table_exists?Akira Matsuda2014-08-311-1/+1
| | | | | | | | so this assertion causes random test fail
* | Refer to the library name instead of the constantRobin Dupret2014-08-301-1/+1
| | | | | | | | | | | | | | | | | | When we are loading a component and we want to know its version, we are actually not speaking about the constant but the library itself. [ci skip] [Godfrey Chan & Xavier Noria]
* | Forgot to set Migration.verbose at f8d9a51949d6f6cfcab7cc7d501e137836eb88dc ↵Akira Matsuda2014-08-301-1/+1
| | | | | | | | :bomb:
* | Merge branch 'master' of github.com:rails/railsDavid Heinemeier Hansson2014-08-2950-457/+668
|\ \
| * | Don't allow AR::Tasks::DatabaseTasks.migrate to mutate Migration.verbose valueAkira Matsuda2014-08-301-1/+3
| | | | | | | | | | | | This fixes random test failure in migrator_test.rb
| * | Don't test PostgreSQL implementation detailsAkira Matsuda & Kohei Suzuki2014-08-291-3/+0
| | | | | | | | | | | | | | | Asserting that the message contains "QUERY PLAN" is enough for the adapter's test. The plan may vary according to number of tuples etc. but that's out of our concern.
| * | Revert "Merge pull request #16254 from ↵Yves Senn2014-08-291-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | zuhao/refactor_activerecord_attribute_decorators_test" This reverts commit 16fe19831548f108c113094d106663497fc190d5, reversing changes made to 4c81c8ce533896be28bdc0b055ff30bb9dee1316. The call to `Model.reset_column_information` was to express the intent of the test. `reset_column_information` itself can trigger SQL queries because it checks for a tables existance. Let's move it outside of the block. /cc @sgrif
| * | [ci skip] Fix example code of ActiveRecord::FixtureSet.context_classyuuji.yaginuma2014-08-291-1/+1
| | |
| * | Reset ActiveRecord::Migration.message_count counter before start testingAkira Matsuda2014-08-291-1/+1
| | |
| * | Bring original puts back after finishing testsAkira Matsuda2014-08-292-4/+12
| | |
| * | Silence another test that runs migrationsAkira Matsuda2014-08-291-0/+5
| | |
| * | MigrationTest doesn't need to be verbose anymoreAkira Matsuda2014-08-291-1/+1
| | |
| * | No tests are dealing with ActiveRecord::Migration.message_count here anymoreAkira Matsuda2014-08-291-1/+0
| | |
| * | Reset ActiveRecord::Migration.verbose to the value beforeAkira Matsuda2014-08-292-2/+5
| | |
| * | Demodulize ActiveRecord::MigratorTestAkira Matsuda2014-08-291-284/+282
| | |
| * | Avoid using heredoc for user warningsGodfrey Chan2014-08-2810-61/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using heredoc would enforce line wrapping to whatever column width we decided to use in the code, making it difficult for the users to read on some consoles. This does make the source code read slightly worse and a bit more error-prone, but this seems like a fair price to pay since the primary purpose for these messages are for the users to read and the code will not stick around for too long.
| * | No transaction for a test that creates fixtures in the test bodyAkira Matsuda2014-08-291-0/+1
| | |
| * | make it easy to copy & paste the config from deprecation warning.Yves Senn2014-08-281-2/+3
| | | | | | | | | | | | [ci skip]
| * | User Model#last to certainly get lastly created dataAkira Matsuda2014-08-281-1/+1
| | | | | | | | | | | | This test would fail when executed after any test that calls fixtures(:binaries)
| * | Move association definition to the model fileAkira Matsuda2014-08-282-2/+1
| | |
| * | Be sure that test fixtures satisfy referential integrity before calculatingAkira Matsuda2014-08-281-1/+1
| | | | | | | | | | | | | | | | | | | | | There exists some other test files that load :minivans fixtures but don't load :speedometers. Loading :speedometers here prevents the following error when this test was run after such test: CalculationsTest#test_should_group_by_association_with_non_numeric_foreign_key: ActiveRecord::RecordNotFound: Couldn't find all Speedometers with 'speedometer_id': (ABC, s1) (found 1 results, but was looking for 2)
| * | No need to sort testsAkira Matsuda2014-08-281-1/+1
| | | | | | | | | | | | Dir.glob result must be already sorted anyway
| * | Ignore SCHEMA queries when asserting no queriesAkira Matsuda2014-08-285-22/+22
| | |
| * | Reset schema properly after schema changing testAkira Matsuda2014-08-281-0/+2
| | |
| * | Merge pull request #16702 from sgrif/sg-binary-serializedRafael Mendonça França2014-08-273-0/+31
| |\ \ | | | | | | | | Correctly detect mutation on serialized columns mapping to binary
| | * | Correctly detect mutation on serialized columns mapping to binarySean Griffin2014-08-273-0/+31
| | | | | | | | | | | | | | | | Fixes #16701
| * | | minor changelog formatting changes.Yves Senn2014-08-271-2/+3
| | | |
| * | | [ci skip] Updated documentation syntax of other parameter for rdocTom Kadwill2014-08-271-1/+1
| | | |
| * | | Merge pull request #16705 from tomkadwill/documented_many_block_paramZachary Scott2014-08-261-1/+1
| |\ \ \ | | | | | | | | | | [ci skip] Updated documentation syntax of block parameter for rdoc
| | * | | [ci skip] Updated documentation syntax of block parameter for rdoc Tom Kadwill2014-08-261-1/+1
| | | | |
| * | | | [ci skip] Updated include to reference record parameter for rdocTom Kadwill2014-08-261-1/+1
| |/ / /
| * / / [ci skip] Updated documentation syntax of block parameter for rdocTom Kadwill2014-08-261-1/+1
| |/ /
| * | [ci skip] Added documentation for has_and_belongs_to_many extension parameterTom Kadwill2014-08-261-0/+15
| | |
| * | Merge pull request #16646 from sgrif/sg-perf-regressionJeremy Kemper2014-08-251-1/+20
| |\ \ | | | | | | | | Cache the value of `changed_attributes` when calling `changes_applied`
| | * | Cache the value of `changed_attributes` when calling `changes_applied`Sean Griffin2014-08-221-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `changes_applied` calles `changes`, which will call `changed_attributes` multiple times in a loop. This method actually performs work now, so we should cache the results while looping over it when we know it cannot change.
| * | | Override #find_by! in core to enable AST cachingGodfrey Chan2014-08-252-0/+26
| | | |
| * | | Fixed find_by("sql fragment without bindings") on masterGodfrey Chan2014-08-254-17/+23
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Also duplicated find_by tests from relations_test.rb to finder_test.rb now that we have a completely different implementation on the class (in core.rb with AST caching stuff). * Also removed a (failing) test that used mocks. Now that we have tests for the behavior, there's no point having another test that tests the implementation (that it delegates). Further, what the test was implying is nolonger true with the current implementation, because Class.find_by is a real method now.
| * | pg, `default_sequence_name` needs to return a string.Yves Senn2014-08-253-8/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is a reacon to https://github.com/rails/rails/commit/d6c1205584b1ba597db4071b168681678b1e9875#commitcomment-7502487 This backwards incompatibility was introduced with d6c12055 to fix #7516. However both `connection.default_sequence_name` and `model.sequence_name` are public API. The PostgreSQL adapter should honor the interface and return strings. /cc @matthewd @chancancode
| * | Fix a few typos [ci skip]Robin Dupret2014-08-241-1/+1
| | |
| * | Merge pull request #16675 from tomkadwill/has_many_documenting_extension_paramSantiago Pastorino2014-08-241-0/+14
| |\ \ | | | | | | | | [ci skip] Added documentation for has_many extension parameter
| | * | [ci skip] Added documentation for has_many extension parameterTom Kadwill2014-08-241-0/+14
| | | |
| * | | CHANGELOG & improvements to #16649Godfrey Chan2014-08-232-2/+9
| | | | | | | | | | | | | | | | | | | | * Require either FIRST or LAST qualifier for "NULLS ..." * Require whitespace before "NULLS ..."