Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | explicitly including child associations that are also included in the parent ↵ | Will Bryant | 2008-10-10 | 5 | -1/+52 |
| | | | | | | | association definition should not result in double records in the collection/double loads (#1110) Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1110 state:committed] | ||||
* | Add documentation for AbstractAdapter#sanitize_limit, and make its code more ↵ | Hongli Lai (Phusion) | 2008-10-09 | 1 | -4/+15 |
| | | | | | | | readable. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1068 status:committed] | ||||
* | Merge docrails | Pratik Naik | 2008-10-05 | 10 | -79/+469 |
| | |||||
* | Ensure Model.sum and Model.avg typecast appropriately. [#1066 state:resolved] | Pratik Naik | 2008-10-04 | 2 | -6/+10 |
| | | | | | Model.sum delegates typecasting to the column being summed. If that's not feasible, returns a string. Model.avg always returns big decimal. | ||||
* | Remove HasManyAssociationStrategy and move the logic to ↵ | Pratik Naik | 2008-10-04 | 2 | -27/+21 |
| | | | | ActiveRecord::Reflection::ThroughReflection. | ||||
* | Introduce ActiveRecord::Reflection::ThroughReflection to simplify hm:t ↵ | Pratik Naik | 2008-10-04 | 2 | -53/+70 |
| | | | | reflection logic | ||||
* | Fix has_many :through when the source is a belongs_to association. [#323 ↵ | Zach Dennis | 2008-10-04 | 6 | -11/+73 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Try reloading model on class mismatch [#229 state:resolved] | Lawrence Pit | 2008-10-04 | 2 | -1/+21 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix performance bug in AttibuteMethods#respond_to? in handling of private ↵ | Aliaksey Kandratsenka | 2008-10-04 | 1 | -1/+3 |
| | | | | | | | | | | | methods We have hit dramatic increase in tests time after upgrading rails. Profiling revealed this particular place. After this fix our test times returned back to norm. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1173 state:committed] | ||||
* | made ConnectionPool#checkout more robust by trying to loot dead threads when ↵ | Aliaksey Kandratsenka | 2008-10-04 | 1 | -1/+5 |
| | | | | | | | | pool is empty Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1169 state:committed] | ||||
* | Fix race in ConnectionPool#checkout | Aliaksey Kandratsenka | 2008-10-04 | 1 | -15/+14 |
| | | | | | | | After releasing monitor some connection(s) may appear in pool before monitor is re-aquired. When this happens we'll wait for connection which is already available. Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | don't quote decimal values for mysql. It doesn't make sense and breaks in ↵ | Aliaksey Kandratsenka | 2008-10-04 | 1 | -1/+1 |
| | | | | | | | newer versions of mysql Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1168 state:committed] | ||||
* | Make sure recreate MySQL test database with the proper encoding and ↵ | Luca Guidi | 2008-10-03 | 2 | -2/+7 |
| | | | | | | | collation [#1165 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1165 state:committed] | ||||
* | Remove AS for oracle compatibility | Michael Koziarski | 2008-10-03 | 1 | -1/+1 |
| | |||||
* | Dynamic finders should use the ActiveRecord::Base::find method instead of ↵ | Eloy Duran | 2008-10-03 | 3 | -13/+30 |
| | | | | | | | | | | | | ::find_initial, :find_last, and ::find_all. This is so when people override ActiveRecord::Base::find, the new ::find method will also be invoked by the dynamic finders. Associations for instance do go through ::find, so this makes it more consistent. Also removed the unnecessary deprecation silence blocks. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1162 state:committed] | ||||
* | fix eager loading's :condition sanitizing expanding against the wrong table | Will Bryant | 2008-09-29 | 1 | -5/+5 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | wrote a test showing eager loading's misbehavior (sanitizing against the ↵ | Will Bryant | 2008-09-29 | 1 | -0/+7 |
| | | | | | | wrong table) when the association has a :conditions hash Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Ignore all exceptions for validates_acceptance_of columns fetch so it can ↵ | Tarmo Tänav | 2008-09-26 | 1 | -1/+1 |
| | | | | | | run even without a database connection Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Changed ActiveRecord attributes to respect access control. | Adam Milligan | 2008-09-24 | 2 | -5/+54 |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1084 state:committed] | ||||
* | Refactor configure_dependency_for_has_many to use a few more methods. | Hongli Lai (Phusion) | 2008-09-24 | 1 | -3/+34 |
| | | | | | | | Add an additional conditions option to make it slightly easier for certain plugins. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1087 state:committed] | ||||
* | Allowed passing arrays-of-strings to :join everywhere. Merge duplicate join ↵ | Pivotal Labs | 2008-09-24 | 4 | -13/+68 |
| | | | | | | | strings to avoid table aliasing problems. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1077 state:committed] | ||||
* | Make AssociationCollection start transactions in the correct database. | Hongli Lai (Phusion) | 2008-09-23 | 5 | -6/+48 |
| | | | | | | | | | | AssociationCollection now starts transactions by calling AssociationCollection#transaction instead of @owner.transaction or @reflection.klass.transaction. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1081 state:committed] | ||||
* | Merge branch 'patches' into multibyte | Michael Koziarski | 2008-09-22 | 8 | -7/+59 |
|\ | |||||
| * | Bump the Version constants to align with the *next* release rather than the ↵ | Michael Koziarski | 2008-09-22 | 1 | -1/+1 |
| | | | | | | | | | | | | previous release. This allows people tracking non-release gems or git submodules to use the constants. | ||||
| * | Association#first and last should not load the association if not needed. ↵ | Jan De Poorter | 2008-09-22 | 3 | -4/+18 |
| | | | | | | | | | | | | [#1091 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
| * | Add Model#delete instance method, similar to Model.delete class method. ↵ | Hongli Lai (Phusion | 2008-09-21 | 4 | -2/+40 |
| | | | | | | | | | | | | [#1086 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | | Change all calls to String#chars to String#mb_chars. | Manfred Stienstra | 2008-09-21 | 3 | -7/+7 |
| | | |||||
* | | Fix a test that assumes .mb_chars to always return an instance of the ↵ | Manfred Stienstra | 2008-09-21 | 1 | -7/+23 |
| | | | | | | | | proxy_class. | ||||
* | | Change all calls to String#chars to String#mb_chars. Remove a exception for ↵ | Manfred Stienstra | 2008-09-21 | 1 | -2/+2 |
|/ | | | | Ruby <= 1.9. | ||||
* | applied patch to fix the associations with blocks in modules bug from an old ↵ | Adeh DeSandies | 2008-09-20 | 2 | -4/+19 |
| | | | | trac ticket | ||||
* | I18n: Introduce I18n.load_path in favor of I18n.load_translations and change ↵ | Sven Fuchs | 2008-09-20 | 2 | -2/+6 |
| | | | | | | Simple backend to load translations lazily. [#1048 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | I18n: move old-style interpolation syntax deprecation to Active Record. ↵ | Sven Fuchs | 2008-09-20 | 2 | -1/+27 |
| | | | | | | [#1044 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fixed an error triggered by a reload followed by a foreign key assignment. | Nathaniel Talbott | 2008-09-20 | 2 | -1/+13 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Update the documentation to reflect the change handling :group earlier | Michael Koziarski | 2008-09-16 | 1 | -1/+4 |
| | |||||
* | When counting grouped records the target should be loaded to return a valid ↵ | miloops | 2008-09-15 | 2 | -0/+4 |
| | | | | | | | | | groups count result. Without this change count_records will group for the count in the query and return erroneous results. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#937 state:committed] | ||||
* | stop AR's debug.log filling with warnings about not being able to load ↵ | Frederick Cheung | 2008-09-14 | 1 | -0/+14 |
| | | | | | | | | fixture classes [#1045 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Deal with MySQL's quirky handling of defaults and blob/text columns | Frederick Cheung | 2008-09-14 | 6 | -3/+49 |
| | | | | | | [#1043 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Multiparameter attributes skip time zone conversion for time-only columns ↵ | gbuesing | 2008-09-14 | 3 | -1/+21 |
| | | | | [#1030 state:resolved] | ||||
* | Base.skip_time_zone_conversion_for_attributes uses ↵ | miloops | 2008-09-14 | 3 | -1/+12 |
| | | | | class_inheritable_accessor, so that subclasses don't overwrite Base [#346 state:resolved] | ||||
* | Merge docrails | Pratik Naik | 2008-09-13 | 3 | -48/+116 |
| | |||||
* | Allow for the dirty tracking to work with the aliased name of aliased ↵ | Rich Cavanaugh | 2008-09-13 | 3 | -1/+33 |
| | | | | | | | attributes. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#812 state:committed] | ||||
* | Support for updating a belongs to association from the foreign key (without ↵ | Jon Leighton | 2008-09-13 | 3 | -1/+33 |
| | | | | | | | saving and reloading the record) Signed-off-by: Michael Koziarski <michael@koziarski.com> [#142 state:committed] | ||||
* | Use select and change test so new tests can work on postgres. | miloops | 2008-09-12 | 3 | -5/+5 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Improve test coverage when using the group option in find, has_many or ↵ | miloops | 2008-09-11 | 6 | -2/+30 |
| | | | | | | has_and_belongs_to_many. Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Remove the .to_s fix in validates_uniqueness_of, as Chars get quoted correctly. | Michael Koziarski | 2008-09-11 | 1 | -1/+1 |
| | |||||
* | Fix ActiveRecord::Base.quote_bound_value for ActiveSupper::Multibyte::Chars ↵ | Manfred Stienstra | 2008-09-11 | 3 | -3/+36 |
| | | | | | | | | | | values. - Adds String#acts_like_string? - Adds Chars#acts_like_string? Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1029 state:committed] | ||||
* | Fixes validates_uniquness_of problem with case insensitive string containing ↵ | wmoxam | 2008-09-11 | 2 | -1/+8 |
| | | | | | | newline characters Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Add missing assert_deprecated calls to prevent spam during test runs | Michael Koziarski | 2008-09-11 | 1 | -2/+6 |
| | |||||
* | add activerecord tests to make sure the deprecated %s and %d interpolation ↵ | Sven Fuchs | 2008-09-10 | 1 | -1/+15 |
| | | | | | | | | syntax still works [#1016 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | add activerecord tests for deprecation of %s and %d in error messages (and ↵ | Sven Fuchs | 2008-09-10 | 1 | -0/+12 |
| | | | | | | translations in general) Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> |