| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Our general contract in Active Record is that strings are assumed to be
SQL literals, and symbols are assumed to reference a column. If a from
clause is given, we shouldn't include the table name, but we should
still quote the value as if it were a column.
Upon fixing this, the tests were still failing on SQLite. This was
because the column name being returned by the query was `"\"join\""`
instead of `"join"`. This is actually a bug in SQLite that was fixed a
long time ago, but I was using the version of SQLite included by OS X
which has this bug. Since I'm guessing this will be a common case for
contributors, I also added an explicit check with a more helpful error
message.
Fixes #20360
|
| | |
|
| | |
|
| |\
| |
| |
| |
| |
| | |
Update docs for ActiveRecord `serialize`
[ci skip]
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
For certain column types, using `serialize` is unnecessary, or the user
may get unexpected contents back from the DB adapter (which is handling
some basic deserialization for them). Call this out in the
documentation.
For background, see:
https://gist.github.com/ernie/33f75f2294885b9806f9
https://twitter.com/erniemiller/status/604262907442905090
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a usability change to fix a quirk from our definition of partial
writes. By default, we only persist changed attributes. When creating a
new record, this is assumed that the default values came from the
database. However, if the user provided a default, it will not be
persisted, since we didn't see it as "changed". Since this is a very
specific case, I wanted to isolate it with the other quirks that come
from user provided default values. The number of edge cases which are
presenting themselves are starting to make me wonder if we should just
remove the ability to assign a default, in favor of overriding
`initialize`. For the time being, this is required for the attributes
API to not have confusing behavior.
We had to delete one test, since this actually changes the meaning of
`.changed?` on Active Record models. It now specifically means
`changed_from_database?`. While I think this will make the attributes
API more ergonomic to use, it is a subtle change in definition (though
not a backwards incompatible one). We should probably figure out the
right place to document this. (Feel free to open a PR doing that if
you're reading this).
/cc @rafaelfranca @kirs @senny
This is an alternate implementation of #19921.
Close #19921.
[Sean Griffin & Kir Shatrov]
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This is a variant implementation of the changes proposed in #19914.
Unlike that PR, the change in behavior is isolated in its own class.
This is to prevent wonky behavior if a Proc is assigned outside of the
default, and it is a natural place to place the behavior required by #19921
as well.
Close #19914.
[Sean Griffin & Kir Shatrov]
|
| |\
| |
| | |
Remove unused package tasks
|
| | |
| |
| |
| | |
We are using `all:build` now.
|
| |/ |
|
| |\
| |
| | |
Properly append preload / includes args on Merger
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Couldn't find other way to get the association name from a given class
other than looping through `reflect_on_all_associations` reflections ..
Noticed this one while looking at this example:
```ruby
class Product < ActiveRecord::Base
has_many :variants
has_many :translations
end
class Translation < ActiveRecord::Base
belongs_to :product
end
class Variant < ActiveRecord::Base
belongs_to :product
end
class BugTest < Minitest::Test
def test_merge_stuff
product = Product.create! name: 'huhu'
variant = Variant.create! product_id: product.id
Translation.create! locale: 'en', product_id: product.id
product_relation = Product.all
.preload(:translations)
.joins(:translations)
.merge(Translation.where(locale: 'en'))
.where(name: 'huhu')
assert_equal variant, Variant.joins(:product).merge(product_relation).first
end
end
```
|
| |\ \
| | |
| | |
| | | |
SQLite3: Add collation support for string and text columns
|
| | | | |
|
| | | | |
|
| |/ / |
|
| |\ \
| | |
| | |
| | | |
Allow the use of symbols or strings to specify enum values in test fixtures
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currently, values for columns backing Active Record enums must be
specified as integers in test fixtures:
awdr:
title: "Agile Web Development with Rails"
status: 2
rfr:
title: "Ruby for Rails"
status: <%= Book.statuses[:proposed] %>
This is potentially confusing, since enum values are typically
specified as symbols or strings in application code. To resolve the
confusion, this change permits the use of symbols or strings to specify
enum values:
awdr:
status: :published
It is compatible with fixtures that specify enum values as integers.
|
| |\ \ \
| | | |
| | | |
| | | | |
Cause ActiveRecord::Base::reload to also ignore the QueryCache.
|
| | | | | |
|
| |\ \ \ \
| |_|/ /
|/| | | |
If specify `strict: :default` explicitly, do not set sql_mode.
|
| | | | |
| | | |
| | | |
| | | | |
Related with #17370.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
Changed mysqldump to include sprocs and functions
|
| | | |_|/
| |/| | |
|
| |\ \ \ \
| |_|/ /
|/| | | |
Remove broken and unused release task
|
| | |/ /
| | |
| | |
| | |
| | | |
- We do release with release.rb
- There is no `rake/gemcutter`
|
| | | | |
|
| | | |
| | |
| | |
| | | |
Was left in adfab2dcf4003ca564d78d4425566dd2d9cd8b4f
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
See #9683 for the reasons we switched to `distinct`.
Here is the discussion that triggered the actual deprecation #20198.
`uniq`, `uniq!` and `uniq_value` are still around.
They will be removed in the next minor release after Rails 5.
|
| |/ / |
|
| | | |
|
| | |
| |
| | |
For Inline formats, changed ` (single backticks) to <tt> tag at active record rdoc as single backticks (`) don't work with rdoc. for inline format.
|
| |\ \
| | |
| | | |
typo fix [ci skip]
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Fix NetAddr link [ci skip]
|
| | | | | |
|
| |/ / / |
|
| | | |
| | |
| | |
| | |
| | | |
we should ask the reflection for its name rather than storing the
reflection name in two places (an array and a reflection object)
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
This line introduced by the commit fd398475 for using
`Arel::Visitors::BindVisitor`. Currently it is not used.
|
| |\ \ \
| | | |
| | | | |
Avoid the heredoc in one line queries and simple queries
|
| | |/ /
| | |
| | |
| | | |
Related with #20028.
|
| |/ / |
|
| |\ \
| | |
| | | |
Add schema cache to new connection pool after fork
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Active Record detects when the process has forked and automatically
creates a new connection pool to avoid sharing file descriptors.
If the existing connection pool had a schema cache associated with it,
the new pool should copy it to avoid unnecessarily querying the database
for its schema.
The code to detect that the process has forked is in ConnectionHandler,
but the existing test for it was in the ConnectionManagement test file.
I moved it to the right place while I was writing the new test for this
change.
|
| |\ \ \
| | | |
| | | | |
Refactoring `ActiveRecord::Type::Integer` limit
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | | |
Divide methods for handling column options separately
|
