aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #18399 from kommen/unify-structure-file-envvar-namesRafael Mendonça França2015-02-052-3/+9
|\ | | | | | | | | | | | | Use SCHEMA instead of DB_STRUCTURE for specifiying structure file. Conflicts: activerecord/CHANGELOG.md
| * Use `SCHEMA` instead of `DB_STRUCTURE` for specifiying structure file.Dieter Komendera2015-01-082-3/+9
| | | | | | | | | | `rake test:load_structure` already uses `SCHEMA` and there's no need to maintain two different env vars.
* | Merge pull request #18589 from kamipo/fix_test_types_line_upRafael Mendonça França2015-02-051-2/+2
|\ \ | | | | | | Fix `test_types_line_up` when column type missing
| * | Fix `test_types_line_up` when column type missingRyuta Kamizono2015-01-301-2/+2
| | | | | | | | | | | | | | | | | | | | | a column type `xml` is missing in regexp pattarn. However, `assert_equal 1, lengths.uniq.length` is success when `lengths` are all `nil` because a column type is missing. a test will be failed by using `compact` when a column type is missing.
* | | Merge pull request #18526 from vipulnsward/add-silence-streamRafael Mendonça França2015-02-053-47/+8
|\ \ \ | | | | | | | | Extracted silence_stream method to new module in activesupport/testing
| * | | - Extracted silence_stream method to new module in activesupport/testing.Vipul A M2015-01-203-47/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Added include for the same in ActiveSupport::Test. - Removed occurrences of silence_stream being used elsewhere. - Reordered activesupport testcase requires alphabetically. - Removed require of silence stream from test_case - Moved quietly method to stream helper - Moved capture output to stream helper module and setup requires for the same elsewhere
* | | | Do not run remove_connection in memory db testRafael Mendonça França2015-02-051-7/+7
| | | | | | | | | | | | | | | | This will make rake test_sqlite3_mem work again
* | | | Mark some methods as nodocRafael Mendonça França2015-02-051-6/+6
| | | | | | | | | | | | | | | | They are implementation details
* | | | Remove special case for symbols at findRafael Mendonça França2015-02-051-2/+0
| | | | | | | | | | | | | | | | Deprecated finders are not supported anymore
* | | | fix transaction rollback in case of aborting threadYuri Smirnov2015-02-051-1/+1
| | | |
* | | | Merge pull request #18809 from meltheadorable/bugfix/postgres_moneySean Griffin2015-02-043-5/+7
|\ \ \ \ | | | | | | | | | | Fix bug causing table creation to fail for models with postgresql 'money' field
| * | | | Fix test cases for money, bit and bit_varyingMelody2015-02-042-2/+4
| | | | |
| * | | | Add default options to 'bit' and 'bit_varying' methodsMelody2015-02-031-2/+2
| | | | |
| * | | | Adds default options hash for postgres money typeMelody Berton2015-02-031-1/+1
| | | | |
* | | | | Respect custom primary keys for associations in `Relation#where`Sean Griffin2015-02-044-2/+65
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While we query the proper columns, we go through normal handling for converting the value to a primitive which assumes it should use the table's primary key. If the association specifies a different value (and we know that we're working with an association), we should use the custom primary key instead. Fixes #18813.
* | | | rm `Column#cast_type`Sean Griffin2015-02-0314-138/+185
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The type from the column is never used, except when being passed to the attributes API. While leaving the type on the column wasn't necessarily a bad thing, I worry that it's existence there implies that it is something which should be used. During the design and implementation process of the attributes API, there have been plenty of cases where getting the "right" type object was hard, but I had easy access to the column objects. For any contributor who isn't intimately familiar with the intents behind the type casting system, grabbing the type from the column might easily seem like the "correct" thing to do. As such, the goal of this change is to express that the column is not something that should be used for type casting. The only places that are "valid" (at the time of this commit) uses of acquiring a type object from the column are fixtures (as the YAML file is going to mirror the database more closely than the AR object), and looking up the type during schema detection to pass to the attributes API Many of the failing tests were removed, as they've been made obsolete over the last year. All of the PG column tests were testing nothing beyond polymorphism. The Mysql2 tests were duplicating the mysql tests, since they now share a column class. The implementation is a little hairy, and slightly verbose, but it felt preferable to going back to 20 constructor options for the columns. If you are git blaming to figure out wtf I was thinking with them, and have a better idea, go for it. Just don't use a type object for this.
* | | | Correct errors in counter cache updatingSean Griffin2015-02-033-3/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The cache name should be converted to a string when given, not compared as a symbol. This edge case is already adequately covered by our tests, but was masked by another issue where we were incorrectly updating the counter cache twice. When paired with a bug where we didn't update the counter cache because we couldn't find a match with the name, this made it look like everything was working fine. Fixes #10865.
* | | | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵Vipul A M2015-02-0328-28/+0
| | | | | | | | | | | | | | | | onwards.
* | | | Merge pull request #18791 from Sinjo/consistent-foreign-key-name-generationSean Griffin2015-02-023-3/+16
|\ \ \ \ | | | | | | | | | | Consistent foreign key name generation
| * | | | Generate consistent names for foreign keysChris Sinjakli2015-02-033-3/+16
| | | | |
* | | | | Properly lookup the limit for bigintSean Griffin2015-02-022-1/+11
|/ / / / | | | | | | | | | | | | Fixes #18787.
* | | | Rename `user_provided_types` to something more meaningfulSean Griffin2015-02-021-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `attributes_to_define_after_schema_loads` better describes the difference between `attribute` and `define_attribute`, and doesn't conflate terms since we no longer differentiate between "user provided" and "schema provided" types.
* | | | Remove unused `Column#with_type`Sean Griffin2015-02-021-6/+0
| | | | | | | | | | | | | | | | | | | | Now that type casting has nothing to do with columns, our only usage of this method is gone.
* | | | Fix validations on child record when record parent has validate: falseeileencodes2015-02-018-5/+76
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #17621. This 5 year old (or older) issue causes validations to fire when a parent record has `validate: false` option and a child record is saved. It's not the responsibility of the model to validate an associated object unless the object was created or modified by the parent. Clean up tests related to validations `assert_nothing_raised` is not benefiting us in these tests Corrected spelling of "respects" It's better to use `assert_not_operator` over `assert !r.valid`
* | | | add destroyed records to the currend transactionAaron Patterson2015-02-012-1/+5
| | | |
* | | | Fix Issue #15549, unbounded memory growth when saving records that have any ↵Will Bryant2015-02-011-2/+3
| | | | | | | | | | | | | | | | after_create callbacks (or any associations, which makes after_create callbacks for you)
* | | | make the private methods privateAaron Patterson2015-02-011-2/+2
| | | |
* | | | push add to transaction logic down to the instanceAaron Patterson2015-02-013-6/+10
| | | | | | | | | | | | | | | | | | | | the transaction object shouldn't know so much about active record objects, so let's push the conditionals in to the instance.
* | | | remove conditional that is always trueAaron Patterson2015-02-011-3/+2
| | | |
* | | | stop making calls to add_recordAaron Patterson2015-02-011-1/+1
| | | |
* | | | Merge pull request #18770 from palkan/docs-hasone-dependentAbdelkader Boudih2015-02-011-0/+4
|\ \ \ \ | | | | | | | | | | Add note about has_one :through and :dependent
| * | | | [ci skip] add note about has_one :through and :dependentpalkan2015-02-011-0/+4
| | | | |
* | | | | Merge branch 'master' into mdluo-masterAaron Patterson2015-02-013-2/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: Move required error message and changelog to Active Record Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846 Use Module#include instead of send :include, since now is a public method [ci skip] :scissors: warning from controller renderer test Conflicts: activerecord/CHANGELOG.md
| * | | | | Move required error message and changelog to Active RecordCarlos Antonio da Silva2015-02-012-0/+6
| |/ / / / | | | | | | | | | | | | | | | | | | | | The new association error belongs to Active Record, not Active Model. See #18700 for reference.
| * | | | Use Module#include instead of send :include, since now is a public method ↵robertomiranda2015-01-311-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] ref https://bugs.ruby-lang.org/issues/8846
* | | | | Merge branch 'master' into pr/18316Mingdong Luo2015-01-31213-1875/+2822
|\| | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/CHANGELOG.md
| * | | | Attribute assignment and type casting has nothing to do with columnsSean Griffin2015-01-3115-113/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's finally finished!!!!!!! The reason the Attributes API was kept private in 4.2 was due to some publicly visible implementation details. It was previously implemented by overloading `columns` and `columns_hash`, to make them return column objects which were modified with the attribute information. This meant that those methods LIED! We didn't change the database schema. We changed the attribute information on the class. That is wrong! It should be the other way around, where schema loading just calls the attributes API for you. And now it does! Yes, this means that there is nothing that happens in automatic schema loading that you couldn't manually do yourself. (There's still some funky cases where we hit the connection adapter that I need to handle, before we can turn off automatic schema detection entirely.) There were a few weird test failures caused by this that had to be fixed. The main source came from the fact that the attribute methods are now defined in terms of `attribute_names`, which has a clause like `return [] unless table_exists?`. I don't *think* this is an issue, since the only place this caused failures were in a fake adapter which didn't override `table_exists?`. Additionally, there were a few cases where tests were failing because a migration was run, but the model was not reloaded. I'm not sure why these started failing from this change, I might need to clear an additional cache in `reload_schema_from_cache`. Again, since this is not normal usage, and it's expected that `reset_column_information` will be called after the table is modified, I don't think it's a problem. Still, test failures that were unrelated to the change are worrying, and I need to dig into them further. Finally, I spent a lot of time debugging issues with the mutex used in `define_attribute_methods`. I think we can just remove that method entirely, and define the attribute methods *manually* in the call to `define_attribute`, which would simplify the code *tremendously*. Ok. now to make this damn thing public, and work on moving it up to Active Model.
| * | | | changed deleted_tables list to setHyonjee Joo2015-01-311-1/+2
| | | | |
| * | | | Merge pull request #18512 from vipulnsward/18492-fixtures-with-stiAaron Patterson2015-01-317-12/+46
| |\ \ \ \ | | | | | | | | | | | | Fix STI for fixtures from multi-files
| | * | | | Fixes #18492Vipul A M2015-01-147-12/+46
| | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Add check for not deleting previously created fixtures, to overcome sti fixtures from multiple files - Added fixtures and fixtures test to verify the same - Fixed wrong fixtures duplicating data insertion in same table
| * | | | Remove `AttributeSet#initialized_keys`Sean Griffin2015-01-312-6/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method doesn't need to be lazy, as it is never called from reads. The only time it is called are in write cases, where we're about to loop through the results of it, and build the attribute objects anyway. So we don't gain anything by dodging the instantiation here. This is the only method that coupled `AttributeSet` to `LazyAttributeHash`, so removing it puts us back in a place where we can use a normal hash instead.
| * | | | Merge pull request #18700 from nygrenh/better-required-messageAaron Patterson2015-01-312-3/+23
| |\ \ \ \ | | | | | | | | | | | | Provide a better error message on :required association
| | * | | | Provide a better error message on :required associationHenrik Nygren2015-01-282-3/+23
| | | | | | | | | | | | | | | | | | | | | | | | Fixes #18696.
| * | | | | unify CHANGELOG format. [ci skip]Yves Senn2015-01-311-3/+5
| | | | | |
| * | | | | Remove most type related predicates from `Column`Sean Griffin2015-01-3026-101/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remaining are `limit`, `precision`, `scale`, and `type` (the symbol version). These will remain on the column, since they mirror the options to the `column` method in the schema definition DSL
| * | | | | Remove most uses of `Column#cast_type`Sean Griffin2015-01-306-22/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The goal is to remove the type object from the column, and remove columns from the type casting process entirely. The primary motivation for this is clarity. The connection adapter does not have sufficient type information, since the type we want to work with might have been overriden at the class level. By taking this object from the column, it is easy to mistakenly think that the column object which exists on the connection adapter is sufficient. It isn't. A concrete example of this is `serialize`. In 4.2 and earlier, `where` worked in a very inconsistent and confusing manner. If you passed a single value to `where`, it would serialize it before querying, and do the right thing. However, passing it as part of an array, hash, or range would cause it to not work. This is because it would stop using prepared statements, so the type casting would come from arel. Arel would have no choice but to get the column from the connection adapter, which would treat it as any other string column, and query for the wrong value. There are a handful of cases where using the column object to find the cast type is appropriate. These are cases where there is not actually a class involved, such as the migration DSL, or fixtures. For all other cases, the API should be designed as such that the type is provided before we get to the connection adapter. (For an example of this, see the work done to decorate the arel table object with a type caster, or the introduction of `QueryAttribute` to `Relation`). There are times that it is appropriate to use information from the column to change behavior in the connection adapter. These cases are when the primitive used to represent that type before it goes to the database does not sufficiently express what needs to happen. An example of this that affects every adapter is binary vs varchar, where the primitive used for both is a string. In this case it is appropriate to look at the column object to determine which quoting method to use, as this is something schema dependent. An example of something which would not be appropriate is to look at the type and see that it is a datetime, and performing string parsing when given a string instead of a date. This is the type of logic that should live entirely on the type. The value which comes out of the type should be a sufficiently generic primitive that the adapter can be expected to know how to work with it. The one place that is still using the column for type information which should not be necessary is the connection adapter type caster which is sometimes given to the arel table when we can't find the associated table. This will hopefully go away in the near future.
| * | | | | Fix a state leak in `autosave_association_test`Sean Griffin2015-01-301-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test added in 85465ed3e6c582d25f0c8fafe21f7a2c182c2f67 was passing when the file was run on its own, but failing when the entire suite was run since this test modifies the class and doesn't clean up.
| * | | | | Always perform validations on nested attribute associationsSean Griffin2015-01-304-5/+22
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Collection associations would have already been validated, but singular associations were not. Fixes #18735.
| * | | | Post.all.or(anything) == Post.allSean Griffin2015-01-293-7/+7
| | | | |
| * | | | Fixed AR::Relation#group method when argument is a SQL reserved keywordBogdan Gusiev2015-01-293-13/+27
| | | | |