| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | | Perf: don't mess around with thread local vars unless we actually need to | Jon Leighton | 2011-08-13 | 1 | -18/+23 | |
| | | | ||||||
| * | | Fix default scope thread safety. Thanks @thedarkone for reporting. | Jon Leighton | 2011-08-13 | 3 | -15/+53 | |
| | | | ||||||
| * | | Merge pull request #2514 from myronmarston/fix_active_record_observer_disabling | José Valim | 2011-08-13 | 2 | -1/+13 | |
| |\ \ | | | | | | | Allow ActiveRecord observers to be disabled. | |||||
| | * | | Allow ActiveRecord observers to be disabled. | Myron Marston | 2011-08-12 | 2 | -1/+13 | |
| | | | | | | | | | | We have to use Observer#update rather than Observer#send since the enabled state is checked in #update before forwarding the method call on. | |||||
| * | | | Work around for lolruby bug. (Read on for explanation.) | Jon Leighton | 2011-08-13 | 2 | -5/+14 | |
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were experiencing CI test failures, for example: * 3-1-stable: http://travis-ci.org/#!/rails/rails/builds/79473/L407 * master: http://travis-ci.org/#!/rails/rails/builds/79507/L80 These failures only happened on 1.8.7-p352, and we were only able to reproduce on the Travis CI VM worker. We even tried creating a new 32 bit Ubuntu VM and running the tests on that, and it all worked fine. After some epic trial and error, we discovered that replacing the following: fuu = Marshal.load(Marshal.dump(fuu)) with: marshalled = Marshal.dump(fuu) fuu = Marshal.load(marshalled) seemed to prevent the failure. We have NO IDEA why this is. If anyone has some great insight to contribute then that is welcome. Otherwise, hopefully this will just help us get the CI green again. Many thanks to @joshk for help with sorting this out. | |||||
| * | | add the gem requirement for sqlite3 | Aaron Patterson | 2011-08-10 | 1 | -0/+2 | |
| | | | ||||||
| * | | Okay, the new incompatible arel is now called 2.2 and the sun shines upon ↵ | Jon Leighton | 2011-08-09 | 1 | -1/+1 | |
| | | | | | | | | | thee once more | |||||
| * | | Remove TODO comment I didn't mean to commit | Jon Leighton | 2011-08-09 | 1 | -2/+0 | |
| | | | ||||||
| * | | Bump arel version | Jon Leighton | 2011-08-08 | 1 | -1/+1 | |
| | | | ||||||
| * | | Fully marshal AR::Base objects. Fixes #2431. | Jon Leighton | 2011-08-08 | 2 | -21/+13 | |
| | | | ||||||
| * | | Make it the responsibility of the connection to hold onto an ARel visitor ↵ | Jon Leighton | 2011-08-08 | 23 | -68/+122 | |
| | | | | | | | | | for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now. | |||||
| * | | Fixed test_disable_referential_integrity on Oracle | Raimonds Simanovskis | 2011-08-08 | 1 | -0/+3 | |
| | | | | | | | On Oracle disable_referential_integrity before execution of block will disable foreign key constraints and after block will enable them but when constraints are enabled then they are validated. Therefore created record with invalid foreign key should be deleted before enabling foreign key constraints. | |||||
| * | | sqlite transactions now logged | Gustavo Delfino | 2011-08-06 | 1 | -3/+3 | |
| | | | | | | | motivation: http://stackoverflow.com/questions/6892630/sqlite-transactions-not-showing-in-test-log | |||||
| * | | Revert "to_key on a destroyed model should return nil". Closes #2440 | Santiago Pastorino | 2011-08-05 | 2 | -4/+3 | |
| | | | | | | | | | This reverts commit c5448721b5054b8a467958d60427fdee15eac604. | |||||
| * | | Fix test for Rubinius | Santiago Pastorino | 2011-08-05 | 1 | -1/+1 | |
| | | | ||||||
| * | | pg does not allow aliases in the having clause, but functions are fine | Aaron Patterson | 2011-08-05 | 1 | -1/+1 | |
| | | | ||||||
| * | | Revert "Explicitly included hashes in sentence regarding SQL-injection-safe ↵ | Xavier Noria | 2011-08-04 | 1 | -3/+3 | |
| | | | | | | | | | | | | | | | | | forms" Reason: The hash form is secure, and preferred over the array form if possible. This reverts commit 6dc749596c328c44c80f898d5fa860fff6cab783. | |||||
| * | | make the warning clear about the effect of using validates_associated on ↵ | Vijay Dev | 2011-08-04 | 1 | -9/+1 | |
| | | | | | | | | | both sides on an association. | |||||
| * | | Removed trailing slash of 'Download and installation' Github URL as per ↵ | ejy | 2011-08-04 | 1 | -1/+1 | |
| | | | | | | | | | convention | |||||
| * | | Explicitly included hashes in sentence regarding SQL-injection-safe forms | Pete Campbell | 2011-08-04 | 1 | -3/+3 | |
| | | | ||||||
| * | | Quote these dates to prevent intermittent test failure. Suppose local time ↵ | Jon Leighton | 2011-08-04 | 2 | -4/+4 | |
| | | | | | | | | | is 00:50 GMT+1. Without the quoting, the YAML parser would parse this as 00:50 UTC, into the local time of 01:50 GMT+1. Then, it would get written into the database in local time as 01:50. When it came back out the UTC date from the database and the UTC date of two weeks ago would be compared. The former would be 23:50, and the latter would be 00:50, so the two dates would differ, causing the assertion to fail. Quoting it prevents the YAML parser from getting involved. | |||||
| * | | accept option for recreate db for postgres (same as mysql now) | artemk | 2011-08-04 | 1 | -2/+4 | |
| | | | ||||||
| * | | initializing @open_transactions in the initialize method | Aaron Patterson | 2011-08-03 | 1 | -4/+2 | |
| | | | ||||||
| * | | add a migrate class method and delegate to the new instance | Aaron Patterson | 2011-08-02 | 1 | -1/+4 | |
| | | | ||||||
| * | | Ensure that .up and .down work as well. | Christopher Meiklejohn | 2011-08-02 | 1 | -2/+13 | |
| | | | ||||||
| * | | Support backwards compatible interface for migration down/up with rails 3.0.x. | Christopher Meiklejohn | 2011-08-02 | 2 | -0/+25 | |
| | | | ||||||
| * | | remove extra require for 'stringio' as it is required in helper.rb | Vishnu Atrai | 2011-07-31 | 1 | -1/+0 | |
| | | | ||||||
| * | | Merge pull request #2358 from arunagw/test_fix_187_skip | José Valim | 2011-07-31 | 1 | -3/+4 | |
| |\ \ | | | | | | | skiping magic comment test for < 1.9 | |||||
| | * | | magic comment test only if encoding_aware?. | Arun Agrawal | 2011-07-30 | 1 | -3/+4 | |
| | | | | ||||||
| * | | | Resolve warnings by instantizing @attrubtes as nil | Brian Cardarella | 2011-07-30 | 1 | -0/+1 | |
| |/ / | ||||||
| * | | default writing the schema file as utf-8 | Aaron Patterson | 2011-07-29 | 1 | -1/+2 | |
| | | | ||||||
| * | | dump IO encoding value along with schema.rb so the file can be reloaded. ↵ | Aaron Patterson | 2011-07-29 | 2 | -3/+16 | |
| | | | | | | | | | fixes #1592 | |||||
| * | | Revert "Merge pull request #2309 from smasry/master" | Jon Leighton | 2011-07-28 | 2 | -6/+1 | |
| | | | | | | | | | | | | | | | This reverts commit 9d396ee8195e31f646e0b89158ed96f4db4ab38f, reversing changes made to fa2bfd832c1d1e997d93c2269a485cc74782c86d. Reason: the change broke the build. | |||||
| * | | Reverse order fix when using function for ActiveRecord::QueryMethods Fixes #1697 | Samer Masry | 2011-07-27 | 2 | -1/+6 | |
| | | | ||||||
| * | | Fixed failing query when performing calculation with having based on select. | Dmitriy Kiriyenko | 2011-07-27 | 2 | -0/+8 | |
| | | | ||||||
| * | | Add a proxy_association method to association proxies, which can be called ↵ | Jon Leighton | 2011-07-27 | 4 | -6/+27 | |
| | | | | | | | | | by association extensions to access information about the association. This replaces proxy_owner etc with proxy_association.owner. | |||||
| * | | remove deprication warning: ambiguous first argument; put parentheses or ↵ | Vishnu Atrai | 2011-07-26 | 1 | -1/+1 | |
| | | | | | | | | | even spaces | |||||
| * | | remove deprication warning for ruby 1.9.3-head for unused variables | Vishnu Atrai | 2011-07-26 | 1 | -1/+1 | |
| | | | ||||||
| * | | Revert "allow select to have multiple arguments" | Piotr Sarnacki | 2011-07-26 | 2 | -11/+3 | |
| | | | | | | | | | | | | | | | This reverts commit 04cc446d178653d362510e79a22db5300d463161. I reverted it because apparently we want to use: select([:a, :b]) instead of select(:a, :b), but there was no tests for that form. | |||||
| * | | Merge pull request #2271 from slawosz/enhance_select_method_api | Piotr Sarnacki | 2011-07-26 | 2 | -3/+11 | |
| |\ \ | | | | | | | allow select to have multiple arguments ie. Post.select(:id,:name,:author) | |||||
| | * | | allow select to have multiple arguments | Sławosz Sławiński | 2011-07-26 | 2 | -3/+11 | |
| | | | | ||||||
| * | | | Simplify the test by using id and name. `id` will be the only real sort ↵ | Franck Verrot | 2011-07-26 | 1 | -1/+1 | |
| | |/ |/| | | | | | criteria in any case as it's unique. | |||||
| * | | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-07-25 | 1 | -1/+1 | |
| |\ \ | |/ |/| | ||||||
| | * | Fixed Typo | John | 2011-07-24 | 1 | -1/+1 | |
| | | | ||||||
| * | | Simplify the way default DATABASE_URL works. | Glenn Gillen | 2011-07-25 | 1 | -1/+1 | |
| | | | ||||||
| * | | Merge pull request #2236 from cldwalker/after_initialize | Santiago Pastorino | 2011-07-25 | 3 | -2/+19 | |
| |\ \ | | | | | | | Fix after_initialize and Base.create edge case | |||||
| | * | | use existing model for testing Base.create with #after_initialize | Gabriel Horner | 2011-07-24 | 4 | -23/+12 | |
| | | | | ||||||
| | * | | simplify and be more explicit about create and after_initialize tests | Gabriel Horner | 2011-07-24 | 2 | -24/+12 | |
| | | | | ||||||
| | * | | fix after_initialize edge case (close #2074 and close #2175) | Les Fletcher | 2011-07-24 | 4 | -2/+42 | |
| | | | | | | | | | | | | | fix behavior when after_initialize is defined and a block is passed to Base.create | |||||
| * | | | Bring back the ability to provide :order for update_all. | thedarkone | 2011-07-25 | 2 | -9/+25 | |
| | | | | ||||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |
path: root/activerecord