Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #11608 from arunagw/ruby-from-rubygems | Aaron Patterson | 2013-07-28 | 1 | -2/+1 |
|\ | | | | | grab executable from rubygems | ||||
| * | grab executable from rubygems | Arun Agrawal | 2013-07-26 | 1 | -2/+1 |
| | | | | | | As done here d7fc97d3f90c0e30865d32ce202658f03248cacc | ||||
* | | Avoid "uninitialized constant ActiveRecord::PendingMigrationError::Rails" | Akira Matsuda | 2013-07-29 | 1 | -1/+1 |
| | | |||||
* | | Revert "fix order dependent test related to migration" | Akira Matsuda | 2013-07-29 | 1 | -4/+0 |
| | | | | | | | | | | | | This reverts commit 10259c3e906da2191ef0d43cd664a3b5504d9f8c. reason: this causes rake test_mysql and test_mysql2 fail | ||||
* | | Properly repair validations when dynamically added | Akira Matsuda | 2013-07-29 | 1 | -24/+30 |
| | | |||||
* | | Clear class ivar before testing | Akira Matsuda | 2013-07-29 | 1 | -0/+2 |
| | | |||||
* | | Unneeded assertion | Akira Matsuda | 2013-07-29 | 1 | -1/+1 |
| | | |||||
* | | Don't rewrite AR connection#commit_db_transaction method globally | Akira Matsuda | 2013-07-29 | 1 | -4/+4 |
| | | |||||
* | | Merge pull request #11641 from ankit8898/test_cleanup | Rafael Mendonça França | 2013-07-28 | 2 | -2/+2 |
|\ \ | | | | | | | Cleanup of class_name | ||||
| * | | Cleanup of class_name | Ankit Gupta | 2013-07-28 | 2 | -2/+2 |
| | | | | | | | | | | | | Don't think class name is needed as by default belongs_to :select will be linked to Select class. | ||||
* | | | Merge pull request #11634 from ↵ | Rafael Mendonça França | 2013-07-28 | 1 | -0/+4 |
|\ \ \ | | | | | | | | | | | | | | | | | neerajdotname/fix_order_dependent_test_for_migration fix order dependent test related to migration | ||||
| * | | | fix order dependent test related to migration | Neeraj Singh | 2013-07-28 | 1 | -0/+4 |
| | |/ | |/| | | | | | | | | | | | | | If the order in which tests are executed is changed then test fails. This commit ensures that all migrations are run before ensuring that there are no pending migration. | ||||
* | | | Merge pull request #11635 from ↵ | Rafael Mendonça França | 2013-07-28 | 1 | -0/+2 |
|\ \ \ | | | | | | | | | | | | | | | | | neerajdotname/make_test_order_independent_by_resetting_timezone make test order independent by resetting timezone | ||||
| * | | | make test order independent by resetting timezone | Neeraj Singh | 2013-07-28 | 1 | -0/+2 |
| |/ / | |||||
* | | | Merge pull request #11637 from neerajdotname/make_test_not_depend_on_order | Rafael Mendonça França | 2013-07-28 | 1 | -0/+4 |
|\ \ \ | | | | | | | | | reset default timezone and make test order independent | ||||
| * | | | reset default timezone and make test order independent | Neeraj Singh | 2013-07-28 | 1 | -0/+4 |
| |/ / | |||||
* | | | Merge pull request #11638 from ↵ | Rafael Mendonça França | 2013-07-28 | 1 | -0/+1 |
|\ \ \ | |_|/ |/| | | | | | | | | neerajdotname/make_order_independent_association_test make test not depend on order | ||||
| * | | make test not depend on order | Neeraj Singh | 2013-07-28 | 1 | -0/+1 |
| |/ | | | | | | | | | | | | | `NestedThroughAssociationsTest` adds records to `member_details` table. When test performs `@member_details[0]` then the order of record is not guaranteed. Hence it is best to start with a clean slate by deleting unwanted records. | ||||
* / | fix order dependent test | Neeraj Singh | 2013-07-28 | 1 | -0/+5 |
|/ | | | | | `ReflectionTest` uses column information in tests and those tests break if tests are run in random order. | ||||
* | used flat_map instead of map.flatten | Karunakar (Ruby) | 2013-07-25 | 1 | -1/+1 |
| | |||||
* | Merge pull request #11582 from steveklabnik/add_bin | Steve Klabnik | 2013-07-25 | 1 | -1/+1 |
|\ | | | | | rake -> bin/rake | ||||
| * | rake -> bin/rake | Steve Klabnik | 2013-07-24 | 1 | -1/+1 |
| | | |||||
* | | :scissors: [ci skip] | Carlos Antonio da Silva | 2013-07-25 | 1 | -1/+1 |
| | | |||||
* | | change function def self.table_name to self.table_name | Rajarshi Das | 2013-07-25 | 2 | -5/+3 |
| | | | | | | | | | | | | change def self.primary_key to self.primary_key change def self.primary_key to self.primary_key | ||||
* | | More unused associations in AR test models | Akira Matsuda | 2013-07-25 | 8 | -13/+0 |
| | | |||||
* | | Clean up unused associations in AR test model | Akira Matsuda | 2013-07-25 | 1 | -3/+0 |
| | | |||||
* | | Cleanup task for informing about hstore | Vipul A M | 2013-07-25 | 1 | -6/+3 |
|/ | |||||
* | Fix indentation. | kennyj | 2013-07-24 | 1 | -8/+8 |
| | |||||
* | Simplify select_one method. | kennyj | 2013-07-24 | 1 | -2/+1 |
| | | | | | | The select_all method always returns ActiveRecord::Result instance, and the ActiveRecord::Result includes Enumerable mixin. If #empty?, #first method returns nil. Thus we can simplify this method. | ||||
* | Refactor to use flat_map | Carlos Antonio da Silva | 2013-07-23 | 1 | -3/+3 |
| | |||||
* | oops! | Aaron Patterson | 2013-07-23 | 1 | -1/+1 |
| | |||||
* | eliminate conditional in JoinHelper | Aaron Patterson | 2013-07-23 | 2 | -2/+2 |
| | |||||
* | acually get the actual source reflection :cry::gun: | Aaron Patterson | 2013-07-23 | 2 | -9/+17 |
| | |||||
* | stop relying on side effects of const_missing | Aaron Patterson | 2013-07-23 | 2 | -7/+13 |
| | |||||
* | add a specific factory method rather than using new | Aaron Patterson | 2013-07-23 | 9 | -13/+11 |
| | |||||
* | factory methods should not have side effects. | Aaron Patterson | 2013-07-23 | 3 | -8/+11 |
| | | | | Move model mutation to the methods that are called on the model. | ||||
* | extract mutation from generation method | Aaron Patterson | 2013-07-23 | 2 | -4/+6 |
| | |||||
* | habtm can only ever be an association reflection | Aaron Patterson | 2013-07-22 | 1 | -2/+4 |
| | |||||
* | use the predicate method | Aaron Patterson | 2013-07-22 | 1 | -1/+1 |
| | |||||
* | AR::Base does not need to know how to create reflection objects | Aaron Patterson | 2013-07-22 | 3 | -21/+21 |
| | |||||
* | remove unnecessary reader | Aaron Patterson | 2013-07-22 | 1 | -4/+4 |
| | |||||
* | only flatten one side | Aaron Patterson | 2013-07-22 | 1 | -1/+1 |
| | |||||
* | extend by adding relationships rather than monkey patching | Aaron Patterson | 2013-07-22 | 2 | -11/+13 |
| | |||||
* | decouple extensions from association object state | Aaron Patterson | 2013-07-22 | 2 | -3/+3 |
| | |||||
* | Uses mysql2 0.3.13 or later | kennyj | 2013-07-23 | 1 | -1/+1 |
| | |||||
* | Added some usage about ActiveRecord::Result [ci skip] | kennyj | 2013-07-23 | 1 | -2/+26 |
| | |||||
* | Defines the return type of select / select_all method. | kennyj | 2013-07-23 | 3 | -6/+8 |
| | |||||
* | Don't allow `quote_value` to be called without a column | Ben Woosley | 2013-07-22 | 3 | -3/+12 |
| | | | | | | | Some adapters require column information to do their job properly. By enforcing the provision of the column for this internal method we ensure that those using adapters that require column information will always get the proper behavior. | ||||
* | Tidy up the "Specified column type for quote_value" changes | Ben Woosley | 2013-07-22 | 3 | -4/+4 |
| | | | | | | This includes fixing typos in changelog, removing a deprecated mocha/setup test require, and preferring the `column_for_attribute` accessor over direct access to the columns_hash in the new code. | ||||
* | Specified column type for quote_value | Alfred Wong | 2013-07-22 | 3 | -1/+21 |
| | | | | | | | | | | | | | | | | | | | | | When calling quote_value the underlying connection sometimes requires more information about the column to properly return the correct quoted value. I ran into this issue when using optimistic locking in JRuby and the activerecord-jdbcmssql-adapter. In SQLSever 2000, we aren't allowed to insert a integer into a NVARCHAR column type so we need to format it as N'3' if we want to insert into the NVARCHAR type. Unfortuantely, without the column type being passed the connection adapter cannot properly return the correct quote value because it doesn't know to return N'3' or '3'. This patch is fairly straight forward where it just passes in the column type into the quote_value, as it already has the ability to take in the column, so it can properly handle at the connection level. I've added the tests required to make sure that the quote_value method is being passed the column type so that the underlying connection can determine how to quote the value. |