aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Pass over the ApplicationRecord changelog entryGenadi Samokovarov2015-12-171-10/+5
| | | | | | | The changelog entry for ApplicationRecord was a bit confusing. Thank you guys for helping me get it in a better shape. [ci skip]
* fix typo in method name [ci skip]yuuji.yaginuma2015-12-171-1/+1
| | | | It was changed by mistake at 428d47adfed8d6aa7b21aec2bf5ad890961c9de3
* Revert "Merge pull request #22615 from ↵Rafael Mendonça França2015-12-173-5/+11
| | | | | | | | | | kamipo/join_to_delete_is_same_as_join_to_update" This reverts commit 4d06ea9a829de8f6f5a345589828e182eacab6a3, reversing changes made to e9d15072a94e2ae4dec5b7a121c84a5db38547b8. Reason: This will break oracle-enhanced, see https://github.com/rsim/oracle-enhanced/blob/3c42131db82b64ac41645db3affc6e4650289df6/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb#L1254
* Merge pull request #22615 from kamipo/join_to_delete_is_same_as_join_to_updateRafael França2015-12-173-11/+5
|\ | | | | `join_to_delete` is same as `join_to_update`
| * `join_to_delete` is same as `join_to_update`Ryuta Kamizono2015-12-173-11/+5
| |
* | Make sure File.exist? run in the root of the applicationRafael Mendonça França2015-12-161-1/+5
| |
* | Do not define attributes_with_index as a Thor taskRafael Mendonça França2015-12-161-4/+4
| | | | | | | | | | All public methods are tasks, so we need to move it to protected visibility.
* | Remove dead codeRafael Mendonça França2015-12-161-4/+0
| |
* | Don't over-specify types in our testsSean Griffin2015-12-161-1/+0
|/ | | | | | | This test was failing when run on Windows using PostgreSQL. Depending on the OS (and 32 vs 64 bit), this type could be a `BigNum`. We could loosen the assertion to `Numeric`, but if the value is equal to the expected, and responds to `bitlength` properly, who cares?
* Fix test failures on WindowsSean Griffin2015-12-161-4/+12
| | | | | | | Unlike unix, the TZ variable on Windows does not look at a database. It is always expected to be in the form {Standard Time Abbreviation}{UTC-Offset}{Daylight Time Abbriviation}. This changes the relevant tests to use the Windows form when run from Windows.
* Fix test failure on WindowsSean Griffin2015-12-161-6/+10
| | | | | | | When this test was run on Windows, the database file would still be in use, and `File.unlink` would fail. This would cause the temp directory to be unable to be removed, and error out. By disconnecting the connection when finished, we can avoid this error.
* Merge pull request #22567 from gsamokovarov/introduce-application-recordRafael França2015-12-162-1/+23
|\ | | | | Introduce ApplicationRecord, an Active Record layer supertype
| * Introduce ApplicationRecord, an Active Record layer supertypeGenadi Samokovarov2015-12-162-1/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's pretty common for folks to monkey patch `ActiveRecord::Base` to work around an issue or introduce extra functionality. Instead of shoving even more stuff in `ActiveRecord::Base`, `ApplicationRecord` can hold all those custom work the apps may need. Now, we don't wanna encourage all of the application models to inherit from `ActiveRecord::Base`, but we can encourage all the models that do, to inherit from `ApplicationRecord`. Newly generated applications have `app/models/application_record.rb` present by default. The model generators are smart enough to recognize that newly generated models have to inherit from `ApplicationRecord`, but only if it's present.
* | Merge pull request #22605 from tonyta/delete-dead-commentsRafael França2015-12-161-1/+0
|\ \ | | | | | | Delete dead code comments
| * | deletes commented code introduced in db045db (initial commit)Tony Ta2015-12-151-1/+0
| | |
* | | Merge pull request #22598 from yui-knk/deprecate_string_callbackRafael França2015-12-162-16/+1
|\ \ \ | |/ / |/| | Deprecate passing string to define callback.
| * | Deprecate passing string to define callback.yui-knk2015-12-162-16/+1
| | |
* | | Merge pull request #22562 from sblackstone/masterJeremy Daer2015-12-152-2/+9
|\ \ \ | |_|/ |/| | Allow users to pass flags from database.yml
| * | Allow users to pass flags from database.ymlStephen Blackstone2015-12-152-2/+9
| | | | | | | | | | | | | | | | | | Fix white-space Add test case demonstrating flags are received by the adapter
* | | Merge pull request #22596 from y-yagi/remove_extra_space_from_deprecation_msgEileen M. Uchitelle2015-12-152-2/+5
|\ \ \ | | | | | | | | remove extra spaces from deprecation message
| * | | remove extra spaces from deprecation messageyuuji.yaginuma2015-12-152-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` # before DEPRECATION WARNING: Time columns will become time zone aware in Rails 5.1. This still causes `String`s to be parsed as if they were in `Time.zone`, and `Time`s to be converted to `Time.zone`. To keep the old behavior, you must add the following to your initializer: config.active_record.time_zone_aware_types = [:datetime] To silence this deprecation warning, add the following: config.active_record.time_zone_aware_types << :time ``` ``` # after DEPRECATION WARNING: Time columns will become time zone aware in Rails 5.1. This still causes `String`s to be parsed as if they were in `Time.zone`, and `Time`s to be converted to `Time.zone`. To keep the old behavior, you must add the following to your initializer: config.active_record.time_zone_aware_types = [:datetime] To silence this deprecation warning, add the following: config.active_record.time_zone_aware_types << :time ```
* | | | Use a real migration version number in docsMatthew Draper2015-12-155-19/+19
| | | | | | | | | | | | | | | | | | | | Even though this means more things to change when we bump after a release, it's more important that our examples are directly copyable.
* | | | Schema uses current migration APIMatthew Draper2015-12-151-1/+1
| | | |
* | | | In 4.2 migrations, `timestamps` defaulted to `null: true`Matthew Draper2015-12-151-0/+24
| | | | | | | | | | | | | | | | | | | | .. it also showed a deprecation warning, but we obviously needn't retain that.
* | | | Find the delegate, even in a deeper inheritance treeMatthew Draper2015-12-151-1/+5
| | | |
* | | | Internal test migrations use the private 'Current' versionMatthew Draper2015-12-1536-49/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Apart from specific versioning support, our tests should focus on the behaviour of whatever version they're accompanying, regardless of when they were written. Application code should *not* do this.
* | | | Use a deliberately-invalid migration version in all doc examplesMatthew Draper2015-12-155-19/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we use a real version, at best that'll be an onerous update required for each release; at worst, it will encourage users to write new migrations against an older version than they're using. The other option would be to leave these bare, without any version specifier. But as that's just a variant spelling of "4.2", it would seem to raise the same concerns as above.
* | | | Add migration versioning via Migration subclassesMatthew Draper2015-12-155-2/+64
| | | |
* | | | Ensure uuid-ossp extension is present before we rely on itMatthew Draper2015-12-151-0/+2
|/ / /
* | | Revert "Perform a more efficient query in `Relation#any?`"Sean Griffin2015-12-143-8/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6d5b1fdf55611de2a1071c37544933bb588ae88e. `eager_load` and `references` can include hashes, which won't match up with `references` A test case has been added to demonstrate the problem
* | | Merge pull request #22395 from avokhmin/becomes-errors-base-2Sean Griffin2015-12-142-2/+21
|\ \ \ | | | | | | | | `ActiveRecord::Base#becomes` should copy the errors
| * | | `ActiveRecord::Base#becomes` should copy the errorsVokhmin Alexey V2015-12-142-2/+21
| | | |
* | | | Perform a more efficient query in `Relation#any?`Sean Griffin2015-12-142-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was changed in 421c81b, as `exists?` blows up if you are eager loading a polymorphic association, as it'll try to construct a join to that table. The previous change decided to execute a `count` instead, which wouldn't join. Of course, the only time we actually need to perform a join on the eager loaded values (which would perform a left outer join) is if they're being referenced in the where clause. This doesn't affect inner joins.
* | | | Fix test failures caused by 574f255Sean Griffin2015-12-141-1/+1
|/ / / | | | | | | | | | | | | There was a test remaining for PG only that was checking for an exact limit clause
* | | Use a bind param for `LIMIT` and `OFFSET`Sean Griffin2015-12-144-13/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We currently generate an unbounded number of prepared statements when `limit` or `offset` are called with a dynamic argument. This changes `LIMIT` and `OFFSET` to use bind params, eliminating the problem. `Type::Value#hash` needed to be implemented, as it turns out we busted the query cache if the type object used wasn't exactly the same object. This drops support for passing an `Arel::Nodes::SqlLiteral` to `limit`. Doing this relied on AR internals, and was never officially supported usage. Fixes #22250.
* | | Deprecate limit strings with commasSean Griffin2015-12-142-3/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some backends allow `LIMIT 1,2` as a shorthand for `LIMIT 1 OFFSET 2`. Supporting this in Active Record massively complicates using bind parameters for limit and offset, and it's trivially easy to build an invalid SQL query by also calling `offset` on the same `Relation`. This is a niche syntax that is only supported by a few adapters, and can be trivially worked around by calling offset explicitly.
* | | Merge pull request #22209 from ↵Sean Griffin2015-12-142-0/+19
|\ \ \ | | | | | | | | | | | | | | | | yui-knk/add_test_sanitize_sql_array_handles_named_bind_variables Add test cases for `#sanitize_sql_array` with named_bind_variables
| * | | Add test cases for `#sanitize_sql_array` with named_bind_variablesyui-knk2015-11-092-0/+19
| | | | | | | | | | | | | | | | | | | | And add code examples to `sanitize_sql_for_conditions`, `sanitize_sql_for_assignment`, and `sanitize_sql_array`.
* | | | Merge pull request #22571 from mtsmfm/travel-backSantiago Pastorino2015-12-131-3/+3
|\ \ \ \ | |_|_|/ |/| | | travel back
| * | | travel backFumiaki MATSUSHIMA2015-12-131-3/+3
| | |/ | |/|
* | | Merge pull request #22381 from yahonda/use_adapter_subsecond_precision_supportedAaron Patterson2015-12-134-60/+17
|\ \ \ | |/ / |/| | Use adapter supports_datetime_with_precision
| * | Consolidate tests for time and datetime columns options, limit and precisionYasuo Honda2015-11-302-59/+12
| | |
| * | Support supports_datetime_with_precision? for sqlite3Yasuo Honda2015-11-301-0/+4
| | |
| * | Use adapter supports_datetime_with_precision to support 3rd party adapter testsYasuo Honda2015-11-301-1/+1
| | |
* | | Revert "Merge pull request #22502 from maclover7/remove-deprecation-notice"Arthur Neves2015-12-111-0/+8
| | | | | | | | | | | | | | | | | | | | | This reverts commit c2e70ca9b042a3461aac0dc073a80e84bd77eb57, reversing changes made to b0e5fc2737ed0b2f67f9b9538d01e084545493fd. this broke the build
* | | Merge pull request #22502 from maclover7/remove-deprecation-noticeArthur Nogueira Neves2015-12-111-8/+0
|\ \ \ | | | | | | | | Remove unused deprecation notice
| * | | Remove unused deprecation noticeJon Moss2015-12-051-8/+0
| | | | | | | | | | | | | | | | | | | | The `rake db:test:*` tasks were deprecated in #13528, but were undeprecated and added back in via #17739.
* | | | Merge pull request #22523 from Elektron1c97/masterRafael França2015-12-071-4/+4
|\ \ \ \ | | | | | | | | | | Typo correction
| * | | | Typo correctionYves Siegrist2015-12-071-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the doc the `dependent` option was set with: `dependent: destroy`. This is not working because destroy would call the method of the activerecord::base object. The right way is: `dependent: :destroy`
* | | | | Merge pull request #22517 from Elektron1c97/masterRafael França2015-12-071-2/+1
|\| | | | | | | | | | | | | | [ci skip] Add a dollar sign to each command in the READMEs
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-30 22:42:41 +0000