aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | fold the collection rather than multiple assigmentsAaron Patterson2013-05-211-3/+2
| | | |
* | | | use drop rather than calculate the array lengthAaron Patterson2013-05-211-1/+1
| | | |
* | | | Merge branch 'bindwhere'Aaron Patterson2013-05-212-20/+42
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * bindwhere: avoid creating a set if no where values are removed remove bind values for where clauses that were removed push partitioning up so bind elimination can get the removed wheres push partion logic down and initialization logic up partition the where values so we can access the removed ones
| * | | | avoid creating a set if no where values are removedAaron Patterson2013-05-212-0/+14
| | | | |
| * | | | remove bind values for where clauses that were removedAaron Patterson2013-05-212-9/+18
| | | | |
| * | | | push partitioning up so bind elimination can get the removed wheresAaron Patterson2013-05-211-5/+3
| | | | |
| * | | | push partion logic down and initialization logic upAaron Patterson2013-05-211-15/+11
| | | | |
| * | | | partition the where values so we can access the removed onesAaron Patterson2013-05-201-1/+6
| |/ / /
* | | | Merge pull request #10711 from senny/10660_rake_db_test_prepare_needs_configRafael Mendonça França2013-05-211-1/+1
|\ \ \ \ | | | | | | | | | | the rake task `db:test:prepare` needs to load the configuration
| * | | | the rake task `db:test:prepare` needs to load the configurationYves Senn2013-05-211-1/+1
| |/ / / | | | | | | | | | | | | Without loading the configuration the task will not perform any work.
* / / / In batches test @total was assigned but not used. Use it in tests instead of ↵Alexander Balashov2013-05-211-7/+5
|/ / / | | | | | | | | | Post.count
* | | eliminate some conditionalsAaron Patterson2013-05-201-3/+3
| | |
* | | change method name to reflect what it actually does.Aaron Patterson2013-05-201-2/+2
| | |
* | | save the where values in variables so we don't need to look them up allAaron Patterson2013-05-201-4/+5
| | | | | | | | | | | | the time
* | | pass where values to the helper function rather than rely on internal stateAaron Patterson2013-05-201-4/+4
| | |
* | | Merge pull request #10692 from vipulnsward/fix_test_3José Valim2013-05-191-1/+1
|\ \ \ | | | | | | | | Fix wrong `case_sensitive` in uniqueness validity test
| * | | Fix wrong `case_sensitive` in uniqueness validity testVipul A M2013-05-201-1/+1
| | | |
* | | | Fix typo in test name and documentationVipul A M2013-05-202-2/+2
|/ / /
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-05-197-10/+42
|\ \ \
| * | | copy edits[ci skip]Vijay Dev2013-05-192-12/+9
| | | |
| * | | Added some more documentation for define_readers and define_writer of the ↵aditya-kapoor2013-05-153-0/+15
| | | | | | | | | | | | | | | | Association and its inherited classes
| * | | Added some more documentation for ↵aditya-kapoor2013-05-151-0/+11
| | | | | | | | | | | | | | | | ActiveRecord::Associations::Builder::Association class
| * | | Added documentation for ActiveRecord::Associations::Builder::Association classaditya-kapoor2013-05-151-0/+4
| | | |
| * | | improved doc for ActiveRecord#find_by_sql method (Refs #10599) [ci skip]Anton Kalyaev2013-05-141-3/+4
| | | |
| * | | Added documentation for model migration generationaditya-kapoor2013-05-141-0/+4
| | | |
| * | | emphasize that callbacks are called in destroy_allNeeraj Singh2013-05-132-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Cleaned up rdoc a bit emphasizing that callbacks are called. Also removed the stress on the fact that records are always removed. If callbacks return false then records will not be deleted.
* | | | Fxied some typosPrathamesh Sonpatki2013-05-181-1/+1
| | | |
* | | | Merge pull request #10676 from tkhr/add-test-to-counter_cache_test.rbRafael Mendonça França2013-05-185-4/+18
|\ \ \ \ | | | | | | | | | | Add test to counter cache test.rb
| * | | | Fix tests which started to fail due to commit ↵Takehiro Adachi2013-05-182-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 0123c39f41e2062311b2197e6e230ef8ad67e20e Due to commit 0123c39f41e2062311b2197e6e230ef8ad67e20e, column topic.unique_replies_count has been added, and these test started to fail since the tests depends on the topic tables column info.
| * | | | Add test to AR's counter_cache_test.rbTakehiro Adachi2013-05-183-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | According to https://github.com/rails/rails/blob/b601399b72ab56cc01368f02615af99f45d1 4f02/activerecord/lib/active_record/counter_cache.rb#L14, u can pass more then one association to the `reset_counters` method.
* | | | | stop swallowing exceptions in assert_queries. Methods that raise anAaron Patterson2013-05-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | exception are unlikely to pass this assertion, but since the assertions raise an exception, the original exception is lost.
* | | | | stop doing assingments in an iteratorAaron Patterson2013-05-171-2/+6
| | | | |
* | | | | include bind values from the default scopeAaron Patterson2013-05-172-6/+5
|/ / / /
* | | | let Ruby do the is_a check for usAaron Patterson2013-05-161-3/+4
| | | |
* | | | test refactorAaron Patterson2013-05-161-5/+2
| | | |
* | | | Add more data to AR::UnknownAttributeErrorBogdan Gusiev2013-05-163-1/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | begin Topic.new("hello" => "world") rescue ActiveRecord::UnknownAttributeError => e e.record # => #<Topic ... > e.attribute # => "hello" end
* | | | Merge pull request #10619 from alno/top_level_array_in_postgres_jsonAaron Patterson2013-05-163-1/+17
|\ \ \ \ | | | | | | | | | | Support array as root element in Postgresql JSON columns
| * | | | Support array as root element in JSONAlexey Noskov2013-05-143-1/+17
| | | | |
* | | | | Check if APP_RAKEFILE is definedPiotr Sarnacki2013-05-161-1/+1
| | | | |
* | | | | Fix detection of engine in rake db:load_configJoel Cogen2013-05-161-1/+1
| | | | | | | | | | | | | | | | | | | | Broken by d1d7c86d0c8dcb7e75a87644b330c4e9e7d6c1c1
* | | | | tiny types should only be integers when the length is <= 1. fixes #10620Aaron Patterson2013-05-151-3/+9
| | | | |
* | | | | add failing test exposing mysql adapter tinyint bugphinze2013-05-151-3/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in myself, a column with type TINYINT(N) where N > 1 can be used to represent an integer, but the rails mysql adapter refuses to interpret as anything but a boolean.
* | | | | require things we needAaron Patterson2013-05-151-0/+1
| | | | |
* | | | | Merge pull request #10504 from kennyj/support_pg_91Rafael Mendonça França2013-05-153-6/+8
|\ \ \ \ \ | | | | | | | | | | | | Also should supports PostgreSQL 9.1 about extensions.
| * | | | | Remove unnecessary code, because this extension is created on demand in ↵kennyj2013-05-151-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | hstore_test.rb.
| * | | | | Also support extensions in PostgreSQL 9.1, because this has been supported ↵kennyj2013-05-152-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | since 9.1.
* | | | | | Merge pull request #10601 from Ichimonji10/fix-docsRafael Mendonça França2013-05-151-15/+27
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Rewrite `activerecord/RUNNING_UNIT_TESTS.rdoc`
| * | | | | Rewrite `activerecord/RUNNING_UNIT_TESTS`Jeremy Audet2013-05-151-15/+27
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `RUNNING_UNIT_TESTS` is written in an unclear and confusing manner. This commit attempts to correct that. Thanks to zzak and vipulnsward for feedback.
* | | | | deprecating string based terminatorsAaron Patterson2013-05-141-1/+3
| | | | |
* | | | | Merge branch 'master' into normalizecbAaron Patterson2013-05-1317-50/+137
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (61 commits) add tests for reset_calbacks Fixing build broken by this change Extract variable out of loop Updated comment to Rails 4 Fixes NoMethodError: `alias_method_chain` when requiring just active_support/core_ext better error message when app name is not passed in `rails new` Code cleanup for ActionDispatch::Flash#call Fix typo: require -> requires Add CHANGELOG entry for #10576 Merge pull request #10556 from Empact/deprecate-schema-statements-distinct Some editorial changes on the documentation. respond_to -> respond to in a message from AM::Lint specify that dom_(id|class) are deprecated in controllers, views are fine copy edits [ci skip] Fix class and method name typos Replace multi_json with json ruby -> Ruby Adding documentation to the automatic inverse_of finder. Improve CHANGELOG entry [ci kip] Call assume_migrated_upto_version on connection ... Conflicts: activesupport/lib/active_support/callbacks.rb