Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | pk should not be required for hm:t associations | Aaron Patterson | 2013-08-29 | 3 | -1/+15 |
| | |||||
* | Merge pull request #12051 from bcherry/preserve_datetime_milliseconds | Andrew White | 2013-08-28 | 2 | -0/+9 |
|\ | | | | | ActiveRecord: Include usecs when quoting DateTime in PostgreSQL adapter | ||||
| * | Test that PostgreSQL adapter includes `usec` when quoting `DateTime` | Ben Cherry | 2013-08-28 | 2 | -0/+9 |
| | | |||||
* | | Merge branch 'typecast' | Aaron Patterson | 2013-08-28 | 2 | -18/+31 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | * typecast: correctly typecast keys, remove conditionals, reduce object allocations no need to to_a the scope remove extra flat_map array avoid extra empty array allocation extract owner id calculation to a method only call to_a when we have to | ||||
| * | | correctly typecast keys, remove conditionals, reduce object allocations | Aaron Patterson | 2013-08-28 | 2 | -7/+11 |
| | | | |||||
| * | | no need to to_a the scope | Aaron Patterson | 2013-08-28 | 1 | -1/+1 |
| | | | |||||
| * | | remove extra flat_map array | Aaron Patterson | 2013-08-28 | 1 | -8/+9 |
| | | | |||||
| * | | avoid extra empty array allocation | Aaron Patterson | 2013-08-28 | 1 | -10/+10 |
| | | | |||||
| * | | extract owner id calculation to a method | Aaron Patterson | 2013-08-28 | 1 | -1/+5 |
| | | | |||||
| * | | only call to_a when we have to | Aaron Patterson | 2013-08-28 | 2 | -2/+6 |
| | | | |||||
* | | | Mention the fast `test_sqlite3_mem` option in `RUNNING_UNIT_TESTS.rdoc` [ci ↵ | Marc Schütz | 2013-08-28 | 1 | -0/+1 |
|/ / | | | | | | | skip] | ||||
* | | use consistent keys between cache get / set | Aaron Patterson | 2013-08-27 | 1 | -1/+1 |
| | | |||||
* | | remove intermediate variable | Aaron Patterson | 2013-08-27 | 1 | -3/+1 |
| | | |||||
* | | cache association reset calculation | Aaron Patterson | 2013-08-27 | 1 | -4/+4 |
| | | |||||
* | | query the association rather than send the method for the association name | Aaron Patterson | 2013-08-27 | 2 | -11/+10 |
|/ | |||||
* | check class hierarchy with is_a? in PredicateBuilder.expand | Mikhail Dieterle | 2013-08-27 | 3 | -1/+32 |
| | | | | add changelog entry for #11945 | ||||
* | Merge pull request #12038 from SamSaffron/memoize_decorate_cols | Rafael Mendonça França | 2013-08-26 | 1 | -17/+27 |
|\ | | | | | Perf: memoize serialized column list and time zone column list | ||||
| * | Perf: memoize serialized column list and time zone column list | Sam | 2013-08-27 | 1 | -17/+27 |
| | | |||||
* | | Perf: avoid array allocation where not needed | Sam | 2013-08-27 | 1 | -1/+1 |
| | | |||||
* | | Perf: fields in pg gem causes an allocation, cache it | Sam | 2013-08-27 | 1 | -2/+3 |
|/ | |||||
* | Add config to method calls in fixtures. | wangjohn | 2013-08-26 | 2 | -24/+27 |
| | | | | | | | Allows you to change your configuration for calls to `table_name_prefix`, `table_name_suffix`, and `pluralize_table_names`. The default configuration is still ActiveRecord::Base, but you are now able to change the configuration easily. | ||||
* | Merge pull request #11827 from vipulnsward/remove_extra_case | Santiago Pastorino | 2013-08-26 | 1 | -1/+0 |
|\ | | | | | Remove extra case. | ||||
| * | Remove extra case. | Vipul A M | 2013-08-10 | 1 | -1/+0 |
| | | |||||
* | | PG adapter deals with negative money values formatted with parenthesis. | Yves Senn | 2013-08-26 | 3 | -0/+19 |
| | | | | | | | | Closes #11899. | ||||
* | | Merge pull request #12014 from wangjohn/change_deprecation_horizon | Santiago Pastorino | 2013-08-25 | 1 | -1/+1 |
|\ \ | | | | | | | Changing deprecation_horizon to be Rails 4.2 | ||||
| * | | Changing deprecation_horizon to be Rails 4.2 | wangjohn | 2013-08-24 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | Also, +ActiveRecord::Migrator.proper_table_name+ should actually have a deprecation horizon of Rails 4.2 (not 4.1). | ||||
* | | | Removing instances of string class_names in fixtures. | wangjohn | 2013-08-24 | 2 | -10/+13 |
|/ / | | | | | | | | | | | | | Also, constantizing the default_fixture_model_name when it gets loaded in from the file. Later, when the class_name is passed to a new FixtureSet, a deprecation warning will occur if the class_name is a string. | ||||
* | | Adding deprecation assertions for proper_table_name. | wangjohn | 2013-08-24 | 1 | -7/+21 |
| | | | | | | | | This prevents deprecation warnings from popping up. | ||||
* | | Merge pull request #12000 from ↵ | Santiago Pastorino | 2013-08-23 | 1 | -7/+1 |
|\ \ | | | | | | | | | | | | | wangjohn/deprecating_class_name_string_in_fixtures Deprecating passing strings as class name in fixtures. | ||||
| * | | Deprecating passing strings as class name in fixtures. | wangjohn | 2013-08-23 | 1 | -7/+1 |
| | | | |||||
* | | | Making proper_table_name take in options. | wangjohn | 2013-08-22 | 2 | -19/+68 |
|/ / | | | | | | | | | | | | | | | | | | | | | The options will specify the prefix and the suffix. Also, I'm moving the method to be an instance method on the +Migration+ instance. This makes more sense than being a class method on the +Migrator+ class because the only place that uses it is on a +Migration+ instance (in a method_missing hook). The logic for the Migrator shouldn't be doing any work to calculate the table name, it should be the Migration itself. Also made some small indentation fixes. | ||||
* | | Merge pull request #11971 from freerunningtechnologies/dynamic_respond_to | Aaron Patterson | 2013-08-22 | 2 | -1/+6 |
|\ \ | | | | | | | Performance regression in AR::Base.respond_to? | ||||
| * | | Avoid compiling regexs in AR::Base.respond_to? | John Hawthorn | 2013-08-21 | 2 | -1/+6 |
| | | | | | | | | | | | | | | | Caches the patterns of ActiveRecord::DynamicMatchers in a class instance variable. | ||||
* | | | Merge pull request #11976 from etehtsea/inf | Yves Senn | 2013-08-22 | 1 | -2/+2 |
|\ \ \ | | | | | | | | | [PG adapter] Use infinity const | ||||
| * | | | Use infinity const | Konstantin Shabanov | 2013-08-22 | 1 | -2/+2 |
| |/ / | |||||
* / / | Stray nodoc causes rest of file not parsed [ci skip] | edogawaconan | 2013-08-22 | 1 | -2/+0 |
|/ / | |||||
* | | write changelog entry for #11922. [ci skip] | Yves Senn | 2013-08-20 | 1 | -0/+5 |
| | | |||||
* | | Merge pull request #11922 from Empact/string-confusion | Yves Senn | 2013-08-20 | 2 | -2/+2 |
|\ \ | | | | | | | Stop interpreting SQL 'string' columns as :string type. | ||||
| * | | Stop interpreting SQL 'string' columns as :string type. | Ben Woosley | 2013-08-17 | 2 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | SQL doesn't have a string type, and interpreting 'string' as text is contrary to at least SQLite3's behavior: "Note that a declared type of 'STRING' has an affinity of NUMERIC, not TEXT." http://www.sqlite.org/datatype3.html | ||||
* | | | documents 565c367 in the CHANGELOG | Xavier Noria | 2013-08-19 | 1 | -0/+4 |
| | | | |||||
* | | | let AR::FinderMethods#exists? return singletons in all cases [closes #11592] | Xavier Noria | 2013-08-19 | 2 | -34/+36 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a regression. The documentation said in its introduction paragraph that the method returns truthy/falsy, but then below it was said that if there were no arguments you'd get `true` or `false`. Also when the argument is exactly `false` a singleton is documented to be returned. The method was not returning the singletons so it didn't conform to those special cases. The best solution here seems to be to just return singletons in all cases. This solution is backwards compatible. Also, the contract has been revised because it has no sense that the predicate varies that way depending on the input. I bet the previous contract was just an accident, not something mixed on purpose. Conflicts: activerecord/lib/active_record/relation/finder_methods.rb activerecord/test/cases/finder_test.rb | ||||
* | | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2013-08-17 | 13 | -9/+22 |
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | Conflicts: actionview/README.rdoc activerecord/lib/active_record/migration.rb guides/source/development_dependencies_install.md guides/source/getting_started.md | ||||
| * | | Revert "Merge branch 'master' of github.com:rails/docrails" | Vijay Dev | 2013-08-17 | 14 | -10/+23 |
| | | | | | | | | | | | | | | | | | | | | | This reverts commit 70d6e16fbad75b89dd1798ed697e7732b8606fa3, reversing changes made to ea4db3bc078fb3093ecdddffdf4f2f4ff3e1e8f9. Seems to be a code merge done by mistake. | ||||
* | | | Fixing multi-word automatic inverse detection. | wangjohn | 2013-08-15 | 4 | -2/+19 |
| | | | | | | | | | | | | | | | Currently, ActiveRecord models with multiple words cannot have their inverse associations detected automatically. | ||||
* | | | Merge pull request #11574 from jetthoughts/11552_rescue_on_invalid_inet_assign | Yves Senn | 2013-08-14 | 3 | -1/+37 |
|\ \ \ | | | | | | | | | Fix assign ip address with invalid values raise exception | ||||
| * | | | Rescue invalid ip address exceptions on assign. | Paul Nikitochkin | 2013-08-14 | 3 | -1/+37 |
| | | | | | | | | | | | | | | | | In order that set attribute should not be bang method | ||||
* | | | | Removed redundant asserts for assigns attribute operation | Paul Nikitochkin | 2013-08-14 | 1 | -28/+28 |
|/ / / | |||||
* | | | test-case for fixed issue #11870. | Yves Senn | 2013-08-14 | 1 | -0/+4 |
| | | | |||||
* | | | using assert_not instead of refute | Rajarshi Das | 2013-08-13 | 2 | -4/+4 |
| | | | |||||
* | | | Merge pull request #11838 from vipulnsward/drop_extra_var | Steve Klabnik | 2013-08-12 | 1 | -2/+2 |
|\ \ \ | | | | | | | | | drop extra variable |