aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Mute psql output when running rake db:schema:loadGodfrey Chan2013-04-303-2/+6
| | | |
* | | | Fix #8856 Ensure has_one association=(associate) triggers save.Chris Thompson2013-04-303-3/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | activerecord/lib/active_record/associations.rb states: # [association=(associate)] # Assigns the associate object, extracts the primary key, sets it as the foreign key, # and saves the associate object. Since commit 42dd5d9f2976677a4bf22347f2dde1a8135dfbb4 to fix #7191, this is no longer the case if the associate has changed, but is the same object. For example: # Pirate has_one :ship pirate = Pirate.create!(catchphrase: "A Pirate") ship = pirate.build_ship(name: 'old name') ship.save! ship.name = 'new name' pirate.ship = ship That last line should trigger a save. Although we are not changing the association, the associate (ship) has changed.
* | | | Merge pull request #10390 from Noemj/bind_param_handlingRafael Mendonça França2013-04-301-3/+3
|\ \ \ \ | | | | | | | | | | Added :nodoc: for relation.rb's private methods
| * | | | Added :nodoc: for private methodsNoemj2013-04-301-3/+3
| | | | |
* | | | | mysql needs to reconnect after recreate. Thanks @mperhamAaron Patterson2013-04-301-0/+1
| | | | |
* | | | | Abort a rake task when missing db/structure.sql like `db:schema:load` task.kennyj2013-05-014-6/+21
|/ / / /
* | | | Moved update_record logic to relation.rbNoemj2013-04-302-26/+28
| | | |
* | | | add missing :nodoc: marks to ActiveRecord::Delegation [ci skip]Francesco Rodriguez2013-04-291-3/+3
| | | |
* | | | rails/master is now 4.1.0.betaRafael Mendonça França2013-04-292-2044/+3
| | | |
* | | | Bump version to rc1David Heinemeier Hansson2013-04-291-1/+1
| | | |
* | | | Bump activerecord-deprecated_finders. Fixes #10304Rafael Mendonça França2013-04-291-1/+1
| | | |
* | | | Merge pull request #10372 from ↵Jeremy Kemper2013-04-283-12/+13
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | jeremy/statement-invalid-wraps-underlying-exception StatementInvalid takes WrappedDatabaseException's place
| * | | | StatementInvalid takes WrappedDatabaseException's placeJeremy Kemper2013-04-283-12/+13
| | | | |
* | | | | Delegate #unscope query methodCarlos Antonio da Silva2013-04-282-1/+11
|/ / / /
* | | | Merge pull request #10368 from demands/fix-typoGuillermo Iguaran2013-04-281-1/+1
|\ \ \ \ | | | | | | | | | | Fix typo in serialized_attribute_test. [ci skip]
| * | | | Fix typo in serialized_attribute_test. [ci skip]Max Edmands2013-04-281-1/+1
| | | | |
* | | | | fixes a test, and explains why AR::AttributeMethods checks ↵Xavier Noria2013-04-283-6/+8
|/ / / / | | | | | | | | | | | | defined?(@attributes) in some places
* | | | adding test for the symbol refsAaron Patterson2013-04-261-0/+7
| | | |
* | | | ActiveRecord -> Active RecordXavier Noria2013-04-251-1/+1
| | | |
* | | | fixes warning in the AR test suiteXavier Noria2013-04-251-1/+1
| | | |
* | | | Review DatabaseTasks docs [ci skip]Carlos Antonio da Silva2013-04-241-17/+17
| | | |
* | | | Merge pull request #10333 from ikataitsev/move-test-method-to-testsRafael Mendonça França2013-04-242-8/+9
|\ \ \ \ | | | | | | | | | | Move method used only in the test to the test code itself
| * | | | Move method used only in the test to the test code itselfIvan Kataitsev2013-04-252-8/+9
| | | | |
* | | | | Minor AR changelog review [ci skip]Carlos Antonio da Silva2013-04-241-6/+8
|/ / / /
* | | | Merge branch 'active-record-standalone-improvements'Piotr Sarnacki2013-04-244-24/+92
|\ \ \ \
| * | | | Use env == 'development' instead of env.development?Piotr Sarnacki2013-04-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's simpler to assume that passed env is just a string without any extensions, especially when DatabaseTasks are intended to be used also without rails.
| * | | | Move CHANGELOG entry for db.rake improvements to 4.0.0Piotr Sarnacki2013-04-241-3/+1
| | | | |
| * | | | Don't require Rails.env in order to use AR::Tasks::DatabaseTasksPiotr Sarnacki2013-04-242-6/+8
| | | | |
| * | | | Add some documentation to ActiveRecord::Tasks::DatabaseTasksPiotr Sarnacki2013-04-241-1/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a public class, which could be used directly in order to allow easier database management. Now it also contains settings, which will be used by databases.rake.
| * | | | Use DatabaseTasks.fixtures_path instead of FIXTURES_PATH in db.rakePiotr Sarnacki2013-04-243-3/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will allow to set fixtures path in global config easier, it should be not needed to use FIXTURES_PATH every time user wants to load fixtures.
| * | | | Don't require having Rails.application to run database tasksPiotr Sarnacki2013-04-244-15/+36
| | | | |
* | | | | Added testcase for #10067 and a CHANGELOG entry about this change.kennyj2013-04-252-0/+21
| | | | |
* | | | | Fix a SystemStackError that occurs when using time zone aware attributes.Dan Erikson2013-04-251-1/+1
| | | | | | | | | | | | | | | | | | | | This fixes issue #10066
* | | | | Remove code duplicationNeeraj Singh2013-04-241-8/+9
| | | | |
* | | | | Lookup the class at runtime, not when the association is builtAndrew White2013-04-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Trying to lookup the parent class when the association is being built runs the risk of generating uninitialized constant errors because classes haven't been fully defined yet. To work around this we look up the class at runtime through the `association` method. Fixes #10197.
* | | | | Removed unused associationsAndrew White2013-04-241-2/+0
| | | | |
* | | | | Reset the primary key for other testsAndrew White2013-04-241-0/+2
| | | | |
* | | | | added test cases for #10197Adam Gamble2013-04-241-0/+56
| | | | |
* | | | | Revert "Revert "`belongs_to :touch` behavior now touches old association ↵Andrew White2013-04-243-1/+78
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when transitioning to new association" until a proper fix is found for #10197" This reverts commit 7389df139a35436f00876c96d20e81ba23c93f0a. Conflicts: activerecord/test/cases/timestamp_test.rb
* | | | Remove test case also related to the belongs_to touch featureDavid Heinemeier Hansson2013-04-231-20/+0
| | | |
* | | | Revert "`belongs_to :touch` behavior now touches old association when ↵David Heinemeier Hansson2013-04-233-58/+1
| | | | | | | | | | | | | | | | transitioning to new association" until a proper fix is found for #10197
* | | | When empty options passed to having clause having_values was [nil] but ↵Fyodor2013-04-232-1/+8
| | | | | | | | | | | | | | | | should be empty.
* | | | Merge pull request #10295 from senny/10237_dirty_with_nullable_datetimeCarlos Antonio da Silva2013-04-221-3/+5
|\ \ \ \ | | | | | | | | | | Also assign nil in dirty nullable_datetime test. Closes #10237
| * | | | also assign nil in dirty nullable_datetime test. #10237Yves Senn2013-04-221-3/+5
| | | | |
* | | | | Update counter cache when pushing into associationMatthew Robertson2013-04-213-3/+22
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit fixes a regression bug in which counter_cache columns were not being updated correctly when newly created records were being pushed into an assocation. EG: # this was fine @post.comment.create! # this was fine @comment = Comment.first @post.comments << @comment # this would not update counters @post.comments << Comment.create!
* | | | Merge pull request #10280 from vipulnsward/fix_typos_tempSteve Klabnik2013-04-212-2/+2
|\ \ \ \ | | | | | | | | | | fix typos [ci skip]
| * | | | fix typosVipul A M2013-04-212-2/+2
| | | | |
* | | | | if singletons belong to the contract, test themXavier Noria2013-04-202-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Object#respond_to? returns singletons and thus we inherit that contract. The implementation of the predicate is good, but the test is only checking boolean semantics, which in this case is not enough.
* | | | | Rewrites a CHANGELOG entry.Xavier Noria2013-04-201-16/+6
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The entry is basically copy & paste of the commit message, but the CHANGELOG has a different purpose than Git history, it just communicates what is new: * No need to explain why did the bug happen (unless it is truly relevant). * No need to explain how was the bug fixed. * Whether the user gives new names to columns does not really matter, use of select to cherry-pick a column for example also presented that behaviour. Non-selected attributes are the key, either because they were not included in the selected list, or because they were but with a different alias. * In the case of an attribute alias, what you really want to depict is that respond_to? returns false for the original attribute name.
* | | | Typo Fix in AR CHANGELOG [ci skip]Prathamesh Sonpatki2013-04-201-2/+2
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-07-13 03:11:56 +0000