aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | adds coverage for the deprecation of error_on_ignored_orderXavier Noria2016-07-181-0/+8
| | | | |
* | | | | Merge pull request #25866 from prathamesh-sonpatki/rm-deprecated-mattr-accessorXavier Noria2016-07-181-1/+8
|\ \ \ \ \ | |_|/ / / |/| | | | Followup of changes done to `error_on_ignored_order`
| * | | | Remove mattr_accessor for deprecated config `error_on_ignored_order_or_limit`.Prathamesh Sonpatki2016-07-181-1/+8
| |/ / / | | | | | | | | | | | | | | | | - It adds lot of warnings while running the tests. After https://github.com/rails/rails/commit/451437c6f57e66cc7586ec966e530493927098c7 it is not needed. - Added reader method with deprecation warning for backward compatibility.
* / / / No need `public_send`Ryuta Kamizono2016-07-171-2/+2
|/ / /
* | | Check if the logger exists before trying to use itRafael Mendonça França2016-07-171-1/+1
| | |
* | | Merge pull request #20818 from ↵Rafael França2016-07-174-0/+95
|\ \ \ | | | | | | | | | | | | | | | | jeremywadsack/use_transactional_fixtures_all_databases Use notification to ensure that lazy-loaded model classes have transactions
| * | | Create connection.active_record notification and use that to ensure that lazy-Jeremy Wadsack2016-07-124-0/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | loaded model classes have their connections wrapped in transactions. See #17776 In Rails 4 config.eager_load was changed to false in the test environment. This means that model classes that connect to alternate databases with establish_connection are not loaded at start up. If use_transactional_fixtures is enabled, transactions are wrapped around the connections that have been established only at the start of the test suite. So model classes loaded later don't have transactions causing data created in the alternate database not to be removed. This change resolves that by creating a new connection.active_record notification that gets fired whenever a connection is established. I then added a subscriber after we set up transactions in the test environment to listen for additional connections and wrap those in transactions as well.
* | | | CHANGELOG for https://github.com/rails/rails/pull/25257 [ci skip]Prathamesh Sonpatki2016-07-171-2/+4
| | | | | | | | | | | | | | | | - Also minor weekly CHANGELOG cleanup.
* | | | Merge pull request #25815 from greysteil/add-newline-between-structure-versionsRafael França2016-07-162-2/+9
|\ \ \ \ | | | | | | | | | | Add newline between each migration in `structure.sql`
| * | | | Add newline between each migration in `structure.sql`Grey Baker2016-07-142-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Keeps schema migration inserts as a single commit, so we still get all of the benefits of https://github.com/rails/rails/commit/42dd2336b31a8d98776d039a2b9fd7f834156a78, but allows for easier git diff-ing. Fixes #25504.
* | | | | Fix wrong test namePrathamesh Sonpatki2016-07-161-1/+1
| | | | | | | | | | | | | | | | | | | | - Followup of https://github.com/rails/rails/pull/23179
* | | | | [ci skip] fix a typoYamaguchi.Tomoki2016-07-151-1/+1
|/ / / /
* | | | small reword [ci skip]Xavier Noria2016-07-141-3/+3
| | | |
* | | | removes a unnecessary limit callXavier Noria2016-07-131-1/+0
| | | | | | | | | | | | | | | | | | | | We are setting a limit unconditionally just below, which overrides any existing one anyway.
* | | | adds support for limits in batch processingXavier Noria2016-07-134-54/+220
|/ / /
* | | Merge pull request #25794 from mechanicles/rails-to-RailsRafael França2016-07-122-2/+2
|\ \ \ | | | | | | | | rails -> Rails [ci skip]
| * | | rails -> Rails [ci skip]Santosh Wadghule2016-07-122-2/+2
| | |/ | |/|
* | | Fix Active Record test failureRyuta Kamizono2016-07-121-3/+2
| | | | | | | | | | | | Caused at a45363a2fb53e0a016f33dd211c00b5d81764379.
* | | Always prefer class types to query types when casting `group`Sean Griffin2016-07-114-6/+23
|/ / | | | | | | | | | | | | | | | | | | | | | | | | When `group` is used in combination with any calculation method, the resulting hash uses the grouping expression as the key. Currently we're incorrectly always favoring the type reported by the query, instead of the type known by the class. This causes differing behavior depending on whether the adaptor actually gives proper types with the query or not. After this change, the behavior will be the same on all adaptors -- we see if we know the type from the class, fall back to the type from the query, and finally fall back to the identity type. Fixes #25595
* | Cleanup CHANGELOGs [ci skip]Prathamesh Sonpatki2016-07-091-7/+7
| | | | | | | | | | | | - Cleanup Active Record CHANGELOG. - Add missing CHANGELOG for https://github.com/rails/rails/pull/25688. - Clarify that assets requests logging is suppressed.
* | fix to_param to maximize contentRob Biedenharn2016-07-083-4/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The documentation states that parameter values longer than 20 characters will be truncated by words, but the example shows that a parameter based on "David Heinemeier Hansson" (with id: 125) becomes "125-david" when "David Heinemeier".length == 16 so why so short? The answer lies in the use of the #truncate option omission: nil which seems to have been intended to mean "nothing", but which actually causes the default string "..." to be used. This causes #truncate to cleave words until the "..." can be added and still remain within the requested size of 20 characters. The better option is omission: '' (which is probably what was originally intended). Furthermore, since the use of #parameterize will remove non-alphanumeric characters, we can maximize the useful content of the output by calling parameterize first and then giving truncate a separator: /-/ rather than a space.
* | [ci skip] Update documentation in AR SchemaStatementsAlex Kitchens2016-07-071-12/+12
| | | | | | | | This includes minor grammar fixes throughout the file.
* | Merge pull request #25707 from matthewd/double-reapMatthew Draper2016-07-074-11/+50
|\ \ | | | | | | Don't reap connections that have already been reassigned
| * | Make connection stealing more explicitMatthew Draper2016-07-063-6/+27
| | |
| * | Reduce locking by taking ownership of stale connectionsMatthew Draper2016-07-061-9/+8
| | | | | | | | | | | | | | | | | | This way, we aren't racing other threads, so we don't need to re-check the conditional. And we no longer need to hold the lock while calling remove (which can choose to make a new connection while we wait).
| * | Re-check that the connection is still stale before we reap itMatthew Draper2016-07-062-0/+9
| | | | | | | | | | | | | | | | | | | | | A concurrent thread may have also detected it to be stale, and already released (or even reassigned) it by now. Fixes #25585
| * | Check connection ownership before allowing a thread to release itMatthew Draper2016-07-061-1/+11
| | | | | | | | | | | | | | | A thread can only release a connection if it owns it, or it's owned by a thread that has died.
* | | [ci skip] Update ConnectionPool documentation for readabilityAlex Kitchens2016-07-061-21/+21
| | |
* | | Merge pull request #24890 from vipulnsward/travel-to-raiseKasper Timm Hansen2016-07-051-6/+5
|\ \ \ | | | | | | | | `travel/travel_to` travel time helpers, now raise on nested calls
| * | | `travel/travel_to` travel time helpers, now raise on nested calls,Vipul A M2016-07-021-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as this can lead to confusing time stubbing. Instead of: travel_to 2.days.from_now do # 2 days from today travel_to 3.days.from_now do # 5 days from today end end preferred way to achieve above is: travel_to 2.days.from_now # 2 days from today travel_back travel_to 5.days.from_now # 5 days from today Closes #24690 Fixes #24689
* | | | Merge pull request #25668 from kamipo/use_squish_rather_than_strip_heredocRafael França2016-07-052-4/+4
|\ \ \ \ | | | | | | | | | | Use `squish` rather than `strip_heredoc`
| * | | | Use `squish` rather than `strip_heredoc`Ryuta Kamizono2016-07-042-4/+4
| | |/ / | |/| |
* | | | Merge pull request #25680 from ↵Rafael França2016-07-041-7/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | HermanHiddema/fix/unnecessary-nesting-in-handle-dependency Fixed unnecessary nesting in handle_dependency
| * | | | Fixed unnecessary nesting in handle_dependencyHerman Hiddema2016-07-041-7/+5
| |/ / / | | | | | | | | | | | | | | | | This nested if checked the same value as the containing case statement. Moved the code in the if/else into when/else in the containing case.
* / / / fix respond_to? documentationKivanio Barbosa2016-07-041-7/+7
|/ / /
* | | Merge pull request #25241 from aguynamedben/fix-touch-error-messagesRichard Schneeman2016-07-032-2/+12
|\ \ \ | | | | | | | | Improve error message when record touch fails.
| * | | Improve error message when record touch fails.Ben Standefer2016-07-022-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | The current error message only indicates that a touch can fail because the record is new. In practice, we saw cases where touches were failing because the record had been destroyed. `persisted?` checks `new_record?` *and* `destroyed?`. It was confusing to get a message about a new record when in reality we were destroying records. I also included a helpful tip for users to consider using `persisted?`, `new_record?`, or `destroyed?` before touching.
* | | | Clarify Postgres initials. [skip ci]William Johnston2016-07-021-2/+2
|/ / /
* | | Fix typo: accidently -> accidentally.Hendy Tanata2016-07-021-1/+1
| | |
* | | Merge pull request #25638 from kamipo/remove_unused_predicate_builderSean Griffin2016-07-023-19/+3
|\ \ \ | |_|/ |/| | Remove unused `predicate_builder` for `BasicObjectHandler` and `RangeHandler`
| * | Remove unused `predicate_builder` for `BasicObjectHandler` and `RangeHandler`Ryuta Kamizono2016-07-023-19/+3
| | |
* | | Merge pull request #25507 from ↵Rafael França2016-07-023-14/+17
|\ \ \ | | | | | | | | | | | | | | | | bquorning/optimize-for-first-result-and-remove-mysql-select_one Remove #select_one from Mysql2Adapter
| * | | Optimize ActiveRecord::Result#lastBenjamin Quorning2016-06-242-1/+7
| | | | | | | | | | | | | | | | | | | | If you only want the last element of a result set, there's no need to create all of hash_rows. Also, add a test.
| * | | Remove MySQL::DatabaseStatements#select_oneBenjamin Quorning2016-06-241-13/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The implementation from abstract/database_statements.rb seems to work just fine. And with ActiveRecord::Result now implementing an optimized #first method, the performance concerns previously addressed in https://github.com/rails/rails/commit/bf79aa4fc14aeb2646331e767038acf0b77e9e7f should not be an issue.
| * | | Add ActiveRecord::Result#firstBenjamin Quorning2016-06-242-0/+10
| | | | | | | | | | | | | | | | | | | | When you only need the first element of a result set, you shouldn't need to instantiate all of hash_rows.
* | | | Merge pull request #25631 from yahonda/revert_rename_to_ar_internal_metadataRafael França2016-07-012-28/+0
|\ \ \ \ | | | | | | | | | | Revert "Rename `active_record_internal_metadatas` to `ar_internal_metadata"
| * | | | Revert "Rename `active_record_internal_metadatas` to `ar_internal_metadata`"Yasuo Honda2016-07-012-28/+0
| | |_|/ | |/| | | | | | | | | | This reverts commit 407e0ab5e5cddf6a8b6b278b12f50772d13b4d86.
* | | | Merge pull request #25633 from kamipo/remove_create_table_info_cacheRafael França2016-07-011-6/+1
|\ \ \ \ | |_|_|/ |/| | | Remove `create_table_info_cache` because it not be reused
| * | | Remove `create_table_info_cache` because it not be reusedRyuta Kamizono2016-07-021-6/+1
| |/ / | | | | | | | | | | | | | | | `create_table_info_cache` is used for sharing `create_table_info` both `table_options` and `foreign_keys`. But `foreign_keys` no longer uses `create_table_info_cache` by #25307. No need caching anymore.
* | | Merge pull request #25620 from kamipo/create_without_primary_keyRafael França2016-07-012-1/+9
|\ \ \ | |/ / |/| | Pass `pk: false` to `connection.insert` explicitly if do not have a primary key
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 09:18:53 +0000