Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Dont perform unnecessary check with false, just use true/false values for ↵ | Vipul A M | 2016-05-11 | 1 | -2/+2 |
| | | | | @active on SQLite adapter. | ||||
* | Merge pull request #24950 from kamipo/should_quote_lock_name | Rafael França | 2016-05-10 | 2 | -5/+5 |
|\ | | | | | Should quote `lock_name` to pass to `get_advisory_lock` | ||||
| * | Should quote `lock_name` to pass to `get_advisory_lock` | Ryuta Kamizono | 2016-05-10 | 2 | -5/+5 |
| | | |||||
* | | Merge pull request #24939 from Neodelf/again_with_loop | Xavier Noria | 2016-05-10 | 1 | -2/+1 |
|\ \ | |/ |/| | Replacement cycle for readability | ||||
| * | Replacement cycle for readability | Molchanov Andrey | 2016-05-10 | 1 | -2/+1 |
| | | |||||
* | | Add migration compatibility class for Rails 5.1 | Rafael Mendonça França | 2016-05-10 | 1 | -1/+4 |
| | | |||||
* | | Start Rails 5.1 development :tada: | Rafael Mendonça França | 2016-05-10 | 2 | -2116/+3 |
|/ | |||||
* | Replacement cycle for readability | Molchanov Andrey | 2016-05-09 | 1 | -2/+2 |
| | |||||
* | Followup to #24844 | Jon Moss | 2016-05-07 | 2 | -3/+4 |
| | | | | | | | Some slight documentation edits and fixes. Also, run remove unnecessary `RuntimeError`. r? @arthurnn | ||||
* | Preparing for 5.0.0.rc1 release | Rafael Mendonça França | 2016-05-06 | 2 | -1/+6 |
| | |||||
* | Merge pull request #24844 from arthurnn/arthurnn/conn | Arthur Nogueira Neves | 2016-05-06 | 11 | -92/+109 |
|\ | | | | | Refactor connection handler | ||||
| * | Update docs for connection handler | Arthur Neves | 2016-05-06 | 1 | -2/+5 |
| | | | | | | | | [skip ci] | ||||
| * | s/specification_name/connection_specification_name | Arthur Neves | 2016-05-06 | 4 | -14/+14 |
| | | |||||
| * | s/specification_id/specification_name | Arthur Neves | 2016-05-05 | 8 | -48/+48 |
| | | |||||
| * | Retrive the right pool for db tasks | Arthur Neves | 2016-05-05 | 1 | -2/+2 |
| | | |||||
| * | inline retrive_conn_pool method | Arthur Neves | 2016-05-05 | 1 | -12/+8 |
| | | |||||
| * | Better code readability | Arthur Neves | 2016-05-05 | 2 | -4/+2 |
| | | |||||
| * | Test to swap connection at runtime | Arthur Neves | 2016-05-05 | 1 | -0/+7 |
| | | |||||
| * | fix test | Arthur Neves | 2016-05-05 | 1 | -8/+7 |
| | | |||||
| * | Add spec_id tests | Arthur Neves | 2016-05-05 | 1 | -0/+9 |
| | | |||||
| * | Use spec key, when given as spec_id | Arthur Neves | 2016-05-05 | 2 | -20/+23 |
| | | |||||
| * | Better specification_id method | Arthur Neves | 2016-05-05 | 1 | -10/+7 |
| | | |||||
| * | Rename method | Arthur Neves | 2016-05-05 | 1 | -3/+3 |
| | | |||||
| * | Refactor connection handler | Arthur Neves | 2016-05-05 | 9 | -83/+88 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ConnectionHandler will not have any knowlodge of AR models now, it will only know about the specs. Like that we can decouple the two, and allow the same model to use more than one connection. Historically, folks used to create abstract AR classes on the fly in order to have multiple connections for the same model, and override the connection methods. With this, now we can override the `specificiation_id` method in the model, to return a key, that will be used to find the connection_pool from the handler. | ||||
* | | Merge pull request #24871 from vipulnsward/disable-transaction-failure | Arthur Nogueira Neves | 2016-05-06 | 1 | -0/+2 |
|\ \ | | | | | | | Fix failures due to transactions | ||||
| * | | We are erroring due to nested transaction failures from mysql on ↵ | Vipul A M | 2016-05-06 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | test_migrate_clears_schema_cache_afterward test. Disable transactions for this test. Fixes #24391 | ||||
* | | | Allow the connection adapters to determine the order of bind params | Sean Griffin | 2016-05-06 | 3 | -4/+46 |
|/ / | | | | | | | | | | | | | | | | | | | | | | | In 5.0 we use bind parameters for limit and offset, while in 4.2 we used the values directly. The code as it was written assumed that limit and offset worked as `LIMIT ? OFFSET ?`. Both Oracle and SQL Server have a different syntax, where the offset is stated before the limit. We delegate this behavior to the connection adapter so that these adapters are able to determine how the bind parameters are flattened based on what order their specification has the various clauses appear. Fixes #24775 | ||||
* | | Merge pull request #24869 from vipulnsward/change-example | Rafael França | 2016-05-05 | 1 | -3/+3 |
|\ \ | | | | | | | Change to use a more realistic example [ci skip] | ||||
| * | | Change to use a more realistic example and not giving the impression that ↵ | Vipul A M | 2016-05-05 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | destroy_all is preferred way to destroy related records. This example just wants to demonstrate callback behaviour. [ci skip] | ||||
* | | | Merge pull request #24868 from vipulnsward/delegate_encode_with | Rafael França | 2016-05-05 | 1 | -1/+1 |
|\ \ \ | |/ / |/| | | delegate encode_with instead of to_yaml, which is deprecated | ||||
| * | | delegate encode_with instead of to_yaml, which is deprecated | Vipul A M | 2016-05-05 | 1 | -1/+1 |
| | | | |||||
* | | | [ci skip] Don't promote SQL interpolation. | Kasper Timm Hansen | 2016-05-05 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | After fb898e9, the `before_destroy` had some code that used SQL interpolation left over. Don't think we should promote that even if the values aren't directly from user input. | ||||
* | | | Merge pull request #24859 from y-yagi/do_not_pass_conditon_to_destroy_all | Vipul A M | 2016-05-05 | 2 | -3/+3 |
|\ \ \ | |_|/ |/| | | do not pass conditions to `#destroy_all` [ci skip] | ||||
| * | | do not pass conditions to `#destroy_all` [ci skip] | yuuji.yaginuma | 2016-05-05 | 2 | -3/+3 |
| |/ | | | | | | | Passing conditions to `#destroy_all` was deprecated in c82c5f8. | ||||
* / | Fix some typos in comments. | Joe Rafaniello | 2016-05-04 | 3 | -3/+3 |
|/ | | | | [ci skip] | ||||
* | Followup of #24835 | Vipul A M | 2016-05-03 | 3 | -5/+5 |
| | | | | Fix failing tests | ||||
* | Merge pull request #24833 from Erol/fix-typo | प्रथमेश Sonpatki | 2016-05-03 | 1 | -1/+1 |
|\ | | | | | Fix small typo in Active Record Migrations documentation | ||||
| * | Fix small typo in Active Record Migrations documentation [ci skip] | Erol Fornoles | 2016-05-03 | 1 | -1/+1 |
| | | |||||
* | | remove `empty?` from CHANGELOG [ci skip] | yuuji.yaginuma | 2016-05-03 | 1 | -2/+1 |
|/ | | | | Follow up to 98264a1343fad6bb6637893a37fd571916b4158c | ||||
* | Do not delegate `AR::Base#empty?` to `all` | Sean Griffin | 2016-05-02 | 2 | -7/+1 |
| | | | | | | | | | | Unlike `one?` and `none?`, `empty?` has interactions with methods outside of enumerable. It also doesn't fit in the same vein. `Topic.any?` makes sense. `Topic.empty?` does not, as `Topic` is not a container. Fixes #24808 Close #24812 | ||||
* | Add `:nodoc:` to `schema_creation` [ci skip] | Ryuta Kamizono | 2016-05-02 | 1 | -1/+1 |
| | | | | | | | `schema_creation` is not public API. https://github.com/rails/rails/blob/v5.0.0.beta4/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb#L121 https://github.com/rails/rails/blob/v5.0.0.beta4/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L78 | ||||
* | Merge pull request #24713 from tomkadwill/fix_counter_cache_increment | Sean Griffin | 2016-04-30 | 3 | -0/+14 |
|\ | | | | | | | | | Fix counter_cache double increment bug Close #24183 | ||||
| * | Fix counter_cache double increment bug | Tom Kadwill | 2016-04-28 | 3 | -0/+14 |
| | | |||||
* | | Replace `Rails.version.to_f` with Active Record | Jon Moss | 2016-04-30 | 2 | -1/+5 |
| | | | | | | | | | | Rails should not be explicity mentioned within Active Record, since railties and the Rails ecosystem is not required for use. | ||||
* | | rm unused require | Vipul A M | 2016-04-29 | 1 | -1/+0 |
| | | | | | | | | Signed-off-by: Jeremy Daer <jeremydaer@gmail.com> | ||||
* | | Extract `add_sql_comment!` method | Ryuta Kamizono | 2016-04-29 | 3 | -20/+13 |
| | | | | | | | | | | | | Refactor of #22911. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com> | ||||
* | | Treat blank comments as no comment for indexes | Ryuta Kamizono | 2016-04-29 | 3 | -6/+11 |
| | | | | | | | | | | | | Follow up of 1683410. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com> | ||||
* | | Migrations: move version-finding responsibility | yui-knk | 2016-04-29 | 2 | -7/+11 |
| | | | | | | | | | | | | | | `ActiveRecord::Migration` needn't know about migration version compatibility lookup. Delegate it to the Compatibility module. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com> | ||||
* | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2016-04-29 | 2 | -2/+7 |
|\ \ | | | | | | | | | | | | | Conflicts: guides/source/configuring.md | ||||
| * | | s/statment/statement/ | Vipul A M | 2016-04-24 | 1 | -1/+1 |
| | | |