aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Fix #has_secure_token documentation [ci skip]Tim Liner2015-02-201-2/+2
| | | | | It's actually #validates_uniqueness_of that can generate a race condition rather than #validates_presence_of.
* Error message testing fixFranky W2015-02-203-5/+11
| | | | | | | | | The testing of error messages have been implemented wrongly a few times. This is an attempt to fix it. For example, some of these test should have failed with the new code. The reason they are not failling with the new string is the fact they were not being tested beforehand.
* Merge branch 'rm-take' into 4-1-stableRafael Mendonça França2015-02-203-1/+43
|
* Do not test, document or use a private API methodRafael Mendonça França2015-02-203-28/+0
| | | | These methods are nodoc so we should not document them.
* Merge pull request #16989 from Empact/reload-cache-clearRafael Mendonça França2015-02-206-28/+53
|\ | | | | | | Isolate access to @associations_cache and @aggregations_cache to the Associations and Aggregations modules, respectively.
| * Isolate access to @associations_cache and @aggregations cache to the ↵Ben Woosley2014-09-289-32/+66
| | | | | | | | | | | | | | | | Associations and Aggregations modules, respectively. This includes replacing the `association_cache` accessor with a more limited `association_cached?` accessor and making `clear_association_cache` and `clear_aggregation_cache` private.
* | Merge pull request #19018 from lucasmazza/lm-activemodel-validate-bangRafael Mendonça França2015-02-201-14/+2
|\ \ | | | | | | Move the `validate!` method to `ActiveModel::Validations`.
| * | Move the `validate!` method to `ActiveModel::Validations`.Lucas Mazza2015-02-201-14/+2
| | |
* | | Merge pull request #16993 from Empact/simplify-find_by-statement-cacheRafael Mendonça França2015-02-201-16/+18
|\ \ \ | |/ / |/| | | | | Simplify find_by_statement_cache interaction
| * | Simplify `find_by_statement_cache` interaction down to a class-level ivar ↵Ben Woosley2014-09-221-20/+18
| | | | | | | | | | | | with a single accessor `cached_find_by_statement`.
* | | Merge pull request #17139 from mfazekas/fix_becomes_changed_attributesRafael Mendonça França2015-02-203-1/+14
|\ \ \ | | | | | | | | | | | | Always reset changed attributes in becomes
| * | | Always reset changed attributes in becomesMiklos Fazekas2015-02-043-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When ```becomes``` changes @attributes it should also change @changed_attributes. Otherwise we'll experience a kind of split head situation where attributes are coming from ```self```, but changed_attributes is coming from ```klass.new```. This affects the inheritance_colmn as it's changed by new for example. Fixes #16881
* | | | Add schema dumping tests for datetime and time precisionRyuta Kamizono2015-02-203-8/+34
| | | |
* | | | Format the time string according to the precision of the time columnRyuta Kamizono2015-02-205-20/+43
| | | | | | | | | | | | | | | | It is also necessary to format a time column like a datetime column.
* | | | Allow `:precision` option for time type columnsRyuta Kamizono2015-02-208-14/+89
| | | |
* | | | fix column name in migration example [ci skip]Daniël de Vries2015-02-191-1/+1
| | | |
* | | | Merge pull request #18996 from morgoth/deprecate-more-errors-methodsYves Senn2015-02-192-2/+2
|\ \ \ \ | | | | | | | | | | | | | | | Deprecate `ActiveModel::Errors` `add_on_empty` and `add_on_blank` methods
| * | | | Deprecate `ActiveModel::Errors` `add_on_empty` and `add_on_blank` methodsWojciech Wnętrzak2015-02-192-2/+2
| | | | | | | | | | | | | | | | | | | | without replacement.
* | | | | Merge pull request #18916 from kamipo/handle_array_option_in_type_to_sqlRafael Mendonça França2015-02-193-37/+32
|\ \ \ \ \ | | | | | | | | | | | | Handle array option in `type_to_sql`
| * | | | | Handle array option in `type_to_sql`Ryuta Kamizono2015-02-191-19/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `[]` is a part of `sql_type`, so it is always necessary to respect to array option when `type_to_sql` is called.
| * | | | | Use `delegate` to call the methods to `@conn`Ryuta Kamizono2015-02-191-16/+3
| | | | | |
| * | | | | Should handle array option for `:cast_as`Ryuta Kamizono2015-02-192-4/+15
| | | | | |
* | | | | | Merge pull request #18979 from ↵Rafael Mendonça França2015-02-193-8/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/extract_precision_from_datetime_and_time_columns Extract precision from datetime and time columns
| * | | | | | Extract precision from datetime and time columnsRyuta Kamizono2015-02-193-8/+5
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The cause by which the test suite for the mysql adapter broke in 1502cae (reverted 89ba5bb) is because the precision was not extracted. The rounding problem in mysql adapter has not been fixed, but `mysql_56` helper tested only mysql2 adapter, its behavior was not apparent.
* | | | | | Return true instead of self when suppressedRafael Mendonça França2015-02-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | save is documented to return singletons so we should always return a singleton.
* | | | | | Copy edit the suppressor documentationRafael Mendonça França2015-02-193-29/+28
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | Add `ActiveRecord::Base.suppress`Michael Ryan2015-02-188-0/+118
|/ / / / /
* / / / / Add `time` option to `#touch`Hyonjee Joo2015-02-183-6/+34
|/ / / / | | | | | | | | | | | | | | | | | | | | Fixes #18905. `#touch` now takes time as an option. Setting the option saves the record with the updated_at/on attributes set to the current time or the time specified. Updated tests and documentation accordingly.
* | | | Merge pull request #18984 from rousisk/masterCarlos Antonio da Silva2015-02-181-2/+2
|\ \ \ \ | | | | | | | | | | Replace deprecated readonly option with scope blocks in docs and guide
| * | | | Replace deprecated readonly option with scope blocks in docs and guideKonstantinos Rousis2015-02-181-2/+2
| | | | |
* | | | | Prefer `drop_table if_exists: true` over raw SQLRyuta Kamizono2015-02-1821-25/+25
|/ / / / | | | | | | | | | | | | | | | | Lowercase raw SQL has been replaced by 07b659c already. This commit replaces everything else of raw SQL.
* | | | prefer `drop_table if_exists: true` over raw SQL.Yves Senn2015-02-1812-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | /cc @yahonda This makes it easier for third party adapters to run our tests, even if that database does not support IF EXISTS.
* | | | Add docs for the type registrySean Griffin2015-02-172-5/+24
| | | |
* | | | Rm `Type#type_cast`Sean Griffin2015-02-1713-28/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This helper no longer makes sense as a separate method. Instead I'll just have `deserialize` call `cast` by default. This led to a random infinite loop in the `JSON` pg type, when it called `super` from `deserialize`. Not really a great way to fix that other than not calling super, or continuing to have the separate method, which makes the public API differ from what we say it is.
* | | | `type_cast_from_user` -> `cast`Sean Griffin2015-02-1722-106/+106
| | | |
* | | | `type_cast_for_database` -> `serialize`Sean Griffin2015-02-1740-79/+79
| | | |
* | | | `Type#type_cast_from_database` -> `Type#deserialize`Sean Griffin2015-02-1736-71/+71
| | | |
* | | | Add line endings to files which are missing themSean Griffin2015-02-1716-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | These files get modified whenever someone uses a tool like `sed`. Let's just get this over with in one commit so it'd not adding diff noise to something else.
* | | | Fix test failures on Mysql 5.5Sean Griffin2015-02-171-1/+1
| | | |
* | | | Update code which depended on methods added by 1502caefSean Griffin2015-02-171-1/+1
| | | |
* | | | Revert "Allow `:precision` option for time type columns"Sean Griffin2015-02-177-90/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 1502caefd30b137fd1a0865be34c5bbf85ba64c1. The test suite for the mysql adapter broke when this commit was used with MySQL 5.6. Conflicts: activerecord/CHANGELOG.md
* | | | correct method name in deprecation messageyuuji.yaginuma2015-02-181-1/+1
| | | |
* | | | Deprecated passing of `start` value to `find_in_batches` and `find_each` in ↵Vipul A M2015-02-173-24/+64
| | | | | | | | | | | | | | | | favour of `begin_at` value.
* | | | Merge pull request #18662 from estum/foreign-key-existsYves Senn2015-02-164-15/+63
|\ \ \ \ | | | | | | | | | | | | | | | Add `foreign_key_exists?` method.
| * | | | Add methods to get foreign key matching argumentsAnton2015-01-292-40/+36
| | | | |
| * | | | Add `foreign_key_exists?` method.Anton2015-01-243-0/+48
| | | | |
* | | | | fix, `to_table` in `remove_foreign_key` should be plural.Yves Senn2015-02-161-1/+1
| | | | |
* | | | | Register adapter specific types with the global type registrySean Griffin2015-02-157-67/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We do this in the adapter classes specifically, so the types aren't registered if we don't use that adapter. Constants under the PostgreSQL namespace for example are never loaded if we're using mysql.
* | | | | Add a global type registry, used to lookup and register typesSean Griffin2015-02-154-0/+336
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per previous discussions, we want to give users the ability to reference their own types with symbols, instead of having to pass the object manually. This adds the class that will be used to do so. ActiveRecord::Type.register(:money, MyMoneyType)
* | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-02-141-3/+3
|\ \ \ \ \
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-10 01:05:37 +0000