aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* A failing test for a nested has many through association loaded via ↵Jon Leighton2010-10-051-0/+6
| | | | Foo.joins(:bar)
* Fix the tests (I have actually verified that these are also the 'right' ↵Jon Leighton2010-10-036-24/+24
| | | | fixes, rather than just making the tests pass again)
* Add support for table aliasing, with a test that needs aliasing in order to ↵Jon Leighton2010-10-027-15/+75
| | | | work correctly. This test incidentally provides a more complicated test case (4 inner joins, 2 using polymorphism).
* Integrate nested support into ThroughAssociationScope, using my concept of ↵Jon Leighton2010-10-025-59/+107
| | | | generating a 'chain' of reflections to be joined. It seems to work at the moment, all existing tests are passing. There may be further complications as we add more test cases for nested associations, though.
* Started implementing nested :through associations by using the existing ↵Jon Leighton2010-10-014-32/+60
| | | | structure of ThroughAssociationScope rather than layering a module over the top
* Prevent ↵Jon Leighton2010-09-301-2/+2
| | | | test_has_many_through_a_has_many_through_association_on_through_reflection failing for me due to ordering of the results
* Merge branch 'master' into nested_has_many_through_2Jon Leighton2010-09-3033-224/+350
|\
| * Fix 'rake db:create' is ignore encoding when using postgres [#5717 ↵yalab2010-09-301-1/+1
| | | | | | | | | | | | state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * Added config.app_generators to allow configuring application's generators ↵Piotr Sarnacki2010-09-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from railties. With config.generators becomes a way to configure generators for current instance only. For example: module Blog class Engine < Rails::Engine config.generators do |g| g.orm :active_record end config.app_generators do |g| g.test_framework :rspec end end end such definition sets :active_record as orm for engine and :rspec as test_framework for application. The values set with app_generators can be overwritten in application using config.generators as you would normally do: module MyApp class Application < Rails::Application config.generators do |g| g.test_framework :test_unit end end end
| * double negative is not goodNeeraj Singh2010-09-301-1/+1
| |
| * no need of nil checkNeeraj Singh2010-09-291-1/+1
| |
| * Use detect instead select to avoid "sh: [mysqldump]: command not found".Emilio Tagua2010-09-291-1/+1
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
| * eliminating method_missing on TableDefinitionAaron Patterson2010-09-292-16/+18
| |
| * DRY up postgresql quote logicAaron Patterson2010-09-291-11/+14
| |
| * fixing where clause indentationAaron Patterson2010-09-291-4/+4
| |
| * use consistent method calls for column inspectionAaron Patterson2010-09-291-1/+1
| |
| * require pg when this adapter is loadedAaron Patterson2010-09-291-5/+4
| |
| * only reopen ConnectionAdapters onceAaron Patterson2010-09-291-2/+0
| |
| * use inheritence to deal with custom methodsAaron Patterson2010-09-292-10/+20
| |
| * fisting test organizationAaron Patterson2010-09-292-52/+50
| |
| * just use if rather than nil?Aaron Patterson2010-09-291-1/+1
| |
| * just require sqlite3 when the database adapter is requiredAaron Patterson2010-09-291-4/+1
| |
| * removing more useless code! yay!Aaron Patterson2010-09-281-6/+2
| |
| * SqlLiteral is a string, so we can dry up these conditionalsAaron Patterson2010-09-281-4/+3
| |
| * shorten up or sql literal creation statementsAaron Patterson2010-09-281-4/+2
| |
| * we only care about arrays and stringsAaron Patterson2010-09-281-1/+1
| |
| * dry up calls to arel.join()Aaron Patterson2010-09-281-5/+4
| |
| * removing unused lasgnsAaron Patterson2010-09-281-4/+4
| |
| * refactoring to remove crazy logicAaron Patterson2010-09-282-9/+6
| |
| * where_values_hash always returns a hashAaron Patterson2010-09-281-1/+1
| |
| * performance improvement based on discussion at ↵Neeraj Singh2010-09-281-9/+3
| | | | | | | | | | | | http://github.com/rails/rails/commit/fbd1d306b95cc2efb6422e12d26d5818a3a42343 Credit goes to all the participants in the discussion
| * Revert "porting 515917f5d8678af6c57842ca5dfd7c18e67ff1fe to master"Aaron Patterson2010-09-281-6/+0
| | | | | | | | This reverts commit bee447a5b9fe1d683c6cc69aefb7fc22c2a9d9af.
| * Revert "porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks ↵Aaron Patterson2010-09-281-1/+1
| | | | | | | | | | | | Marcelo Giorgi" This reverts commit 9eca11a4a564f44675cca951216e917b8f610eab.
| * removing a conditional that is not usedAaron Patterson2010-09-281-2/+0
| |
| * fisting the postgresql testsAaron Patterson2010-09-281-1/+2
| |
| * Set attributes properly for model built from association with conditions ↵Marcelo Giorgi2010-09-288-10/+61
| | | | | | | | | | | | [#5562 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * each works well tooAaron Patterson2010-09-281-1/+1
| |
| * no need for splat and flattenAaron Patterson2010-09-281-1/+1
| |
| * avoid calling to_sql when we canAaron Patterson2010-09-282-4/+4
| |
| * removing an inject + merge in favor of Hash#[]Aaron Patterson2010-09-281-1/+1
| |
| * fixing indentation warningAaron Patterson2010-09-281-1/+1
| |
| * Test add_index and remove_index with a symbol name #4891Étienne Barrié2010-09-282-4/+10
| |
| * porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks Marcelo ↵Aaron Patterson2010-09-281-1/+1
| | | | | | | | Giorgi
| * porting 515917f5d8678af6c57842ca5dfd7c18e67ff1fe to masterAaron Patterson2010-09-281-0/+6
| |
| * use new skool Ruby instead of Ruby Classic™Aaron Patterson2010-09-271-5/+3
| |
| * be kind to the garbage collector: only instantiate objects when absolutely ↵Aaron Patterson2010-09-271-14/+17
| | | | | | | | necessary
| * adding test cases for the dynamic finder matcher match methodAaron Patterson2010-09-271-0/+49
| |
| * constructor should not do so much work; avoid allocating object if possibleAaron Patterson2010-09-271-10/+5
| |
| * @klass also uses DynamicFinderMatch, so no need for it on the relationAaron Patterson2010-09-272-9/+5
| |
| * no need for a case / when statementAaron Patterson2010-09-271-11/+7
| |