aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
| * SqlLiteral is a string, so we can dry up these conditionalsAaron Patterson2010-09-281-4/+3
| |
| * shorten up or sql literal creation statementsAaron Patterson2010-09-281-4/+2
| |
| * we only care about arrays and stringsAaron Patterson2010-09-281-1/+1
| |
| * dry up calls to arel.join()Aaron Patterson2010-09-281-5/+4
| |
| * removing unused lasgnsAaron Patterson2010-09-281-4/+4
| |
| * refactoring to remove crazy logicAaron Patterson2010-09-282-9/+6
| |
| * where_values_hash always returns a hashAaron Patterson2010-09-281-1/+1
| |
| * performance improvement based on discussion at ↵Neeraj Singh2010-09-281-9/+3
| | | | | | | | | | | | http://github.com/rails/rails/commit/fbd1d306b95cc2efb6422e12d26d5818a3a42343 Credit goes to all the participants in the discussion
| * Revert "porting 515917f5d8678af6c57842ca5dfd7c18e67ff1fe to master"Aaron Patterson2010-09-281-6/+0
| | | | | | | | This reverts commit bee447a5b9fe1d683c6cc69aefb7fc22c2a9d9af.
| * Revert "porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks ↵Aaron Patterson2010-09-281-1/+1
| | | | | | | | | | | | Marcelo Giorgi" This reverts commit 9eca11a4a564f44675cca951216e917b8f610eab.
| * removing a conditional that is not usedAaron Patterson2010-09-281-2/+0
| |
| * fisting the postgresql testsAaron Patterson2010-09-281-1/+2
| |
| * Set attributes properly for model built from association with conditions ↵Marcelo Giorgi2010-09-288-10/+61
| | | | | | | | | | | | [#5562 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * each works well tooAaron Patterson2010-09-281-1/+1
| |
| * no need for splat and flattenAaron Patterson2010-09-281-1/+1
| |
| * avoid calling to_sql when we canAaron Patterson2010-09-282-4/+4
| |
| * removing an inject + merge in favor of Hash#[]Aaron Patterson2010-09-281-1/+1
| |
| * fixing indentation warningAaron Patterson2010-09-281-1/+1
| |
| * Test add_index and remove_index with a symbol name #4891Étienne Barrié2010-09-282-4/+10
| |
| * porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks Marcelo ↵Aaron Patterson2010-09-281-1/+1
| | | | | | | | Giorgi
| * porting 515917f5d8678af6c57842ca5dfd7c18e67ff1fe to masterAaron Patterson2010-09-281-0/+6
| |
| * use new skool Ruby instead of Ruby Classic™Aaron Patterson2010-09-271-5/+3
| |
| * be kind to the garbage collector: only instantiate objects when absolutely ↵Aaron Patterson2010-09-271-14/+17
| | | | | | | | necessary
| * adding test cases for the dynamic finder matcher match methodAaron Patterson2010-09-271-0/+49
| |
| * constructor should not do so much work; avoid allocating object if possibleAaron Patterson2010-09-271-10/+5
| |
| * @klass also uses DynamicFinderMatch, so no need for it on the relationAaron Patterson2010-09-272-9/+5
| |
| * no need for a case / when statementAaron Patterson2010-09-271-11/+7
| |
| * do not need intermediate variable, avoid lasgnAaron Patterson2010-09-271-2/+3
| |
| * DRY up our regular expressionAaron Patterson2010-09-271-3/+3
| |
| * reduce method calls in the dynamic finder matcherAaron Patterson2010-09-271-4/+4
| |
| * make sure we use the engine assigned to the table when quotingAaron Patterson2010-09-272-1/+19
| |
| * Fix for #5579 involved the code change for both has_one and has_many ↵Neeraj Singh2010-09-271-1/+9
| | | | | | | | | | | | | | | | relationships. The path included test only for has_one. This patch adds test for has_many relationship. [#5706 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * Fix for nested_attributes with has_many association fails when a single ↵Neeraj Singh2010-09-272-1/+14
| | | | | | | | | | | | | | | | record is being updated. [#5705 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * Merge remote branch 'miloops/warnings'José Valim2010-09-271-3/+3
| |\ | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/url_for.rb
| | * Prevent shadowing outer local variable.Emilio Tagua2010-09-271-3/+3
| | |
| * | adding a test for slug behaviorAaron Patterson2010-09-271-0/+4
| | |
| * | Three performance improvements:Neeraj Singh2010-09-271-10/+9
| | | | | | | | | | | | | | | | | | | | | | | | * for simple cases like User.last and User.order('name desc').last no need to perform Array#join operation. * Instead of performing String#blank? do Array#empty? * no need to create variable relation
| * | depending on arel 2.0.0Aaron Patterson2010-09-271-1/+1
| |/
| * third parameter is not usedAaron Patterson2010-09-261-1/+1
| |
| * db:structure:dump should list current Rails.env adapter in errors, not ↵Nic Benders2010-09-261-1/+1
| | | | | | | | | | | | | | | | always the test adapter [#5710 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * Fix remove_index issue when provided :name is a symbolTim Connor2010-09-262-2/+2
| | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | Initial nested_has_many_through support [#1152]Bodaniel Jeanes2010-09-2610-15/+220
|/
* Add namespacing for observer generatorPiotr Sarnacki2010-09-251-0/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Generators fix: properly check if module should be created when creating a ↵Piotr Sarnacki2010-09-251-1/+1
| | | | | | namespaced model Signed-off-by: José Valim <jose.valim@gmail.com>
* Delegate ActiveRecord::Base.offset to scoped methods (analogous to limit) ↵Marcelo Giorgi2010-09-242-1/+7
| | | | | | [#5688 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Fix warning message when db/schema.rb doesn't exist [#5625 state:resolved]Brian Candler2010-09-241-1/+1
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Refactor namespaced generators to use module_namespacing block helperPiotr Sarnacki2010-09-243-2/+6
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Generators are not aware of namespace of isolated engines and applicationsPiotr Sarnacki2010-09-241-2/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* restore behavior of touch for models without :updated_xx [#5439 state:resolved]tnp2010-09-242-8/+15
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* reject_id option should be respected while using nested_attributesNeeraj Singh2010-09-242-3/+12
| | | | | | [#5579 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>