aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Ambiguous reflections are on :through relationships are no longer supported.Aaron Patterson2013-06-134-3/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For example, you need to change this: class Author < ActiveRecord::Base has_many :posts has_many :taggings, :through => :posts end class Post < ActiveRecord::Base has_one :tagging has_many :taggings end class Tagging < ActiveRecord::Base end To this: class Author < ActiveRecord::Base has_many :posts has_many :taggings, :through => :posts, :source => :tagging end class Post < ActiveRecord::Base has_one :tagging has_many :taggings end class Tagging < ActiveRecord::Base end
* Merge pull request #10425 from ↵Rafael Mendonça França2013-06-134-38/+47
|\ | | | | | | | | ranjaykrishna/push_add_column_options_to_schema_creation Push add column options to schema creation
| * Moving add_column_options! up to SchemaCreationjeran2013-06-124-38/+47
| | | | | | | | | | | | | | | | removed two instances of add_column_options! from abstract_mysql_adapter reworked rename_column_sql to remove add_column_options from schema_statements changed to use new hash syntax.
* | sometimes singularize does not work, so we get a list of two strings. just ↵Aaron Patterson2013-06-121-1/+1
| | | | | | | | uniq them
* | no need to cache hash lookupsAaron Patterson2013-06-121-1/+1
| |
* | split aggregates from association reflections to avoid is_a checks laterAaron Patterson2013-06-121-5/+11
| |
* | remove unnecessary is_a checkAaron Patterson2013-06-121-2/+1
| |
* | we should apply the default scope before queryingAaron Patterson2013-06-121-1/+2
| |
* | Fix typos in AR changelog [ci skip]Prathamesh Sonpatki2013-06-121-2/+2
| |
* | bind values should not be merged between scopesAaron Patterson2013-06-111-1/+1
| |
* | stop adding a new method for touch callbacksAaron Patterson2013-06-111-29/+21
| |
* | push the touch method outside the evalAaron Patterson2013-06-111-13/+34
| |
* | remove unused variableAaron Patterson2013-06-111-1/+0
| |
* | check whether the association is constructible rather than checking constantsAaron Patterson2013-06-111-3/+3
| |
* | use attribute methods for finding key values rather than generating method namesAaron Patterson2013-06-111-3/+3
| |
* | push belongs_to counter cache method to a single methodAaron Patterson2013-06-111-17/+18
| |
* | push before_destroy counter cache method to a single methodAaron Patterson2013-06-111-12/+17
| |
* | remove evaled belongs_to counter cache methodAaron Patterson2013-06-111-8/+22
| |
* | adding callbacks should be privateAaron Patterson2013-06-111-4/+6
| |
* | indentationAaron Patterson2013-06-111-1/+1
| |
* | remove evals from the associationAaron Patterson2013-06-111-8/+2
| |
* | reduce evals in depdendent associationsAaron Patterson2013-06-111-1/+2
| |
* | Remove fall back and column restrictions for `count`.Yves Senn2013-06-093-10/+31
| |
* | cleanup whitespace in relation.rbYves Senn2013-06-091-1/+1
| |
* | Getting rid of the +automatic_inverse_of: false+ option in associations in favorwangjohn2013-06-0811-19/+45
| | | | | | | | | | of using +inverse_of: false+ option. Changing the documentation and adding a CHANGELOG entry for the automatic inverse detection feature.
* | Revert "Merge pull request #10539 from davidcelis/ar-sql-improvements"Jon Leighton2013-06-071-1/+5
| | | | | | | | | | | | | | | | | | This reverts commit 257fa6897d9c85da16b7c9fcb4ae3008198d320e, reversing changes made to 94725b81f5588e4b0f43222c4f142c3135941b4b. The build failed https://travis-ci.org/rails/rails/builds/7883546
* | ActiveRecord::Relation#blank? should `LIMIT 1`David Celis2013-06-071-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an SQL improvement to ActiveRecord::Relation#blank?. Currently, it calls `to_a` on the Relation, which loads all records in the association, and calls `blank?` on the loaded Array. There are other ways, however, to check the emptiness of an association that are far more performant. `#empty?`, `#exists?` and `#any?` all attach a `LIMIT 1` to the SQL query before firing it off, which is a nice query improvement. `#blank?` should do the same! Bonus performance improvements will also happen for `#present?`, which merely calls the negation of `#blank?` Signed-off-by: David Celis <me@davidcel.is>
* | Merge pull request #10561 from Empact/nix-throwresultJon Leighton2013-06-076-23/+35
|\ \ | | | | | | Rather than raising ThrowResult when construct_limited_ids_conditions comes up empty, set the relation to NullRelation and rely on its results.
| * | Rather than raising ThrowResult when construct_limited_ids_conditions comes ↵Ben Woosley2013-05-103-21/+15
| | | | | | | | | | | | | | | | | | up empty, set the relation to NullRelation and rely on its results. This will help avoid errors like 2fcafee250ee2, because in most cases NullRelation will do the right thing. Minor bonus is avoiding the use of exceptions for flow control.
| * | Make NullRelation a bit more like a real relation by returning 0 for ↵Ben Woosley2013-05-102-3/+8
| | | | | | | | | | | | #calculate(:count)
| * | No point in memoizing a simple literal string.Ben Woosley2013-05-101-1/+1
| | |
| * | Add coverage for the fact that pluck without an argument returns all the ↵Ben Woosley2013-05-101-0/+5
| | | | | | | | | | | | table's columns.
| * | Fix that #pluck wasn't rescuing ThrowResult, meaning it would blow up when ↵Ben Woosley2013-05-102-0/+8
| | | | | | | | | | | | failing to construct_limited_ids_condition.
* | | Fix Build. Changing constructor.Arun Agrawal2013-06-051-3/+3
| | |
* | | Merge pull request #10482 from scudco/10432-fix-add-column-with-arrayAaron Patterson2013-06-053-0/+34
|\ \ \ | | | | | | | | Fixes #10432 add_column not creating array columns in PostgreSQL
| * | | Fixes #10432 add_column not creating array columns in PostgreSQLAdam Anderson2013-06-043-0/+34
| | | | | | | | | | | | | | | | | | | | | | | | When then PostgreSQL visitor was [added](https://github.com/rails/rails/commit/6b7fdf3bf3675a14eae74acc5241089308153a34) `add_column` was no longer receiving the column options directly. This caused the options to be lost along the way.
* | | | only check pending migrations if there are new filesAaron Patterson2013-06-051-2/+25
| | | |
* | | | Fix #10789. Now at last ::Logger doesn't support #silence method .kennyj2013-06-052-3/+10
| | | |
* | | | the typecast value should be passed to the serializer. fixes #10830Aaron Patterson2013-06-052-6/+5
| | | |
* | | | adding a test for #10830Aaron Patterson2013-06-051-0/+18
|/ / / | | | | | | | | | | | | Conflicts: activerecord/test/cases/adapters/postgresql/bytea_test.rb
* | | Revert "Merge pull request #4490 from EmmanuelOga/master"José Valim2013-06-043-19/+2
| | | | | | | | | | | | | | | | | | | | | | | | This behaviour doesn't actually make sense, the context of the child should not be affected by the parent. See #10492. This reverts commit 5f8274efe128ffeec8fa3179460f5167a078f007, reversing changes made to 81e837e810460d066a2e5fc5a795366ec8ab2313.
* | | Merge pull request #10825 from arunagw/remove-rake-packagetask-loadGuillermo Iguaran2013-06-021-1/+0
|\ \ \ | | | | | | | | No need to load 'rake/packagetask' as it's already in 'rubygems/package_task'
| * | | No need to load 'rake/packagetask' as it's alreadyArun Agrawal2013-06-021-1/+0
| | | | | | | | | | | | | | | | | | | | in 'rubygems/package_task'
* | | | Merge pull request #10824 from vipulnsward/wonderfulGuillermo Iguaran2013-06-021-1/+1
|\ \ \ \ | |/ / / |/| | | wonderfull => wonderful
| * | | wonderfull => wonderfulVipul A M2013-06-021-1/+1
| | | |
* | | | Remove unnecessary testcase for instance level stored_attributes.kennyj2013-06-021-5/+0
| | | |
* | | | Remove instance level serialized_attributes setting was deprecated.kennyj2013-06-022-13/+0
| | | |
* | | | Remove instance level attr_readonly setting was deprecated.kennyj2013-06-022-12/+0
| | | |
* | | | Remove behavior that deals with a string as third argument of `add_index`, ↵kennyj2013-06-022-38/+14
| | | | | | | | | | | | | | | | | | | | | | | | because this was deprecated. Some testcases is failed, so I replaced nil to empty hash in add_reference.
* | | | Remove #sum with a block was deprecated.kennyj2013-06-013-21/+1
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-03 07:19:20 +0000