aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Reuse the Column integer converterRafael Mendonça França2013-01-031-1/+1
|
* Change duplicated test nameRafael Mendonça França2013-01-031-2/+2
|
* Fix undefined method `to_i' introduced since 3.2.8Jason Stirk2013-01-044-8/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit fixes a bug introduced in 96a13fc7 which breaks behaviour of integer fields. In 3.2.8, setting the value of an integer field to a non-integer (eg. Array, Hash, etc.) would default to 1 (true) : # 3.2.8 p = Post.new p.category_id = [ 1, 2 ] p.category_id # => 1 p.category_id = { 3 => 4 } p.category_id # => 1 In 3.2.9 and above, this will raise a NoMethodError : # 3.2.9 p = Post.new p.category_id = [ 1, 2 ] NoMethodError: undefined method `to_i' for [1, 2]:Array Whilst at first blush this appear to be sensible, it combines in bad ways with scoping. For example, it is common to use scopes to control access to data : @collection = Posts.where(:category_id => [ 1, 2 ]) @new_post = @collection.new In 3.2.8, this would work as expected, creating a new Post object (albeit with @new_post.category_id = 1). However, in 3.2.9 this will cause the NoMethodError to be raised as above. It is difficult to avoid triggering this error without descoping before calling .new, breaking any apps running on 3.2.8 that rely on this behaviour. This patch deviates from 3.2.8 in that it does not retain the somewhat spurious behaviour of setting the attribute to 1. Instead, it explicitly sets these invalid values to nil : p = Post.new p.category_id = [ 1, 2 ] p.category_id # => nil This also fixes the situation where a scope using an array will "pollute" any newly instantiated records. @new_post = @collection.new @new_post.category_id # => nil Finally, 3.2.8 exhibited a behaviour where setting an object to an integer field caused it to be coerced to "1". This has not been retained, as it is spurious and surprising in the same way that setting Arrays and Heshes was : c = Category.find(6) p = Post.new # 3.2.8 p.category_id = c p.category_id # => 1 # This patch p.category_id = c p.category_id # => nil This commit includes explicit test cases that expose the original issue with calling new on a scope that uses an Array. As this is a common situation, an explicit test case is the best way to prevent regressions in the future. It also updates and separates existing tests to be explicit about the situation that is being tested (eg. AR objects vs. other objects vs. non-integers)
* Merge pull request #8728 from amatsuda/model_all_returns_a_relationRafael Mendonça França2013-01-031-1/+1
|\ | | | | A small fix for an AR test case
| * need to to_a the Relation to execute SQL hereAkira Matsuda2013-01-041-1/+1
| |
* | Merge pull request #8705 from amparo-luna/change_update_attributes_to_updateGuillermo Iguaran2013-01-0322-98/+147
|\ \ | |/ |/| Rename update_attributes method to update
| * Add Changelog entry regarding update_attibutes being renamed to updateAmparo Luna + Guillermo Iguaran2013-01-031-0/+7
| |
| * Change docs to use update instead of update_attributesAmparo Luna + Guillermo Iguaran2013-01-033-3/+3
| |
| * Rename update_attributes method to update, keep update_attributes as an aliasAmparo Luna + Guillermo Iguaran2013-01-0319-95/+137
| |
* | Changelog improvements [ci skip]Carlos Antonio da Silva2013-01-021-1/+2
| |
* | CVE-2012-5664 options hashes should only be extracted if there are extra ↵Aaron Patterson2013-01-021-0/+12
|/ | | | | | | parameters Conflicts: activerecord/lib/active_record/dynamic_matchers.rb
* refactoring to_sym of Symbol in preloadAngelo capilleri2013-01-021-1/+3
|
* Merge pull request #8682 from amatsuda/rm_as_frozen_object_errorGuillermo Iguaran2013-01-014-7/+4
|\ | | | | remove meaningless AS::FrozenObjectError
| * remove meaningless AS::FrozenObjectErrorAkira Matsuda2013-01-024-7/+4
| |
* | Standardize the use of current_adapter?Rafael Mendonça França2013-01-019-19/+19
| |
* | Merge pull request #8678 from yahonda/remove_column_oracleRafael Mendonça França2013-01-011-2/+3
|\ \ | | | | | | Address a failure test_remove_column_with_multi_column_index with Oracle
| * | Address a failure test_remove_column_with_multi_column_index with Oracle ↵Yasuo Honda2013-01-021-2/+3
| |/ | | | | | | | | | | | | database Not only PostgreSQL, Oracle database adapter drops the multi-column index if any of the indexed columns dropped by remove_column.
* / unused scopeAkira Matsuda2013-01-021-2/+0
|/
* Updated copyright notices for 2013Andrew Nesbitt2012-12-312-2/+2
|
* Merge pull request #8664 from acapilleri/spawn_methodRafael Mendonça França2012-12-311-8/+10
|\ | | | | refatctoring of some code repetition in spawn_methods
| * refatctoring of some code repetition in spawn_methodsAngelo capilleri2012-12-311-8/+10
| |
* | Alias refute methods to assert_not and perfer assert_not on testsRafael Mendonça França2012-12-3110-40/+40
| |
* | Add active_support/testing/autorunRafael Mendonça França2012-12-312-2/+2
|/ | | | | minitest/autorun load minitest/spec polluting the global namespace with the DSL that we don't want on Rails
* Point to guides.rubyonrails.org instead of edgeguides.rubyonrails.orgSantiago Pastorino2012-12-301-2/+2
|
* Fix missing ending newline in db structure dump:Thibault Jouan2012-12-301-1/+3
| | | | | | | | | | | When dumping database structure with `rake db:structure:dump` and using migrations, the resulting file will not end with a newline char. Although it's not mandatory, it breaks a lot of simple use cases with programs like cat, more, grep, etc. This changes use `puts' instead of `<<' to append migration versions data to the dump and also split the line where this is happening as it was a bit long.
* warning removed: shadowing outer local variableArun Agrawal2012-12-301-2/+2
|
* add missing require and fixturesAaron Patterson2012-12-291-0/+3
|
* fix time typcasting on group counts in PGAaron Patterson2012-12-282-2/+11
|
* mysql does not return alias names, so fall backAaron Patterson2012-12-281-4/+10
|
* fix PG typecasting errorsAaron Patterson2012-12-282-22/+12
|
* small refactoring, added blob_or_text_colum? in AbstractMysqlAdapterAngelo Capilleri2012-12-281-2/+6
|
* work off FIXME comments in AR rename_column_test.rbYves Senn2012-12-281-9/+22
| | | | | | There were a couple of tests, which had FIXME comments in palce of assertions. I replaced these FIXME comments with actual assertions to get more feedback from our test suite.
* Fix CHANGELOG style [ci skip]Rafael Mendonça França2012-12-261-5/+5
|
* validate :on option on after_commit and after_rollback callbacksPascal Friederich2012-12-263-6/+29
|
* Fixes for PR [#8267]Marc-Andre Lafortune2012-12-224-7/+22
| | | | | | | | * Fix Migration#reversible by not using `transaction`. * Adapt mysql adapter to updated api for remove_column * Update test after aedcd683684d08eaf30623a4b48ce31a31426372
* Correctly shows RAILS_ENV=development even when ENV['RAILS_ENV'] is not set ↵Andy Lindeman2012-12-211-1/+1
| | | | | | (e.g., in Pow) * Fixes #8025
* Remove duplicated methods in command recorder and duplicated test nameCarlos Antonio da Silva2012-12-212-4/+4
|
* Fix calling quote column name in interpolated stringCarlos Antonio da Silva2012-12-211-1/+1
|
* Merge pull request #8267 from marcandre/reversible_drop_table_etcAaron Patterson2012-12-2111-208/+591
|\ | | | | Reversible commands
| * Update Migration and 4.0 Release Guides, Changelogs [#8267]Marc-Andre Lafortune2012-12-211-0/+17
| |
| * Make execute, change_column and remove_columns methods actually irreversibleMarc-Andre Lafortune2012-12-212-2/+9
| | | | | | | | [#8267]
| * Make change_table reversible when possible [#8267]Marc-Andre Lafortune2012-12-212-1/+25
| |
| * Migration generators use `change` even for destructive methods [#8267]Marc-Andre Lafortune2012-12-211-16/+4
| |
| * Factorize methods that are easily reversible [#8267]Marc-Andre Lafortune2012-12-212-42/+28
| |
| * Make remove_index reversible [#8267]Marc-Andre Lafortune2012-12-212-7/+34
| |
| * Differentiate between remove_column and remove_columns. Make remove_column ↵Marc-Andre Lafortune2012-12-216-19/+44
| | | | | | | | | | | | reversible. [#8267]
| * Make drop_table reversible [#8267]Marc-Andre Lafortune2012-12-214-17/+41
| |
| * Add drop_join_table [#8267]Marc-Andre Lafortune2012-12-214-7/+69
| |
| * Add Migration#reversible for reversible data operations [#8267]Marc-Andre Lafortune2012-12-213-1/+85
| |
| * Allow revert of whole migration [#8267]Marc-Andre Lafortune2012-12-212-3/+102
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 00:59:18 +0000