| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
As we move towards removing the `klass` method from `column`, the else
clause as it stands right now will become the only case.
|
|\
| |
| | |
Add missing test cases for schema dumping defaults
|
| | |
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before this patch, using `ActiveRecord::Base.primary_key_prefix_type`
with `:table_name_with_underscore` would change the `SchemaMigration` model
to have a primary key. This resulted in broken queries for PG because it tried
to return the inserted PK (which does not exist).
Closes #15051.
Closes #15419.
|
| | |
|
| |
| |
| |
| | |
/cc @zuhao
|
|/
|
|
|
|
|
| |
This adds a regression test for #14411, which was fixed by #15503.
Closes #14411
Closes #14595
|
|\
| |
| | |
Bring type casting behavior of hstore/json in line with serialized
|
| |
| |
| |
| |
| | |
`@raw_attributes` should not contain the type-cast, mutable version of
the value.
|
| |
| |
| |
| |
| |
| |
| | |
The migration numbers were normalized different ways. This left
the task output in an inconsistent state.
Closes #15538.
|
|\ \
| | |
| | |
| | | |
Baseclass becomes! subclass
|
| | | |
|
| | |
| | |
| | |
| | | |
Whiny nils is no longer a thing, so we no longer need this optimization
|
| | |
| | |
| | |
| | | |
BC era year is (astronomical year + 1) and starts from 1 BC.
|
|\ \ \
| | | |
| | | |
| | | | |
Remove deprecated method ActiveRecord::Migrator.proper_table_name
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
`InverseHasManyTests#test_parent_instance_should_be_shared_within_create_block_of_new_child`
was mistakenly the same as
`InverseHasManyTests#test_parent_instance_should_be_shared_within_build_block_of_new_child`.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Follow up to #15438 and #15502.
/cc @sgrif
|
|\ \ \
| | | |
| | | |
| | | | |
Use null column for association key types
|
| | |/
| |/| |
|
|\ \ \
| | | |
| | | | |
Collapse PG default extractoin of most types to single regex
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
For any type that is represented as a string and then type cast, we do
not need separate regular expressions for the various types. No function
will match this regex. User defined types *should* match this, so that
the type object can decide what to do with the value.
|
|\ \ \
| |/ /
|/| | |
Refactor XML serializer to not depend on `serialized_attributes`
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The previous tests were passing, because nothing ever looked at the
generated XML. What was previously being generated was
`<firstname type="NilClass">...`, which is not consistent with all other
cases where there is not a known type.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
prathamesh-sonpatki/change-wording-of-explanation-about-precision-and-scale-of-decimal-numbers
Change wording of explanation about precision & scale of decimal numbers [ci skip]
|
| | | |
| | | |
| | | |
| | | | |
skip]
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | | |
Fix regression on eager loading association based on SQL query rather than existing column.
Conflicts:
activerecord/CHANGELOG.md
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
than existing column.
Fixes #15480.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Reflection has a `belongs_to?` method. Instead of checking for
`macro == :belongs_to` throughout the source reuse existing
method.
I also bumped `foreign_key_present?` method onto on line because
the `belongs_to?` makes it shorter than other longer lines in
the same class.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Return a null column when no column exists for an attribute
Conflicts:
activerecord/CHANGELOG.md
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
implement ActiveRecord::Base#pretty_print
Conflicts:
activerecord/CHANGELOG.md
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Keep column defaults in type cast form
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The contract of `_field_changed?` assumes that the old value is always
type cast. That is not the case for the value in `Column#default` as
things are today. It appears there are other public methods that
assume that `Column#default` is type cast, as well. The reason for this
change originally was because the value gets put into `@raw_attributes`
in initialize. This reverts to the old behavior on `Column`, and updates
`initialize` to make sure that the values are in the right format.
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Revert "test pg, remove unused column assignments. Follow up to 254cdf47"
Related to #15492
This reverts commit 254cdf4728291277f3fbaa854f34495030e476b4.
This reverts commit 4bcf9029452e0c760af04faab6b549710401e8cf.
There are public methods that assume `Column#default` is type casted.
The return value of `Column#default` is publicly relevant and should not change.
/cc @sgrif
|
|\ \ \ \ \ \ \
| |_|_|_|/ / /
|/| | | | | | |
Refactor quoting of binary data to not be based on the column type
|
| |/ / / / / |
|
| | | | | | |
|
| | | | | | |
|
| |_|/ / /
|/| | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Respect limit for PG bit strings
|
| | | | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Refactor determination of whether the field has changed
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
The types know more about what is going on than the dirty module. Let's
ask them!
|
| | | | | |
|