aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | Call `attributes_for_update` in `_update_record` w/ optimistic lockingSean Griffin2015-02-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Fixes #19057
* | | | | | Fix c479480638508c20601af69ca46b5b606c2d5b4d to account for from_value -> ↵Jeremy Kemper2015-02-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | from_clause in bdc5141652770fd227455681cde1f9899f55b0b9
* | | | | | Merge pull request #18744 from mfazekas/no-table-name-with-fromRafael Mendonça França2015-02-242-5/+20
| | | | | | | | | | | | | | | | | | | | | | | | Fix appending table_name to select and group when used with subquery (fr...
* | | | | | Fix mysql's schema.rb dumper so it does not include limit on emulated ↵Court3nay2015-02-242-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | boolean tinyint(1) fields
* | | | | | rework `disable_referential_integrity` for PostgreSQL.Yves Senn2015-02-243-9/+136
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Toby Ovod-Everett & Andrey Nering & Yves Senn] Closes #17726. Closes #10939. This patch makes three distinct modifications: 1. no longer fall back to disabling user triggers if system triggers can't be disabled 2. warn the user when referential integrity can't be disabled 3. restore aborted transactions when referential integrity can't be disabled The motivation behind these changes is to make the behavior of Rails transparent and less error-prone. To require superuser privileges is not optimal but it's what Rails currently needs. Users who absolutely rely on disabling user triggers can patch `disable_referential_integrity`. We should investigate `SET CONSTRAINTS` as a possible solution which does not require superuser privileges. /cc @matthewd
* | | | | | Merge pull request #19064 from kamipo/remove_unused_tableRafael Mendonça França2015-02-241-10/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove unused table
| * | | | | | Remove unused tableRyuta Kamizono2015-02-251-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `postgresql_xml_data_type` table is used from nowhere.
* | | | | | | Move back `new_column_definition` into `TableDefinition`Ryuta Kamizono2015-02-251-4/+4
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only `primary_key` should be extracted by d47357e in #19030, but `new_coclumn_definition` was also extracted because #17631 is merged previously, then #19030 is auto merged without conflicts. This commit is for move back `new_column_definition` into `TableDefinition`.
* | | | | | Merge pull request #19030 from kamipo/extract_short_hand_column_methodsRafael Mendonça França2015-02-234-110/+173
|\ \ \ \ \ \ | | | | | | | | | | | | | | Extract the short-hand column methods into `ColumnMethods`
| * | | | | | The short-hand methods should be able to define multiple columnsRyuta Kamizono2015-02-232-45/+69
| | | | | | |
| * | | | | | Extract the short-hand methods into `ColumnMethods`Ryuta Kamizono2015-02-232-23/+36
| | | | | | |
| * | | | | | Extract `primary_key` method into `ColumnMethods`Ryuta Kamizono2015-02-224-42/+68
| | | | | | |
* | | | | | | Merge pull request #17631 from kamipo/bigint_pk_supportRafael Mendonça França2015-02-233-0/+35
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Allow limit option for MySQL bigint primary key support.
| * | | | | | | Allow `:limit` option for MySQL bigint primary key supportRyuta Kamizono2015-02-243-0/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: create_table :foos, id: :primary_key, limit: 8 do |t| end # or create_table :foos, id: false do |t| t.column :id, limit: 8 end
* | | | | | | | Fix typo [ci skip]Luke Hutscal2015-02-231-1/+1
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | I think this was supposed to be "roundTrip".
* | | | | | | some indenting and punctuation fixes. [ci skip]Yves Senn2015-02-231-5/+7
| | | | | | |
* | | | | | | Require `belongs_to` by default.Josef Šimánek2015-02-217-9/+92
|/ / / / / / | | | | | | | | | | | | | | | | | | Deprecate `required` option in favor of `optional` for belongs_to.
* | | | | | Fix #has_secure_token documentation [ci skip]Tim Liner2015-02-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's actually #validates_uniqueness_of that can generate a race condition rather than #validates_presence_of.
* | | | | | Error message testing fixFranky W2015-02-203-5/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The testing of error messages have been implemented wrongly a few times. This is an attempt to fix it. For example, some of these test should have failed with the new code. The reason they are not failling with the new string is the fact they were not being tested beforehand.
* | | | | | Merge branch 'rm-take' into 4-1-stableRafael Mendonça França2015-02-203-1/+43
| | | | | |
* | | | | | Do not test, document or use a private API methodRafael Mendonça França2015-02-203-28/+0
| | | | | | | | | | | | | | | | | | | | | | | | These methods are nodoc so we should not document them.
* | | | | | Merge pull request #16989 from Empact/reload-cache-clearRafael Mendonça França2015-02-206-28/+53
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Isolate access to @associations_cache and @aggregations_cache to the Associations and Aggregations modules, respectively.
| * | | | | | Isolate access to @associations_cache and @aggregations cache to the ↵Ben Woosley2014-09-289-32/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Associations and Aggregations modules, respectively. This includes replacing the `association_cache` accessor with a more limited `association_cached?` accessor and making `clear_association_cache` and `clear_aggregation_cache` private.
* | | | | | | Merge pull request #19018 from lucasmazza/lm-activemodel-validate-bangRafael Mendonça França2015-02-201-14/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Move the `validate!` method to `ActiveModel::Validations`.
| * | | | | | | Move the `validate!` method to `ActiveModel::Validations`.Lucas Mazza2015-02-201-14/+2
| | | | | | | |
* | | | | | | | Merge pull request #16993 from Empact/simplify-find_by-statement-cacheRafael Mendonça França2015-02-201-16/+18
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | Simplify find_by_statement_cache interaction
| * | | | | | | Simplify `find_by_statement_cache` interaction down to a class-level ivar ↵Ben Woosley2014-09-221-20/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with a single accessor `cached_find_by_statement`.
* | | | | | | | Merge pull request #17139 from mfazekas/fix_becomes_changed_attributesRafael Mendonça França2015-02-203-1/+14
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | Always reset changed attributes in becomes
| * | | | | | | | Always reset changed attributes in becomesMiklos Fazekas2015-02-043-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When ```becomes``` changes @attributes it should also change @changed_attributes. Otherwise we'll experience a kind of split head situation where attributes are coming from ```self```, but changed_attributes is coming from ```klass.new```. This affects the inheritance_colmn as it's changed by new for example. Fixes #16881
* | | | | | | | | Add schema dumping tests for datetime and time precisionRyuta Kamizono2015-02-203-8/+34
| | | | | | | | |
* | | | | | | | | Format the time string according to the precision of the time columnRyuta Kamizono2015-02-205-20/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is also necessary to format a time column like a datetime column.
* | | | | | | | | Allow `:precision` option for time type columnsRyuta Kamizono2015-02-208-14/+89
| | | | | | | | |
* | | | | | | | | fix column name in migration example [ci skip]Daniël de Vries2015-02-191-1/+1
| | | | | | | | |
* | | | | | | | | Merge pull request #18996 from morgoth/deprecate-more-errors-methodsYves Senn2015-02-192-2/+2
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Deprecate `ActiveModel::Errors` `add_on_empty` and `add_on_blank` methods
| * | | | | | | | | Deprecate `ActiveModel::Errors` `add_on_empty` and `add_on_blank` methodsWojciech Wnętrzak2015-02-192-2/+2
| | |_|_|_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | without replacement.
* | | | | | | | | Merge pull request #18916 from kamipo/handle_array_option_in_type_to_sqlRafael Mendonça França2015-02-193-37/+32
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Handle array option in `type_to_sql`
| * | | | | | | | | Handle array option in `type_to_sql`Ryuta Kamizono2015-02-191-19/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `[]` is a part of `sql_type`, so it is always necessary to respect to array option when `type_to_sql` is called.
| * | | | | | | | | Use `delegate` to call the methods to `@conn`Ryuta Kamizono2015-02-191-16/+3
| | | | | | | | | |
| * | | | | | | | | Should handle array option for `:cast_as`Ryuta Kamizono2015-02-192-4/+15
| | | | | | | | | |
* | | | | | | | | | Merge pull request #18979 from ↵Rafael Mendonça França2015-02-193-8/+5
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/extract_precision_from_datetime_and_time_columns Extract precision from datetime and time columns
| * | | | | | | | | | Extract precision from datetime and time columnsRyuta Kamizono2015-02-193-8/+5
| |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The cause by which the test suite for the mysql adapter broke in 1502cae (reverted 89ba5bb) is because the precision was not extracted. The rounding problem in mysql adapter has not been fixed, but `mysql_56` helper tested only mysql2 adapter, its behavior was not apparent.
* | | | | | | | | | Return true instead of self when suppressedRafael Mendonça França2015-02-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | save is documented to return singletons so we should always return a singleton.
* | | | | | | | | | Copy edit the suppressor documentationRafael Mendonça França2015-02-193-29/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | | | Add `ActiveRecord::Base.suppress`Michael Ryan2015-02-188-0/+118
|/ / / / / / / / /
* / / / / / / / / Add `time` option to `#touch`Hyonjee Joo2015-02-183-6/+34
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #18905. `#touch` now takes time as an option. Setting the option saves the record with the updated_at/on attributes set to the current time or the time specified. Updated tests and documentation accordingly.
* | | | | | | | Merge pull request #18984 from rousisk/masterCarlos Antonio da Silva2015-02-181-2/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Replace deprecated readonly option with scope blocks in docs and guide
| * | | | | | | | Replace deprecated readonly option with scope blocks in docs and guideKonstantinos Rousis2015-02-181-2/+2
| | | | | | | | |
* | | | | | | | | Prefer `drop_table if_exists: true` over raw SQLRyuta Kamizono2015-02-1821-25/+25
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Lowercase raw SQL has been replaced by 07b659c already. This commit replaces everything else of raw SQL.
* | | | | | | | prefer `drop_table if_exists: true` over raw SQL.Yves Senn2015-02-1812-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | /cc @yahonda This makes it easier for third party adapters to run our tests, even if that database does not support IF EXISTS.
* | | | | | | | Add docs for the type registrySean Griffin2015-02-172-5/+24
| | | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 12:49:38 +0000