aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-05-233-34/+463
|\
| * copy edits in collection proxy docs [ci skip]Vijay Dev2012-05-231-25/+18
| |
| * Revert "Remove blank trailing comments"Vijay Dev2012-05-2321-0/+31
| | | | | | | | | | | | | | | | | | | | This reverts commit fa6d921e11363e9b8c4bc10f7aed0b9faffdc33a. Reason: Not a fan of such massive changes. We usually close such changes if made to Rails master as a pull request. Following the same principle here and reverting. [ci skip]
| * add CollectionProxy#length documentationFrancesco Rodriguez2012-05-221-5/+37
| |
| * add CollectionProxy#size documentationFrancesco Rodriguez2012-05-221-2/+25
| |
| * add :call-seq: to +first+ and +last+ CollectionProxy methodsFrancesco Rodriguez2012-05-221-0/+6
| |
| * add CollectionProxy#create! documentationFrancesco Rodriguez2012-05-221-0/+22
| |
| * add CollectionProxy#create documentationFrancesco Rodriguez2012-05-221-0/+33
| |
| * add more examples to CollectionProxy#findFrancesco Rodriguez2012-05-221-0/+9
| |
| * adding :call-seq: to CollectionProxy methodsFrancesco Rodriguez2012-05-221-0/+39
| |
| * add CollectionProxy#build documentationFrancesco Rodriguez2012-05-221-0/+31
| |
| * remove repeated documentation in CollectionProxy#clearFrancesco Rodriguez2012-05-221-24/+2
| |
| * update CollectionProxy#clear documentationFrancesco Rodriguez2012-05-211-3/+2
| |
| * update CollectionProxy#delete_all documentationFrancesco Rodriguez2012-05-211-2/+29
| |
| * add CollectionProxy#delete_all documentationFrancesco Rodriguez2012-05-211-0/+65
| |
| * Fix AR preloader exampleAlexey Vakhov2012-05-221-1/+1
| |
| * fix CollectionProxy documentation markupFrancesco Rodriguez2012-05-211-8/+8
| |
| * add CollectionProxy#reload documentationFrancesco Rodriguez2012-05-211-0/+18
| |
| * improve CollectionProxy#destroy documentationFrancesco Rodriguez2012-05-211-5/+37
| |
| * add CollectionProxy#destroy documentationFrancesco Rodriguez2012-05-211-1/+42
| |
| * update CollectionProxy#destroy_all documentationFrancesco Rodriguez2012-05-201-1/+9
| |
| * Remove blank trailing commentsHenrik Hodne2012-05-2021-31/+0
| | | | | | | | | | | | | | For future reference, this is the regex I used: ^\s*#\s*\n(?!\s*#). Replace with the first match, and voilà! Note that the regex matches a little bit too much, so you probably want to `git add -i .` and go through every single diff to check if it actually should be changed.
| * add CollectionProxy#select documentationFrancesco Rodriguez2012-05-191-2/+55
| |
| * add CollectionProxy#find documentationFrancesco Rodriguez2012-05-191-0/+20
| |
| * Revert typoOscar Del Ben2012-05-191-1/+1
| |
| * TypoOscar Del Ben2012-05-191-4/+4
| |
* | Merge pull request #6462 from grosser/feature/licensesJosé Valim2012-05-231-0/+1
|\ \ | | | | | | Add license field to gemspecs, by Matt Griffin
| * | Add license field to gemspecs, by Matt GriffinMatt Griffin2012-05-231-0/+1
| | |
* | | ConnectionPool wait_timeout no longer used for different types of timeouts. ↵Jonathan Rochkind2012-05-234-12/+21
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #6441 An AR ConnectionSpec `wait_timeout` is pre-patch used for three different things: * mysql2 uses it for MySQL's own wait_timeout (how long MySQL should allow an idle connection before closing it), and defaults to 2592000 seconds. * ConnectionPool uses it for "number of seconds to block and wait for a connection before giving up and raising a timeout error", default 5 seconds. * ConnectionPool uses it for the Reaper, for deciding if a 'dead' connection can be reaped. Default 5 seconds. Previously, if you want to change these from defaults, you need to change them all together. This is problematic _especially_ for the mysql2/ConnectionPool conflict, you will generally _not_ want them to be the same, as evidenced by their wildly different defaults. This has caused real problems for people #6441 #2894 But as long as we're changing this, forcing renaming the ConnectionPool key to be more specific, it made sense to seperate the two ConnectionPool uses too -- these two types of ConnectionPool timeouts ought to be able to be changed independently, you won't neccesarily want them to be the same, even though the defaults are (currently) the same.
* | changed xml type datetime to dateTime, fixes #6328Angelo capilleri2012-05-232-9/+9
| | | | | | | | | | | | | | | | | | XmlMini define the xml 'datatime', but according to http://www.w3.org/TR/xmlschema-2/#dateTime could be better change this to 'dateTime' with upper case letter 'T. So 'DateTime' and 'Time' are redefined from 'datetime' to 'dateTime' add the changing to the changelog
* | Revert "Merge pull request #6416 from pmahoney/threadsafe-connection-pool"Rafael Mendonça França2012-05-223-202/+35
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d2901f0fc4270a765717ad572d559dc49a56b3a8, reversing changes made to 525839fdd8cc34d6d524f204528d5b6f36fe410c. Conflicts: activerecord/test/cases/connection_pool_test.rb Reason: This change broke the build (http://travis-ci.org/#!/rails/rails/builds/1391490) and we don't have any solution until now. I asked the author to try to fix it and open a new pull request.
* | Fix the buildSantiago Pastorino2012-05-221-1/+0
| |
* | require active_support/lazy_load_hooks where is neededSantiago Pastorino2012-05-221-0/+1
| |
* | Merge pull request #6368 from Antiarchitect/store-indifferent-accessJeremy Kemper2012-05-222-10/+61
|\ \ | | | | | | Support migrating from Hash to HashWithIndifferentAccess for accessing attributes.
| * | Convert Hash to HashWithIndifferentAccess in ActiveRecord::Store.Andrey Voronkov2012-05-222-10/+61
| | | | | | | | | | | | | | | | | | | | | In order to make migration from 3.x apps easier, we should try to convert Hash instances to HashWithIndifferentAccess, to allow accessing values with both symbol and a string. This is follow up to changes in 3c0bf043.
* | | Restore the frozen state on rollback. Fixes #6417.Godfrey Chan2012-05-212-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, when saving a frozen record, an exception would be thrown which causes a rollback. However, there is a bug in active record that "defrost" the record as a side effect: >> t = Topic.new => #<Topic id: nil, ...> >> t.freeze => #<Topic id: nil, ...> >> t.save RuntimeError: can't modify a frozen Hash >> t.frozen? => false >> t.save => true This patch fixes the bug by explictly restoring the frozen state on the attributes Hash after every rollback.
* | | Remove not used variables from connection poll testCarlos Antonio da Silva2012-05-211-2/+2
| | | | | | | | | | | | These variables were issuing some "not used" warnings.
* | | Refactor aggregation writer methodCarlos Antonio da Silva2012-05-212-5/+3
| | | | | | | | | | | | Only constantize class_name once.
* | | Merge pull request #6416 from pmahoney/threadsafe-connection-poolAaron Patterson2012-05-213-35/+202
|\ \ \ | | | | | | | | Make connection pool fair with respect to waiting threads.
| * | | Make connection pool fair with respect to waiting threads.Patrick Mahoney2012-05-203-35/+202
| | | |
* | | | Merge pull request #6143 from senny/composed_of_converter_returns_nilAaron Patterson2012-05-213-7/+31
|\ \ \ \ | |/ / / |/| | | allow the :converter Proc form composed_of to return nil
| * | | allow the :converter Proc form composed_of to return nilYves Senn2012-05-033-7/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes it possible to filter invalid input values before they are passed into the value-object (like empty strings). This behaviour is only relevant if the :allow_nil options is set to true. Otherwise you will get the resulting NoMethodError.
* | | | fixed typo in word finidingIvan Kukobko2012-05-201-1/+1
| | | |
* | | | Merge pull request #6397 from kennyj/fix_translate_exceptionAaron Patterson2012-05-191-3/+7
|\ \ \ \ | | | | | | | | | | Fix a problem of translate_exception method in a Japanese (non English) environment.
| * | | | Fix a problem of translate_exception method in Japanese.kennyj2012-05-201-3/+7
| | |_|/ | |/| |
* / | | Synchronize read and modification of @reserved_connections hash to avoid ↵Patrick Mahoney2012-05-191-4/+8
|/ / / | | | | | | | | | concurrency error.
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-05-194-23/+305
|\ \ \
| * | | copy edits [ci skip]Vijay Dev2012-05-191-17/+20
| | | |
| * | | add CollectionProxy#last documentationFrancesco Rodriguez2012-05-191-0/+27
| | | |
| * | | add CollectionProxy#first documentationFrancesco Rodriguez2012-05-191-0/+27
| | | |