aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | Fix typo: adaptors => adapters [ci skip]Carlos Antonio da Silva2013-01-271-1/+1
| |
* | Fix cases where delete_records on a has_many association caused errorsDerek Kraan2013-01-277-5/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | because of an ambiguous column name. This happened if the association model had a default scope that referenced a third table, and the third table also referenced the original table (with an identical foreign_key). Mysql requires that ambiguous columns are deambiguated by using the full table.column syntax. Postgresql and Sqlite use a different syntax for updates altogether (and don't tolerate table.name syntax), so the fix requires always including the full table.column and discarding it later for Sqlite and Postgresql.
* | Use `silence` instead of `quietly` to silence the `CheckPending` middleware.Lucas Mazza2013-01-261-1/+1
| | | | | | | | | | | | | | | | `Kernel.quietly` silences `STDOUT` and `STDERR`, which is useless if the logger is writing to a file, while `AS::Logger#silence` swaps the logger level to `ERROR`. Related to #8820 and #8052.
* | Simplify type casting code for timezone aware attributesAndrew White2013-01-261-10/+5
| | | | | | | | | | | | With the addition of String#in_time_zone and Date#in_time_zone we can simplify the type casting code by checking if the value has an `in_time_zone` method.
* | Fix handling of dirty time zone aware attributesLilibeth De La Cruz2013-01-263-2/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, when `time_zone_aware_attributes` were enabled, after changing a datetime or timestamp attribute and then changing it back to the original value, `changed_attributes` still tracked the attribute as changed. This caused `[attribute]_changed?` and `changed?` methods to return true incorrectly. Example: in_time_zone 'Paris' do order = Order.new original_time = Time.local(2012, 10, 10) order.shipped_at = original_time order.save order.changed? # => false # changing value order.shipped_at = Time.local(2013, 1, 1) order.changed? # => true # reverting to original value order.shipped_at = original_time order.changed? # => false, used to return true end
* | Merge remote-tracking branch 'docrails/master'Xavier Noria2013-01-263-5/+5
|\ \ | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/form_options_helper.rb guides/code/getting_started/app/controllers/comments_controller.rb
| * | Fix typoTatsuro Baba2013-01-221-1/+1
| | |
| * | Remove useless number signTatsuro Baba2013-01-181-2/+2
| | | | | | | | | | | | I think that these signs are probably mistake.
| * | fix example of setting DEFAULTS in fixturesJonathan Garvin2013-01-161-2/+2
| | |
* | | `#count` in conjunction with `#uniq` performs distinct count.Yves Senn2013-01-263-1/+15
| | | | | | | | | | | | closes #6865
* | | Remove obsolete test fileJon Leighton2013-01-251-35/+0
| | | | | | | | | | | | https://github.com/rails/rails/commit/4beb4dececcf10c642c74fbcb8548c833e921a86#commitcomment-2482869
* | | reduce the number of queries on IN clauses, fix relation queries in `where`Aaron Patterson2013-01-243-2/+20
| | |
* | | stop converting strings to symbolsAaron Patterson2013-01-241-1/+1
| | |
* | | Default dead_connection_timeout to 5Akira Matsuda2013-01-241-1/+1
| | | | | | | | | | | | or the ConnectionPool silently fails to close connections inside the Thread
* | | Describing the reason for defining BlankTopic#blank? which will never be calledAkira Matsuda2013-01-241-0/+1
| | |
* | | Revert "Unused methods, module, etc."Akira Matsuda2013-01-244-0/+28
| | | | | | | | | | | | | | | | | | This reverts commit 4e05bfb8e254c3360a3ca4a6cb332995314338fe. Reason: BlankTopic#blank? should not be removed to check that dynamic finder with a bang can find a model that responds to `blank?`
* | | Unused methods, module, etc.Akira Matsuda2013-01-244-28/+0
| | |
* | | Set Thread.abort_on_exception for the whole AS, AP, and AR testsAkira Matsuda + Koichi Sasada2013-01-241-0/+2
| | | | | | | | | | | | this would give us some more clues in case a test silently dies inside Thread
* | | Unused test modelAkira Matsuda2013-01-241-5/+0
| | |
* | | Goodbye there, very special rubbish!Akira Matsuda2013-01-244-19/+1
| | |
* | | proxy_{owner,reflection,target} are no more availableAkira Matsuda2013-01-241-11/+1
| | |
* | | Unused model DeprecatedPostWithCommentAkira Matsuda2013-01-241-7/+0
| | |
* | | Fix PostgreSQL tests on TravisAndrew White2013-01-243-11/+37
| | | | | | | | | | | | Travis only has PostgreSQL 9.1.x but 9.2 is required for range datatypes.
* | | Merge pull request #7345 from slbug/masterRafael Mendonça França2013-01-2311-189/+431
|\ \ \ | | | | | | | | Postgresql range support
| * | | Add postgresql range types supportbUg2013-01-2311-189/+431
| | | |
* | | | Remove warning by using a custom coderAndrew White2013-01-231-2/+16
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The native JSON library bypasses the `to_json` overrides in active_support/core_ext/object/to_json.rb by calling its native implementation directly. However `ActiveRecord::Store` uses a HWIA so `JSON.dump` will call our `to_json` instead with a `State` object for options rather than a `Hash`. This generates a warning when the `:encoding`, `:only` & `:except` keys are accessed in `Hash#as_json` because the `State` object delegates unknown keys to `instance_variable_get` in its `:[]` method. Workaround this warning in the test by using a custom coder that calls `ActiveSupport::JSON.encode` directly.
* | | A test case name needs to start with "test_"Akira Matsuda2013-01-231-1/+1
| | |
* | | Less strict activerecord-deprecated_finders versionRafael Mendonça França2013-01-221-1/+1
| | |
* | | Revert "Round usec when writing timestamp attribute."Andrew White2013-01-222-28/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e9d2ad395ec2ef929d74752f3d71c80674044fbe. Closes #8460 Conflicts: activerecord/lib/active_record/attribute_methods/time_zone_conversion.rb activerecord/test/cases/dirty_test.rb
* | | Add failing test case for #8460Andrew White2013-01-221-0/+14
| | | | | | | | | | | | Add a test case to ensure that fractional second updates are detected.
* | | Whitespaces :scissors:Rafael Mendonça França2013-01-222-19/+16
| | | | | | | | | | | | [ci skip]
* | | Just ignore all PRAGMA queriesAkira Matsuda2013-01-221-1/+1
| | |
* | | Reset SchemaMigration after updatingAkira Matsuda2013-01-221-0/+1
| | |
* | | Preload some join table schemasAkira Matsuda2013-01-221-0/+9
| | |
* | | Ignore schema queries on SQLite 3 as wellAkira Matsuda2013-01-221-1/+2
| | |
* | | Be sure to clear schema cacheAkira Matsuda2013-01-221-0/+3
| | |
* | | Ignore "SHOW search_path" when counting PostgreSQL queriesAkira Matsuda2013-01-221-1/+1
| | |
* | | Reset table_name_{prefix,suffix}, and table_name after each testAkira Matsuda2013-01-221-11/+4
| | | | | | | | | | | | because some tests were not resetting them, and thus the tests were order dependent
* | | Missing repair_validationsAkira Matsuda2013-01-221-12/+14
| | |
* | | Refactored transaction state into its own object. Each transaction creates a ↵wangjohn2013-01-212-7/+34
| | | | | | | | | | | | new transaction state object upon initialization.
* | | Remove extra sort from testVipul A M2013-01-211-3/+3
| | | | | | | | | | | | Cleanup change_schema tests to remove extra sorts on columns.
* | | Merge pull request #8913 from ↵Carlos Antonio da Silva2013-01-202-0/+10
|\ \ \ | | | | | | | | | | | | | | | | seejee/regression_test_for_chained_preloaded_scopes Added test case to prevent regression of chained, preloaded scopes.
| * | | Added test case to prevent regression of chained, preloaded scopes. (#7490)Chris Geihsler2013-01-192-0/+10
| | | |
* | | | Merge pull request #9008 from ranjaykrishna/dbcreateGuillermo Iguaran2013-01-201-0/+1
|\ \ \ \ | | | | | | | | | | Added a new rake task in activerecord
| * | | | added db:drop task that executes mysql:drop_databses and ↵Ranjay Krishna2013-01-201-0/+1
| | | | | | | | | | | | | | | | | | | | postgresql:drop_databases
* | | | | Merge pull request #9006 from wangjohn/activerecord_transaction_stateAaron Patterson2013-01-204-11/+49
|\ \ \ \ \ | | |_|_|/ | |/| | | Created state for a transaction and added tests.
| * | | | Added a changelog entry.wangjohn2013-01-201-0/+5
| | | | |
| * | | | Removed reflects_transaction_state.wangjohn2013-01-201-1/+0
| | | | |
| * | | | Created state for a transaction and added tests.wangjohn2013-01-203-11/+45
| | | | |
* | | | | Merge pull request #9005 from ranjaykrishna/dbcreateAaron Patterson2013-01-201-0/+4
|\ \ \ \ \ | | |/ / / | |/| | | added a db create rake task.
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-08 04:27:39 +0000