| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fixed #columns_for_distinct of postgresql adapter
Conflicts:
activerecord/CHANGELOG.md
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Many of the methods defined in `AttributeMethods::Serialization` can be
refactored onto this type as well, but this is a reasonable small step.
Removes the `Type` class, and the need for `decorate_columns` to handle
serialized types.
|
| |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
MySQL and PostgreSQL provide a column type override in order to properly
type cast computed columns included in a result set. This should never
override the known types of full fledged columns. In addition to messing
up computed properties, this would have led to inconsistent behavior
between a record created with `new`, and a record created with `last` on
the mysql adapter in the following cases:
- `tinyint(1)` with `emulate_booleans` set to `false`
- `text`, `string`, `binary`, and `decimal` columns
|
|\ \ \
| | | |
| | | | |
Ensure we always use instances of the adapter specific column class
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Create a consistent API across adapters for building new columns
- Use it for custom properties so we don't get `UndefinedMethodError`s
in stuff I'm implementing elsewhere.
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Keep closer to other methods that touch @transaction
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
Working towards re-implementing serialized attributes to use the
properties API exposed the need for this, as serializing a column
shouldn't change the order of the columns.
|
|\ \ \
| | | |
| | | | |
Ensure custom properties work correctly with inheritance
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Move types to the top level `ActiveRecord` namespace
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`ActiveRecord::ConnectionAdapters::Type::Value` =>
`ActiveRecord::Type::Value`
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Initial doc for TransactionIsolationError [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Remove unused `Column#coder`
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
It appears this property was added, but never actually used. It would be
broken if it were, as it only type casts one way.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The solution presented in this patch is not efficient. We should replace it
in the near future. The following needs to be worked out:
* Is `@attributes` storing the Ruby or SQL representation?
* `cacheable_column?` is broken but `hstore` and `json` rely on that behavior
Refs #15369.
/cc @sgrif @rafaelfranca
|
|\ \ \
| | | |
| | | | |
Remove AR Properties from the public API
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Making this part of the public API was premature, let's make it private
again while I continue to work on the surrounding code.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
rake railties:install:migrations respects the order of railties
|
| | | | |
| | | | |
| | | | |
| | | | | |
This PR fixes #8930 and some stuff from #8985
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Silence deprecation warning in test
|
| | |/ / /
| |/| | |
| | | | |
| | | | | |
Missed a case that only occured for mysql/mysql2
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Correctly alias table names when joining more than once
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Deprecate decimal columns being automatically treated as integers
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
With ActiveRecord::Properties, we now have a reasonable path for users
to continue to keep this behavior if they want it. This is an edge case
that has added a lot of complexity to the code base.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix redefine a has_and_belongs_to_many inside inherited class
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
After ad7b5efb55bcc2e0ccd3e7f22a81e984df8676d1, which changed how
has_an_belongs_to_many used to work, we start raising an error when
redefining the same has_an_belongs_to_many association. This commits fix
that regression.
[Fixes #14983]
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
remove unwanted `to_sym` call.
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
All preload tests are in the eager_test file
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Skip if the association was already loaded.
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Remove unnecessary branch from quoting in Mysql
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
This is already the behavior for `BigDecimal` in the abstract adapter.
|
| |_|_|/ / / / /
|/| | | | | | | |
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
As a result of all of the refactoring that's been done, it's now
possible for us to define a public API to allow users to specify
behavior. This is an initial implementation so that I can work off of it
in smaller pieces for additional features/refactorings.
The current behavior will continue to stay the same, though I'd like to
refactor towards the automatic schema detection being built off of this
API, and add the ability to opt out of automatic schema detection.
Use cases:
- We can deprecate a lot of the edge cases around types, now that there
is an alternate path for users who wish to maintain the same behavior.
- I intend to refactor serialized columns to be built on top of this
API.
- Gem and library maintainers are able to interact with `ActiveRecord`
at a slightly lower level in a more stable way.
- Interesting ability to reverse the work flow of adding to the schema.
Model can become the single source of truth for the structure. We can
compare that to what the database says the schema is, diff them, and
generate a migration.
|