aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | Merge pull request #14526 from chancancode/fix_ar_equalityXavier Noria2014-03-293-8/+9
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | Ensure we are returning either `true` or `false` for `#==`
| * | | | | Ensure we are returning either `true` or `false` for `#==`Godfrey Chan2014-03-293-8/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 460eb83d cused `ActiveRecord::Base#==` to sometimes return `nil` in some cases, this ensures we always return a boolean value. Also fixed a similar problem in AR reflections.
* | | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-03-291-1/+5
|\ \ \ \ \ \ | |/ / / / / |/| | | | |
| * | | | | Update documentation on group method to indicate it takes an arrayEarl St Sauver2014-03-171-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The group method also takes an array, however this isn't immediately clear by reading the source since it delegates this method. If you trace it back to the AREL building you can see that it does support an array. Shoutout to @betovelandia for pointing this out.
| * | | | | Fix misspelling in references docsSteven Harman2014-03-141-1/+1
| | | | | |
* | | | | | Replace trivial regexp with string or index, twice as fastKelley Reynolds2014-03-282-2/+2
| |/ / / / |/| | | |
* | | | | PostgreSQL, use `PostgreSQLColumn` in PG specific tests.Yves Senn2014-03-281-8/+8
| | | | |
* | | | | PostgreSQL, test-cases to lock down column default values.Yves Senn2014-03-283-0/+33
| | | | |
* | | | | PostgreSQL, test cases to lock the current column types.Yves Senn2014-03-288-15/+68
| | | | |
* | | | | Merge pull request #14154 from al2o3cr/issue12770Aaron Patterson2014-03-274-4/+14
|\ \ \ \ \ | | | | | | | | | | | | Pass a base relation to build_default_scope when joining
| * | | | | Pass a base relation to build_default_scope when joiningMatt Jones2014-02-214-4/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows the default scope to be built using the current table alias. Resolves #12770
* | | | | | Merge pull request #14469 from tiegz/timestamp_inheritance_fixRafael Mendonça França2014-03-273-1/+23
| | | | | | | | | | | | | | | | | | | | | | | | Swap Timestamp/Callbacks order in ActiveRecord::Base
* | | | | | AR .persisted? throws SystemStackError for an unsaved model with achrisfinne2014-03-274-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | custom primary_key that didn't save due to validation error
* | | | | | ActiveRecord/ActiveModel '#validate' alias for 'valid?'Henrik Nyh2014-03-273-0/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies.
* | | | | | require dependency to execute a single test from xml_serialization_testYves Senn2014-03-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the tests are executed in order, the dependency is loaded at the right time. However this makes it impossible to execute a single test later down the line. Let's require the dependecy at the beginning to get them working independent of the order. This resolves the following error: ``` $ ARCONN=postgresql ruby -Itest /Users/senny/Projects/rails/activerecord/test/cases/xml_serialization_test.rb -n test_to_xml Using postgresql Run options: -n test_to_xml --seed 51819 E Finished in 0.081320s, 12.2971 runs/s, 0.0000 assertions/s. 1) Error: DatabaseConnectedXmlSerializationTest#test_to_xml: NameError: uninitialized constant DatabaseConnectedXmlSerializationTest::REXML /Users/senny/Projects/rails/activerecord/test/cases/xml_serialization_test.rb:226:in `test_to_xml' ``` /cc @tgxworld fyi
* | | | | | only run citext_test if the connection supports_extensions?.Yves Senn2014-03-271-52/+54
| | | | | | | | | | | | | | | | | | | | | | | | This will keep the test suite passing with older PG installations.
* | | | | | Add a test case for save(validate:false) with invalid foreign key.Lauro Caetano2014-03-271-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is supposed to raise ActiveRecord::InvalidForeignKey when the database has a fk constraint.
* | | | | | Remove unused methodRafael Mendonça França2014-03-261-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method is not being called anywhere in our code and a GitHub search show it is not being used in any project.
* | | | | | Improve CHANGELOG entryRafael Mendonça França2014-03-261-3/+5
| | | | | |
* | | | | | No need to use begin/end blocksRafael Mendonça França2014-03-262-16/+16
| | | | | |
* | | | | | No need to gsub the stringRafael Mendonça França2014-03-263-3/+3
| | | | | |
* | | | | | Don't use send when we own the methodRafael Mendonça França2014-03-262-35/+35
| | | | | |
* | | | | | Make method privateRafael Mendonça França2014-03-261-5/+6
| | | | | |
* | | | | | Improve the methodRafael Mendonça França2014-03-261-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * cache `o.name` value * Avoid extra `concat` call * Avoid extra `<<` call
* | | | | | Remove unneeded comments about feature support on the adaptersRafael Mendonça França2014-03-261-20/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These comments will likely be outdated with time and doesn't include any information that can't be found in the adapters
* | | | | | Invert the conditionals to make easier to readRafael Mendonça França2014-03-261-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | Also improve some of the code conventions
* | | | | | Fixes bugs for using indexes in CREATE TABLE by adding checks for table ↵Steve Rice2014-03-255-6/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | existence Also: - updates tests by stubbing table_exists? method - adds entry for creating indexes in CREATE TABLE to changelog
* | | | | | create indexes inline in CREATE TABLE for MySQLCody Cutrer2014-03-255-11/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is important, because adding an index on a temporary table after it has been created would commit the transaction Conflicts: activerecord/CHANGELOG.md
* | | | | | Use rails convetionsRafael Mendonça França2014-03-251-2/+2
| | | | | |
* | | | | | Merge pull request #14390 from huoxito/true-touchRafael Mendonça França2014-03-252-0/+13
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Still touch associations when theres no timestamp
| * | | | | | Still touch associations when theres no timestampWashington Luiz2014-03-142-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to Rails 4.0.4 when touching a object which doesn't have timestamp attributes (updated_at / updated_on) rails would still touch all associations. After 73ba2c14cd7d7dfb2d132b18c47ade995401736f it updates associations but rollsback because `touch` would return nil since there's no timestamp attribute
* | | | | | | Revert "Merge pull request #8313 from alan/only_save_changed_has_one_objects"Rafael Mendonça França2014-03-253-22/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6e3ab3e15faf782f6a937ccf5574a4fb63e3e353, reversing changes made to 39e07b64ce3f4bb55e60ba0266e677f8e4f4893a. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/autosave_association_test.rb
* | | | | | | clarify CHANGELOG [ci skip].Yves Senn2014-03-251-8/+2
| | | | | | |
* | | | | | | Fix Generation of proper migration whenKuldeep Aggarwal2014-03-252-3/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::Base.pluralize_table_names = false. Previously, generation a migration like this: rails g migration add_column_name_to_user name would not generating the correct table name. Fixes #13426.
* | | | | | | do not rely on method_missing hitting arelAaron Patterson2014-03-241-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | arel methods are not supposed to be public API for ActiveRecord
* | | | | | | use ARel factory methods for building AST nodesAaron Patterson2014-03-242-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This abstracts us from the actual construction of the nodes
* | | | | | | Clean up tables after each test.Guo Xiang Tan2014-03-222-92/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow-Up to https://github.com/rails/rails/pull/14400 This ensures that all tables are removed after each test and thereby allowing us to run the tests in a random order.
* | | | | | | Extract with_example_table into helper method.Guo Xiang Tan2014-03-202-6/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This setups the helper method which other tests can benefit from.
* | | | | | | Merge pull request #12955 from joshwilliams/masterYves Senn2014-03-203-0/+51
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Postgres schema: Constrain sequence search classid
| * | | | | | | Postgres schema: Constrain sequence search classidJosh Williams2014-03-203-0/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The pk_an_sequence_for query previously joined against pg_class's oid for rows in pg_depend, but pg_depend's objid may point to other system tables, such as pg_attrdef. If a row in one of those other tables coincidentally has the same oid as an (unrelated) sequence, that sequence name may be returned instead of the real one. This ensures that only the pg_depend entries pointing to pg_class are considered.
* | | | | | | | Remove extra indirection for testing exceptions and messagesCarlos Antonio da Silva2014-03-201-28/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | assert_raise + assert_equal on the returned exception message work just fine, there is no need for extra work, specially like this overly complicated helper.
* | | | | | | | Improve touch docs with extra attributes passed in [ci skip]Carlos Antonio da Silva2014-03-202-11/+10
| | | | | | | |
* | | | | | | | Merge pull request #14423 from yakko/persistence-touches-manyCarlos Antonio da Silva2014-03-203-2/+27
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord#touch should accept multiple attributes Conflicts: activerecord/CHANGELOG.md
| * | | | | | | | ActiveRecord#touch should accept multiple attributes #14423Thiago Pinto2014-03-193-2/+27
| |/ / / / / / /
* / / / / / / / only dump schema information if migration table exists. Closes #14217Yves Senn2014-03-202-1/+9
|/ / / / / / /
* | | | | | | Add counter cache test for class_nameArthur Neves2014-03-171-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport test from #14410
* | | | | | | test should only pass if the pool.size+1 checkout failsAaron Patterson2014-03-171-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, any of the connection checkouts could have failed, and this test would pass.
* | | | | | | use a latch to avoid busy loopsAaron Patterson2014-03-171-3/+4
| | | | | | |
* | | | | | | Reap connections based on owning-thread deathMatthew Draper2014-03-187-68/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | .. not a general timeout. Now, if a thread checks out a connection then dies, we can immediately recover that connection and re-use it. This should alleviate the pool exhaustion discussed in #12867. More importantly, it entirely avoids the potential issues of the reaper attempting to check whether connections are still active: as long as the owning thread is alive, the connection is its business alone. As a no-op reap is now trivial (only entails checking a thread status per connection), we can also perform one in-line any time we decide to sleep for a connection.
* | | | | | | Teach PostgreSQLAdapter#reset! to actually resetMatthew Draper2014-03-182-1/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It wasn't doing anything beyond clearing the statement cache.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-03 09:35:44 +0000