aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Follow the coding conventionsAndrey Deryabin2014-11-121-1/+1
|
* Merge pull request #17580 from ccutrer/change_table_nameYves Senn2014-11-113-17/+29
|\ | | | | | | add a Table#name accessor like TableDefinition#name
| * add a Table#name accessor like TableDefinition#nameCody Cutrer2014-11-103-17/+29
| |
* | Merge pull request #17585 from aderyabin/remove_limited_update_conditionsRafael Mendonça França2014-11-102-8/+0
|\ \ | |/ |/| remove never called method `limited_update_conditions`
| * remove never called method `limited_update_conditions`Andrey Deryabin2014-11-112-8/+0
| |
* | Merge pull request #17579 from aderyabin/cleanup_sqliteRafael Mendonça França2014-11-101-6/+2
|\ \ | | | | | | Tiny improvement in sqlite3 adapter
| * | tiny code improvement in sqlite3 adapter:Andrey Deryabin2014-11-101-6/+2
| |/ | | | | | | | | - remove unused method `supports_add_column?` - change additional restriction method to `valid_alter_table_type?` - fix code style
* | Merge pull request #17578 from codeodor/fix-17217-test-bugRafael Mendonça França2014-11-101-1/+1
|\ \ | | | | | | Fix bug found when running individual tests against #17217 after merging
| * | Fixes a bug found when running individual tests against #17217 after mergingSammy Larbi2014-11-101-1/+1
| |/
* | Merge pull request #11694 from ↵Rafael Mendonça França2014-11-103-1/+20
|\ \ | |/ |/| | | | | | | | | | | | | Empact/association-bind-values-not-updated-on-save Fix that a collection proxy could be cached before the save of the owner, resulting in an invalid proxy lacking the owner’s id Conflicts: activerecord/CHANGELOG.md
| * Fix that a collection proxy could be cached before the save of the owner, ↵Ben Woosley2014-10-033-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | resulting in an invalid proxy lacking the owner’s id. Absent this fix calls like: owner.association.update_all to behave unexpectedly because they try to act on association objects where owner_id is null. more evidence here: https://gist.github.com/Empact/5865555 ``` Active Record 3.2.13 -- create_table(:firms, {:force=>true}) -> 0.1371s -- create_table(:clients, {:force=>true}) -> 0.0005s 1 clients. 1 expected. 1 clients updated. 1 expected. ``` ``` Active Record 4.0.0 -- create_table(:firms, {:force=>true}) -> 0.1606s -- create_table(:clients, {:force=>true}) -> 0.0004s 1 clients. 1 expected. 0 clients updated. 1 expected. ```
* | Revert the behavior of booleans in string columns to that of 4.1Sean Griffin2014-11-093-7/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Why are people assigning booleans to string columns? >_> We unintentionally changed the behavior on Sqlite3 and PostgreSQL. Boolean values should cast to the database's representation of true and false. This is 't' and 'f' by default, and "1" and "0" on Mysql. The implementation to make the connection adapter specific behavior is hacky at best, and should be re-visted once we decide how we actually want to separate the concerns related to things that should change based on the database adapter. That said, this isn't something I'd expect to change based on my database adapter. We're storing a string, so the way the database represents a boolean should be irrelevant. It also seems strange for us to give booleans special behavior at all in string columns. Why is `to_s` not sufficient? It's inconsistent and confusing. Perhaps we should consider deprecating in the future. Fixes #17571
* | Ensure HABTM relationships produce valid class names (Fixes #17119)Sammy Larbi2014-11-097-3/+25
| |
* | default scopes should break the cache on singulur_association.alfa-jpn2014-11-082-1/+31
| | | | | | | | fixes #17495
* | default scopes should break the cache on has_many.Aaron Patterson2014-11-072-1/+28
| | | | | | | | | | | | if you specify a default scope on a model, it will break caching. We cannot predict what will happen inside the scope, so play it safe for now. fixes #17495
* | pg tests, get rid of `sql_types_test.rb`.Yves Senn2014-11-073-18/+14
| |
* | pg tests, only execute what's necessary.Yves Senn2014-11-072-27/+26
| |
* | remove the last traces of OpenBase from our codebase. [ci skip]Yves Senn2014-11-071-6/+0
| |
* | docs, the abstract data type `:timestamp` was removed. See #15184 [ci skip]Yves Senn2014-11-071-2/+2
| |
* | Merge pull request #17541 from OpenSourceProjects/meaninful_messageYves Senn2014-11-073-5/+15
|\ \ | | | | | | | | | Print out a meaningful error when ActiveRecord::ReadOnlyRecord is raised
| * | Print out a meaningful error when ActiveRecord::ReadOnlyRecord is raisedFranky W2014-11-062-5/+8
|/ / | | | | | | | | | | | | Currently, there is no messages which get printed out. Convoluted system may have hooks that create other objects in which case we only fail with no messages. This commit changes this information allowing you to know which object is the one that actually raised the error.
* | tests, remove unneeded requires.Yves Senn2014-11-064-11/+0
| |
* | tests, use SchemaDumpingHelper to dump a specific table.Yves Senn2014-11-061-12/+12
| | | | | | | | | | This makes debugging the generated schema output much easier. As a side effect it also shaves off 2.5 seconds of test runtime.
* | Remove unneccesary default parametersSean Griffin2014-11-051-1/+1
| |
* | Improve performance of AR object instantiationSean Griffin2014-11-055-11/+61
| | | | | | | | | | | | | | We introduced a performance hit by adding an additional iteration through a model's attributes on creation. We don't actually need the values from `Result` to be a hash, we can separate the columns and values and zip them up ourself during the iteration that we have to do.
* | Merge pull request #17360 from bronzle/includes_and_unscopedYves Senn2014-11-053-0/+15
|\ \ | | | | | | | | | copy reflection_scopes’s unscoped value when building scope for preloading
| * | copy reflection_scopes’s unscoped value when building scope for ↵Byron Bischoff2014-10-222-0/+12
| | | | | | | | | | | | preloading, fixes #11036
* | | Merge pull request #17510 from pda/ar-create-database-error-messageCarlos Antonio da Silva2014-11-051-0/+1
|\ \ \ | | | | | | | | rake db:create shows underlying error message.
| * | | activerecord: rake db:create shows underlying error message.Paul Annesley2014-11-041-0/+1
| | | |
* | | | Merge pull request #17473 from vipulnsward/rm-unused-methodYves Senn2014-11-051-8/+0
|\ \ \ \ | |/ / / |/| | | Remove unused duplicated method `add_column_position` from AbstractMysqlAdapter.
| * | | - Remove unused duplicated method `add_column_position` from ↵Vipul A M2014-11-011-8/+0
| | | | | | | | | | | | | | | | AbstractMysqlAdapter
* | | | Added SchemaDumper support for tables with jsonb columns.Ted O'Meara2014-11-045-18/+17
| | | |
* | | | Remove unneeded autoloadRafael Mendonça França2014-11-031-4/+1
| | | |
* | | | Merge pull request #17487 from pabloh/avoid_allocationsRafael Mendonça França2014-11-034-4/+4
|\ \ \ \ | | | | | | | | | | Avoid unnecessary allocations and method calls
| * | | | Avoid unnecessary allocations/callsPablo Herrero2014-11-024-4/+4
| | | | |
* | | | | Add comment to point out String#[] is intentionalAndrew White2014-11-021-0/+1
| | | | |
* | | | | Revert "Replace String index juggling with Pathname goodness in ↵yuuji.yaginuma2014-11-021-1/+1
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | db:fixtures:load" This reverts commit 482fdad5ef8a73688b50bba3991dd4ef6f286edd. Fixes #17237.
* | | | Add an `assert_deprecated` for `sanitize_sql_hash_for_conditions`Sean Griffin2014-11-021-1/+3
| | | |
* | | | Handle `RangeError` from casting in `find_by` and `find_by!` on RelationSean Griffin2014-11-022-0/+14
| | | | | | | | | | | | | | | | | | | | We should not behave differently just because a class has a default scope.
* | | | Revert deprecation of `sanitize_sql_hash_for_assignment`Sean Griffin2014-11-022-6/+2
| | | | | | | | | | | | | | | | This method is still used by `update_all`
* | | | Deprecate `sanitize_sql_hash_` methods on ActiveRecordSean Griffin2014-11-022-0/+12
| | | | | | | | | | | | | | | | | | | | These appear to be implementation relics of times past. They duplicate the logic in Relation, and are no longer used internally.
* | | | Pass the `SelectManager`, rather than the AST when querying w/ RelationSean Griffin2014-11-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Arel specifically handles `SelectManager`, with the same logic we're currently performing. The AST is `Enumerable`, which Arel looks for separately now.
* | | | Merge pull request #17483 from pabloh/optimize_gsub_callsSean Griffin2014-11-011-1/+1
|\ \ \ \ | | | | | | | | | | Call gsub with a Regexp instead of a String for better performance
| * | | | Call gsub with a Regexp instead of a String for better performancePablo Herrero2014-11-011-1/+1
| | | | |
* | | | | Don't duplicate predicate building logic in Relation findersSean Griffin2014-11-011-5/+2
| | | | |
* | | | | Add a test case for range type castingSean Griffin2014-11-011-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | We support this behavior, but have no tests which assert that type casting actually occurs.
* | | | | Use a bound parameter for the "id = " portion of update statementsSean Griffin2014-11-012-5/+14
|/ / / / | | | | | | | | | | | | | | | | | | | | We need to re-order the bind parameters since the AST returned by the relation will have the where statement as the first bp, which breaks on PG.
* | | | Correctly cast calculation results on PGSean Griffin2014-11-013-1/+16
| | | | | | | | | | | | | | | | | | | | MySQL reports the column name as `"MAX(developer_id)"`. PG will report it as `"max"`
* | | | [ci skip] `Relation#bind` is not public APISean Griffin2014-11-011-1/+1
| | | |
* | | | Fix test which failed in isolationSean Griffin2014-11-011-0/+1
| | | | | | | | | | | | | | | | It was transitively relying on the vertex model being loaded
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 19:00:55 +0000