| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
fix test not failing when executed isolated
|
| |
| |
| |
| |
| | |
the test was created in 7659fb6
the fixtures were added in c092dbe
|
|/
|
|
|
|
|
|
|
|
|
| |
After discussing, we've decided it makes more sense to include it. We're
already forwarding every conflicting method to `to_a`, and there's no
conflation of concerns. `Enumerable` has no mutating methods, and it
just allows us to simplify the code. No existing methods will have a
change in behavior. Un-overridden Enumerable methods will simply
delegate to `each`.
[Sean Griffin & bogdan]
|
|
|
|
|
|
|
|
| |
This matches our behavior in other cases where useful enumerable methods
might have a different definition in `Relation`. Wanting to actually
enumerate over the records in this case is completely reasonable, and
wanting `.sum` is reasonable for the same reason it is on `Enumerable`
in the first place.
|
|\
| |
| |
| | |
Update documentation for ActiveRecord::Migration#remove_index
|
| |
| |
| |
| | |
`remove_index` works with multiple column names as `add_index`
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Let WITH (CTE) queries be explainable
Conflicts:
activerecord/CHANGELOG.md
|
| | | |
|
| | |
| | |
| | |
| | | |
Fixes #20626
|
| | |
| | |
| | |
| | | |
revert create and drop task descriptions
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
relationship without the foreign key attribute
fixes regression reported on #20253
ActiveRecord::Base#[] was not used cause of 8b95420
|
|\ \ \
| | | |
| | | | |
Small refactor on db:reset
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
db:reset should not prematurely load the environment, so, for instance,
if there is any initializer that touches th DB, it will not touch that
before droping it.
Also this makes the code simpler.
This changed was made back in 15fb4302b6ff16e641b6279a3530eb8ed97f2899
, not sure why. But I am pretty much sure we should do it like this, as
drop and setup should load its dependencies tasks if necessary.
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
prathamesh-sonpatki/test-for-serial-for-quoted-sequence
Added test case for serial? method when sequence name is not quoted
|
| | |/
| |/|
| | |
| | | |
- Followup of https://github.com/rails/rails/pull/20190/.
|
|\ \ \
| | | |
| | | | |
make sure to load_config for db:abort_if_pending_migrations
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This used to raise a `IrreversibleMigration` error (since #10437).
However since `remove_index :table, :column` is probably the most basic
use-case we should make it reversible again.
Conflicts:
activerecord/CHANGELOG.md
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Add RDoc about add_reference to ActiveRecord::Migration
[ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | | |
[ci skip]
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
My impression of the code sample is that the intent is to assign guy_1, guy_2, etc. The code as it stood would have assigned guy_1, guy_1, etc.
This simply replaces the 1 with the iterator variable i.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
The examples now take in consideration when Active Record finds inverse
associations automatically.
|
| | | | |
|
| | | |
| | | |
| | | | |
the test case for this commit is in cd3f5db
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If a getter has side effects on the DB, `changes_applied` will be called
twice. The second time will try and remove the changed attributes cache,
and will crash because it's already been unset. This also demonstrates
that we shouldn't assume that calling getters won't change the value of
`changed_attributes`, and we need to clear the cache if an attribute is
modified.
Fixes #20531.
|
|\ \ \ \
| | | | |
| | | | | |
use our own runner for Rails framework components `bin/test`
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Make remove_foreign_key reversible
Conflicts:
activerecord/CHANGELOG.md
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
Fixes #17511 and #17415
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`serialize` makes the contract that if it is given a class name, it will
never return something other than an instance of that class. This means
that it must cast `nil` to the empty form of that object. As such, we
should then persist empty forms of that object as `nil`. While this is
techincally under the contract of
```
model.attribute = value
assert_equal model.attribute, model.tap(&:save).reload.attribute
```
which we can't actually test universally without property based testing,
it has come up more than once and is worth calling out specifically
since we aren't looking to change it.
|
| | | | |
| | | | |
| | | | |
| | | | | |
[Sean Griffin & jmondo]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If the subtype provides custom schema dumping behavior, we need to defer
to it. We purposely choose not to handle any values other than an array
(which technically should only ever be `nil`, but I'd rather code
defensively here).
Fixes #20515.
|
| | | | |
| | | | |
| | | | |
| | | | | |
change AR clear order in ActionDisplatch::Reloader hook
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
refactor ActiveRecord's #become by removing not needed code
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Fix crash when loading fixture with belongs_to association defined in abstract base class
|
| | | | |
| | | | |
| | | | |
| | | | | |
abstract base class.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Stop `to_s(:db)` for fixture's timestamp
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Time instance will be casted so we don't have to do `to_s(:db)`.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Return a `Point` object from the PG Point type
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This introduces a deprecation cycle to change the behavior of the
default point type in the PostgreSQL adapter. The old behavior will
continue to be available for the immediate future as `:legacy_point`.
The current behavior of returning an `Array` causes several problems,
the most significant of which is that we cannot differentiate between an
array of points, and a point itself in the case of a column with the
`point[]` type.
The attributes API gives us a reasonable way to have a proper
deprecation cycle for this change, so let's take advantage of it. If we
like this change, we can also add proper support for the other geometric
types (line, lseg, box, path, polygon, and circle), all of which are
just aliases for string today.
Fixes #20441
|
| |/ / / /
|/| | | |
| | | | |
| | | | | |
[Robin Dupret & Shunsuke Aida]
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
|