Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | join parts in `build` are *always* new, so don't bother checking | Aaron Patterson | 2013-10-08 | 1 | -1/+2 | |
| | ||||||
* | stop looking up the reflection multiple times | Aaron Patterson | 2013-10-08 | 1 | -6/+5 | |
| | ||||||
* | cache join associations and join base on the stack | Aaron Patterson | 2013-10-08 | 1 | -4/+11 | |
| | | | | No reason to decompose the join objects on every iteration | |||||
* | use the API rather than accessing underlying data structures | Aaron Patterson | 2013-10-08 | 1 | -1/+1 | |
| | ||||||
* | associations is always a hash | Aaron Patterson | 2013-10-08 | 1 | -19/+13 | |
| | ||||||
* | keys are always symbols | Aaron Patterson | 2013-10-08 | 1 | -2/+4 | |
| | ||||||
* | we can get a list of reflections from the join parts, so let's remove | Aaron Patterson | 2013-10-08 | 1 | -3/+5 | |
| | | | | the @reflections ivar. | |||||
* | transform the association input so we can avoid type checks later. | Aaron Patterson | 2013-10-08 | 1 | -17/+31 | |
| | | | | | We should consider moving the input munging outside the class instantiation | |||||
* | we know the keys are scalars, so avoid some typechecking | Aaron Patterson | 2013-10-08 | 1 | -8/+12 | |
| | ||||||
* | this method is only ever called with a reflection | Aaron Patterson | 2013-10-08 | 1 | -6/+2 | |
| | | | | Stop typechecking the parameter. We know the type. | |||||
* | don't access the reflections hash | Aaron Patterson | 2013-10-08 | 2 | -3/+7 | |
| | | | | The reflections hash is supposed to be private, so let's use the API. | |||||
* | build association tree thing on demand. | Aaron Patterson | 2013-10-08 | 1 | -6/+11 | |
| | | | | | `instantiate` is only called once, so there is no reason to cache the data structure on the instance and mutate itself. | |||||
* | hide join_parts internals from other classes | Aaron Patterson | 2013-10-08 | 2 | -17/+17 | |
| | ||||||
* | decouple JoinAssociation from JoinDependency | Aaron Patterson | 2013-10-08 | 2 | -10/+5 | |
| | ||||||
* | @associations can never have an array, so remove the dead code | Aaron Patterson | 2013-10-08 | 1 | -4/+0 | |
| | ||||||
* | typecast records returned from the db rather than to_sing everything | Aaron Patterson | 2013-10-08 | 2 | -12/+21 | |
| | ||||||
* | extract the string handling part to a method. | Aaron Patterson | 2013-10-07 | 1 | -15/+15 | |
| | | | | | | We know the structure passed in to the `construct` method will be a hash, so we don't need to test it all the time. The key value will be a symbol or string, so handle it with the special method | |||||
* | remove more dead code | Aaron Patterson | 2013-10-07 | 1 | -2/+0 | |
| | | | | | We control the inputs to `construct`, so the wrong type shouldn't be passed in ever. | |||||
* | this code is never used, remove it | Aaron Patterson | 2013-10-07 | 1 | -4/+0 | |
| | ||||||
* | log the statement name along with the SQL | Aaron Patterson | 2013-10-04 | 4 | -6/+20 | |
| | ||||||
* | log every sql statement, even when they error | Aaron Patterson | 2013-10-04 | 1 | -25/+25 | |
| | ||||||
* | prepare the statement inside the begin / rescue block | Aaron Patterson | 2013-10-04 | 1 | -4/+4 | |
| | ||||||
* | rm LogIntercepter | Aaron Patterson | 2013-10-04 | 1 | -15/+0 | |
| | ||||||
* | stop adding singleton methods to the SQLite3 connection | Aaron Patterson | 2013-10-04 | 1 | -11/+11 | |
| | ||||||
* | stop adding singleton methods to the mysql2 adapter | Aaron Patterson | 2013-10-04 | 3 | -22/+22 | |
| | ||||||
* | stop adding singleton methods to the PG connection | Aaron Patterson | 2013-10-04 | 1 | -11/+26 | |
| | ||||||
* | wrap logging around the actual query call itself. | Aaron Patterson | 2013-10-04 | 2 | -50/+50 | |
| | | | | This is to be consistent with the way the mysql2 adapter times queries | |||||
* | add regression test for set_inverse_instance on add_to_target | Arthur Neves | 2013-10-04 | 1 | -0/+13 | |
| | ||||||
* | inject down the hash cache | Aaron Patterson | 2013-10-03 | 1 | -3/+2 | |
| | ||||||
* | hashes are ordered, so we do not need to sort | Aaron Patterson | 2013-10-03 | 1 | -3/+3 | |
| | ||||||
* | Always pass parameters to `build` | Aaron Patterson | 2013-10-03 | 1 | -2/+2 | |
| | | | | | We always know the parameters in advance, so we don't need to build it in to the method signature | |||||
* | Set the join type on construction | Aaron Patterson | 2013-10-03 | 2 | -6/+5 | |
| | | | | | We always set the join type immediately after construction, just make it part of the constructor and we can skip that step | |||||
* | simplify the JoinAssociation constructor, check validity *before* | Aaron Patterson | 2013-10-03 | 2 | -6/+6 | |
| | ||||||
* | parent is always passed in, so make it non-optional | Aaron Patterson | 2013-10-03 | 1 | -1/+1 | |
| | ||||||
* | require the files we need so the classes are stand-alone | Aaron Patterson | 2013-10-03 | 3 | -1/+4 | |
| | ||||||
* | Merge pull request #12435 from sikachu/master-port-12084 | Aaron Patterson | 2013-10-03 | 2 | -1/+10 | |
|\ | | | | | Port test from cf1904f to avoid future regression | |||||
| * | Port test from cf1904f to avoid future regression | Prem Sichanugrist | 2013-10-03 | 2 | -1/+10 | |
| | | | | | | | | Related issue: #11939, #12084 | |||||
* | | map the association chain to table names | Aaron Patterson | 2013-10-03 | 1 | -4/+2 | |
|/ | ||||||
* | `intiantiated` => `instantiated` [ci-skip] | Vipul A M | 2013-10-03 | 1 | -1/+1 | |
| | ||||||
* | fix the variable name | Aaron Patterson | 2013-10-02 | 1 | -7/+7 | |
| | ||||||
* | preheat habtm column cache | Aaron Patterson | 2013-10-02 | 1 | -0/+1 | |
| | ||||||
* | add missing require | Aaron Patterson | 2013-10-02 | 1 | -0/+1 | |
| | ||||||
* | remove some duplicate code | Aaron Patterson | 2013-10-02 | 1 | -8/+1 | |
| | ||||||
* | add a note to the changelog | Aaron Patterson | 2013-10-02 | 1 | -0/+3 | |
| | ||||||
* | remove HABTM associations | Aaron Patterson | 2013-10-02 | 5 | -66/+0 | |
| | ||||||
* | remove HABTM special cases from reflections | Aaron Patterson | 2013-10-02 | 1 | -14/+2 | |
| | ||||||
* | remove the HABTM preloader | Aaron Patterson | 2013-10-02 | 2 | -74/+0 | |
| | ||||||
* | remove HABTM special cases from associations classes | Aaron Patterson | 2013-10-02 | 4 | -31/+1 | |
| | ||||||
* | remove HABTM special cases from the fixtures | Aaron Patterson | 2013-10-02 | 1 | -12/+0 | |
| | ||||||
* | repurpose the HABTM builder class | Aaron Patterson | 2013-10-02 | 2 | -29/+3 | |
| |