aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Remove extra indirection for testing exceptions and messagesCarlos Antonio da Silva2014-03-201-28/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | assert_raise + assert_equal on the returned exception message work just fine, there is no need for extra work, specially like this overly complicated helper.
* | | | | Improve touch docs with extra attributes passed in [ci skip]Carlos Antonio da Silva2014-03-202-11/+10
| | | | |
* | | | | Merge pull request #14423 from yakko/persistence-touches-manyCarlos Antonio da Silva2014-03-203-2/+27
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord#touch should accept multiple attributes Conflicts: activerecord/CHANGELOG.md
| * | | | | ActiveRecord#touch should accept multiple attributes #14423Thiago Pinto2014-03-193-2/+27
| |/ / / /
* / / / / only dump schema information if migration table exists. Closes #14217Yves Senn2014-03-202-1/+9
|/ / / /
* | | | Add counter cache test for class_nameArthur Neves2014-03-171-0/+11
| | | | | | | | | | | | | | | | Backport test from #14410
* | | | test should only pass if the pool.size+1 checkout failsAaron Patterson2014-03-171-3/+2
| | | | | | | | | | | | | | | | | | | | Previously, any of the connection checkouts could have failed, and this test would pass.
* | | | use a latch to avoid busy loopsAaron Patterson2014-03-171-3/+4
| | | |
* | | | Reap connections based on owning-thread deathMatthew Draper2014-03-187-68/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | .. not a general timeout. Now, if a thread checks out a connection then dies, we can immediately recover that connection and re-use it. This should alleviate the pool exhaustion discussed in #12867. More importantly, it entirely avoids the potential issues of the reaper attempting to check whether connections are still active: as long as the owning thread is alive, the connection is its business alone. As a no-op reap is now trivial (only entails checking a thread status per connection), we can also perform one in-line any time we decide to sleep for a connection.
* | | | Teach PostgreSQLAdapter#reset! to actually resetMatthew Draper2014-03-182-1/+37
| | | | | | | | | | | | | | | | It wasn't doing anything beyond clearing the statement cache.
* | | | `where.not` adds `references` for `includes`.Yves Senn2014-03-174-0/+26
| | | | | | | | | | | | | | | | Closes #14406.
* | | | format ActiveRecord CHANGELOG. [ci skip]Yves Senn2014-03-171-8/+9
| | | |
* | | | Extend fixture label replacement to allow string interpolationEric Steele2014-03-154-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allows fixtures to use their $LABEL as part of a string instead of limiting use to the entire value. mark: first_name: $LABEL username: $LABEL1973 email: $LABEL@$LABELmail.com users(:mark).first_name # => mark users(:mark).username # => mark1973 users(:mark).email # => mark@markmail.com
* | | | Merge pull request #14380 from ↵Yves Senn2014-03-1549-61/+51
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | tgxworld/use_teardown_helper_method_in_activerecord Use teardown helper method.
| * | | | Use teardown helper method.Guo Xiang Tan2014-03-1449-61/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow-Up to https://github.com/rails/rails/pull/14348 Ensure that SQLCounter.clear_log is called after each test. This is a step to prevent side effects when running tests. This will allow us to run them in random order.
* | | | | Obey `validate: false` option for habtmCarlos Antonio da Silva2014-03-144-1/+39
| | | | | | | | | | | | | | | | | | | | Fixes #14383.
* | | | | Merge pull request #14387 from huoxito/touch-api-docArthur Nogueira Neves2014-03-141-2/+2
|\ \ \ \ \ | | | | | | | | | | | | Update callbacks executed on AR::Base#touch [skip ci]
| * | | | | Update callbacks executed on AR::Base#touch [skip ci]Washington Luiz2014-03-141-2/+2
| | |/ / / | |/| | | | | | | | | | | | | | | | | | As of https://github.com/rails/rails/pull/12031 after_commit and after_rollback are also executed
* / | | | Allow custom JDBC urlsschneems2014-03-142-2/+8
|/ / / / | | | | | | | | | | | | mitigates #14323
* / / / Avoid duplicated conditionalsCarlos Antonio da Silva2014-03-141-2/+1
|/ / /
* | | No need to binds be optionalRafael Mendonça França2014-03-131-2/+2
| | |
* | | Merge pull request #14372 from arthurnn/fix_query_cache_bindsRafael Mendonça França2014-03-134-12/+24
|\ \ \ | | | | | | | | Make select_all on query cache accept a Relation without binds.
| * | | Make select_all on query cache accept a Relation without binds.Arthur Neves2014-03-134-12/+24
| | | | | | | | | | | | | | | | | | | | [fixes #14361] [related #13886]
* | | | Add test for deprecation warning for passing an AR object to `find`.Lauro Caetano2014-03-131-0/+6
| | | |
* | | | Test deprecation warning for passing an ActiveRecord object toLauro Caetano2014-03-131-0/+6
|/ / / | | | | | | | | | `exists?`
* | | passing an instance of an AR object to `find` is deprecatedAaron Patterson2014-03-135-6/+13
| | | | | | | | | | | | please pass the id of the AR object by calling `.id` on the model first.
* | | passing an ActiveRecord object to `exists?` is deprecated.Aaron Patterson2014-03-135-4/+14
| | | | | | | | | | | | | | | Pass the id of the object to the method by calling `.id` on the AR object.
* | | make tests pass on Ruby 2.2Aaron Patterson2014-03-131-4/+4
| | | | | | | | | | | | | | | | | | Apparently we've been using a buggy feature for the past 6 years: https://bugs.ruby-lang.org/issues/9593
* | | Use Sqlite3 adapter in examplesJulian Simioni2014-03-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Two bits of example code use sqlite as an adapter, which doesn't exist. Using the code verbatim will raise a LoadError exception: ActiveRecord::Base.establish_connection( "adapter" => "sqlite", "database" => "db.sqlite" ) # => LoadError: Could not load 'active_record/connection_adapters/sqlite_adapter'... Considering this is code a lot of people new to Rails might be running, it's especially confusing. Closes #14367 [ci skip]
* | | Merge pull request #14364 from why-el/better-docs-for-update-attributeArthur Nogueira Neves2014-03-121-0/+2
|\ \ \ | | | | | | | | Enhance docs for update_attribute [skip ci]
| * | | Enhance docs for update_attribute [ci-skip]Mohamed Wael Khobalatte2014-03-121-0/+2
| | | |
* | | | Change usec to 0 on tests that compare secondsArthur Neves2014-03-121-3/+3
| | | | | | | | | | | | | | | | | | | | Avoid rounding problems with `.usec` method rounding the seconds when the field doesn't persist the `.usec` piece.
* | | | Unit test for mysql quote time usecArthur Neves2014-03-121-0/+7
|/ / /
* | | Merge pull request #13040 from kamipo/case_sensitive_comparisonRafael Mendonça França2014-03-126-6/+62
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Only use BINARY for mysql case sensitive uniqueness check when column has a case insensitive collation. Conflicts: activerecord/CHANGELOG.md
| * | | Only use BINARY for mysql case sensitive uniqueness check when column has a ↵Ryuta Kamizono2013-11-266-6/+62
| | | | | | | | | | | | | | | | case insensitive collation.
* | | | Changelog entry for mysql56 microsecondsArthur Neves2014-03-121-0/+4
| | | |
* | | | Test microsecond on mysql 5.6Arthur Neves2014-03-123-2/+11
| | | |
* | | | MySQL 5.6 and later supports microsecond precision in datetime.Tatsuhiko Miyagawa2014-03-121-0/+8
| | | | | | | | | | | | | | | | | | | | You might want to branch it to include this only for 5.6, but passing these values to < 5.6 doesn't cause issues either.
* | | | Remove mocking on save, when not necessaryArthur Neves2014-03-111-3/+1
| | | |
* | | | Merge pull request #14345 from arthurnn/revert_14052Godfrey Chan2014-03-112-3/+16
|\ \ \ \ | | | | | | | | | | Fixes STI when 2+ levels deep.
| * | | | Fixes STI when 2+ levels deep.Arthur Neves2014-03-102-3/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PR #14052 Added a regression where it was only looking for methods in one level up, So when the method was defined in a 2+ levels up the inheritance chain, the method was not found as defined.
* | | | | `change_table` supports `citext`. Follow up to #12523.Yves Senn2014-03-112-8/+31
| | | | |
* | | | | register OID for PostgreSQL citex datatype [Troy Kruthoff & Lachlan Sylvester]lsylvester2014-03-116-2/+89
|/ / / / | | | | | | | | | | | | citext makes it possible to use AR Hash finders for case-insensitive matching as sql UPPER/LOWER functions are not needed.
* | | | Merge pull request #8313 from alan/only_save_changed_has_one_objectsRafael Mendonça França2014-03-103-2/+24
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Save has_one associations only if record has changes Conflicts: activerecord/CHANGELOG.md
| * | | | Save has_one associations only if record has changesAlan Kennedy2013-10-313-2/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevents save related callbacks such as `after_commit` being triggered when `has_one` objects are already persisted and have no changes.
* | | | | current_adapter? accepts multiple argumentsRafael Mendonça França2014-03-101-2/+2
| | | | |
* | | | | mysql adapter also fails with a number bigger than intRafael Mendonça França2014-03-101-2/+5
| | | | |
* | | | | Change the assertions depending in the database adapterRafael Mendonça França2014-03-101-14/+9
| | | | | | | | | | | | | | | | | | | | This will avoid the confusing flunk logic
* | | | | Do proper adapter checkRafael Mendonça França2014-03-101-2/+2
| | | | |
* | | | | WhitespacesRafael Mendonça França2014-03-101-2/+2
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-15 17:18:02 +0000