| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| |
| |
| | |
* Use NOT IN in SQL query
* Quote table names propertly
* Use array form of command invocation
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
When using `sql` as the schema format, or even just doing `rake
db:structure:dump`, it would be good to respect the list of ignored
tables that has been configured.
|
|\ \
| | |
| | |
| | |
| | | |
meinac/fix_ambigious_exception_message_of_select_query_method
Fix ambigious error message of select query method [ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | | |
Don't eager loading if unneeded for `FinderMethods#exists?`
|
| | |/
| |/|
| | |
| | | |
Fixes #29025.
|
|/ /
| |
| |
| |
| |
| | |
Because we don't need to load tasks for DBs that we don't use for the current app.
Also, these Tasks classes load AR::Base in their class level, and so immediately kick :active_record on_load hooks.
This used to happen when we were loading tasks, not when we run a task.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
```
% ARCONN=sqlite3 be ruby -w -Itest test/cases/quoting_test.rb
test/cases/quoting_test.rb:92: warning: ambiguous first argument; put parentheses or a space even after `/' operator
test/cases/quoting_test.rb:96: warning: ambiguous first argument; put parentheses or a space even after `/' operator
Using sqlite3
Run options: --seed 9495
.....................................
Finished in 0.046403s, 797.3622 runs/s, 1120.6172 assertions/s.
37 runs, 52 assertions, 0 failures, 0 errors, 0 skips
```
|
|\ \
| | |
| | | |
Clarify deprecation message for #quoted_id
|
| | |
| | |
| | |
| | |
| | | |
In this case, it's the method definition that's more at fault, rather
than the current caller.
|
| | |
| | |
| | |
| | | |
`DelegationTest#call_method` is no longer used since 9d79334a.
|
| | |
| | |
| | |
| | |
| | |
| | | |
The argument of `Arel::SelectManager.new` is `table`, not `engine`.
https://github.com/rails/arel/blob/v8.0.0/lib/arel/select_manager.rb#L10
|
|/ /
| |
| |
| | |
Since through association is always loaded by `preloader.preload`.
|
| |
| |
| |
| | |
Since legacy `Relation#bind_values` was removed in b06f64c.
|
|\ \
| | |
| | | |
Extract `bind_param` and `bind_attribute` into `ActiveRecord::TestCase`
|
| | |
| | |
| | |
| | | |
These are used in tests from anywhere.
|
|/ /
| |
| |
| |
| |
| | |
The same test exists in `test/cases/relation/merging_test.rb`.
https://github.com/rails/rails/blob/v5.1.0/activerecord/test/cases/relation/merging_test.rb#L94-L101
|
| |
| |
| |
| |
| | |
Since we have been using this `Arel::Table` since 111ccc832bc977b15af12c14e7ca078dad2d4373,
in order to properly handle queries, it's important that we properly type cast arguments.
|
|\ \
| | |
| | | |
Deprecate `supports_statement_cache?`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`supports_statement_cache?` was introduced in 3.1.0.beta1 (104d0b2) for
bind parameter substitution, but it is no longer used in 3.1.0.rc1
(73ff679). Originally it should respect `prepared_statements` rather
than `supports_statement_cache?` (fd39847).
One more thing, named `supports_statement_cache?` is pretty misreading.
We have `StatementCache` and `StatementPool`. However,
`supports_statement_cache?` doesn't mean `StatementCache`, but
`StatementPool` unlike its name.
https://github.com/rails/rails/blob/v5.1.0/activerecord/lib/active_record/statement_cache.rb
https://github.com/rails/rails/blob/v5.1.0/activerecord/lib/active_record/connection_adapters/statement_pool.rb
|
|\ \ \
| |/ /
|/| | |
Use `flat_map` rather than `map(&:...).flatten`
|
| | | |
|
|/ /
| |
| |
| |
| |
| | |
* Remove trailing spaces.
* Add backticks around method and command.
* Fix indentation.
|
| |
| |
| |
| |
| |
| | |
Just use one `Event` class. Reduces duplication, makes the tests easier
to read. It might seem like each tests needs a different kind of Struct,
since we make a new one for each test case.
|
| |
| |
| |
| | |
Fix #28905
|
|/ |
|
|
|
|
|
| |
This change reverted in eac6f369 but it is needed for data integrity.
See #25328.
|
|\
| |
| | |
PostgreSQL 10 does not convert `CURRENT_DATE` into `('now'::text)::date`
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Address #28797
In the previous versions of PostgreSQL, `CURRENT_DATE` converted to `('now'::text)::date`
and `CURRENT_TIMESTAMP` converted to `now()`.
Refer these discussions and commit at PostgreSQL :
https://www.postgresql.org/message-id/flat/5878.1463098164%40sss.pgh.pa.us#5878.1463098164@sss.pgh.pa.us
https://github.com/postgres/postgres/commit/0bb51aa96783e8a6c473c2b5e3725e23e95db834
|
|\ \
| | |
| | | |
Set consistent typecast ENV["VERBOSE"]
|
| | |
| | |
| | |
| | |
| | | |
Add cases to ensure that environment variables VERBOSE and VERSION have
correct typecast.
|
| |/
| |
| |
| |
| | |
Set consistent type cast ENV["VERBOSE"]:
ENV["VERBOSE"] is true if it not equal "false"
|
|\ \
| | |
| | | |
Remove useless test case
|
| |/
| |
| |
| |
| | |
Cannot call private methods in `@klass` against `CollectionProxy`
(inherites `Relation`) because using `public_send` in `method_missing`.
|
|\ \
| | |
| | | |
Remove mysql2 database adapter default username root
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
mtsmfm/disable-referential-integrity-without-superuser-privilege-take-2"
This reverts commit c1faca6333abe4b938b98fedc8d1f47b88209ecf, reversing
changes made to 8c658a0ecc7f2b5fc015d424baf9edf6f3eb2b0b.
See https://github.com/rails/rails/pull/27636#issuecomment-297534129
|
|/ |
|
|\
| |
| | |
Mixin `CollectionProxy::DelegateExtending` after `ClassSpecificRelation`
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`ClassSpecificRelation` has `method_missing` and the `method_missing` is
called first. if an associated class has the missing method in a
relation, never reach to the `method_missing` in the `CollectionProxy`.
I extracted `DelegateExtending` and included it to the delegate class
that including `ClassSpecificRelation` to fix the issue.
Fixes https://github.com/rails/rails/pull/28246#issuecomment-296033784.
|
|\ \
| | |
| | | |
`respond_to_missing?` should be private
|
| |/
| |
| |
| |
| |
| |
| | |
Follow up of 03d3f036.
Some of `respond_to?` were replaced to `respond_to_missing?` in 03d3f036.
But the visibility is still public. It should be private.
|
| |
| |
| |
| |
| |
| |
| | |
Add `ActiveRecord::Migration.verbose = true`
to be sure that verbose is turned on in the test.
Related to #28865
|
|\ \
| | |
| | | |
Replace \Z to \z
|
| |/
| |
| |
| | |
\Z was a mistake of \z. Replace \Z to \z to prevent newly \Z added.
|
|\ \
| | |
| | | |
Remove checks for Enumerator#size method
|