Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #12779 from ↵ | Aaron Patterson | 2013-11-15 | 4 | -10/+10 |
|\ | | | | | | | | | dougbarth/dont_swallow_exceptions_during_transactional_statements_in_mysql Don't swallow exceptions in transctional statements | ||||
| * | Remove tests for not swallowing exceptions. | Doug Barth | 2013-11-15 | 2 | -42/+0 |
| | | | | | | | | From PR, @tenderlove would prefer to not maintain these tests. | ||||
| * | Don't swallow exceptions in transctional statements | Doug Barth | 2013-11-05 | 4 | -10/+52 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The MySQL connection adapater swallows all StandardError exceptions, which includes Mysql::Error and Mysql2::Error. The comment in the exception clause claims errors thrown here indicate that transactions aren't supported by the server but that isn't necessarily true. It's possible the MySQL server has gone away and swallowing a failed commit may let the application return a successful response when the data has not been saved. Also, replication libraries like Galera require that the application handle exceptions thrown at BEGIN/COMMIT. I'm unable to determine what version of MySQL threw an exception for transactional statements. I tried as far back as 3.23.49 with InnoDB disabled but BEGIN & COMMIT statements do not throw an error. If there's a real case for this logic to continue, we could instead push this behavior into a configuration setting. The exception swallowing has been there since the beginning: db045dbbf60b53dbe013ef25554fd013baf88134 | ||||
* | | Merge pull request #12531 from iamvery/database-tasks-exit-status | Rafael Mendonça França | 2013-11-15 | 6 | -16/+51 |
|\ \ | | | | | | | | | | | | | | | | | | | Explicitly exit with status "1" for create and drop task failures Conflicts: activerecord/CHANGELOG.md | ||||
| * | | Explicitly exit with status "1" for create and drop failures | Jay Hayes | 2013-11-11 | 6 | -16/+51 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * A non-zero exit status allows subsequent shell commands to be chained together such as: `rake db:reset test:prepare && rspec && cap deploy` (if you're feeling brave :) * Any exceptions raised during the `create` and `drop` tasks are caught in order to print a "pretty" message to the user. Unfortunately doing so prevents rake from aborting with a non-zero exit status to the shell. * Therefore we re-raise the exceptions after the "pretty" message and re-catch them in the task. * From the task we explicitly exit with a non-zero status. This method was chosen (rather than just letting rake fail from the exception) so that the backtrace is suppressed and the output to stderr is unchanged. * Update activerecord CHANGELOG | ||||
* | | | explain how `to_param` wil truncate long values. [ci skip] refs #12900. | Yves Senn | 2013-11-15 | 1 | -0/+3 |
| | | | |||||
* | | | added one test case and example for ActiveRecord::Base.to_param method | Kuldeep Aggarwal | 2013-11-15 | 2 | -0/+10 |
| | | | |||||
* | | | document id prefixed String usage of `.find`. refs #12891 [ci skip] | Yves Senn | 2013-11-15 | 1 | -5/+6 |
| | | | |||||
* | | | Fix test name [ci skip] | Carlos Antonio da Silva | 2013-11-14 | 2 | -3/+1 |
| | | | |||||
* | | | Fix AR Changelog examples and improve syntax highlight [ci skip] | Carlos Antonio da Silva | 2013-11-14 | 1 | -12/+12 |
| | | | |||||
* | | | Revert "Used Yield instead of block.call" -- this causes all of ↵ | David Heinemeier Hansson | 2013-11-14 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | | atom_feed_helper_test.rb to fail with "SystemStackError: stack level too deep". This reverts commit d3a1ce1cdc60d593de1682c5f4e3230c8db9a0fd. | ||||
* | | | Fix that eager loading of polymorphic associations did not work with ↵ | David Heinemeier Hansson | 2013-11-14 | 3 | -4/+10 |
| | | | | | | | | | | | | association empty?/any? predicates any more (there is still a problem when select is applied to a relation, or if you try association#exists? -- but its easier to work around) | ||||
* | | | Merge pull request #12893 from javan/to-param-addendum | Rafael Mendonça França | 2013-11-14 | 2 | -8/+28 |
|\ \ \ | | | | | | | | | Addendum to #12891 | ||||
| * | | | Addendum to #12891 | Javan Makhmali | 2013-11-14 | 2 | -8/+28 |
| | | | | | | | | | | | | | | | | | | | | | | | | * Fix incorrectly named tests * Restore Object#to_param behavior * Ensure param is derived from a squished and truncated string | ||||
* | | | | Merge pull request #12819 from vipulnsward/also_dup_column_types | Rafael Mendonça França | 2013-11-14 | 1 | -3/+4 |
|\ \ \ \ | |/ / / |/| | | | Also dup `column_types` in AR::Result `initialize_copy` | ||||
| * | | | Also dup `column_types` in AR::Result `initialize_copy` | Vipul A M | 2013-11-10 | 1 | -3/+4 |
| | | | | |||||
* | | | | Merge pull request #12889 from kuldeepaggarwal/speed_ups | Rafael Mendonça França | 2013-11-14 | 1 | -3/+3 |
|\ \ \ \ | | | | | | | | | | | Used Yield instead of block.call | ||||
| * | | | | Used Yield instead of block.call | Kuldeep Aggarwal | 2013-11-15 | 1 | -3/+3 |
| | | | | | |||||
* | | | | | Add AR::Base.to_param for convenient "pretty" URLs derived from a model's ↵ | Javan Makhmali | 2013-11-14 | 4 | -0/+65 |
| | | | | | | | | | | | | | | | | | | | | attribute or method. | ||||
* | | | | | Merge pull request #12832 from vipulnsward/move_schema_creation | Yves Senn | 2013-11-14 | 2 | -78/+84 |
|\ \ \ \ \ | | | | | | | | | | | | | Move `SchemaCreation` to its own file instead of `AbstractAdapter`. | ||||
| * | | | | | Move `SchemaCreation` to its own file instead of `AbstractAdapter`. | Vipul A M | 2013-11-12 | 2 | -78/+84 |
| | |/ / / | |/| | | | |||||
* | | | | | Merge pull request #12845 from amatsuda/should_ar_depend_on_rails | Guillermo Iguaran | 2013-11-13 | 1 | -1/+5 |
|\ \ \ \ \ | | | | | | | | | | | | | Refer to Rails.env from AR only when Rails is defined | ||||
| * | | | | | Refer to Rails.env only when Rails is defined | Akira Matsuda | 2013-11-11 | 1 | -1/+5 |
| | | | | | | |||||
* | | | | | | Merge pull request #12772 from dmathieu/no_touching | Rafael Mendonça França | 2013-11-13 | 5 | -0/+112 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Add No Touching | ||||
| * | | | | | | add #no_touching on ActiveRecord models | Damien Mathieu | 2013-11-13 | 5 | -0/+112 |
| | | | | | | | |||||
* | | | | | | | fix weird Emacs auto indentation. [ci skip] | Yves Senn | 2013-11-13 | 1 | -8/+8 |
| | | | | | | | |||||
* | | | | | | | tests for merging Relations of different classes. | Yves Senn | 2013-11-13 | 1 | -0/+19 |
| | | | | | | | |||||
* | | | | | | | move Relation#merge tests into separate file. | Yves Senn | 2013-11-13 | 2 | -121/+131 |
| | | | | | | | |||||
* | | | | | | | Ensure that a column added in a test is being removed after all | Akira Matsuda | 2013-11-13 | 1 | -0/+7 |
|/ / / / / / | |||||
* | | | | | | Remove the unused, undocumented SQLite3Adapter#supports_count_distinct? | Ben Woosley | 2013-11-12 | 1 | -5/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | This has returned true since 3cc9b5f1, and is not used internally. | ||||
* | | | | | | Drop a sqlite_version check because we only support SQLite 3.6.16 or newer. | Ben Woosley | 2013-11-12 | 2 | -7/+1 |
| | | | | | | | | | | | | | | | | | | Drop some comments that document the implementation rather than the interface. | ||||
* | | | | | | Prevent the counter cache from being decremented twice | dm1try | 2013-11-11 | 3 | -1/+17 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when destroying a record on a has_many :through association. :destroy method has own counter_cache callbacks. | ||||
* | | | | | | Unifies mysql and mysql2 casting of booleans. | Yves Senn | 2013-11-11 | 4 | -9/+16 |
| | | | | | | |||||
* | | | | | | test cases to describe the MySQL boolean behavior. | Yves Senn | 2013-11-11 | 1 | -0/+91 |
| | | | | | | |||||
* | | | | | | Do not count "SHOW CREATE TABLE" queries when testing against mysql | Akira Matsuda | 2013-11-11 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | tidy Active Record CHANGELOG. [ci skip]. | Yves Senn | 2013-11-11 | 1 | -1/+3 |
| | | | | | | |||||
* | | | | | | Avoid sorting an Array including objects from different Classes | Akira Matsuda | 2013-11-11 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | addresses "ArgumentError: comparison of VerySpecialComment with SpecialComment failed" in ActiveRecord::DelegationRelationTest#test_#sort!_delegation_is_deprecated | ||||
* | | | | | | Load test fixtures where data are needed | Akira Matsuda | 2013-11-11 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | Without this, some tests here were not actually testing anything. | ||||
* | | | | | | Merge pull request #12834 from dredozubov/has_one_association_replacement | Yves Senn | 2013-11-11 | 3 | -4/+26 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Fixes problem with replacing has_one association record with itself | ||||
| * | | | | | | Fixes problem with replacing has_one association record with itself | Denis Redozubov | 2013-11-11 | 3 | -4/+26 |
| | |_|/ / / | |/| | | | | |||||
* | | | | | | A tiny grammatical fix | Akira Matsuda | 2013-11-11 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] | ||||
* | | | | | | autoload ChangeColumnDefinition (Fixes #12835) | Anton Kalyaev | 2013-11-11 | 1 | -0/+1 |
| |/ / / / |/| | | | | |||||
* | | | | | Merge pull request #12749 from iantropov/issue_5303 | Rafael Mendonça França | 2013-11-10 | 1 | -0/+4 |
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | Add test for ActiveRecord::Relation YAML serialization, for #5303 issue | ||||
| * | | | | Add test for ActiveRecord::Relation YAML serialization, for #5303 issue | Ivan Antropov | 2013-11-03 | 1 | -0/+4 |
| | | | | | |||||
* | | | | | use complete Relation API and not only `Model.all.merge!`. | Yves Senn | 2013-11-09 | 1 | -88/+83 |
| | | | | | |||||
* | | | | | Change array check for better aesthetics / reading the code | Carlos Antonio da Silva | 2013-11-09 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Merge pull request #12821 from arunagw/aa-removed-missleading-message | Yves Senn | 2013-11-09 | 2 | -2/+2 |
|\ \ \ \ \ | | | | | | | | | | | | | clarified missleading message | ||||
| * | | | | | Changed message for Model.inspect | Arun Agrawal | 2013-11-09 | 2 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (No database connection) sounds not be able to connect database. see more #12804 | ||||
* | | | | | | improve Active Record Store docs when using PG types. [ci skip]. | Yves Senn | 2013-11-09 | 1 | -3/+4 |
| | | | | | | |||||
* | | | | | | type casted PG bytea values are represented as a Hash. | Yves Senn | 2013-11-09 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to: 97f0d9a0dd12e7ad634815eecfeff866f64aad92 This change is also related to: df0edafac9eb47cd971970a9e7b13a3eaddf214e |