Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Handle nil in add_index :length option in MySQL | Paul Sadauskas | 2012-01-24 | 2 | -2/+8 | |
| | | | | | | | | | | | | | | | | | Our schema.rb is being generated with an `add_index` line similar to this: add_index "foo", ["foo", "bar"], :name => "xxx", :length => {"foo"=>8, "bar=>nil} This is the same as it was on Rails 3.1.3, however, now when that schema.rb is evaluated, its generating bad SQL in MySQL: Mysql::Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '))' at line 1: CREATE UNIQUE INDEX `xxx` ON `foo` (`foo`(8), `bar`()) This commit adds a check for nil on the length attribute to prevent the empty parens from being output. | |||||
* | deprecated AR::TestCase in favor of AS::TestCase | Aaron Patterson | 2012-01-24 | 1 | -0/+4 | |
| | ||||||
* | Moving AR::TestCase in to the AR tests directory | Aaron Patterson | 2012-01-24 | 3 | -32/+64 | |
| | ||||||
* | Only show the type if column is present | Rafael Mendonça França | 2012-01-23 | 1 | -1/+2 | |
| | ||||||
* | Merge pull request #4558 from stephencelis/type-cast-unknown-should-fail | Aaron Patterson | 2012-01-23 | 3 | -8/+6 | |
|\ | | | | | Don't type-cast unknown types to YAML. | |||||
| * | Don't type-cast unknown types to YAML. | Stephen Celis | 2012-01-20 | 3 | -8/+6 | |
| | | ||||||
* | | Merge pull request #4563 from amatsuda/ar_relation_pp | Aaron Patterson | 2012-01-23 | 1 | -0/+4 | |
|\ \ | | | | | | | let AR::Relation pretty_printed like an Array | |||||
| * | | let AR::Relation pretty_printed like an Array | Akira Matsuda | 2012-01-21 | 1 | -0/+4 | |
| | | | ||||||
* | | | Remove not used if..else clause | Carlos Antonio da Silva | 2012-01-23 | 1 | -6/+0 | |
| | | | | | | | | | | | | Related to #4614. | |||||
* | | | Unused var removed | Arun Agrawal | 2012-01-23 | 1 | -1/+1 | |
| | | | ||||||
* | | | Fix typo | Jari Jokinen | 2012-01-22 | 1 | -1/+1 | |
| | | | ||||||
* | | | change AR default_timezone to :utc since it's the default for AR::Railtie | Akira Matsuda | 2012-01-21 | 2 | -5/+5 | |
| | | | ||||||
* | | | pushed broadcasting down to a module | Aaron Patterson | 2012-01-20 | 1 | -2/+1 | |
|/ / | ||||||
* / | restored logging to the log file and display on the console | Aaron Patterson | 2012-01-20 | 1 | -1/+3 | |
|/ | ||||||
* | Fix another race condition. | Jon Leighton | 2012-01-20 | 3 | -3/+11 | |
| | | | | | | From 2c667f69aa2daac5ee6c29ca9679616e2a71532a. Thanks @pwnall for the heads-up. | |||||
* | Revert "just use an alias. The target method is public, so make this one ↵ | Aaron Patterson | 2012-01-20 | 1 | -1/+4 | |
| | | | | | | public" This reverts commit be7d2248e9505983d1aacf0b33c657e6e3ddd9db. | |||||
* | push ivar initialization down to a common method | Aaron Patterson | 2012-01-19 | 1 | -16/+20 | |
| | ||||||
* | adding tests for previous_changes hash | Aaron Patterson | 2012-01-19 | 1 | -0/+25 | |
| | ||||||
* | just use an alias. The target method is public, so make this one public | Aaron Patterson | 2012-01-19 | 1 | -4/+1 | |
| | | | | too. | |||||
* | avoid useless is_a checks | Aaron Patterson | 2012-01-19 | 1 | -8/+8 | |
| | ||||||
* | Merge pull request #4531 from exviva/pessimistic_with_lock | Aaron Patterson | 2012-01-19 | 3 | -1/+70 | |
|\ | | | | | Add ActiveRecord::Base#with_lock | |||||
| * | Add ActiveRecord::Base#with_lock | Olek Janiszewski | 2012-01-18 | 3 | -1/+70 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a `with_lock` method to ActiveRecord objects, which starts a transaction, locks the object (pessimistically) and yields to the block. The method takes one (optional) parameter and passes it to `lock!`. Before: class Order < ActiveRecord::Base def cancel! transaction do lock! # ... cancelling logic end end end After: class Order < ActiveRecord::Base def cancel! with_lock do # ... cancelling logic end end end | |||||
* | | select doesn't take multiple arguments - fixes #4539 [ci skip] | Vijay Dev | 2012-01-19 | 1 | -5/+5 | |
|/ | | | | | Also, fixed the bit about returning AM::MissingAttributeError. This seems to be fixed earlier in 3-2-stable only. | |||||
* | Merge pull request #4487 from sarenji/fix-reset-counters | Aaron Patterson | 2012-01-17 | 7 | -3/+45 | |
|\ | | | | | Fix bug where reset_counters resets the wrong counter cache. | |||||
| * | Fix bug where reset_counters resets the wrong counter cache. | David Peter | 2012-01-16 | 7 | -3/+45 | |
| | | | | | | | | | | | | | | | | If a model belongs_to two associations with the same class, then reset_counters will reset the wrong counter cache. Finding the right reflection should use the foreign_key instead, which should be unique. | |||||
* | | disable transactions for this test | Aaron Patterson | 2012-01-17 | 1 | -1/+4 | |
| | | ||||||
* | | validate related records in the same validation context as parent. | Emmanuel Oga | 2012-01-17 | 3 | -2/+19 | |
|/ | | | | | | | | | | | | | | | | | | | | E.G.: ```ruby class Parent < ActiveRecord::Base has_one :child validates_presence_of :name, :on => "custom_context" validates_associated :child end class Child < ActiveRecord::Base belongs_to :parent validates_presence_of :name, :on => "custom_context" end p = Parent.new(:name => "Montoto", :child => Child.new) p.valid?(:custom_context) # => Returns true, even though the child is not valid under the same context. ``` | |||||
* | stop more ddl changes | Aaron Patterson | 2012-01-16 | 2 | -14/+16 | |
| | ||||||
* | stop ddl modifications for another test | Aaron Patterson | 2012-01-16 | 2 | -12/+10 | |
| | ||||||
* | use one based indexes for the mock migrations | Aaron Patterson | 2012-01-16 | 1 | -16/+16 | |
| | ||||||
* | stop making ddl changes for migrator tests | Aaron Patterson | 2012-01-16 | 2 | -67/+78 | |
| | ||||||
* | actually use the variable I created. :bomb: thanks @exviva | Aaron Patterson | 2012-01-16 | 1 | -1/+1 | |
| | ||||||
* | move another migrator to use sensors | Aaron Patterson | 2012-01-16 | 2 | -12/+18 | |
| | ||||||
* | Make it more explicit that the feature is deprecated, not removed. | Jon Leighton | 2012-01-16 | 1 | -2/+4 | |
| | ||||||
* | Deprecate inferred JOINs with includes + SQL snippets. | Jon Leighton | 2012-01-16 | 23 | -66/+216 | |
| | | | | | | See the CHANGELOG for details. Fixes #950. | |||||
* | infer references from Relation#order | Jon Leighton | 2012-01-16 | 2 | -2/+28 | |
| | ||||||
* | store references as a string | Jon Leighton | 2012-01-16 | 4 | -8/+8 | |
| | ||||||
* | Avoid sanitize_sql when we can use Relation#where instead | Jon Leighton | 2012-01-16 | 4 | -22/+16 | |
| | ||||||
* | automatically add references when we can | Jon Leighton | 2012-01-16 | 3 | -1/+29 | |
| | ||||||
* | Make referencing an included item trigger eager loading | Jon Leighton | 2012-01-16 | 2 | -1/+13 | |
| | ||||||
* | Add ActiveRecord::Relation#references (#950) | Jon Leighton | 2012-01-16 | 4 | -4/+35 | |
| | ||||||
* | Revert "Deprecate implicit eager loading. Closes #950." | Jon Leighton | 2012-01-16 | 27 | -181/+99 | |
| | | | | This reverts commit c99d507fccca2e9e4d12e49b4387e007c5481ae9. | |||||
* | moving verbosity tests to the migrator test, removing ddl changes | Aaron Patterson | 2012-01-16 | 3 | -20/+25 | |
| | ||||||
* | silencing migrator tests, refactoring the migration test helper | Aaron Patterson | 2012-01-16 | 4 | -23/+13 | |
| | ||||||
* | fix tests on sqlite3 | Aaron Patterson | 2012-01-16 | 1 | -0/+4 | |
| | ||||||
* | prefer method sensors over actual ddl changes | Aaron Patterson | 2012-01-16 | 2 | -69/+84 | |
| | ||||||
* | testing the current version method | Aaron Patterson | 2012-01-16 | 1 | -1/+26 | |
| | ||||||
* | test that migrations have connections, and method missing delegates | Aaron Patterson | 2012-01-16 | 1 | -7/+16 | |
| | ||||||
* | making sure the temp connection and the real connection are different after dup | Aaron Patterson | 2012-01-16 | 1 | -3/+3 | |
| | ||||||
* | Merge pull request #4480 from lest/use-rack-body-proxy | José Valim | 2012-01-16 | 6 | -102/+37 | |
|\ | | | | | Use Rack::BodyProxy |