aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* cleaning up a bunch of method already defined warnings [#4209 state:resolved]Aaron Patterson2010-03-171-0/+3
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Move require closer to homeJeremy Kemper2010-03-171-1/+0
|
* fixing activerecord tests [#4205 state:resolved]Aaron Patterson2010-03-171-0/+1
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* fisting uninitialized ivar warnings. [#4198 state:resolved]Aaron Patterson2010-03-163-8/+14
| | | | Signed-off-by: wycats <wycats@gmail.com>
* clean up more warnings, remove unnecessary methods, fix eval line numbers. ↵Aaron Patterson2010-03-164-3/+11
| | | | | | [#4193 state:resolved] Signed-off-by: wycats <wycats@gmail.com>
* removing dead code from activerecord tests. [#4187 state:resolved]Aaron Patterson2010-03-154-46/+0
| | | | Signed-off-by: wycats <wycats@gmail.com>
* cleaning up a bunch of parse time warnings in AR [#4186 state:resolved]Aaron Patterson2010-03-159-26/+26
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Hack to keep column metadata queries out of test query countsJeremy Kemper2010-03-151-0/+5
|
* Hack to keep column metadata queries out of test query countsJeremy Kemper2010-03-151-3/+7
|
* cleaning up many more warnings in activerecord [#4180 state:resolved]Aaron Patterson2010-03-154-3/+17
| | | | Signed-off-by: wycats <wycats@gmail.com>
* speeding up clone_attributes, changing readonly to be initialized in def ↵Aaron Patterson2010-03-141-8/+9
| | | | | | initialize Signed-off-by: wycats <wycats@gmail.com>
* cleaning up some test warningsAaron Patterson2010-03-144-5/+16
| | | | Signed-off-by: wycats <wycats@gmail.com>
* restricts a test to < 1.9, and rewrites it using a proper expectationXavier Noria2010-03-132-11/+6
| | | | Signed-off-by: wycats <wycats@gmail.com>
* adds coverage for the issue addressed in fe43bbdXavier Noria2010-03-121-0/+14
| | | | | | [#4166 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* keep AssociationProxy#to_a to avoid warning in Array(post.author), and ↵Xavier Noria2010-03-122-1/+2
| | | | | | | | delegate it to @target in association collections [#4165 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Use arel 0.3.1, for srsJeremy Kemper2010-03-101-1/+1
|
* Bump arel dep to 0.3.0+Jeremy Kemper2010-03-101-1/+1
|
* Arel now fallback to using Arel::Attribute if the table/column doesn't exists.Emilio Tagua2010-03-101-3/+1
| | | | | | [#4142 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* removing spawn from SpawnMethodsAaron Patterson2010-03-104-13/+13
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Fix scope loading issue when the table doesn't existPratik Naik2010-03-101-1/+3
|
* Fix associations to call :destroy or :delete based on the right :dependent ↵Carlos Antonio da Silva2010-03-097-40/+39
| | | | | | option Signed-off-by: José Valim <jose.valim@gmail.com>
* Make many parts of Rails lazy. In order to facilitate this,wycats2010-03-075-185/+206
| | | | | | | | | | | | add lazy_load_hooks.rb, which allows us to declare code that should be run at some later time. For instance, this allows us to defer requiring ActiveRecord::Base at boot time purely to apply configuration. Instead, we register a hook that should apply configuration once ActiveRecord::Base is loaded. With these changes, brings down total boot time of a new app to 300ms in production and 400ms in dev. TODO: rename base_hook
* drying up more code in associations.rbAaron Patterson2010-03-061-17/+11
| | | | Signed-off-by: wycats <wycats@gmail.com>
* deleting repeated codeAaron Patterson2010-03-061-17/+7
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Load RAILS_VERSION relative to the gemspec file.Stefan Penner2010-03-061-1/+1
|
* converting inject to each and mapAaron Patterson2010-03-061-5/+4
| | | | | | [#4119 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* refactoring build_whereAaron Patterson2010-03-061-7/+7
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Read Rails version from a file instead of modifying the load path and doing ↵Bryan Helmkamp2010-03-041-5/+4
| | | | | | requires Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Somehow this fixes the AR tests when ran with rake. I should probably figure ↵Carl Lerche2010-03-041-1/+1
| | | | out why.
* Fix active_records' log testsCarl Lerche2010-03-021-2/+3
|
* Wordsmith gem descriptionsJeremy Kemper2010-03-021-1/+1
|
* Leverage VERSION constants from gemspecs to avoid tedious updates when releasingBryan Helmkamp2010-03-022-4/+6
|
* Update versions of all components to normalize them to new formatBryan Helmkamp2010-03-021-2/+3
|
* Remove cruft in the gem packaging and release codeBryan Helmkamp2010-03-011-14/+0
|
* activerecord test load pathsJoshua Peek2010-02-281-0/+3
|
* ActiveRecord should raise an error on invalid migration types.José Valim2010-02-282-4/+17
|
* Print database.rake errors to stderr.S. Christoffer Eliesen2010-02-271-5/+5
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* no more warning interpreted as argument prefix on association_preload.rbSantiago Pastorino2010-02-261-1/+1
|
* fixed a 'RecordNotFound' bug when calling 'reload' on a object which doesn't ↵Tobias Bielohlawek2010-02-262-1/+7
| | | | | | | | met the default_scope conditions, added test [#3166 status:resolved] The reload method didn't made use of 'with_exclusive_scope' when reloading the object. This lead to a RecordNotFound exception, in case the object doesn't met the default_scope condition (anymore) - which is obviously a bug. This quick fix makes use of with_exclusive_scope in the reload method as well. See test for full example. Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix a bug where default_scope was overriding attributes given on model ↵Henry Hsu2010-02-263-1/+16
| | | | | | initialization [#3218 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Use Object#singleton_class instead of #metaclass. Prefer Ruby's choice.Jeremy Kemper2010-02-253-5/+5
|
* Revert "Fix test load paths for those not using bundler"Carlhuda2010-02-233-8/+3
| | | | | | This reverts commit eec2d301d4ce9df9c71c1a5aa63053eb970b6818. This commit broke tests. You cannot have a file called "bundler" on the load path.
* avoid @lock_value not initialized warningSantiago Pastorino2010-02-221-1/+1
|
* avoid @transaction_joinable not initialized warningSantiago Pastorino2010-02-221-1/+1
|
* avoid active not initialized warningSantiago Pastorino2010-02-221-0/+1
|
* Require persisted? in ActiveModel::Lint and remove new_record? and ↵José Valim2010-02-212-9/+26
| | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not.
* Add to_key and to_param methods to ActiveModel::Conversion.José Valim2010-02-211-1/+1
|
* AMo #key is now #to_key and CI is probably happysnusnu2010-02-202-8/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Obviously #key is a too common name to be included in the AMo interface, #to_key fits better and also relates nicely to #to_param. Thx wycats, koz and josevalim for the suggestion. AR's #to_key implementation now takes customized primary keys into account and there's a testcase for that too. The #to_param AMo lint makes no assumptions on how the method behaves in the presence of composite primary keys. It leaves the decision wether to provide a default, or to raise and thus signal to the user that implementing this method will need his special attention, up to the implementers. All AMo cares about is that #to_param is implemented and returns nil in case of a new_record?. The default CompliantObject used in lint_test provides a naive default implementation that just joins all key attributes with '-'. The #to_key default implementation in lint_test's CompliantObject now returns [id] instead of [1]. This was previously causing the (wrong) tests I added for AR's #to_key implementation to pass. The #to_key tests added with this patch should be better. The CI failure was caused by my lack of knowledge about the test:isolated task. The tests for the record_identifier code in action_controller are using fake non AR models and I forgot to stub the #to_key method over there. This issue didn't come up when running the test task, only test:isolated revealed it. This patch fixes that. All tests pass isolated or not, well, apart from one previously unpended test in action_controller that is unrelated to my patch.
* Adds #key and #to_param to the AMo interfacesnusnu2010-02-192-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit introduces two new methods that every AMo compliant object must implement. Below are the default implementations along with the implied interface contract. # Returns an Enumerable of all (primary) key # attributes or nil if new_record? is true def key new_record? ? nil : [1] end # Returns a string representing the object's key # suitable for use in URLs, or nil if new_record? # is true def to_param key ? key.first.to_s : nil end 1) The #key method Previously rails' record_identifier code, which is used in the #dom_id helper, relied on calling #id on the record to provide a reasonable DOM id. Now with rails3 being all ORM agnostic, it's not safe anymore to assume that every record ever will have an #id as its primary key attribute. Having a #key method available on every AMo object means that #dom_id can be implemented using record.to_model.key # instead of record.id Using this we're able to take composite primary keys into account (e.g. available in datamapper) by implementing #dom_id using a newly added record_key_for_dom_id(record) method. The user can overwrite this method to provide customized versions of the object's key used in #dom_id. Also, dealing with more complex keys that can contain arbitrary strings, means that we need to make sure that we only provide DOM ids that are valid according to the spec. For this reason, this patch sends the key provided through a newly added sanitize_dom_id(candidate_id) method, that makes sure we only produce valid HTML The reason to not just add #dom_id to the AMo interface was that it feels like providing a DOM id should not be a model concern. Adding #dom_id to the AMo interface would force these concern on the model, while it's better left to be implemented in a helper. Now one could say the same is true for #to_param, and actually I think that it doesn't really fit into the model either, but it's used in AR and it's a main part of integrating into the rails router. This is different from #dom_id which is only used in view helpers and can be implemented on top of a semantically more meaningful method like #key. 2) The #to_param method Since the rails router relies on #to_param to be present, AR::Base implements it and returns the id by default, allowing the user to overwrite the method if desired. Now with different ORMs integrating into rails, every ORM railtie needs to implement it's own #to_param implementation while already providing code to be AMo compliant. Since the whole point of AMo compliance seems to be to integrate any ORM seamlessly into rails, it seems fair that all we really need to do as another ORM, is to be AMo compliant. By including #to_param into the official interface, we can make sure that this code can be centralized in the various AMo compliance layers, and not be added separately by every ORM railtie. 3) All specs pass
* Merge master.José Valim2010-02-173-3/+8
|\
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-12 17:38:01 +0000