Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | Add documentation for ActiveRecord.select when use strings as arguments | Maurizio De Santis | 2013-02-07 | 1 | -0/+10 | |
| | | | | ||||||
| * | | | Add ActiveRecord.count documentation when used on group relations | Maurizio De Santis | 2013-02-07 | 1 | -0/+6 | |
| | | | | ||||||
* | | | | Revert "Make valid_type? public" | Jon Leighton | 2013-02-15 | 4 | -12/+17 | |
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 5d528f835e871f5f9d4b68e8a81cfbe900b7e718. Relates to f8c8ad5 which is also getting reverted due to failing test. | |||||
* | | | | Revert "checking in the abstractions for valid type checking:" | Jon Leighton | 2013-02-15 | 4 | -28/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c321b309a9a90bbfa0912832c11b3fef52e71840. Conflicts: activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb Reason: failing test 1) Error: test_valid_column(ActiveRecord::ConnectionAdapters::SQLite3AdapterTest): NoMethodError: undefined method `column' for test/cases/adapters/sqlite3/sqlite3_adapter_test.rb:29:in `test_valid_column' | |||||
* | | | | Revert "Revert "Merge pull request #9206 from ranjaykrishna/use_define_method"" | Jon Leighton | 2013-02-15 | 1 | -18/+13 | |
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8aa4603a5adaa56c818a7bd1c0b761b4ecca3d3e. Reverting the revert because I reverted the wrong thing! Fail. | |||||
* | | | | Revert "Merge pull request #9206 from ranjaykrishna/use_define_method" | Jon Leighton | 2013-02-15 | 1 | -13/+18 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 1fc6876b57f2e1d31731e74eb4271b5655e746d2, reversing changes made to 0268b5d8cdc3c5a1337462135f0a326a2654ba1a. Reason: failing test 1) Error: test_valid_column(ActiveRecord::ConnectionAdapters::SQLite3AdapterTest): NoMethodError: undefined method `column' for test/cases/adapters/sqlite3/sqlite3_adapter_test.rb:29:in `test_valid_column' | |||||
* | | | | Merge pull request #9252 from senny/8423_hmt_preloading_bug | Rafael Mendonça França | 2013-02-14 | 3 | -1/+30 | |
|\ \ \ \ | | | | | | | | | | | don't cache invalid subsets when preloading hmt associations | |||||
| * | | | | don't cache invalid subsets when preloading hmt associations. | Yves Senn | 2013-02-14 | 3 | -1/+30 | |
| | | | | | | | | | | | | | | | | | | | | closes #8423. | |||||
* | | | | | Make valid_type? public | Sam Ruby | 2013-02-14 | 4 | -17/+12 | |
|/ / / / | ||||||
* | | | | Merge pull request #9254 from warnickr/9253_avoid_bigdecimal_performance_issue | Carlos Antonio da Silva | 2013-02-13 | 1 | -4/+5 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before writing a numeric attribute value, ActiveRecord does an implicit conversion of boolean types (true => 1 and false => 0). If the numeric value being assigned is a BigDecimal, then ActiveRecord compares a BigDecimal to true and false. This is known to be very slow in Ruby 1.9.3 (see http://www.ruby-forum.com/topic/4409452 and https://bugs.ruby-lang.org/issues/7645#change-35188). The Ruby core team has implemented a fix for this issue that will be included in Ruby 2, but they appear to have no intention of back-porting this fix to Ruby 1.9.3. In my case, the performance impact of this issue was enormous (200% - 300% performance hit) for some of the pages in my application. See c75b5a88a82c79fdf95dfea4d72bf3c5a829930e applied to 3-2-stable branch for more reasoning and a benchmark. | |||||
| * | | | | 9253: Before writing a numeric attribute value, ActiveRecord does an implicit | Ryan Warnick | 2013-02-13 | 1 | -4/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | conversion of boolean types (true => 1 and false => 0). If the numeric value being assigned is a BigDecimal, then ActiveRecord compares a BigDecimal to true and false. This is known to be very slow in Ruby 1.9.3. | |||||
* | | | | | Don't call after_commit when creating through an association and save fails, ↵ | James Miller | 2013-02-13 | 3 | -1/+36 | |
|/ / / / | | | | | | | | | | | | | fixes #5802 | |||||
* | | | | Merge pull request #9204 from ranjaykrishna/col-prob | Aaron Patterson | 2013-02-12 | 8 | -1/+43 | |
|\ \ \ \ | | | | | | | | | | | schema dumper tests now conducted by ActiveRecord::Base.Connection | |||||
| * | | | | checking in the abstractions for valid type checking: | Ranjay Krishna | 2013-02-12 | 8 | -1/+43 | |
| | | | | | ||||||
* | | | | | Merge pull request #9206 from ranjaykrishna/use_define_method | Carlos Antonio da Silva | 2013-02-12 | 1 | -18/+13 | |
|\ \ \ \ \ | | | | | | | | | | | | | Use define method instead of class_eval | |||||
| * | | | | | reverted back our changes and added in the new define_method | Ranjay Krishna | 2013-02-12 | 1 | -18/+13 | |
| |/ / / / | ||||||
* | | | | | test for regression from a712e08ebe21f6d8653a0e6602df2e0f5d40d9ca | Aaron Patterson | 2013-02-11 | 1 | -0/+6 | |
| | | | | | ||||||
* | | | | | define Active Record Store accessors in a module | Sergey Nartimov | 2013-02-11 | 4 | -12/+54 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow store accessors to be overrided like other attribute methods, e.g.: class User < ActiveRecord::Base store :settings, accessors: [ :color, :homepage ], coder: JSON def color super || 'red' end end | |||||
* | | | | | fixing bit string test | Aaron Patterson | 2013-02-10 | 1 | -3/+3 | |
| | | | | | ||||||
* | | | | | Update activerecord/CHANGELOG.md | Guillermo Iguaran | 2013-02-09 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Use IN operator like arel for empty hash in where clause | robertomiranda | 2013-02-09 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Reverting e170014113 (Change behaviour with empty hash in where clause) | Guillermo Iguaran | 2013-02-08 | 3 | -12/+3 | |
| | | | | | ||||||
* | | | | | Reverting 16f6f25 (Change behaviour with empty array in where clause) | Guillermo Iguaran | 2013-02-08 | 6 | -14/+13 | |
| | | | | | ||||||
* | | | | | Improve changelog entries in AR | Carlos Antonio da Silva | 2013-02-08 | 1 | -5/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Describe better the changes related to raising errors with empty array/hash values in where clauses. [ci skip] | |||||
* | | | | | Change behaviour with empty array in where clause | robertomiranda | 2013-02-08 | 6 | -13/+14 | |
| | | | | | ||||||
* | | | | | Change behaviour with empty hash in where clause | robertomiranda | 2013-02-08 | 3 | -3/+11 | |
| | | | | | ||||||
* | | | | | Merge pull request #9207 from dylanahsmith/mysql-quote-numeric | Guillermo Iguaran | 2013-02-07 | 8 | -14/+60 | |
|\ \ \ \ \ | |_|_|_|/ |/| | | | | active_record: Quote numeric values compared to string columns. | |||||
| * | | | | active_record: Quote numeric values compared to string columns. | Dylan Smith | 2013-02-07 | 8 | -14/+60 | |
| | | | | | ||||||
* | | | | | Skip schema dumper extensions test if connection does not support it | Carlos Antonio da Silva | 2013-02-07 | 1 | -0/+1 | |
|/ / / / | | | | | | | | | | | | | | | | | Travis failed because the postgresql version installed there does not support extensions, so we just need to skip this for now. | |||||
* | | | | Run schema dumper extensions without creating real extensions | Carlos Antonio da Silva | 2013-02-06 | 1 | -9/+2 | |
| | | | | | | | | | | | | | | | | | | | | There is no need to create the extension in the database just to test if it's dumped, we can stub that instead. | |||||
* | | | | Do not print anything related to extensions when they don't none exist | Carlos Antonio da Silva | 2013-02-06 | 2 | -4/+16 | |
| | | | | | | | | | | | | | | | | | | | | When extensions are supported but there's no one enabled in the database, we should not print anything related to them in schema.rb. | |||||
* | | | | Add blank line after extensions to separate from tables in schema | Carlos Antonio da Silva | 2013-02-06 | 1 | -0/+1 | |
| | | | | ||||||
* | | | | Fix indentation of extensions in schema | Carlos Antonio da Silva | 2013-02-06 | 1 | -4/+2 | |
| | | | | ||||||
* | | | | Call super to use the abstract adapter implementation instead | Carlos Antonio da Silva | 2013-02-06 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Add changelog entry for #9203 about schema dumper with db extensions | Carlos Antonio da Silva | 2013-02-06 | 2 | -2/+7 | |
| | | | | | | | | | | | | | | | | [ci skip] | |||||
* | | | | add ActiveRecord::AbstractAdapter#extensions and ↵ | Justin George | 2013-02-06 | 3 | -0/+27 | |
| | | | | | | | | | | | | | | | | ActiveRecord::ConnectionAdapters::PostgreSQLAdapter#extensions to allow dumping of enabled extensions to schema.rb, add ActiveRecord::SchemaDumper#extensions to dump extensions to schema.rb | |||||
* | | | | improve tests to check for existence of extensions method, and skip testing ↵ | Justin George | 2013-02-06 | 2 | -8/+8 | |
| | | | | | | | | | | | | | | | | dumped extensions if they are unsupported by the database | |||||
* | | | | Add some tests to enumerate how extensions should be stored in the schema output | Justin George | 2013-02-06 | 2 | -0/+15 | |
| | | | | ||||||
* | | | | Enable hstore extensions on tests if it is not enabled and database supports it | Rafael Mendonça França | 2013-02-05 | 1 | -1/+8 | |
| | | | | ||||||
* | | | | Put .rdoc at the end of the files named RUNNING_UNIT_TESTS | Yuki Nishijima | 2013-02-03 | 1 | -0/+0 | |
| |/ / |/| | | | | | | | | So that they are printed nicely on GitHub. | |||||
* | | | Fix typo :bomb: | Rafael Mendonça França | 2013-01-31 | 1 | -1/+1 | |
| | | | ||||||
* | | | Fix typo | Rafael Mendonça França | 2013-01-31 | 1 | -2/+2 | |
| | | | ||||||
* | | | CHANGELOG review | Rafael Mendonça França | 2013-01-31 | 1 | -3/+3 | |
| | | | ||||||
* | | | Strict regexp | Rafael Mendonça França | 2013-01-31 | 1 | -2/+2 | |
| | | | ||||||
* | | | Extract the value casting to a method | Rafael Mendonça França | 2013-01-31 | 1 | -15/+23 | |
| | | | ||||||
* | | | DATABASE_URL parsing should turn numeric strings into numeric types, and | Aaron Stone | 2013-01-31 | 3 | -11/+68 | |
| | | | | | | | | | | | | | | | | | | the strings true and false into boolean types, in order to match how YAML would parse the same values from database.yml and prevent unexpected type errors in the database adapters. | |||||
* | | | Merge pull request #9119 from dazuma/database_tasks_for_unknown_adapter | Carlos Antonio da Silva | 2013-01-31 | 2 | -0/+10 | |
|\ \ \ | | | | | | | | | Raise an exception with a useful message if a rake task is requested for an unknown adapter | |||||
| * | | | Raise a specific exception with a useful message if a rake task is requested ↵ | Daniel Azuma | 2013-01-30 | 2 | -0/+10 | |
| | | | | | | | | | | | | | | | | for an unknown adapter | |||||
* | | | | class_eval should use __FILE__ and __LINE__ | Neeraj Singh | 2013-01-30 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Remove pre-emptive adapter name check from databases.rake so third party ↵ | Daniel Azuma | 2013-01-29 | 1 | -9/+3 | |
|/ / / | | | | | | | | | | adapters can register rake tasks |