Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | refactor dynamic finder name matching into its own class | Josh Susser | 2008-08-25 | 4 | -72/+125 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | ensure tests load sibling Active Support instead of a gem | Jeremy Kemper | 2008-08-25 | 1 | -0/+1 |
| | |||||
* | Use DECIMAL instead of INTEGER when casting as mysql doesn't work with just ↵ | Tarmo Tänav | 2008-08-25 | 1 | -3/+8 |
| | | | | | | | | "INTEGER" and other databases don't like "UNSIGNED" which mysql requires And don't mask exceptions. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Cache migrated versions list in Migrator and use it to fetch the latest ↵ | Tarmo Tänav | 2008-08-25 | 1 | -6/+8 |
| | | | | | | | | | | | | migrated version name [#845 state:resolved] Also optimized Migrator#current_version class method to fetch only the latest version number and not all of them. With this change no matter how many migrations there are the schema_migrations table is only SELECTed from once. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Load the first and not the last has_one result when doing join-based eager ↵ | Tarmo Tänav | 2008-08-25 | 3 | -0/+17 |
| | | | | | | | | | | | loading This matters when the has_one is defined with an order in which case there is an expectation that the first one will be loaded. [#904 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Implement old-skool eagerloading for has_one :through | Frederick Cheung | 2008-08-25 | 2 | -2/+18 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Harmonize framework require strategy. Don't add self to load path since ↵ | Jeremy Kemper | 2008-08-25 | 1 | -10/+7 |
| | | | | Rails initializer and RubyGems handle it. | ||||
* | Fix preloading of has_one through associations | Frederick Cheung | 2008-08-25 | 2 | -11/+11 |
| | | | | | | [#903 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | strip trailing whitespace | Jeremy Kemper | 2008-08-25 | 1 | -157/+157 |
| | |||||
* | Ruby 1.9 compat: fix test error masked by old String#each behavior | Jeremy Kemper | 2008-08-25 | 1 | -1/+1 |
| | |||||
* | I18n: fix activerecord i18n test for classy backend | Sven Fuchs | 2008-08-25 | 1 | -1/+1 |
| | |||||
* | Fix test to assign the module instead of a new instance | Jeremy Kemper | 2008-08-24 | 1 | -1/+1 |
| | |||||
* | Merge branch 'patches' | Michael Koziarski | 2008-08-24 | 4 | -4/+88 |
|\ | |||||
| * | Rollback the transaction when a before_* callback returns false. | Xavier Noria | 2008-08-24 | 4 | -4/+88 |
| | | | | | | | | | | | | | | Previously this would have committed the transaction but not carried out save or destroy operation. [#891 state:committed] Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | | Ruby 1.9 compat: Hash is now flattenable, so explicitly exclude it | Jeremy Kemper | 2008-08-23 | 1 | -1/+1 |
| | | |||||
* | | Don't set "NULL" as a constraint on nullable columns [#398 state:resolved] | Tarmo Tänav | 2008-08-23 | 2 | -10/+6 |
|/ | | | | This is already the default and adding it breaks SQL standards compatibility. | ||||
* | Always require activesupport, even if its constant already exists | Tarmo Tänav | 2008-08-23 | 1 | -10/+8 |
| | | | | | | | | | | This is needed because the existance of the ActiveSupport constant by itself does not guarantee that the whole library has been loaded. Also load the StringInquirer in the Rails#env method as the it might be called inside the initializer block before activesupport itself has been loaded. | ||||
* | coerce blank strings to nil values for boolean and integer fields | Josh Susser | 2008-08-22 | 5 | -12/+27 |
| | | | | [#860 state:resolved] | ||||
* | Made migrations transactional for PostgreSQL [#834 state:resolved] | Tarmo Tänav | 2008-08-22 | 6 | -4/+59 |
| | | | | Patch originally from http://dev.rubyonrails.org/ticket/5470 | ||||
* | Merge branch 'master' into i18n | Jeremy Kemper | 2008-08-22 | 5 | -10/+44 |
|\ | |||||
| * | Ensure t.timestamps respects options. [#828 state:resolved] | Patrick Reagan | 2008-08-22 | 2 | -5/+39 |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
| * | Fixed ordering in ↵ | Tarmo Tänav | 2008-08-22 | 2 | -2/+2 |
| | | | | | | | | test_find_in_association_with_custom_finder_sql_and_multiple_interpolations | ||||
| * | Properly quote CREATE DATABASE parameters in postgresql [#771 state:resolved] | Tarmo Tänav | 2008-08-22 | 1 | -3/+3 |
| | | |||||
* | | Merge commit 'sven/i18n' into i18n | Jeremy Kemper | 2008-08-22 | 7 | -142/+478 |
|\ \ | |/ |/| | |||||
| * | Merge branch 'master' into i18n | Sven Fuchs | 2008-08-21 | 27 | -53/+157 |
| |\ | |||||
| * | | Custom error messages scope improved | Iain Hecker | 2008-08-21 | 2 | -37/+89 |
| | | | |||||
| * | | Removed en-US ruby locale in favor of yaml | Iain Hecker | 2008-08-20 | 1 | -28/+0 |
| | | | |||||
| * | | Locale file changed to yaml | Iain Hecker | 2008-08-20 | 3 | -2/+35 |
| | | | |||||
| * | | add human_name and value to ar validation #generate_message | Sven Fuchs | 2008-08-20 | 1 | -3/+3 |
| | | | |||||
| * | | Added :value as interpolation variable available to error messages | Iain Hecker | 2008-08-20 | 2 | -10/+12 |
| | | | |||||
| * | | Introduced AR::Base.human_name to validations | Iain Hecker | 2008-08-20 | 2 | -3/+3 |
| | | | |||||
| * | | Added Base.human_name method | Iain Hecker | 2008-08-20 | 2 | -0/+59 |
| | | | |||||
| * | | Cleaned up ActiveRecord i18n scoping | Iain Hecker | 2008-08-14 | 4 | -157/+196 |
| | | | |||||
| * | | fixing unit tests for active_record validations_i18n | Sven Fuchs | 2008-08-13 | 1 | -2/+2 |
| | | | |||||
| * | | provide more useful feedback on missing translations for validation error ↵ | Sven Fuchs | 2008-08-13 | 1 | -1/+1 |
| | | | | | | | | | | | | messages | ||||
| * | | fix validations_i18n tests for changed locale file format | Sven Fuchs | 2008-08-13 | 1 | -1/+1 |
| | | | |||||
| * | | switch to using I18n.load_translations instead of requiring plain ruby files | Sven Fuchs | 2008-08-13 | 2 | -24/+25 |
| | | | |||||
| * | | update i18n usage for pluralization hashes (api change) | Sven Fuchs | 2008-08-10 | 2 | -11/+189 |
| | | | |||||
* | | | Revert "Performance: freeze cached rows instead of duping" | Jeremy Kemper | 2008-08-21 | 2 | -5/+14 |
| | | | | | | | | | | | | This reverts commit cd8e653d5b18e6d3c3acc9930832f8e23945e392. | ||||
* | | | Revert "coerce blank strings to nil values for boolean and integer fields" | Jeremy Kemper | 2008-08-21 | 3 | -17/+10 |
| | | | | | | | | | | | | | | | | | | This reverts commit aee14630d4dc0856e597794cc731fac68c2d2e34. [#860 state:incomplete] | ||||
* | | | remember created records and select a random one instead of relying on ↵ | S. Brent Faulkner | 2008-08-21 | 1 | -12/+30 |
| | | | | | | | | | | | | | | | | | | sequential id values starting at 1 Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | | | coerce blank strings to nil values for boolean and integer fields | Josh Susser | 2008-08-21 | 3 | -10/+17 |
| |/ |/| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | | Don't interpret decimals as table names in ↵ | Peter Wagenet | 2008-08-21 | 2 | -3/+10 |
| | | | | | | | | | | | | ActiveRecord::Associations::ClassMethods#references_eager_loaded_tables? [#532 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | | Fix incorrect signature for NamedScope#respond_to? [#852 state:resolved] | Tom Lea | 2008-08-21 | 2 | -2/+7 |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | | Fix postgres bug when change_column is called with invalid parameters. [#861 ↵ | Miles Georgi | 2008-08-21 | 1 | -1/+2 |
| | | | | | | | | | | | | | | state:resolved] Signed-off-by: Tarmo Tänav <tarmo@itech.ee> Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | | Fix generated WHERE IN query for named scopes. [#583 state:resolved] | Philip Hallstrom | 2008-08-21 | 3 | -1/+8 |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | | Fix has_many#count_records. [#865 state:resolved] | Xavier Noria | 2008-08-21 | 2 | -2/+17 |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | | Fix that has_one natural assignment to already associated record. [#854 ↵ | Jakub Kuźma | 2008-08-21 | 2 | -2/+12 |
| | | | | | | | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | | Support find_all on named scopes. [#730 state:resolved] | Ryan Bates | 2008-08-21 | 2 | -1/+5 |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | | Consistently use the framework's configured logger and avoid reverting to ↵ | Joshua Peek | 2008-08-18 | 1 | -3/+1 |
| | | | | | | | | RAILS_DEFAULT_LOGGER unless necessary. |