aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | Update docs for ActiveRecord `serialize`Ernie Miller2015-05-291-0/+9
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For certain column types, using `serialize` is unnecessary, or the user may get unexpected contents back from the DB adapter (which is handling some basic deserialization for them). Call this out in the documentation. For background, see: https://gist.github.com/ernie/33f75f2294885b9806f9 https://twitter.com/erniemiller/status/604262907442905090
* | | | | Fix the shadowing warning for `reflection`Roque Pinel2015-05-281-2/+2
| | | | |
* | | | | Persist user provided default values, even if unchangedSean Griffin2015-05-284-27/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a usability change to fix a quirk from our definition of partial writes. By default, we only persist changed attributes. When creating a new record, this is assumed that the default values came from the database. However, if the user provided a default, it will not be persisted, since we didn't see it as "changed". Since this is a very specific case, I wanted to isolate it with the other quirks that come from user provided default values. The number of edge cases which are presenting themselves are starting to make me wonder if we should just remove the ability to assign a default, in favor of overriding `initialize`. For the time being, this is required for the attributes API to not have confusing behavior. We had to delete one test, since this actually changes the meaning of `.changed?` on Active Record models. It now specifically means `changed_from_database?`. While I think this will make the attributes API more ergonomic to use, it is a subtle change in definition (though not a backwards incompatible one). We should probably figure out the right place to document this. (Feel free to open a PR doing that if you're reading this). /cc @rafaelfranca @kirs @senny This is an alternate implementation of #19921. Close #19921. [Sean Griffin & Kir Shatrov]
* | | | | Allow proc defaults with the Attributes APISean Griffin2015-05-283-1/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a variant implementation of the changes proposed in #19914. Unlike that PR, the change in behavior is isolated in its own class. This is to prevent wonky behavior if a Proc is assigned outside of the default, and it is a natural place to place the behavior required by #19921 as well. Close #19914. [Sean Griffin & Kir Shatrov]
* | | | | Merge pull request #20331 from arunagw/arunagw-remove-unused-package-tasksRafael Mendonça França2015-05-281-7/+0
|\ \ \ \ \ | |_|_|_|/ |/| | | | Remove unused package tasks
| * | | | Remove unused package tasksArun Agrawal2015-05-281-7/+0
| | | | | | | | | | | | | | | | | | | | We are using `all:build` now.
* | | | | Give credit to extra contributor for Base.reload fixShane Hender2015-05-281-2/+2
|/ / / /
* | | | Merge pull request #20196 from huoxito/preload-association-and-mergesRafael Mendonça França2015-05-282-2/+50
|\ \ \ \ | | | | | | | | | | Properly append preload / includes args on Merger
| * | | | Properly append preload / includes args on MergerWashington Luiz2015-05-282-2/+50
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Couldn't find other way to get the association name from a given class other than looping through `reflect_on_all_associations` reflections .. Noticed this one while looking at this example: ```ruby class Product < ActiveRecord::Base has_many :variants has_many :translations end class Translation < ActiveRecord::Base belongs_to :product end class Variant < ActiveRecord::Base belongs_to :product end class BugTest < Minitest::Test def test_merge_stuff product = Product.create! name: 'huhu' variant = Variant.create! product_id: product.id Translation.create! locale: 'en', product_id: product.id product_relation = Product.all .preload(:translations) .joins(:translations) .merge(Translation.where(locale: 'en')) .where(name: 'huhu') assert_equal variant, Variant.joins(:product).merge(product_relation).first end end ```
* | | | Merge pull request #20041 from akshay-vishnoi/sqlite_collationRafael Mendonça França2015-05-286-9/+139
|\ \ \ \ | | | | | | | | | | | | | | | SQLite3: Add collation support for string and text columns
| * | | | Add collation support for string and text columns in SQLite3Akshay Vishnoi2015-05-286-9/+139
| | | | |
* | | | | Add test to 57daaefRafael Mendonça França2015-05-281-1/+1
| | | | |
* | | | | Allow Relation#compact using delegationJordan Raine2015-05-281-1/+1
|/ / / /
* | | | Merge pull request #20171 from georgeclaghorn/enums-in-fixturesRafael Mendonça França2015-05-276-32/+64
|\ \ \ \ | | | | | | | | | | | | | | | Allow the use of symbols or strings to specify enum values in test fixtures
| * | | | Resolve enums in test fixturesGeorge Claghorn2015-05-276-32/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, values for columns backing Active Record enums must be specified as integers in test fixtures: awdr: title: "Agile Web Development with Rails" status: 2 rfr: title: "Ruby for Rails" status: <%= Book.statuses[:proposed] %> This is potentially confusing, since enum values are typically specified as symbols or strings in application code. To resolve the confusion, this change permits the use of symbols or strings to specify enum values: awdr: status: :published It is compatible with fixtures that specify enum values as integers.
* | | | | Merge pull request #19886 from henders/henders/reload_wipe_query_cacheRafael Mendonça França2015-05-273-1/+34
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Cause ActiveRecord::Base::reload to also ignore the QueryCache.
| * | | | | Cause ActiveRecord::Base::reload to also ignore the QueryCache.Shane Hender2015-04-282-1/+30
| | | | | |
* | | | | | Merge pull request #17654 from kamipo/strict_mode_explicitlyRafael Mendonça França2015-05-273-2/+22
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | If specify `strict: :default` explicitly, do not set sql_mode.
| * | | | | If specify `strict: :default` explicitly, do not set sql_mode.Ryuta Kamizono2015-05-263-2/+22
| | | | | | | | | | | | | | | | | | | | | | | | Related with #17370.
* | | | | | Merge pull request #20269 from wojobucco/masterRafael Mendonça França2015-05-273-4/+9
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Changed mysqldump to include sprocs and functions
| * | | | | | Changed mysqldump to include sprocs and functionsJonathan Worek2015-05-222-4/+5
| | |_|/ / / | |/| | | |
* | | | | | Merge pull request #20262 from arunagw/aa-remove-broken-unused-release-taskYves Senn2015-05-271-9/+0
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Remove broken and unused release task
| * | | | | Remove broken and unused release taskArun Agrawal2015-05-221-9/+0
| |/ / / / | | | | | | | | | | | | | | | | | | | | - We do release with release.rb - There is no `rake/gemcutter`
* | | | | add `extend` option on `has_and_belongs_to_many`.keepcosmos2015-05-263-1/+20
| | | | |
* | | | | Remove unused variableArun Agrawal2015-05-261-1/+1
| | | | | | | | | | | | | | | | | | | | Was left in adfab2dcf4003ca564d78d4425566dd2d9cd8b4f
* | | | | deprecate `Relation#uniq` use `Relation#distinct` instead.Yves Senn2015-05-2612-31/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See #9683 for the reasons we switched to `distinct`. Here is the discussion that triggered the actual deprecation #20198. `uniq`, `uniq!` and `uniq_value` are still around. They will be removed in the next minor release after Rails 5.
* | | | | Remove `.superclass_delegating_accessor`. Refer #14271Akshay Vishnoi2015-05-241-1/+0
|/ / / /
* | | | "maybe" => "may be"Waynn Lue2015-05-211-1/+1
| | | |
* | | | updated Inline format at activerecord rdocManish shrivastava2015-05-201-2/+2
| | | | | | | | | | | | For Inline formats, changed ` (single backticks) to <tt> tag at active record rdoc as single backticks (`) don't work with rdoc. for inline format.
* | | | Merge pull request #20219 from karanarora/Typo-fixSantiago Pastorino2015-05-201-1/+1
|\ \ \ \ | | | | | | | | | | typo fix [ci skip]
| * | | | typo fix [ci skip]karanarora2015-05-201-1/+1
| | | | |
* | | | | Merge pull request #20217 from amitsuroliya/fix_netaddr_linkArun Agrawal2015-05-201-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Fix NetAddr link [ci skip]
| * | | | | Fix NetAddr link [ci skip]amitkumarsuroliya2015-05-201-1/+1
| | | | | |
* | | | | | Updated postgresql documentation link to use latest version [ci skip]Ronak Jangir2015-05-203-6/+6
|/ / / / /
* | | | | parent_reflection should store only a reflection objectAaron Patterson2015-05-192-7/+9
| | | | | | | | | | | | | | | | | | | | | | | | | we should ask the reflection for its name rather than storing the reflection name in two places (an array and a reflection object)
* | | | | Remove unused already requireRyuta Kamizono2015-05-193-8/+0
| | | | |
* | | | | Remove `require 'arel/visitors/bind_visitor'`Ryuta Kamizono2015-05-193-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | This line introduced by the commit fd398475 for using `Arel::Visitors::BindVisitor`. Currently it is not used.
* | | | | Merge pull request #20212 from kamipo/avoid_heredocRafael Mendonça França2015-05-191-20/+5
|\ \ \ \ \ | | | | | | | | | | | | Avoid the heredoc in one line queries and simple queries
| * | | | | Avoid the heredoc in one line queries and simple queriesRyuta Kamizono2015-05-191-20/+5
| |/ / / / | | | | | | | | | | | | | | | Related with #20028.
* / / / / Eliminate the duplication code of `StatementPool`Ryuta Kamizono2015-05-194-92/+36
|/ / / /
* | | | Merge pull request #20175 from eugeneius/copy_schema_cache_after_forkRafael Mendonça França2015-05-183-24/+49
|\ \ \ \ | | | | | | | | | | Add schema cache to new connection pool after fork
| * | | | Add schema cache to new connection pool after forkEugene Kenny2015-05-173-24/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Active Record detects when the process has forked and automatically creates a new connection pool to avoid sharing file descriptors. If the existing connection pool had a schema cache associated with it, the new pool should copy it to avoid unnecessarily querying the database for its schema. The code to detect that the process has forked is in ConnectionHandler, but the existing test for it was in the ConnectionManagement test file. I moved it to the right place while I was writing the new test for this change.
* | | | | Merge pull request #20187 from yui-knk/refactor/type_intRafael Mendonça França2015-05-181-3/+6
|\ \ \ \ \ | | | | | | | | | | | | Refactoring `ActiveRecord::Type::Integer` limit
| * | | | | Refactoring `ActiveRecord::Type::Integer` limityui-knk2015-05-181-3/+6
| | | | | |
* | | | | | Merge pull request #20192 from kamipo/divide_to_column_options_handling_methodsRafael Mendonça França2015-05-182-10/+34
|\ \ \ \ \ \ | | | | | | | | | | | | | | Divide methods for handling column options separately
| * | | | | | Divide methods for handling column options separatelyRyuta Kamizono2015-05-182-10/+34
| | |/ / / / | |/| | | |
* | | | | | Merge pull request #20190 from kamipo/fix_serial_with_quoted_sequence_nameRafael Mendonça França2015-05-182-1/+10
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix `serial?` with quoted sequence name
| * | | | | | Fix `serial?` with quoted sequence nameRyuta Kamizono2015-05-182-1/+10
| |/ / / / /
* | | | | | Merge pull request #20082 from sh6khan/nested-attributes-docsEileen M. Uchitelle2015-05-181-0/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | docs for updating nested attributes while creating parent record
| * | | | | | docs for updating nested attributes while creating parent record [cish6khan2015-05-181-0/+5
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 08:38:58 +0000