Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | Merge pull request #10766 from kylerippey/minor_schema_migration_refactor | Rafael Mendonça França | 2013-05-28 | 1 | -18/+24 | |
|\ \ \ | | | | | | | | | Minor refactor of ActiveRecord::SchemaMigration | |||||
| * | | | Minor refactor of ActiveRecord::SchemaMigration to remove references to ↵ | Kyle Rippey | 2013-05-26 | 1 | -18/+24 | |
| |/ / | | | | | | | | | | Base, override table_exists method, and switch to preferred style for class method definitions. | |||||
* | | | Merge pull request #10495 from senny/postgres_test_cleanup | Rafael Mendonça França | 2013-05-28 | 2 | -30/+30 | |
|\ \ \ | | | | | | | | | PostgreSQL specific test cleanup | |||||
| * | | | cleanup, assert on warning from postgres adapter | Yves Senn | 2013-05-08 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | cleanup, switch arguments in assert_equal calls | Yves Senn | 2013-05-08 | 1 | -29/+29 | |
| | | | | ||||||
* | | | | test cleanup, replace `define_method` and `remove_method` with stubs. | Yves Senn | 2013-05-28 | 1 | -5/+1 | |
| | | | | ||||||
* | | | | `implicit_readonly` is being removed in favor of calling `readonly` explicitly | Yves Senn | 2013-05-27 | 5 | -24/+25 | |
| | | | | ||||||
* | | | | cleanup whitespace in `active_record/relation.rb`. | Yves Senn | 2013-05-27 | 1 | -4/+4 | |
| |/ / |/| | | ||||||
* | | | Merge pull request #10713 from senny/10693_fix_primary_key_option_on_has_many | Rafael Mendonça França | 2013-05-23 | 4 | -2/+15 | |
|\ \ \ | | | | | | | | | Fix the `:primary_key` option for `has_many` associations. | |||||
| * | | | Fix the `:primary_key` option for `has_many` associations. | Yves Senn | 2013-05-23 | 4 | -2/+15 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When removing records from a `has_many` association it used the `primary_key` defined on the association. Our test suite didn't fail because on all occurences of `:primary_key`, the specified column was available in both tables. This prevented the code from raising an exception but it still behaved badly. I added a test-case to prevent regressions that failed with: ``` 1) Error: HasManyAssociationsTest#test_has_many_assignment_with_custom_primary_key: ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: essays.first_name: UPDATE "essays" SET "writer_id" = NULL WHERE "essays"."writer_id" = ? AND "essays"."first_name" IS NULL ``` | |||||
* | | | | deprecate Validator#setup (to get rid of a respond_to call). validators do ↵ | Nick Sutterer | 2013-05-23 | 1 | -6/+1 | |
|/ / / | | | | | | | | | | their setup in their constructor now. | |||||
* | | | Add CHANGELOG entry for 99860582b2b1c0fc42bf84c52aac57b243d42678 | Rafael Mendonça França | 2013-05-22 | 1 | -0/+6 | |
| | | | ||||||
* | | | remove code duplication | Neeraj Singh | 2013-05-22 | 1 | -2/+3 | |
| | | | ||||||
* | | | Merge pull request #10714 from tkhr/extract_test_from_base_test.rb_in_AR | Carlos Antonio da Silva | 2013-05-22 | 4 | -45/+54 | |
|\ \ \ | | | | | | | | | Extract tests code out from AR's base_test.rb | |||||
| * | | | Extract AR::Persistence#becomes's test code out from base_test.rb | Takehiro Adachi | 2013-05-22 | 2 | -13/+13 | |
| | | | | | | | | | | | | | | | | | | | | The method got extracted out from AR::Base in commit d916c62cfc7c59ab6411407a05b946d3dd7535e9, but the tests never did. | |||||
| * | | | Extract AR::AttributeMethods#attribute_for_inspect's test code out from ↵ | Takehiro Adachi | 2013-05-22 | 2 | -8/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | base_test.rb The method itself got extracted out from ActiveRecored::Base in commit ceb33f84933639d3b61aac62e5e71fd087ab65ed, but the test code never did. | |||||
| * | | | Extract AR::Core#inspect and AR::Core.inspect's test code from base_test.rb | Takehiro Adachi | 2013-05-22 | 2 | -24/+33 | |
| | | | | | | | | | | | | | | | | | | | | The methods got moved to core.rb in commit b2c9ce341a1c907041f55461aefebb0321280cb5, but the tests never did. | |||||
* | | | | reverse comparison because of strange AS behavior | Aaron Patterson | 2013-05-21 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | http://tenderlovemaking.com/2013/05/21/one-danger-of-freedom-patches.html | |||||
* | | | | just set the default argument, a nil parent should be an error | Aaron Patterson | 2013-05-21 | 1 | -2/+1 | |
| | | | | ||||||
* | | | | fold the collection rather than multiple assigments | Aaron Patterson | 2013-05-21 | 1 | -3/+2 | |
| | | | | ||||||
* | | | | use drop rather than calculate the array length | Aaron Patterson | 2013-05-21 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Merge branch 'bindwhere' | Aaron Patterson | 2013-05-21 | 2 | -20/+42 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * bindwhere: avoid creating a set if no where values are removed remove bind values for where clauses that were removed push partitioning up so bind elimination can get the removed wheres push partion logic down and initialization logic up partition the where values so we can access the removed ones | |||||
| * | | | | avoid creating a set if no where values are removed | Aaron Patterson | 2013-05-21 | 2 | -0/+14 | |
| | | | | | ||||||
| * | | | | remove bind values for where clauses that were removed | Aaron Patterson | 2013-05-21 | 2 | -9/+18 | |
| | | | | | ||||||
| * | | | | push partitioning up so bind elimination can get the removed wheres | Aaron Patterson | 2013-05-21 | 1 | -5/+3 | |
| | | | | | ||||||
| * | | | | push partion logic down and initialization logic up | Aaron Patterson | 2013-05-21 | 1 | -15/+11 | |
| | | | | | ||||||
| * | | | | partition the where values so we can access the removed ones | Aaron Patterson | 2013-05-20 | 1 | -1/+6 | |
| |/ / / | ||||||
* | | | | Merge pull request #10711 from senny/10660_rake_db_test_prepare_needs_config | Rafael Mendonça França | 2013-05-21 | 1 | -1/+1 | |
|\ \ \ \ | | | | | | | | | | | the rake task `db:test:prepare` needs to load the configuration | |||||
| * | | | | the rake task `db:test:prepare` needs to load the configuration | Yves Senn | 2013-05-21 | 1 | -1/+1 | |
| |/ / / | | | | | | | | | | | | | Without loading the configuration the task will not perform any work. | |||||
* / / / | In batches test @total was assigned but not used. Use it in tests instead of ↵ | Alexander Balashov | 2013-05-21 | 1 | -7/+5 | |
|/ / / | | | | | | | | | | Post.count | |||||
* | | | eliminate some conditionals | Aaron Patterson | 2013-05-20 | 1 | -3/+3 | |
| | | | ||||||
* | | | change method name to reflect what it actually does. | Aaron Patterson | 2013-05-20 | 1 | -2/+2 | |
| | | | ||||||
* | | | save the where values in variables so we don't need to look them up all | Aaron Patterson | 2013-05-20 | 1 | -4/+5 | |
| | | | | | | | | | | | | the time | |||||
* | | | pass where values to the helper function rather than rely on internal state | Aaron Patterson | 2013-05-20 | 1 | -4/+4 | |
| | | | ||||||
* | | | Merge pull request #10692 from vipulnsward/fix_test_3 | José Valim | 2013-05-19 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | Fix wrong `case_sensitive` in uniqueness validity test | |||||
| * | | | Fix wrong `case_sensitive` in uniqueness validity test | Vipul A M | 2013-05-20 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Fix typo in test name and documentation | Vipul A M | 2013-05-20 | 2 | -2/+2 | |
|/ / / | ||||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-05-19 | 7 | -10/+42 | |
|\ \ \ | ||||||
| * | | | copy edits[ci skip] | Vijay Dev | 2013-05-19 | 2 | -12/+9 | |
| | | | | ||||||
| * | | | Added some more documentation for define_readers and define_writer of the ↵ | aditya-kapoor | 2013-05-15 | 3 | -0/+15 | |
| | | | | | | | | | | | | | | | | Association and its inherited classes | |||||
| * | | | Added some more documentation for ↵ | aditya-kapoor | 2013-05-15 | 1 | -0/+11 | |
| | | | | | | | | | | | | | | | | ActiveRecord::Associations::Builder::Association class | |||||
| * | | | Added documentation for ActiveRecord::Associations::Builder::Association class | aditya-kapoor | 2013-05-15 | 1 | -0/+4 | |
| | | | | ||||||
| * | | | improved doc for ActiveRecord#find_by_sql method (Refs #10599) [ci skip] | Anton Kalyaev | 2013-05-14 | 1 | -3/+4 | |
| | | | | ||||||
| * | | | Added documentation for model migration generation | aditya-kapoor | 2013-05-14 | 1 | -0/+4 | |
| | | | | ||||||
| * | | | emphasize that callbacks are called in destroy_all | Neeraj Singh | 2013-05-13 | 2 | -7/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cleaned up rdoc a bit emphasizing that callbacks are called. Also removed the stress on the fact that records are always removed. If callbacks return false then records will not be deleted. | |||||
* | | | | Fxied some typos | Prathamesh Sonpatki | 2013-05-18 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Merge pull request #10676 from tkhr/add-test-to-counter_cache_test.rb | Rafael Mendonça França | 2013-05-18 | 5 | -4/+18 | |
|\ \ \ \ | | | | | | | | | | | Add test to counter cache test.rb | |||||
| * | | | | Fix tests which started to fail due to commit ↵ | Takehiro Adachi | 2013-05-18 | 2 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 0123c39f41e2062311b2197e6e230ef8ad67e20e Due to commit 0123c39f41e2062311b2197e6e230ef8ad67e20e, column topic.unique_replies_count has been added, and these test started to fail since the tests depends on the topic tables column info. | |||||
| * | | | | Add test to AR's counter_cache_test.rb | Takehiro Adachi | 2013-05-18 | 3 | -0/+14 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | According to https://github.com/rails/rails/blob/b601399b72ab56cc01368f02615af99f45d1 4f02/activerecord/lib/active_record/counter_cache.rb#L14, u can pass more then one association to the `reset_counters` method. | |||||
* | | | | | stop swallowing exceptions in assert_queries. Methods that raise an | Aaron Patterson | 2013-05-17 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | exception are unlikely to pass this assertion, but since the assertions raise an exception, the original exception is lost. |